From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by mx.groups.io with SMTP id smtpd.web10.10262.1597326445419717249
 for <devel@edk2.groups.io>;
 Thu, 13 Aug 2020 06:47:25 -0700
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: ard.biesheuvel@arm.com)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
	by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A0FA71063;
	Thu, 13 Aug 2020 06:47:24 -0700 (PDT)
Received: from [192.168.178.54] (unknown [172.31.20.19])
	by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 6331C3F6CF;
	Thu, 13 Aug 2020 06:47:23 -0700 (PDT)
Subject: Re: [edk2-platform][PATCH v1 0/7] Platform/RaspberryPi : SMBIOS fixes and cleanup
To: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>, devel@edk2.groups.io
Cc: Leif Lindholm <leif@nuviainc.com>, Pete Batard <pete@akeo.ie>,
 Andrei Warkentin <awarkentin@vmware.com>
References: <20200720181646.2891-1-Samer.El-Haj-Mahmoud@arm.com>
From: "Ard Biesheuvel" <ard.biesheuvel@arm.com>
Message-ID: <9fdd755d-d11f-8c24-d8fc-1f46dd037432@arm.com>
Date: Thu, 13 Aug 2020 15:47:21 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.7.0
MIME-Version: 1.0
In-Reply-To: <20200720181646.2891-1-Samer.El-Haj-Mahmoud@arm.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit

On 7/20/20 8:16 PM, Samer El-Haj-Mahmoud wrote:
> Fixes and enhancements to RaspberryPi SMBIOS Types 0, 2, 3, 4, 7, 16, 17, and 19.
> These were compared against SMBIOS spec ver 3.3, and SBBR ver 1.2, and tested
> in UEFI Shell with smbiosview.
> 
> One issue found in smbiosview (for Type 17, "VolatileSize") and
> will be fixed as a seperate patch.
> 
> This series addresses :
>    - Most items in https://github.com/pftf/RPi4/issues/16
>    - One of the issues in https://github.com/pftf/RPi4/issues/75
> 
> Series pushed to:
> https://github.com/samerhaj/edk2-platforms/tree/rpi_smbios_fixes_v1
> 
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Pete Batard <pete@akeo.ie>
> Cc: Andrei Warkentin <awarkentin@vmware.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
> Signed-off-by: Samer El-Haj-Mahmoud <samer.el-haj-mahmoud@arm.com>
> 
> Samer El-Haj-Mahmoud (7):
>    Platforms/RaspberryPi: Fix NULL AssetTag in SMBIOS
>    Platforms/RaspberryPi: SMBIOS Type 2 and Type 3 fixes
>    Platforms/RaspberryPi: SMBIOS Type 0 fixes
>    Platforms/RaspberryPi: SMBIOS Type 4 fixes
>    Platforms/RaspberryPi: SMBIOS Type 7 fixes
>    Platforms/RaspberryPi: SMBIOS Memory Types fixes
>    Platforms/RaspberryPi: SMBIOS minor cleanup
> 

Thanks

Pushed as e28ea561e07b..f2e4f25b83bf

>   .../PlatformSmbiosDxe/PlatformSmbiosDxe.inf   |   7 +-
>   .../PlatformSmbiosDxe/PlatformSmbiosDxe.c     | 457 ++++++++++++------
>   2 files changed, 320 insertions(+), 144 deletions(-)
>