From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.115; helo=mga14.intel.com; envelope-from=star.zeng@intel.com; receiver=edk2-devel@lists.01.org Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 2D7B721165269 for ; Tue, 16 Oct 2018 00:46:37 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Oct 2018 00:46:36 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,387,1534834800"; d="scan'208";a="100606358" Received: from shzintpr02.sh.intel.com (HELO [10.7.209.21]) ([10.239.4.160]) by orsmga002.jf.intel.com with ESMTP; 16 Oct 2018 00:46:35 -0700 To: "Wu, Hao A" , Leif Lindholm Cc: "Ni, Ruiyu" , "edk2-devel@lists.01.org" , star.zeng@intel.com References: <20181015045522.18732-1-hao.a.wu@intel.com> <20181015045522.18732-7-hao.a.wu@intel.com> <20181016062008.tubfnsw3p6nbkew6@bivouac.eciton.net> From: "Zeng, Star" Message-ID: <9ff35864-15d9-aa86-f855-4d3dff83b700@intel.com> Date: Tue, 16 Oct 2018 15:46:04 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: Subject: Re: [PATCH v1 6/7] MdeModulePkg/UdfDxe: Remove dead codes in FileName.c X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Oct 2018 07:46:37 -0000 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Hao, If these code removing will make the function to be not matched with its original implementation purpose according to the function description, and the description is not updated, the code's readability will be sacrificed. I prefer to keep the code's readability and follow the function's original implementation purpose. Thanks, Star On 2018/10/16 14:28, Wu, Hao A wrote: >> -----Original Message----- >> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of >> Leif Lindholm >> Sent: Tuesday, October 16, 2018 2:20 PM >> To: Wu, Hao A >> Cc: Ni, Ruiyu; edk2-devel@lists.01.org; Zeng, Star >> Subject: Re: [edk2] [PATCH v1 6/7] MdeModulePkg/UdfDxe: Remove dead >> codes in FileName.c >> >> On Mon, Oct 15, 2018 at 12:55:21PM +0800, Hao Wu wrote: >>> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1249 >>> >>> We found potential dead codes within File.c during the code coverage test. >>> >>> After manual review, we think the below ones are positive reports: >>> >>> A. In function MangleFileName(): >>> >>> FileName = TrimString (FileName); >>> // Begin of dead codes >>> if (*FileName == L'\0') { >>> goto Exit; >>> } >>> // End of dead codes >>> >>> When the code reaches the TrimString() call, the string in 'FileName' is >>> guaranteed to have a '\' character due to the call patterns of >> >> What in the call pattern guarantees this? Please be precise. > > OK, I will update the log message. > >> >>> MangleFileName(). So after trimming the lead-off/tailing white spaces, >>> string in 'FileName' will not be an empty string. >>> >>> B. In function MangleFileName(): >>> >>> if (FileName[0] == L'.') { >>> if (FileName[1] == L'.') { >>> if (FileName[2] == L'\0') { >>> goto Exit; >>> } else { >>> FileName += 2; >>> } >>> } else if (FileName[1] == L'\0') { >>> goto Exit; >>> } >>> } >>> >>> When the code hits the above checks, string in 'FileName' will always have >>> a leading '\' character (denoting an absolute path) due to the call >>> patterns of MangleFileName(). So no leading '.' can be there in string >>> 'FileName'. >> >> What in the call pattern guarantees this? Please be precise. > > OK, I will update the log message. > > Thanks for the comments. > > Best Regards, > Hao Wu > >> >> Regards, >> >> Leif >> _______________________________________________ >> edk2-devel mailing list >> edk2-devel@lists.01.org >> https://lists.01.org/mailman/listinfo/edk2-devel