public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Sami Mujawar" <sami.mujawar@arm.com>
To: Kun Qin <kuqin12@gmail.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: Alexei Fedorov <Alexei.Fedorov@arm.com>,
	Pierre Gondois <Pierre.Gondois@arm.com>
Subject: Re: [edk2-devel] [PATCH v3 0/6] Enhance DynamicTablesPkg modules
Date: Mon, 8 Aug 2022 15:44:09 +0000	[thread overview]
Message-ID: <A17E0BC9-78FD-4DE7-8CCC-F1EDBCCFCF44@arm.com> (raw)
In-Reply-To: <2a2ecc26-fc8e-ec22-77ef-88fb2eff9221@gmail.com>

Hi Kun,

I have just replied to your patch series. I think patches 4 & 5 may need some adjustment.

Can you look into those, please?

Regards,

Sami Mujawar

On 08/08/2022, 16:34, "Kun Qin" <kuqin12@gmail.com> wrote:

    Hi DynamicTablePkg maintainers,

    Just a gentle ping on this patch series. If there is no further
    feedback, can we merge
    them into the mainline? Otherwise, any feedback is appreciated.

    Regards,
    Kun

    On 8/3/2022 9:57 AM, Kun Qin wrote:
    > Hi DynamicTablePkg maintainers,
    >
    > Do you have any further feedback on this patch series? Any input is
    > appreciated.
    >
    > Thanks,
    > Kun
    >
    > On 7/30/2022 10:37 PM, Kun Qin via groups.io wrote:
    >> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3996
    >> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3997
    >> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3998
    >>
    >> This patch series is a follow-up of previous submission:
    >> https://edk2.groups.io/g/devel/message/91926
    >>
    >> The main changes between v2 and v3 patches are:
    >>    - Added reviewed-by collected from previous iteration
    >>    - Added descriptions for newly introduced structures
    >>    - Updated functions names
    >>
    >> Current DynamicTablesPkg provide great support for creating dynamic ACPI
    >> tables during boot time.
    >>
    >> However, there are some modules needs minor tweaks to expand support and
    >> compatibility for OS requirements and platform needs.
    >>
    >> This patch series proposes a few fixes to resolve minor issues
    >> discovered
    >> in DynamicPlatRepoLib, AcpiSsdtPcieLibArm and DynamicTableManagerDxe.
    >>
    >> Patch v3 branch: https://github.com/kuqin12/edk2/tree/dynamic_update_v3
    >>
    >> Cc: Sami Mujawar <Sami.Mujawar@arm.com>
    >> Cc: Alexei Fedorov <Alexei.Fedorov@arm.com>
    >> Cc: Pierre Gondois <pierre.gondois@arm.com>
    >>
    >> Kun Qin (6):
    >>    DynamicTablesPkg: DynamicPlatRepoLib: Added MemoryAllocationLib to
    >> inf
    >>    DynamicTablesPkg: DynamicPlatRepoLib: Fix incorrect dereferencing
    >>    DynamicTablesPkg: DynamicPlatRepoLib: Adding more token fixers
    >>    DynamicTablesPkg: DynamicTableManagerDxe: Added check for installed
    >>      tables
    >>    DynamicTablesPkg: AcpiSsdtPcieLibArm: Added function to reserve ECAM
    >>      space
    >>    DynamicTablesPkg: AcpiSsdtPcieLibArm: Added case handling for PCI
    >>      config
    >>
    >> DynamicTablesPkg/Drivers/DynamicTableManagerDxe/DynamicTableManagerDxe.c
    >> | 214 ++++++++++++--------
    >> DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieGenerator.c
    >> | 176 ++++++++++++++++
    >> DynamicTablesPkg/Library/Common/DynamicPlatRepoLib/CmObjectTokenFixer.c
    >> |  80 +++++++-
    >> DynamicTablesPkg/Drivers/DynamicTableManagerDxe/DynamicTableManagerDxe.inf
    >> |   4 +
    >> DynamicTablesPkg/Library/Common/DynamicPlatRepoLib/DynamicPlatRepoLib.inf
    >> |   1 +
    >>   5 files changed, 391 insertions(+), 84 deletions(-)
    >>

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

  reply	other threads:[~2022-08-08 15:44 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1706D34FB5A53D97.608@groups.io>
2022-08-03 16:57 ` [edk2-devel] [PATCH v3 0/6] Enhance DynamicTablesPkg modules Kun Qin
2022-08-08 15:34   ` Kun Qin
2022-08-08 15:44     ` Sami Mujawar [this message]
2022-08-08 19:37       ` Kun Qin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=A17E0BC9-78FD-4DE7-8CCC-F1EDBCCFCF44@arm.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox