From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: daocheng.bu@intel.com) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by groups.io with SMTP; Mon, 15 Apr 2019 00:55:50 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Apr 2019 00:55:49 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,352,1549958400"; d="scan'208";a="164794307" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga001.fm.intel.com with ESMTP; 15 Apr 2019 00:55:50 -0700 Received: from fmsmsx151.amr.corp.intel.com (10.18.125.4) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 15 Apr 2019 00:55:49 -0700 Received: from shsmsx108.ccr.corp.intel.com (10.239.4.97) by FMSMSX151.amr.corp.intel.com (10.18.125.4) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 15 Apr 2019 00:55:49 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.93]) by SHSMSX108.ccr.corp.intel.com ([169.254.8.147]) with mapi id 14.03.0415.000; Mon, 15 Apr 2019 15:55:47 +0800 From: "Bu, Daocheng" To: "Gao, Zhichao" , "devel@edk2.groups.io" CC: "Piwko, Maciej" , "Oram, Isaac W" , "Gao, Liming" Subject: Re: [edk2-platforms/devel-MinPlatform][PATCH 3/5] LewisburgPkg/DxeRuntimeResetSystemLib: Add a new API ResetSystem Thread-Topic: [edk2-platforms/devel-MinPlatform][PATCH 3/5] LewisburgPkg/DxeRuntimeResetSystemLib: Add a new API ResetSystem Thread-Index: AQHU8zh0c8w3+wctUEGoZc/9yFS7a6Y82i3Q Date: Mon, 15 Apr 2019 07:55:47 +0000 Message-ID: References: <20190415030739.14328-1-zhichao.gao@intel.com> <20190415030739.14328-5-zhichao.gao@intel.com> In-Reply-To: <20190415030739.14328-5-zhichao.gao@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNDJkYTdmMTgtYzZlMS00N2ExLTlhY2YtZjEyMWU0YTE5Y2FiIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiT0lZbFBSYUtcLzJaXC9PeHNyaHhnS1MyMExiNm1KZnRydmtvUEtQcFV2S0NaeERGMVMzT2FUYXVaUnpnTkVnVW5UIn0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: daocheng.bu@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Maciej,=20 Please help review this code from PCH perspective.=20 If you approve this change , please also help cherry pick this change to S= erverSiliconPkg\Pch\SouthClusterLbg pkg @10nm trunk. Thanks, Amos UEFI FW, IAFW or System Firmware is more generic & accurate it's not BIOS anymore! -----Original Message----- From: Gao, Zhichao=20 Sent: Monday, April 15, 2019 11:08 AM To: devel@edk2.groups.io Cc: Piwko, Maciej ; Bu, Daocheng ; Oram, Isaac W ; Gao, Liming Subject: [edk2-platforms/devel-MinPlatform][PATCH 3/5] LewisburgPkg/DxeRunt= imeResetSystemLib: Add a new API ResetSystem REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1460 Add a new API ResetSystem to this ResetSystemLib instance. It only adds the basic functions from ResetSystemRuntimeDxe. Lacking of this interface may cause link error, if some drivers use this ne= w API and link to this library instance. Make the ResetPlatformSpecific's parameters same with the interface in Edk2= repo. Notes: This library API only provide a basic function of reset. If the consumers w= ant full functions, they should use the instance in the MdeModulePkg and ma= ke sure the depex driver is dispatched. Cc: "Piwko, Maciej" Cc: "Bu, Daocheng" Cc: "Oram, Isaac W" Cc: Liming Gao Signed-off-by: Zhichao Gao --- .../DxeRuntimeResetSystemLib/PchReset.c | 47 +++++++++++++++++-- 1 file changed, 44 insertions(+), 3 deletions(-) diff --git a/Silicon/Intel/LewisburgPkg/Library/DxeRuntimeResetSystemLib/Pc= hReset.c b/Silicon/Intel/LewisburgPkg/Library/DxeRuntimeResetSystemLib/PchR= eset.c index cdc0f19c17..673f42e72c 100644 --- a/Silicon/Intel/LewisburgPkg/Library/DxeRuntimeResetSystemLib/PchReset.= c +++ b/Silicon/Intel/LewisburgPkg/Library/DxeRuntimeResetSystemLib/PchRes +++ et.c @@ -1,6 +1,6 @@ /** @file =20 -Copyright (c) 2018, Intel Corporation. All rights reserved.
+Copyright (c) 2018 - 2019, Intel Corporation. All rights reserved.
This program and the accompanying materials are licensed and made availabl= e under the terms and conditions of the BSD License that accompanies this = distribution. The full text of the license may be found at @@ -255,7 +255,6 @@ ResetShut= down ( /** Calling this function causes the system to enter a power state for platf= orm specific. =20 - @param[in] ResetStatus The status code for the reset. @param[in] DataSize The size of ResetData in bytes. @param[in] ResetData Optional element used to introduce a pla= tform specific reset. The exact type of the reset is defined b= y the EFI_GUID that follows @@ -265,7 +264,6 @@ ResetShutdown ( VOID EFIA= PI ResetPlatformSpecific ( - IN EFI_STATUS ResetStatus, IN UINTN DataSize, IN VOID *ResetData OPTIONAL ) @@ -306,6 +304,49 @@ EnterS3WithImmediateWake ( PchReset (mPchResetInstance, (PCH_RESET_TYPE) EfiResetWarm); } =20 +/** + The ResetSystem function resets the entire platform. + + @param[in] ResetType The type of reset to perform. + @param[in] ResetStatus The status code for the reset. + @param[in] DataSize The size, in bytes, of ResetData. + @param[in] ResetData For a ResetType of EfiResetCold, EfiResetWarm,= or EfiResetShutdown + the data buffer starts with a Null-terminated = string, optionally + followed by additional binary data. The string= is a description + that the caller may use to further indicate th= e reason for the + system reset. +**/ +VOID +EFIAPI +ResetSystem ( + IN EFI_RESET_TYPE ResetType, + IN EFI_STATUS ResetStatus, + IN UINTN DataSize, + IN VOID *ResetData OPTIONAL + ) +{ + switch (ResetType) { + case EfiResetWarm: + ResetWarm (); + break; + + case EfiResetCold: + ResetCold (); + break; + + case EfiResetShutdown: + ResetShutdown (); + return ; + + case EfiResetPlatformSpecific: + ResetPlatformSpecific (DataSize, ResetData); + return; + + default: + return ; + } +} + /** PchReset Runtime DXE Driver Entry Point\n - Introduction\n -- 2.21.0.windows.1