Re: [PATCH 0/3] MdePkg/Misc: fix Arm BaseMemoryLib

[Andrew Fish <afish@apple.com>]

> On Sep 2, 2016, at 8:57 AM, Leif Lindholm <leif.lindholm@linaro.org> wrote:
> 
> On Fri, Sep 02, 2016 at 03:49:03PM +0000, Kinney, Michael D wrote:
>> Moving this library into MdePkg looks good to me along with the
>> addition of the 2 new BaseMemoryLib APIs.
>> 
>> Minor issues in ArmPkg.dsc, ArmPkg.dsc.inc not updating the
>> Copyright to 2016.
> 
> Ah, OK, I could fix that before pushing if you'd like?
> 
>> Reviewed-by: Michael Kinney <michael.d.kinney@intel.com>
> 
> Many thanks. I'll wait to hear back from Ard before I push.
> 

Reviewed-by: Andrew Fish <afish@apple.com>

Thanks,

Andrew Fish

> Regards,
> 
> Leif
> 
>> Mike
>> 
>>> -----Original Message-----
>>> From: Leif Lindholm [mailto:leif.lindholm@linaro.org]
>>> Sent: Friday, September 2, 2016 7:29 AM
>>> To: edk2-devel@lists.01.org
>>> Cc: Laszlo Ersek <lersek@redhat.com>; Kinney, Michael D <michael.d.kinney@intel.com>;
>>> Gao, Liming <liming.gao@intel.com>; Ard Biesheuvel <ard.biesheuvel@linaro.org>
>>> Subject: [PATCH 0/3] MdePkg/Misc: fix Arm BaseMemoryLib
>>> 
>>> The recent addition, and use, of new functions IsZeroGuid/IsZeroBuffer
>>> caused all ARM/AARCH64 platforms to stop building. The oversight was
>>> helped by the ARM implementation residing in ArmPkg rather than in
>>> MdePkg with all of the others.
>>> 
>>> Move BaseMemoryLibStm across to MdePkg to reduce risk of similar
>>> accidents in future, and add the new functions.
>>> 
>>> This set resolves the build issue without affecting any non-ARM
>>> platforms, in the interest of getting back to a working master
>>> branch. It would be very nice if it could be approved quickly.
>>> 
>>> Ard Biesheuvel (2):
>>>  MdePkg/BaseMemoryLibStm: implement new IsZeroGuid() API function
>>>  MdePkg/BaseMemoryLibStm: implement new IsZeroBuffer() API function
>>> 
>>> Leif Lindholm (1):
>>>  MdePkg/Misc: Move ARM* BaseMemoryLibStm to MdePkg
>>> 
>>> ArmPkg/ArmPkg.dsc                                  |  1 -
>>> ArmVirtPkg/ArmVirt.dsc.inc                         |  2 +-
>>> BeagleBoardPkg/BeagleBoardPkg.dsc                  |  2 +-
>>> .../Library/BaseMemoryLibStm/AArch64/CopyMem.c     |  0
>>> .../Library/BaseMemoryLibStm/AArch64/SetMem.c      |  0
>>> .../Library/BaseMemoryLibStm/Arm/CopyMem.S         |  0
>>> .../Library/BaseMemoryLibStm/Arm/CopyMem.asm       |  0
>>> .../Library/BaseMemoryLibStm/Arm/SetMem.S          |  0
>>> .../Library/BaseMemoryLibStm/Arm/SetMem.asm        |  0
>>> .../Library/BaseMemoryLibStm/BaseMemoryLibStm.inf  |  1 +
>>> .../Library/BaseMemoryLibStm/CompareMemWrapper.c   |  0
>>> .../Library/BaseMemoryLibStm/CopyMem.c             |  0
>>> .../Library/BaseMemoryLibStm/CopyMemWrapper.c      |  0
>>> .../Library/BaseMemoryLibStm/IsZeroBufferWrapper.c | 54 ++++++++++++++++++++++
>>> .../Library/BaseMemoryLibStm/MemLibGeneric.c       | 29 ++++++++++++
>>> .../Library/BaseMemoryLibStm/MemLibGuid.c          | 29 ++++++++++++
>>> .../Library/BaseMemoryLibStm/MemLibInternals.h     | 17 +++++++
>>> .../Library/BaseMemoryLibStm/ScanMem16Wrapper.c    |  0
>>> .../Library/BaseMemoryLibStm/ScanMem32Wrapper.c    |  0
>>> .../Library/BaseMemoryLibStm/ScanMem64Wrapper.c    |  0
>>> .../Library/BaseMemoryLibStm/ScanMem8Wrapper.c     |  0
>>> .../Library/BaseMemoryLibStm/SetMem.c              |  0
>>> .../Library/BaseMemoryLibStm/SetMem16Wrapper.c     |  0
>>> .../Library/BaseMemoryLibStm/SetMem32Wrapper.c     |  0
>>> .../Library/BaseMemoryLibStm/SetMem64Wrapper.c     |  0
>>> .../Library/BaseMemoryLibStm/SetMemWrapper.c       |  0
>>> .../Library/BaseMemoryLibStm/ZeroMemWrapper.c      |  0
>>> MdePkg/MdePkg.dsc                                  |  1 +
>>> 28 files changed, 133 insertions(+), 3 deletions(-)
>>> rename {ArmPkg => MdePkg}/Library/BaseMemoryLibStm/AArch64/CopyMem.c (100%)
>>> rename {ArmPkg => MdePkg}/Library/BaseMemoryLibStm/AArch64/SetMem.c (100%)
>>> rename {ArmPkg => MdePkg}/Library/BaseMemoryLibStm/Arm/CopyMem.S (100%)
>>> rename {ArmPkg => MdePkg}/Library/BaseMemoryLibStm/Arm/CopyMem.asm (100%)
>>> rename {ArmPkg => MdePkg}/Library/BaseMemoryLibStm/Arm/SetMem.S (100%)
>>> rename {ArmPkg => MdePkg}/Library/BaseMemoryLibStm/Arm/SetMem.asm (100%)
>>> rename {ArmPkg => MdePkg}/Library/BaseMemoryLibStm/BaseMemoryLibStm.inf (94%)
>>> rename {ArmPkg => MdePkg}/Library/BaseMemoryLibStm/CompareMemWrapper.c (100%)
>>> rename {ArmPkg => MdePkg}/Library/BaseMemoryLibStm/CopyMem.c (100%)
>>> rename {ArmPkg => MdePkg}/Library/BaseMemoryLibStm/CopyMemWrapper.c (100%)
>>> create mode 100644 MdePkg/Library/BaseMemoryLibStm/IsZeroBufferWrapper.c
>>> rename {ArmPkg => MdePkg}/Library/BaseMemoryLibStm/MemLibGeneric.c (88%)
>>> rename {ArmPkg => MdePkg}/Library/BaseMemoryLibStm/MemLibGuid.c (81%)
>>> rename {ArmPkg => MdePkg}/Library/BaseMemoryLibStm/MemLibInternals.h (90%)
>>> rename {ArmPkg => MdePkg}/Library/BaseMemoryLibStm/ScanMem16Wrapper.c (100%)
>>> rename {ArmPkg => MdePkg}/Library/BaseMemoryLibStm/ScanMem32Wrapper.c (100%)
>>> rename {ArmPkg => MdePkg}/Library/BaseMemoryLibStm/ScanMem64Wrapper.c (100%)
>>> rename {ArmPkg => MdePkg}/Library/BaseMemoryLibStm/ScanMem8Wrapper.c (100%)
>>> rename {ArmPkg => MdePkg}/Library/BaseMemoryLibStm/SetMem.c (100%)
>>> rename {ArmPkg => MdePkg}/Library/BaseMemoryLibStm/SetMem16Wrapper.c (100%)
>>> rename {ArmPkg => MdePkg}/Library/BaseMemoryLibStm/SetMem32Wrapper.c (100%)
>>> rename {ArmPkg => MdePkg}/Library/BaseMemoryLibStm/SetMem64Wrapper.c (100%)
>>> rename {ArmPkg => MdePkg}/Library/BaseMemoryLibStm/SetMemWrapper.c (100%)
>>> rename {ArmPkg => MdePkg}/Library/BaseMemoryLibStm/ZeroMemWrapper.c (100%)
>>> 
>>> --
>>> 2.9.3
>> 
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel