From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-in7.apple.com (mail-out7.apple.com [17.151.62.29]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id BA9901A1E06 for ; Fri, 2 Sep 2016 08:59:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; d=apple.com; s=mailout2048s; c=relaxed/simple; q=dns/txt; i=@apple.com; t=1472831951; x=2336745551; h=From:Sender:Reply-To:Subject:Date:Message-id:To:Cc:MIME-version:Content-type: Content-transfer-encoding:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-reply-to:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=8/oOMmK4tCKkamqmHK3uTt9v7u1g+msQbY1uVwbQDW4=; b=SmBFXChkNwQZVm3s9B/ORWjjiKXyRaJWejHWhKfyDdQ89vJPEA9Ypv6rbOxDJrxm +OmJCZI2SNqHwI9HUUKftGLJEx+Cv99RO6/48iKBLyw37aheflAgcxR/hIi/j9/L Q/3/vM3IDORX6vLob+rhJAYKGqz9oamrBRtHJR43Y0nkRQWFR7hjTzdm1LqHTrf6 xOspAfVH4ChnZPP8k7byXDsn8WL2iRnkF2uiTTy28JE6mgvSLGob6NOf2nPFp83F Eyx5LzN/WoPCcoccPkXnOm4aNGlTmKnTTRqsfNTv1Zh7a1vKgMwYy0wh5GCeoSXS MYcMt5Nr2oVSipTjfeS5fQ==; Received: from relay6.apple.com (relay6.apple.com [17.128.113.90]) by mail-in7.apple.com (Apple Secure Mail Relay) with SMTP id F7.3B.17422.FC1A9C75; Fri, 2 Sep 2016 08:59:11 -0700 (PDT) X-AuditID: 11973e16-f793f6d00000440e-74-57c9a1cf7ed2 Received: from nwk-mmpp-sz07.apple.com (nwk-mmpp-sz07.apple.com [17.128.115.240]) by relay6.apple.com (Apple SCV relay) with SMTP id 39.0F.23613.FC1A9C75; Fri, 2 Sep 2016 08:59:11 -0700 (PDT) MIME-version: 1.0 Received: from [17.153.16.29] by nwk-mmpp-sz07.apple.com (Oracle Communications Messaging Server 8.0.1.1.0 64bit (built Jun 15 2016)) with ESMTPSA id <0OCV00J3VWEL0P20@nwk-mmpp-sz07.apple.com>; Fri, 02 Sep 2016 08:59:11 -0700 (PDT) Sender: afish@apple.com From: Andrew Fish In-reply-to: <20160902155736.GC4715@bivouac.eciton.net> Date: Fri, 02 Sep 2016 08:59:09 -0700 Cc: Mike Kinney , "edk2-devel@lists.01.org" , Laszlo Ersek , "Gao, Liming" , Ard Biesheuvel Message-id: References: <20160902142912.17297-1-leif.lindholm@linaro.org> <20160902155736.GC4715@bivouac.eciton.net> To: Leif Lindholm X-Mailer: Apple Mail (2.3112) X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrGLMWRmVeSWpSXmKPExsUi2FAYpXt+4clwgzN9ghb/P+xmtNhz6Ciz xafde1gslh3bwWKx4t4GdouOjn9MDmwei/e8ZPK4c20Pm0f37H8sHu/3XWULYInisklJzcks Sy3St0vgyji+5w9rwSfdivfr57A3MC5V62Lk5JAQMJG4NOMaE4QtJnHh3nq2LkYuDiGBvYwS ax++ZYcp2nHhPStE4hCjxJ/VU8E6eAUEJX5MvsfSxcjBwSwgL3HwvCxImFlAS+L7o1YWEFtI 4C2jxJIZJiC2sIC4xLszm5ghbCeJDy9/sIHYbALKEivmfwDbxSlgLrH+6SQwm0VAVWLp3llM IHuZBW4zSvyfMJ0dYq+NxIzdq1ggDtrCKHH84SGwqSICOhKnv/5jhrhaVmLfhgVg70gIPGeT WLr8DtMERpFZSA6fhXD4LCSHL2BkXsUolJuYmaObmWeul1hQkJOql5yfu4kRFDHT7cR2MD5c ZXWIUYCDUYmH90bdyXAh1sSy4srcQ4zSHCxK4rzeM4BCAumJJanZqakFqUXxRaU5qcWHGJk4 OKUaGIV/9B+0KHPieORTUmWrd3ytXd829aeszxhr8/WYL1xNzZxxXWL5W8alTJ9Udmdb7zvt X8jUw3tr+Tmv+ITCzpdnIgSPfEr3PtH2pf3BnimsIQGG+dcnexTODr9TuvSi0ZxTu699L2mU 6Dv51016R6xupftS46hP3c3HeBb9Fjl5bUnJhA0HZJRYijMSDbWYi4oTAazSExh5AgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrIIsWRmVeSWpSXmKPExsUi2FD8Qff8wpPhBivv81j8/7Cb0WLPoaPM Fp9272GxWHZsB4vFinsb2C06Ov4xObB5LN7zksnjzrU9bB7ds/+xeLzfd5UtgCWKyyYlNSez LLVI3y6BK+P4nj+sBZ90K96vn8PewLhUrYuRk0NCwERix4X3rBC2mMSFe+vZuhi5OIQEDjFK /Fk9lQkkwSsgKPFj8j2WLkYODmYBeYmD52VBwswCWhLfH7WygNhCAm8ZJZbMMAGxhQXEJd6d 2cQMYTtJfHj5gw3EZhNQllgx/wM7iM0pYC6x/ukkMJtFQFVi6d5ZTCB7mQVuM0r8nzCdHWKv jcSM3atYIA7awihx/OEhsKkiAjoSp7/+Y4a4WlZi34YFbBMYBWchuXUWwq2zkNy6gJF5FaNA UWpOYqWZXmJBQU6qXnJ+7iZGcIAXRu1gbFhudYhRgINRiYfXoPFkuBBrYllxZS4wMDiYlUR4 teYDhXhTEiurUovy44tKc1KLDzEmA30wkVlKNDkfGH15JfGGJiYGJsbGZsbG5ibmpAkrifNu PXI0XEggPbEkNTs1tSC1CGYLEwenVAOjiurWiX16SUpV8365tHl1nJinlrQjdeHBiAcbl0vN PMsUsztscl9FgIun1Mm7AYFHZpuvNrR4YLBn1oVnuVfVlPI+bFXQeX9IfG98XecS3iNr3nbU 7eT20PVdPrHL91k/78op37VPFG/e1NbLY3oirfPerh9snJNiZwqJLmP23XHjcV7N75Q4JZbi jERDLeai4kQA9fx5wrQCAAA= Subject: Re: [PATCH 0/3] MdePkg/Misc: fix Arm BaseMemoryLib X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Sep 2016 15:59:12 -0000 Content-transfer-encoding: 7BIT Content-type: text/plain; CHARSET=US-ASCII > On Sep 2, 2016, at 8:57 AM, Leif Lindholm wrote: > > On Fri, Sep 02, 2016 at 03:49:03PM +0000, Kinney, Michael D wrote: >> Moving this library into MdePkg looks good to me along with the >> addition of the 2 new BaseMemoryLib APIs. >> >> Minor issues in ArmPkg.dsc, ArmPkg.dsc.inc not updating the >> Copyright to 2016. > > Ah, OK, I could fix that before pushing if you'd like? > >> Reviewed-by: Michael Kinney > > Many thanks. I'll wait to hear back from Ard before I push. > Reviewed-by: Andrew Fish Thanks, Andrew Fish > Regards, > > Leif > >> Mike >> >>> -----Original Message----- >>> From: Leif Lindholm [mailto:leif.lindholm@linaro.org] >>> Sent: Friday, September 2, 2016 7:29 AM >>> To: edk2-devel@lists.01.org >>> Cc: Laszlo Ersek ; Kinney, Michael D ; >>> Gao, Liming ; Ard Biesheuvel >>> Subject: [PATCH 0/3] MdePkg/Misc: fix Arm BaseMemoryLib >>> >>> The recent addition, and use, of new functions IsZeroGuid/IsZeroBuffer >>> caused all ARM/AARCH64 platforms to stop building. The oversight was >>> helped by the ARM implementation residing in ArmPkg rather than in >>> MdePkg with all of the others. >>> >>> Move BaseMemoryLibStm across to MdePkg to reduce risk of similar >>> accidents in future, and add the new functions. >>> >>> This set resolves the build issue without affecting any non-ARM >>> platforms, in the interest of getting back to a working master >>> branch. It would be very nice if it could be approved quickly. >>> >>> Ard Biesheuvel (2): >>> MdePkg/BaseMemoryLibStm: implement new IsZeroGuid() API function >>> MdePkg/BaseMemoryLibStm: implement new IsZeroBuffer() API function >>> >>> Leif Lindholm (1): >>> MdePkg/Misc: Move ARM* BaseMemoryLibStm to MdePkg >>> >>> ArmPkg/ArmPkg.dsc | 1 - >>> ArmVirtPkg/ArmVirt.dsc.inc | 2 +- >>> BeagleBoardPkg/BeagleBoardPkg.dsc | 2 +- >>> .../Library/BaseMemoryLibStm/AArch64/CopyMem.c | 0 >>> .../Library/BaseMemoryLibStm/AArch64/SetMem.c | 0 >>> .../Library/BaseMemoryLibStm/Arm/CopyMem.S | 0 >>> .../Library/BaseMemoryLibStm/Arm/CopyMem.asm | 0 >>> .../Library/BaseMemoryLibStm/Arm/SetMem.S | 0 >>> .../Library/BaseMemoryLibStm/Arm/SetMem.asm | 0 >>> .../Library/BaseMemoryLibStm/BaseMemoryLibStm.inf | 1 + >>> .../Library/BaseMemoryLibStm/CompareMemWrapper.c | 0 >>> .../Library/BaseMemoryLibStm/CopyMem.c | 0 >>> .../Library/BaseMemoryLibStm/CopyMemWrapper.c | 0 >>> .../Library/BaseMemoryLibStm/IsZeroBufferWrapper.c | 54 ++++++++++++++++++++++ >>> .../Library/BaseMemoryLibStm/MemLibGeneric.c | 29 ++++++++++++ >>> .../Library/BaseMemoryLibStm/MemLibGuid.c | 29 ++++++++++++ >>> .../Library/BaseMemoryLibStm/MemLibInternals.h | 17 +++++++ >>> .../Library/BaseMemoryLibStm/ScanMem16Wrapper.c | 0 >>> .../Library/BaseMemoryLibStm/ScanMem32Wrapper.c | 0 >>> .../Library/BaseMemoryLibStm/ScanMem64Wrapper.c | 0 >>> .../Library/BaseMemoryLibStm/ScanMem8Wrapper.c | 0 >>> .../Library/BaseMemoryLibStm/SetMem.c | 0 >>> .../Library/BaseMemoryLibStm/SetMem16Wrapper.c | 0 >>> .../Library/BaseMemoryLibStm/SetMem32Wrapper.c | 0 >>> .../Library/BaseMemoryLibStm/SetMem64Wrapper.c | 0 >>> .../Library/BaseMemoryLibStm/SetMemWrapper.c | 0 >>> .../Library/BaseMemoryLibStm/ZeroMemWrapper.c | 0 >>> MdePkg/MdePkg.dsc | 1 + >>> 28 files changed, 133 insertions(+), 3 deletions(-) >>> rename {ArmPkg => MdePkg}/Library/BaseMemoryLibStm/AArch64/CopyMem.c (100%) >>> rename {ArmPkg => MdePkg}/Library/BaseMemoryLibStm/AArch64/SetMem.c (100%) >>> rename {ArmPkg => MdePkg}/Library/BaseMemoryLibStm/Arm/CopyMem.S (100%) >>> rename {ArmPkg => MdePkg}/Library/BaseMemoryLibStm/Arm/CopyMem.asm (100%) >>> rename {ArmPkg => MdePkg}/Library/BaseMemoryLibStm/Arm/SetMem.S (100%) >>> rename {ArmPkg => MdePkg}/Library/BaseMemoryLibStm/Arm/SetMem.asm (100%) >>> rename {ArmPkg => MdePkg}/Library/BaseMemoryLibStm/BaseMemoryLibStm.inf (94%) >>> rename {ArmPkg => MdePkg}/Library/BaseMemoryLibStm/CompareMemWrapper.c (100%) >>> rename {ArmPkg => MdePkg}/Library/BaseMemoryLibStm/CopyMem.c (100%) >>> rename {ArmPkg => MdePkg}/Library/BaseMemoryLibStm/CopyMemWrapper.c (100%) >>> create mode 100644 MdePkg/Library/BaseMemoryLibStm/IsZeroBufferWrapper.c >>> rename {ArmPkg => MdePkg}/Library/BaseMemoryLibStm/MemLibGeneric.c (88%) >>> rename {ArmPkg => MdePkg}/Library/BaseMemoryLibStm/MemLibGuid.c (81%) >>> rename {ArmPkg => MdePkg}/Library/BaseMemoryLibStm/MemLibInternals.h (90%) >>> rename {ArmPkg => MdePkg}/Library/BaseMemoryLibStm/ScanMem16Wrapper.c (100%) >>> rename {ArmPkg => MdePkg}/Library/BaseMemoryLibStm/ScanMem32Wrapper.c (100%) >>> rename {ArmPkg => MdePkg}/Library/BaseMemoryLibStm/ScanMem64Wrapper.c (100%) >>> rename {ArmPkg => MdePkg}/Library/BaseMemoryLibStm/ScanMem8Wrapper.c (100%) >>> rename {ArmPkg => MdePkg}/Library/BaseMemoryLibStm/SetMem.c (100%) >>> rename {ArmPkg => MdePkg}/Library/BaseMemoryLibStm/SetMem16Wrapper.c (100%) >>> rename {ArmPkg => MdePkg}/Library/BaseMemoryLibStm/SetMem32Wrapper.c (100%) >>> rename {ArmPkg => MdePkg}/Library/BaseMemoryLibStm/SetMem64Wrapper.c (100%) >>> rename {ArmPkg => MdePkg}/Library/BaseMemoryLibStm/SetMemWrapper.c (100%) >>> rename {ArmPkg => MdePkg}/Library/BaseMemoryLibStm/ZeroMemWrapper.c (100%) >>> >>> -- >>> 2.9.3 >> > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel