Marvin

On 30. Mar 2023, at 09:3= 1, Lean Sheng Tan <sheng.tan@9elements.com> wrote:

=EF=BB=BF
HI Liming,
If no further concern, would you mind to help get thi= s patch merged?
Thanks!

Best Regards,
Lean Sheng Tan

On Tue, 28 Mar 2023 at 07:42, gaoliming via groups.io <gaoliming=3Dbyosoft.com.cn@groups.io> wrote:
Reviewed-by: Liming Gao <gaoliming@byosoft.co= m.cn>

> -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6-----
> =E5=8F=91=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io <devel@edk2.groups.io> =E4=BB=A3=E8=A1= =A8 Patrick
> Rudolph
> =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2023=E5=B9=B43=E6=9C=8817=E6=97= =A5 22:06
> =E6=8A=84=E9=80=81: devel@edk2.groups.io; guo.dong@intel.com; gua.guo@intel.com;
> james.lu@intel= .com; ray.ni@inte= l.com; mhaeuser= @posteo.de;
> ardb@kernel.org
> =E4=B8=BB=E9=A2=98: [edk2-devel] [PATCH 1/3] BaseTools/Conf/tools_def:= Fix linking using
> CLANGDWARF_IA32
>
> The clang toolchain might default to fPIE/fPIC, which prevents
> lld from linking the objects into a binary.
>
> Specify -fno-pie -fno-pic as done on GCC to fix linking.
>
> Test:
> Building the Universal Payload using the command
> 'python UefiPayloadPkg/UniversalPayloadBuild.py -a IA32' actually
> works.
>
> Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com>
> Ref: https://bugzilla.tianocore.org/show_b= ug.cgi?id=3D4356
> ---
> BaseTools/Conf/tools_def.template | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/BaseTools/Conf/tools_def.template
> b/BaseTools/Conf/tools_def.template
> index 471eb67c0c..9b59bd75c3 100755
> --- a/BaseTools/Conf/tools_def.template
> +++ b/BaseTools/Conf/tools_def.template
> @@ -2888,7 +2888,7 @@ DEFINE CLANGDWARF_X64_DLINK2_FLAGS
> =3D -Wl,--defsym=3DPECOFF_HEADER_SIZE=3D0x22
> *_CLANGDWARF_IA32_RC_PATH &nbs= p; =3D
> DEF(CLANGDWARF_IA32_PREFIX)llvm-rc
>
>
>
> *_CLANGDWARF_IA32_ASLCC_FLAGS = =3D DEF(GCC_ASLCC_FLAGS)
> -m32 -fno-lto DEF(CLANG38_IA32_TARGET)
>
> -*_CLANGDWARF_IA32_ASLDLINK_FLAGS =3D
> DEF(CLANGDWARF_IA32_X64_ASLDLINK_FLAGS) -Wl,-m,elf_i386 -fuse-ld=3Dlld=
>
> +*_CLANGDWARF_IA32_ASLDLINK_FLAGS =3D
> DEF(CLANGDWARF_IA32_X64_ASLDLINK_FLAGS) -Wl,-m,elf_i386 -fuse-ld=3Dlld=
> -no-pie
>
> *_CLANGDWARF_IA32_ASM_FLAGS &n= bsp; =3D DEF(GCC5_ASM_FLAGS)
> -m32 -march=3Di386 DEF(CLANG38_IA32_TARGET)
>
> *_CLANGDWARF_IA32_RC_FLAGS &nb= sp; =3D
> DEF(GCC_IA32_RC_FLAGS)
>
> *_CLANGDWARF_IA32_OBJCOPY_FLAGS =3D >
> @@ -2897,17 +2897,17 @@ DEFINE CLANGDWARF_X64_DLINK2_FLAGS
> =3D -Wl,--defsym=3DPECOFF_HEADER_SIZE=3D0x22
> *_CLANGDWARF_IA32_ASLPP_FLAGS = =3D DEF(GCC_ASLPP_FLAGS)
> DEF(CLANG38_IA32_TARGET)
>
> *_CLANGDWARF_IA32_VFRPP_FLAGS = =3D DEF(GCC_VFRPP_FLAGS)
> DEF(CLANG38_IA32_TARGET)
>
>
>
> -DEBUG_CLANGDWARF_IA32_CC_FLAGS =3D > DEF(CLANG38_ALL_CC_FLAGS) -m32 -Oz -flto -march=3Di586
> DEF(CLANG38_IA32_TARGET) -g -malign-double
>
> +DEBUG_CLANGDWARF_IA32_CC_FLAGS =3D > DEF(CLANG38_ALL_CC_FLAGS) -fno-pic -fno-pie -m32 -Oz -flto -march=3Di5= 86
> DEF(CLANG38_IA32_TARGET) -g -malign-double
>
> DEBUG_CLANGDWARF_IA32_DLINK_FLAGS =3D
> DEF(CLANGDWARF_IA32_X64_DLINK_FLAGS) -flto -Wl,-O3 -Wl,-melf_i386
> -Wl,--oformat,elf32-i386
>
> -DEBUG_CLANGDWARF_IA32_DLINK2_FLAGS =3D
> DEF(CLANGDWARF_IA32_DLINK2_FLAGS) -O3 -fuse-ld=3Dlld
>
> +DEBUG_CLANGDWARF_IA32_DLINK2_FLAGS =3D
> DEF(CLANGDWARF_IA32_DLINK2_FLAGS) -O3 -fuse-ld=3Dlld -no-pie
>
>
>
> -RELEASE_CLANGDWARF_IA32_CC_FLAGS =3D
> DEF(CLANG38_ALL_CC_FLAGS) -m32 -Oz -flto -march=3Di586
> DEF(CLANG38_IA32_TARGET) -malign-double
>
> +RELEASE_CLANGDWARF_IA32_CC_FLAGS =3D
> DEF(CLANG38_ALL_CC_FLAGS) -fno-pic -fno-pie -m32 -Oz -flto -march=3Di5= 86
> DEF(CLANG38_IA32_TARGET) -malign-double
>
> RELEASE_CLANGDWARF_IA32_DLINK_FLAGS =3D
> DEF(CLANGDWARF_IA32_X64_DLINK_FLAGS) -flto -Wl,-O3 -Wl,-melf_i386
> -Wl,--oformat,elf32-i386
>
> -RELEASE_CLANGDWARF_IA32_DLINK2_FLAGS =3D
> DEF(CLANGDWARF_IA32_DLINK2_FLAGS) -O3 -fuse-ld=3Dlld
>
> +RELEASE_CLANGDWARF_IA32_DLINK2_FLAGS =3D
> DEF(CLANGDWARF_IA32_DLINK2_FLAGS) -O3 -fuse-ld=3Dlld -no-pie
>
>
>
> -NOOPT_CLANGDWARF_IA32_CC_FLAGS =3D > DEF(CLANG38_ALL_CC_FLAGS) -m32 -O0 -march=3Di586
> DEF(CLANG38_IA32_TARGET) -g -malign-double
>
> +NOOPT_CLANGDWARF_IA32_CC_FLAGS =3D > DEF(CLANG38_ALL_CC_FLAGS) -fno-pic -fno-pie -m32 -O0 -march=3Di586
> DEF(CLANG38_IA32_TARGET) -g -malign-double
>
> NOOPT_CLANGDWARF_IA32_DLINK_FLAGS =3D
> DEF(CLANGDWARF_IA32_X64_DLINK_FLAGS) -Wl,-O0 -Wl,-melf_i386
> -Wl,--oformat,elf32-i386
>
> -NOOPT_CLANGDWARF_IA32_DLINK2_FLAGS =3D
> DEF(CLANGDWARF_IA32_DLINK2_FLAGS) -O0 -fuse-ld=3Dlld
>
> +NOOPT_CLANGDWARF_IA32_DLINK2_FLAGS =3D
> DEF(CLANGDWARF_IA32_DLINK2_FLAGS) -O0 -fuse-ld=3Dlld -no-pie
>
>
>
> ##########################
>
> # CLANGDWARF X64 definitions
>
> --
> 2.39.1
>
>
>
> -=3D-=3D-=3D-=3D-=3D-=3D
> Groups.io Links: You receive all messages sent to this group.
> View/Reply Online (#101340):
> https://edk2.groups.io/g/devel/message/101340<= br> > Mute This Topic: https://groups.io/mt/97673648/4905953=
> Group Owner: devel+owner@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub
> [gaolimi= ng@byosoft.com.cn]
> -=3D-=3D-=3D-=3D-=3D-=3D
>