From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mout01.posteo.de (mout01.posteo.de [185.67.36.65])
 by mx.groups.io with SMTP id smtpd.web11.5442.1682056879411212038
 for <devel@edk2.groups.io>;
 Thu, 20 Apr 2023 23:01:20 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@posteo.de header.s=2017 header.b=Mz1+kXxa;
 spf=pass (domain: posteo.de, ip: 185.67.36.65, mailfrom: mhaeuser@posteo.de)
Received: from submission (posteo.de [185.67.36.169]) 
	by mout01.posteo.de (Postfix) with ESMTPS id AEF51240238
	for <devel@edk2.groups.io>; Fri, 21 Apr 2023 08:01:16 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.de; s=2017;
	t=1682056876; bh=nPUp9EYBb8I42fd0hsEToXRRsh+vY3TntefX/VU5VSQ=;
	h=From:Subject:Date:Cc:To:From;
	b=Mz1+kXxasesjLKIXjCRTp7JDOQ4bhq8E4VyftREBLlHZ8QtBc4v/ZrNVzCF58/ns4
	 IasBehQD7NawntRbuhASQODNE0Vx/922uhGjwxj1xLSaQJ+zBU8xskbaYtMvoHlnsi
	 9M4yL9tGbeXs/Hqf16izPtwX77mMZcDOevfg/76F2vadPIpxgWrwxiQkn9q4jE0hIX
	 J+nqUG+DRJO9X1GtMfLzoSmABfuHblJAboFFlDNWlxGPS2zVQ40i+JLbQ2jP5ZJ4if
	 9GIEoHRgsJ9nRoE5MeKDygGADziEFa6UhUHLjfgsYTBA8OLkNPNbah6lg+Kd0TfK9g
	 WNNttcXhfCcaQ==
Received: from customer (localhost [127.0.0.1])
	by submission (posteo.de) with ESMTPSA id 4Q2kRW4wFgz9rxK;
	Fri, 21 Apr 2023 08:01:11 +0200 (CEST)
From: =?UTF-8?B?TWFydmluIEjDpHVzZXI=?= <mhaeuser@posteo.de>
Mime-Version: 1.0 (1.0)
Subject: Re: [PATCH v5 02/10] MdePkg: don't set visibility to hidden
Date: Fri, 21 Apr 2023 06:01:11 +0000
Message-Id: <A520C426-43A2-445D-9CF4-F20C37C87024@posteo.de>
References: <20230421044535.4030762-3-kraxel@redhat.com>
Cc: devel@edk2.groups.io, Yuwei Chen <yuwei.chen@intel.com>,
 Oliver Steffen <osteffen@redhat.com>, Bob Feng <bob.c.feng@intel.com>,
 Daniel Schaefer <git@danielschaefer.me>, Chao Li <lichao@loongson.cn>,
 Dongyan Qian <qiandongyan@loongson.cn>,
 Michael D Kinney <michael.d.kinney@intel.com>,
 Pawel Polawski <ppolawsk@redhat.com>, Baoqi Zhang <zhangbaoqi@loongson.cn>,
 Leif Lindholm <quic_llindhol@quicinc.com>,
 Rebecca Cran <rebecca@bsdio.com>, Zhiguang Liu <zhiguang.liu@intel.com>,
 Sunil V L <sunilvl@ventanamicro.com>,
 Ard Biesheuvel <ardb+tianocore@kernel.org>,
 Liming Gao <gaoliming@byosoft.com.cn>
In-Reply-To: <20230421044535.4030762-3-kraxel@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


> On 21. Apr 2023, at 06:45, Gerd Hoffmann <kraxel@redhat.com> wrote:
>=20
> =EF=BB=BFNot needed any more on modern toolchains, they are better
> in not creating a GOT without this trick.

Hi Gerd,

Thanks! Just out of interest, how did you test this and what were the result=
s?

Best regards,
Marvin

>=20
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
> MdePkg/Include/X64/ProcessorBind.h | 14 --------------
> 1 file changed, 14 deletions(-)
>=20
> diff --git a/MdePkg/Include/X64/ProcessorBind.h b/MdePkg/Include/X64/Proce=
ssorBind.h
> index f0a4d00142b9..afbb4b6273fb 100644
> --- a/MdePkg/Include/X64/ProcessorBind.h
> +++ b/MdePkg/Include/X64/ProcessorBind.h
> @@ -21,20 +21,6 @@
>   #pragma pack()
> #endif
>=20
> -#if defined (__GNUC__) && defined (__pic__) && !defined (USING_LTO)  && !=
defined (__APPLE__)
> -//
> -// Mark all symbol declarations and references as hidden, meaning they wi=
ll
> -// not be subject to symbol preemption. This allows the compiler to refer=
 to
> -// symbols directly using relative references rather than via the GOT, wh=
ich
> -// contains absolute symbol addresses that are subject to runtime relocat=
ion.
> -//
> -// The LTO linker will not emit GOT based relocations when all symbol
> -// references can be resolved locally, and so there is no need to set the=

> -// pragma in that case (and doing so will cause other issues).
> -//
> -  #pragma GCC visibility push (hidden)
> -#endif
> -
> #if defined (__INTEL_COMPILER)
> //
> // Disable ICC's remark #869: "Parameter" was never referenced warning.
> --=20
> 2.40.0
>=20