From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: yi.qian@intel.com) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by groups.io with SMTP; Wed, 17 Apr 2019 19:11:25 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Apr 2019 19:11:25 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,364,1549958400"; d="scan'208";a="162595594" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga002.fm.intel.com with ESMTP; 17 Apr 2019 19:11:25 -0700 Received: from fmsmsx126.amr.corp.intel.com (10.18.125.43) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 17 Apr 2019 19:11:25 -0700 Received: from shsmsx105.ccr.corp.intel.com (10.239.4.158) by FMSMSX126.amr.corp.intel.com (10.18.125.43) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 17 Apr 2019 19:11:24 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.206]) by SHSMSX105.ccr.corp.intel.com ([169.254.11.25]) with mapi id 14.03.0415.000; Thu, 18 Apr 2019 10:11:21 +0800 From: "Qian, Yi" To: "Sun, Zailiang" , "devel@edk2.groups.io" CC: "Wei, David" Subject: Re: [PATCH] Vlv2TbltDevicePkg: Remove ResetSystem declaration Thread-Topic: [PATCH] Vlv2TbltDevicePkg: Remove ResetSystem declaration Thread-Index: AQHU9P7+vknBvYc8B06bCmEtnXu3ZaZBLepw Date: Thu, 18 Apr 2019 02:11:20 +0000 Message-ID: References: <20190417092129.5952-1-zailiang.sun@intel.com> In-Reply-To: <20190417092129.5952-1-zailiang.sun@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: yi.qian@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed by Qian, Yi Thanks Qian Yi -----Original Message----- From: Sun, Zailiang=20 Sent: Wednesday, April 17, 2019 5:21 PM To: devel@edk2.groups.io Cc: Wei, David ; Qian, Yi Subject: [PATCH] Vlv2TbltDevicePkg: Remove ResetSystem declaration Use MdeModulePkg declaration of ResetSystem function, comment the one in p= latform source code. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Zailiang Sun Cc: David Wei Cc: Yi Qian --- Vlv2TbltDevicePkg/PlatformPei/Platform.c | 1 - Vlv2TbltDevicePkg/Platfo= rmPei/Platform.h | 12 +++++++----- 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/Vlv2TbltDevicePkg/PlatformPei/Platform.c b/Vlv2TbltDevicePkg/= PlatformPei/Platform.c index cf47a56a52..eba1dfff30 100644 --- a/Vlv2TbltDevicePkg/PlatformPei/Platform.c +++ b/Vlv2TbltDevicePkg/PlatformPei/Platform.c @@ -18,7 +18,6 @@ Module Name: #include "PlatformBaseAddresses.h" #include "PchAccess.h" #include -#include "Platform.h" #include "PchCommonDefinitions.h" #include #include diff --git a/Vlv2TbltDevicePkg/PlatformPei/Platform.h b/Vlv2TbltDevicePkg/= PlatformPei/Platform.h index 4158dd4cf5..e1817b28c6 100644 --- a/Vlv2TbltDevicePkg/PlatformPei/Platform.h +++ b/Vlv2TbltDevicePkg/PlatformPei/Platform.h @@ -47,16 +47,18 @@ UpdateBootMode ( /** This function reset the entire platform, including all processor and de= vices, and reboots the system. + + Declaration of this function goes to=20 + MdeModulePkg/Include/Library/ResetSystemLib.h =20 @param PeiServices General purpose services available to every PEIM. =20 @retval EFI_SUCCESS if it completed successfully. **/ -EFI_STATUS -EFIAPI -ResetSystem ( - IN CONST EFI_PEI_SERVICES **PeiServices - ); +// EFI_STATUS +// EFIAPI +// ResetSystem ( + // IN CONST EFI_PEI_SERVICES **PeiServices + // ); =20 /** This function will be called when MRC is done. -- 2.19.1.windows.1 --=20 Qian Yi