From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: yi.qian@intel.com) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by groups.io with SMTP; Thu, 09 May 2019 06:18:31 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 May 2019 06:18:30 -0700 X-ExtLoop1: 1 Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga006.fm.intel.com with ESMTP; 09 May 2019 06:18:30 -0700 Received: from fmsmsx111.amr.corp.intel.com (10.18.116.5) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 9 May 2019 06:18:30 -0700 Received: from shsmsx108.ccr.corp.intel.com (10.239.4.97) by fmsmsx111.amr.corp.intel.com (10.18.116.5) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 9 May 2019 06:18:30 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.249]) by SHSMSX108.ccr.corp.intel.com ([169.254.8.126]) with mapi id 14.03.0415.000; Thu, 9 May 2019 21:18:28 +0800 From: "Qian, Yi" To: "Kinney, Michael D" , "devel@edk2.groups.io" CC: "Sun, Zailiang" Subject: Re: [Patch 03/16] Vlv2TbltDevicePkg/AcpiPlatform: Add variable protocols to depex Thread-Topic: [Patch 03/16] Vlv2TbltDevicePkg/AcpiPlatform: Add variable protocols to depex Thread-Index: AQHVBiAQoDY6sqyCJ0e+e2pDOhfXAaZixwvA Date: Thu, 9 May 2019 13:18:27 +0000 Message-ID: References: <20190509043111.15272-1-michael.d.kinney@intel.com> <20190509043111.15272-4-michael.d.kinney@intel.com> In-Reply-To: <20190509043111.15272-4-michael.d.kinney@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: yi.qian@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed by Qian, Yi Thanks QianYi -----Original Message----- From: Kinney, Michael D=20 Sent: Thursday, May 9, 2019 12:31 PM To: devel@edk2.groups.io Cc: Sun, Zailiang ; Qian, Yi Subject: [Patch 03/16] Vlv2TbltDevicePkg/AcpiPlatform: Add variable protoc= ols to depex Add the arch protocols gEfiVariableArchProtocolGuid and gEfiVariableWriteA= rchProtocolGuid to the dependency expression for the AcpiPlatform module to= guarantee that the variables that AcpiPlatform depends upon are set before= they are used by this module. Cc: Zailiang Sun Cc: Yi Qian Signed-off-by: Michael D Kinney --- Vlv2TbltDevicePkg/AcpiPlatform/AcpiPlatform.inf | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/Vlv2TbltDevicePkg/AcpiPlatform/AcpiPlatform.inf b/Vlv2TbltDev= icePkg/AcpiPlatform/AcpiPlatform.inf index 8422985764..c59920db03 100644 --- a/Vlv2TbltDevicePkg/AcpiPlatform/AcpiPlatform.inf +++ b/Vlv2TbltDevicePkg/AcpiPlatform/AcpiPlatform.inf @@ -1,10 +1,12 @@ # # -# Copyright (c) 1999 - 2018, Intel Corporation. All rights reserved -# = +# Copyright (c) 1999 - 2019, Intel Corporation. All rights reserved # + # SPDX-License-Identifier: BSD-2-Clause-Patent =20 -# = +# + # # # Module Name: @@ -79,6 +81,8 @@ [Pcd] gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiTableStorageFile =20 [Depex] + gEfiVariableArchProtocolGuid AND + gEfiVariableWriteArchProtocolGuid AND gEfiAcpiSupportProtocolGuid AND gEfiMpServiceProtocolGuid AND gEfiCpuIoProtocolGuid -- 2.21.0.windows.1 --=20 Qian Yi