From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: yi.qian@intel.com) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by groups.io with SMTP; Thu, 09 May 2019 06:19:09 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 May 2019 06:19:09 -0700 X-ExtLoop1: 1 Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga007.fm.intel.com with ESMTP; 09 May 2019 06:19:09 -0700 Received: from fmsmsx112.amr.corp.intel.com (10.18.116.6) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 9 May 2019 06:19:08 -0700 Received: from shsmsx105.ccr.corp.intel.com (10.239.4.158) by FMSMSX112.amr.corp.intel.com (10.18.116.6) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 9 May 2019 06:19:08 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.249]) by SHSMSX105.ccr.corp.intel.com ([169.254.11.10]) with mapi id 14.03.0415.000; Thu, 9 May 2019 21:19:06 +0800 From: "Qian, Yi" To: "Kinney, Michael D" , "devel@edk2.groups.io" CC: "Sun, Zailiang" Subject: Re: [Patch 04/16] Vlv2TbltDevicePkg/PpmPolicy: Fix call to MP Services Protocol Thread-Topic: [Patch 04/16] Vlv2TbltDevicePkg/PpmPolicy: Fix call to MP Services Protocol Thread-Index: AQHVBiARI9GgPAafdkmcB6L+418yn6Zix0gA Date: Thu, 9 May 2019 13:19:06 +0000 Message-ID: References: <20190509043111.15272-1-michael.d.kinney@intel.com> <20190509043111.15272-5-michael.d.kinney@intel.com> In-Reply-To: <20190509043111.15272-5-michael.d.kinney@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: yi.qian@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed by Qian, Yi Thanks QianYi -----Original Message----- From: Kinney, Michael D=20 Sent: Thursday, May 9, 2019 12:31 PM To: devel@edk2.groups.io Cc: Sun, Zailiang ; Qian, Yi Subject: [Patch 04/16] Vlv2TbltDevicePkg/PpmPolicy: Fix call to MP Service= s Protocol The NumberOfEnabledProcessors parameter to the MP Services Protocol servic= e GetNumberOfProcessors() is not optional and is not allowed to be NULL. A= dd the CpuEnabledCount local variable and pass it into GetNumberOfProcessor= s(). Cc: Zailiang Sun Cc: Yi Qian Signed-off-by: Michael D Kinney --- Vlv2TbltDevicePkg/PpmPolicy/PpmPolicy.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/Vlv2TbltDevicePkg/PpmPolicy/PpmPolicy.c b/Vlv2TbltDevicePkg/P= pmPolicy/PpmPolicy.c index 28de8457ce..3583e324e6 100644 --- a/Vlv2TbltDevicePkg/PpmPolicy/PpmPolicy.c +++ b/Vlv2TbltDevicePkg/PpmPolicy/PpmPolicy.c @@ -1,5 +1,5 @@ /** - Copyright (c) 2009 - 2013, Intel Corporation. All rights reserved.
+ Copyright (c) 2009 - 2019, Intel Corporation. All rights=20 + reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent =20 =20 @@ -40,6 +40,7 @@ PpmPolicyEntry( EFI_HANDLE Handle; EFI_STATUS Status; UINTN CpuCount; + UINTN CpuEnabledCount; UINT8 CPUMobileFeature; =20 PCH_STEPPING Stepping; @@ -63,7 +64,7 @@ PpmPolicyEntry( // // Get processor count from MP service. // - Status =3D MpService->GetNumberOfProcessors (MpService, &CpuCount, NULL= ); + Status =3D MpService->GetNumberOfProcessors (MpService, &CpuCount,=20 + &CpuEnabledCount); ASSERT_EFI_ERROR (Status); =20 // -- 2.21.0.windows.1 --=20 Qian Yi