From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.120, mailfrom: yi.qian@intel.com) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by groups.io with SMTP; Thu, 09 May 2019 06:19:21 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 May 2019 06:19:21 -0700 X-ExtLoop1: 1 Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga008.jf.intel.com with ESMTP; 09 May 2019 06:19:20 -0700 Received: from FMSMSX109.amr.corp.intel.com (10.18.116.9) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 9 May 2019 06:19:20 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx109.amr.corp.intel.com (10.18.116.9) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 9 May 2019 06:19:19 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.249]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.129]) with mapi id 14.03.0415.000; Thu, 9 May 2019 21:19:17 +0800 From: "Qian, Yi" To: "Kinney, Michael D" , "devel@edk2.groups.io" CC: "Sun, Zailiang" Subject: Re: [Patch 02/16] Vlv2TbltDevicePkg/AcpiPlatform: Change Size type to UINTN Thread-Topic: [Patch 02/16] Vlv2TbltDevicePkg/AcpiPlatform: Change Size type to UINTN Thread-Index: AQHVBiAROWVDTMcUwUKJuW4gxELT/6Zix1dQ Date: Thu, 9 May 2019 13:19:17 +0000 Message-ID: References: <20190509043111.15272-1-michael.d.kinney@intel.com> <20190509043111.15272-3-michael.d.kinney@intel.com> In-Reply-To: <20190509043111.15272-3-michael.d.kinney@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: yi.qian@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed by Qian, Yi Thanks QianYi -----Original Message----- From: Kinney, Michael D=20 Sent: Thursday, May 9, 2019 12:31 PM To: devel@edk2.groups.io Cc: Sun, Zailiang ; Qian, Yi Subject: [Patch 02/16] Vlv2TbltDevicePkg/AcpiPlatform: Change Size type to= UINTN Change the type of the local variable Size in the function AcpiPlatformEntryPoint() from UINT32 to UINTN. This local variable is pas= sed into the function ReadSection() that returns a value of type UINTN. Us= ing type UINT32 can potentially corrupt an adjacent local on the stack. Cc: Zailiang Sun Cc: Yi Qian Signed-off-by: Michael D Kinney --- Vlv2TbltDevicePkg/AcpiPlatform/AcpiPlatform.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Vlv2TbltDevicePkg/AcpiPlatform/AcpiPlatform.c b/Vlv2TbltDevic= ePkg/AcpiPlatform/AcpiPlatform.c index 0bd375391e..5c03f66edb 100644 --- a/Vlv2TbltDevicePkg/AcpiPlatform/AcpiPlatform.c +++ b/Vlv2TbltDevicePkg/AcpiPlatform/AcpiPlatform.c @@ -1,6 +1,6 @@ /** @file =20 - Copyright (c) 2004 - 2018, Intel Corporation. All rights reserved.
+ Copyright (c) 2004 - 2019, Intel Corporation. All rights=20 + reserved.
=20 =20 SPDX-License-Identifier: BSD-2-Clause-Patent @@ -778,7 +778,7 @@ AcpiPl= atformEntryPoint ( EFI_ACPI_COMMON_HEADER *CurrentTable; UINTN TableHandle; UINT32 FvStatus; - UINT32 Size; + UINTN Size; EFI_EVENT Event; EFI_ACPI_TABLE_VERSION TableVersion; UINTN VarSize; @@ -1223,7 +1223,7 @@ AcpiPlatformEntryPoint ( EFI_SECTION_RAW, Instance, (VOID **) &CurrentTable, - (UINTN *) &Size, + &Size, &FvStatus ); =20 -- 2.21.0.windows.1 --=20 Qian Yi