From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.120, mailfrom: yi.qian@intel.com) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by groups.io with SMTP; Thu, 09 May 2019 06:20:24 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 May 2019 06:20:24 -0700 X-ExtLoop1: 1 Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga003.jf.intel.com with ESMTP; 09 May 2019 06:20:24 -0700 Received: from fmsmsx114.amr.corp.intel.com (10.18.116.8) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 9 May 2019 06:20:24 -0700 Received: from shsmsx153.ccr.corp.intel.com (10.239.6.53) by FMSMSX114.amr.corp.intel.com (10.18.116.8) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 9 May 2019 06:20:23 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.249]) by SHSMSX153.ccr.corp.intel.com ([169.254.12.150]) with mapi id 14.03.0415.000; Thu, 9 May 2019 21:20:21 +0800 From: "Qian, Yi" To: "Kinney, Michael D" , "devel@edk2.groups.io" CC: "Sun, Zailiang" Subject: Re: [Patch 10/16] Vlv2TbltDevicePkg: Always enable QuietBoot to produce BGRT Thread-Topic: [Patch 10/16] Vlv2TbltDevicePkg: Always enable QuietBoot to produce BGRT Thread-Index: AQHVBiASDseCtrCA5Ee6M/DkCEe69aZix6FA Date: Thu, 9 May 2019 13:20:21 +0000 Message-ID: References: <20190509043111.15272-1-michael.d.kinney@intel.com> <20190509043111.15272-11-michael.d.kinney@intel.com> In-Reply-To: <20190509043111.15272-11-michael.d.kinney@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: yi.qian@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed by Qian, Yi Thanks QianYi -----Original Message----- From: Kinney, Michael D=20 Sent: Thursday, May 9, 2019 12:31 PM To: devel@edk2.groups.io Cc: Sun, Zailiang ; Qian, Yi Subject: [Patch 10/16] Vlv2TbltDevicePkg: Always enable QuietBoot to produ= ce BGRT Cc: Zailiang Sun Cc: Yi Qian Signed-off-by: Michael D Kinney --- .../Library/PlatformBdsLib/BdsPlatform.c | 19 +++++++++---------- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/Vlv2TbltDevicePkg/Library/PlatformBdsLib/BdsPlatform.c b/Vlv2= TbltDevicePkg/Library/PlatformBdsLib/BdsPlatform.c index e86c6b3e2e..4d5997d6e9 100644 --- a/Vlv2TbltDevicePkg/Library/PlatformBdsLib/BdsPlatform.c +++ b/Vlv2TbltDevicePkg/Library/PlatformBdsLib/BdsPlatform.c @@ -1,6 +1,6 @@ /** @file =20 - Copyright (c) 2004 - 2018, Intel Corporation. All rights reserved.
+ Copyright (c) 2004 - 2019, Intel Corporation. All rights reserved.
= SPDX-License-Identifier: BSD-2-Clause-Patent = @@ -1702,6 +1702,8 @@ PlatformBdsPolicyBehavior ( EsrtManagement =3D NULL; } =20 + DEBUG ((DEBUG_INFO, "BDS: BootMode=3D%02x\n", BootMode)); + switch (BootMode) { =20 case BOOT_WITH_MINIMAL_CONFIGURATION: @@ -1778,9 +1780,8 @@ PlatformBdsPolicyBehavior ( goto FULL_CONFIGURATION; } =20 - if (SystemConfiguration.QuietBoot) { - EnableQuietBoot (PcdGetPtr(PcdLogoFile)); - } else { + EnableQuietBoot (PcdGetPtr(PcdLogoFile)); + if (!SystemConfiguration.QuietBoot) { PlatformBdsDiagnostics (IGNORE, FALSE, BaseMemoryTest); } =20 @@ -1864,8 +1865,7 @@ PlatformBdsPolicyBehavior ( // Boot with the specific configuration // PlatformBdsConnectConsole (gPlatformConsole); - PlatformBdsDiagnostics (EXTENSIVE, FALSE, BaseMemoryTest); - EnableQuietBoot (PcdGetPtr(PcdLogoFile)); + PlatformBdsDiagnostics (EXTENSIVE, TRUE, BaseMemoryTest); =20 DEBUG((DEBUG_INFO, "ProcessCapsules Before EndOfDxe......\n")); ProcessCapsules (); @@ -1968,10 +1968,9 @@ FULL_CONFIGURATION: // Perform some platform specific connect sequence // PlatformBdsConnectSequence (); - if (SystemConfiguration.QuietBoot) { - EnableQuietBoot (PcdGetPtr(PcdLogoFile)); - } else { - PlatformBdsDiagnostics (IGNORE, FALSE, BaseMemoryTest); + EnableQuietBoot (PcdGetPtr(PcdLogoFile)); + if (!SystemConfiguration.QuietBoot) { + PlatformBdsDiagnostics (IGNORE, FALSE, BaseMemoryTest); } =20 // --=20 2.21.0.windows.1 --=20 Qian Yi