From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: yi.qian@intel.com) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by groups.io with SMTP; Thu, 09 May 2019 06:20:33 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 May 2019 06:20:33 -0700 X-ExtLoop1: 1 Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga006.fm.intel.com with ESMTP; 09 May 2019 06:20:33 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 9 May 2019 06:20:32 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.249]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.216]) with mapi id 14.03.0415.000; Thu, 9 May 2019 21:20:31 +0800 From: "Qian, Yi" To: "Kinney, Michael D" , "devel@edk2.groups.io" CC: "Sun, Zailiang" Subject: Re: [Patch 09/16] Vlv2TbltDevicePkg: Add PchInitSmm module Thread-Topic: [Patch 09/16] Vlv2TbltDevicePkg: Add PchInitSmm module Thread-Index: AQHVBiATMbFYz/QxSk6H82N0mkk06KZix60A Date: Thu, 9 May 2019 13:20:30 +0000 Message-ID: References: <20190509043111.15272-1-michael.d.kinney@intel.com> <20190509043111.15272-10-michael.d.kinney@intel.com> In-Reply-To: <20190509043111.15272-10-michael.d.kinney@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: yi.qian@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed by Qian, Yi Thanks QianYi -----Original Message----- From: Kinney, Michael D=20 Sent: Thursday, May 9, 2019 12:31 PM To: devel@edk2.groups.io Cc: Sun, Zailiang ; Qian, Yi Subject: [Patch 09/16] Vlv2TbltDevicePkg: Add PchInitSmm module Add the PcdInitSmm module that should not have been removed. This module = performs actions at Exit Boot Services to place devices in an OS compatible= state. Wothout this module, so versions of Linux are not bootable. Cc: Zailiang Sun Cc: Yi Qian Signed-off-by: Michael D Kinney --- Vlv2TbltDevicePkg/PlatformPkg.fdf | 1 + Vlv2TbltDevicePkg/PlatformPkgGcc.fdf | 1 + Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc | 3 +++ Vlv2TbltDevicePkg/PlatformPkgIA32.dsc | 2 ++ Vlv2TbltDevicePkg/PlatformPkgX64.dsc | 2 ++ 5 files changed, 9 insertions(+) diff --git a/Vlv2TbltDevicePkg/PlatformPkg.fdf b/Vlv2TbltDevicePkg/Platfor= mPkg.fdf index c725cdcf31..098602b9d8 100644 --- a/Vlv2TbltDevicePkg/PlatformPkg.fdf +++ b/Vlv2TbltDevicePkg/PlatformPkg.fdf @@ -517,6 +517,7 @@ [FV.FVMAIN] =20 !if $(MINNOW2_FSP_BUILD) =3D=3D FALSE INF RuleOverride =3D BINARY $(PLATFORM_BINARY_PACKAGE)/$(DXE_ARCHITECTURE= )$(TARGET)/$(DXE_ARCHITECTURE)/PchInitDxe.inf +INF RuleOverride =3D BINARY=20 +$(PLATFORM_BINARY_PACKAGE)/$(DXE_ARCHITECTURE)$(TARGET)/$(DXE_ARCHITECT +URE)/PchInitSmm.inf !endif INF RuleOverride =3D BINARY $(PLATFORM_BINARY_PACKAGE)/$(DXE_ARCHITECTURE= )$(TARGET)/$(DXE_ARCHITECTURE)/PchSmiDispatcher.inf !if $(PCIESC_ENABLE) =3D=3D TRUE diff --git a/Vlv2TbltDevicePkg/PlatformPkgGcc.fdf b/Vlv2TbltDevicePkg/Plat= formPkgGcc.fdf index 349fbb2887..40385794a3 100644 --- a/Vlv2TbltDevicePkg/PlatformPkgGcc.fdf +++ b/Vlv2TbltDevicePkg/PlatformPkgGcc.fdf @@ -473,6 +473,7 @@ [FV.FVMAIN] =20 !if $(MINNOW2_FSP_BUILD) =3D=3D FALSE INF RuleOverride =3D BINARY $(PLATFORM_BINARY_PACKAGE)/$(DXE_ARCHITECTURE= )$(TARGET)/$(DXE_ARCHITECTURE)/PchInitDxe.inf +INF RuleOverride =3D BINARY=20 +$(PLATFORM_BINARY_PACKAGE)/$(DXE_ARCHITECTURE)$(TARGET)/$(DXE_ARCHITECT +URE)/PchInitSmm.inf !endif INF RuleOverride =3D BINARY $(PLATFORM_BINARY_PACKAGE)/$(DXE_ARCHITECTURE= )$(TARGET)/$(DXE_ARCHITECTURE)/PchSmiDispatcher.inf !if $(PCIESC_ENABLE) =3D=3D TRUE diff --git a/Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc b/Vlv2TbltDevicePkg/P= latformPkgGccX64.dsc index 44a5806153..b9faf558b7 100644 --- a/Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc +++ b/Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc @@ -1193,6 +1193,8 @@ [Components.X64] gEfiMdePkgTokenSpaceGuid.PcdDebugPrintErrorLevel|0xF0000043 } + + $(PLATFORM_BINARY_PACKAGE)/$(DXE_ARCHITECTURE)$(TARGET)/$(DXE_ARCHITEC + TURE)/PchInitSmm.inf + $(PLATFORM_BINARY_PACKAGE)/$(DXE_ARCHITECTURE)$(TARGET)/$(DXE_ARCHITECT= URE)/PchSmiDispatcher.inf =20 !if $(PCIESC_ENABLE) =3D=3D TRUE @@ -1449,6 +1451,7 @@ [Components.X64] } =20 =20 + !if $(NETWORK_ENABLE) =3D=3D TRUE !if $(NETWORK_ISCSI_ENABLE) =3D=3D TRUE NetworkPkg/IScsiDxe/IScsiDxe.inf diff --git a/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc b/Vlv2TbltDevicePkg/Pla= tformPkgIA32.dsc index bff0fe21af..2324794841 100644 --- a/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc +++ b/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc @@ -1180,6 +1180,8 @@ [Components.IA32] gEfiMdePkgTokenSpaceGuid.PcdDebugPrintErrorLevel|0xF0000043 } + + $(PLATFORM_BINARY_PACKAGE)/$(DXE_ARCHITECTURE)$(TARGET)/$(DXE_ARCHITEC + TURE)/PchInitSmm.inf + $(PLATFORM_BINARY_PACKAGE)/$(DXE_ARCHITECTURE)$(TARGET)/$(DXE_ARCHITECT= URE)/PchSmiDispatcher.inf =20 !if $(PCIESC_ENABLE) =3D=3D TRUE diff --git a/Vlv2TbltDevicePkg/PlatformPkgX64.dsc b/Vlv2TbltDevicePkg/Plat= formPkgX64.dsc index 7630b48ea6..10d44d5652 100644 --- a/Vlv2TbltDevicePkg/PlatformPkgX64.dsc +++ b/Vlv2TbltDevicePkg/PlatformPkgX64.dsc @@ -1195,6 +1195,8 @@ [Components.X64] gEfiMdePkgTokenSpaceGuid.PcdDebugPrintErrorLevel|0xF0000043 } + + $(PLATFORM_BINARY_PACKAGE)/$(DXE_ARCHITECTURE)$(TARGET)/$(DXE_ARCHITEC + TURE)/PchInitSmm.inf + $(PLATFORM_BINARY_PACKAGE)/$(DXE_ARCHITECTURE)$(TARGET)/$(DXE_ARCHITECT= URE)/PchSmiDispatcher.inf =20 !if $(PCIESC_ENABLE) =3D=3D TRUE -- 2.21.0.windows.1 --=20 Qian Yi