From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: yi.qian@intel.com) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by groups.io with SMTP; Thu, 09 May 2019 06:20:43 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 May 2019 06:20:43 -0700 X-ExtLoop1: 1 Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga006.fm.intel.com with ESMTP; 09 May 2019 06:20:43 -0700 Received: from fmsmsx156.amr.corp.intel.com (10.18.116.74) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 9 May 2019 06:20:43 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by fmsmsx156.amr.corp.intel.com (10.18.116.74) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 9 May 2019 06:20:42 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.249]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.70]) with mapi id 14.03.0415.000; Thu, 9 May 2019 21:20:41 +0800 From: "Qian, Yi" To: "Kinney, Michael D" , "devel@edk2.groups.io" CC: "Sun, Zailiang" Subject: Re: [Patch 13/16] Vlv2TbltDevicePkg/Capsule: Do not clear UEFI varstore Thread-Topic: [Patch 13/16] Vlv2TbltDevicePkg/Capsule: Do not clear UEFI varstore Thread-Index: AQHVBiATFy0Q1uuvvEqHF4dPH86QwaZix7cw Date: Thu, 9 May 2019 13:20:40 +0000 Message-ID: References: <20190509043111.15272-1-michael.d.kinney@intel.com> <20190509043111.15272-14-michael.d.kinney@intel.com> In-Reply-To: <20190509043111.15272-14-michael.d.kinney@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: yi.qian@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed by Qian, Yi Thanks QianYi -----Original Message----- From: Kinney, Michael D=20 Sent: Thursday, May 9, 2019 12:31 PM To: devel@edk2.groups.io Cc: Sun, Zailiang ; Qian, Yi Subject: [Patch 13/16] Vlv2TbltDevicePkg/Capsule: Do not clear UEFI varsto= re Preserve the UEFI Variable store when a capsule update is performed. UEFI= Variables are used to store firmware version information for the sample de= vices (Red, Green, Blue). Cc: Zailiang Sun Cc: Yi Qian Signed-off-by: Michael D Kinney --- .../Feature/Capsule/Library/FmpDeviceLib/FmpDeviceLib.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/Vlv2TbltDevicePkg/Feature/Capsule/Library/FmpDeviceLib/FmpDev= iceLib.c b/Vlv2TbltDevicePkg/Feature/Capsule/Library/FmpDeviceLib/FmpDevice= Lib.c index 3d5649164b..a863d69381 100644 --- a/Vlv2TbltDevicePkg/Feature/Capsule/Library/FmpDeviceLib/FmpDeviceLib.= c +++ b/Vlv2TbltDevicePkg/Feature/Capsule/Library/FmpDeviceLib/FmpDeviceLi +++ b.c @@ -1,8 +1,8 @@ /** =20 -Copyright (c) 2016, Microsoft Corporation +Copyright (c) 2016, Microsoft Corporation. All rights reserved. +Copyright (c) 2019, Intel Corporation. All rights reserved. =20 -All rights reserved. SPDX-License-Identifier: BSD-2-Clause-Patent =20 **/ @@ -36,8 +36,7 @@ UPDATE_CONFIG_DATA mUpdateConfigData[] =3D { { PlatformFirmwareTypeSystemFirmware, FlashAddressTypeRelativeAddress, = 0x000C0000, 0x00050000, 0x000C0000 }, { PlatformFirmwareTypeSystemFirmware, FlashAddressTypeRelativeAddress, = 0x00110000, 0x00210000, 0x00110000 }, { PlatformFirmwareTypeSystemFirmware, FlashAddressTypeRelativeAddress, = 0x00320000, 0x00070000, 0x00320000 }, - { PlatformFirmwareTypeSystemFirmware, FlashAddressTypeRelativeAddress, = 0x00390000, 0x00070000, 0x00390000 }, - { PlatformFirmwareTypeNvRam, FlashAddressTypeRelativeAddress, = 0x00040000, 0x00080000, 0x00040000 } + { PlatformFirmwareTypeSystemFirmware,=20 + FlashAddressTypeRelativeAddress, 0x00390000, 0x00070000, 0x00390000 } }; =20 /** -- 2.21.0.windows.1 --=20 Qian Yi