From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.120, mailfrom: yi.qian@intel.com) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by groups.io with SMTP; Thu, 09 May 2019 06:20:56 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 May 2019 06:20:56 -0700 X-ExtLoop1: 1 Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga005.jf.intel.com with ESMTP; 09 May 2019 06:20:55 -0700 Received: from fmsmsx151.amr.corp.intel.com (10.18.125.4) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 9 May 2019 06:20:55 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by FMSMSX151.amr.corp.intel.com (10.18.125.4) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 9 May 2019 06:20:55 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.249]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.18]) with mapi id 14.03.0415.000; Thu, 9 May 2019 21:20:53 +0800 From: "Qian, Yi" To: "Kinney, Michael D" , "devel@edk2.groups.io" CC: "Sun, Zailiang" Subject: Re: [Patch 14/16] Vlv2TbltDevicePkg/Capsule: Remove path to openssl tools Thread-Topic: [Patch 14/16] Vlv2TbltDevicePkg/Capsule: Remove path to openssl tools Thread-Index: AQHVBiATYK624dnZWUaoXyfyg6hz0KZix8cA Date: Thu, 9 May 2019 13:20:53 +0000 Message-ID: References: <20190509043111.15272-1-michael.d.kinney@intel.com> <20190509043111.15272-15-michael.d.kinney@intel.com> In-Reply-To: <20190509043111.15272-15-michael.d.kinney@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: yi.qian@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed by Qian, Yi Thanks QianYi -----Original Message----- From: Kinney, Michael D=20 Sent: Thursday, May 9, 2019 12:31 PM To: devel@edk2.groups.io Cc: Sun, Zailiang ; Qian, Yi Subject: [Patch 14/16] Vlv2TbltDevicePkg/Capsule: Remove path to openssl t= ools Remove path to openssl tools from batch scripts. Instead, the path to the= openssl tools must be included in PATH for a build to complete. Cc: Zailiang Sun Cc: Yi Qian Signed-off-by: Michael D Kinney --- .../Feature/Capsule/GenerateCapsule/GenCapsuleMinnowMax.bat | 2 -- .../Capsule/GenerateCapsule/GenCapsuleMinnowMaxRelease.bat | 2 -- .../Feature/Capsule/GenerateCapsule/GenCapsuleSampleColor.bat | 2 -- 3 files changed, 6 deletions(-) diff --git a/Vlv2TbltDevicePkg/Feature/Capsule/GenerateCapsule/GenCapsuleM= innowMax.bat b/Vlv2TbltDevicePkg/Feature/Capsule/GenerateCapsule/GenCapsule= MinnowMax.bat index 80f9be7fb8..50ebb160ee 100644 --- a/Vlv2TbltDevicePkg/Feature/Capsule/GenerateCapsule/GenCapsuleMinnowMa= x.bat +++ b/Vlv2TbltDevicePkg/Feature/Capsule/GenerateCapsule/GenCapsuleMinnow +++ Max.bat @@ -69,7 +69,6 @@ if exist "NewCert.pem" ( --lsv %FMP_CAPSULE_LSV% ^ --capflag PersistAcrossReset ^ --capflag InitiateReset ^ - --signing-tool-path=3Dc:\OpenSSL-Win32\bin ^ --signer-private-cert=3DNewCert.pem ^ --other-public-cert=3DNewSub.pub.pem ^ --trusted-public-cert=3DNewRoot.pub.pem ^ @@ -106,7 +105,6 @@ call Ge= nerateCapsule ^ --lsv %FMP_CAPSULE_LSV% ^ --capflag PersistAcrossReset ^ --capflag InitiateReset ^ - --signing-tool-path=3Dc:\OpenSSL-Win32\bin ^ --signer-private-cert=3D%WORKSPACE%\edk2\BaseTools\Source\Python\Pkcs7S= ign\TestCert.pem ^ --other-public-cert=3D%WORKSPACE%\edk2\BaseTools\Source\Python\Pkcs7Sig= n\TestSub.pub.pem ^ --trusted-public-cert=3D%WORKSPACE%\edk2\BaseTools\Source\Python\Pkcs7S= ign\TestRoot.pub.pem ^ diff --git a/Vlv2TbltDevicePkg/Feature/Capsule/Gener= ateCapsule/GenCapsuleMinnowMaxRelease.bat b/Vlv2TbltDevicePkg/Feature/Capsu= le/GenerateCapsule/GenCapsuleMinnowMaxRelease.bat index c6c78f0285..9d08c86717 100644 --- a/Vlv2TbltDevicePkg/Feature/Capsule/GenerateCapsule/GenCapsuleMinnowMa= xRelease.bat +++ b/Vlv2TbltDevicePkg/Feature/Capsule/GenerateCapsule/GenCapsuleMinnow +++ MaxRelease.bat @@ -69,7 +69,6 @@ if exist "NewCert.pem" ( --lsv %FMP_CAPSULE_LSV% ^ --capflag PersistAcrossReset ^ --capflag InitiateReset ^ - --signing-tool-path=3Dc:\OpenSSL-Win32\bin ^ --signer-private-cert=3DNewCert.pem ^ --other-public-cert=3DNewSub.pub.pem ^ --trusted-public-cert=3DNewRoot.pub.pem ^ @@ -106,7 +105,6 @@ call Ge= nerateCapsule ^ --lsv %FMP_CAPSULE_LSV% ^ --capflag PersistAcrossReset ^ --capflag InitiateReset ^ - --signing-tool-path=3Dc:\OpenSSL-Win32\bin ^ --signer-private-cert=3D%WORKSPACE%\edk2\BaseTools\Source\Python\Pkcs7S= ign\TestCert.pem ^ --other-public-cert=3D%WORKSPACE%\edk2\BaseTools\Source\Python\Pkcs7Sig= n\TestSub.pub.pem ^ --trusted-public-cert=3D%WORKSPACE%\edk2\BaseTools\Source\Python\Pkcs7S= ign\TestRoot.pub.pem ^ diff --git a/Vlv2TbltDevicePkg/Feature/Capsule/Gener= ateCapsule/GenCapsuleSampleColor.bat b/Vlv2TbltDevicePkg/Feature/Capsule/Ge= nerateCapsule/GenCapsuleSampleColor.bat index ba4bc0f081..3e9f94c530 100644 --- a/Vlv2TbltDevicePkg/Feature/Capsule/GenerateCapsule/GenCapsuleSampleCo= lor.bat +++ b/Vlv2TbltDevicePkg/Feature/Capsule/GenerateCapsule/GenCapsuleSample +++ Color.bat @@ -73,7 +73,6 @@ if exist "NewCert.pem" ( --lsv %FMP_CAPSULE_LSV% ^ --capflag PersistAcrossReset ^ --capflag InitiateReset ^ - --signing-tool-path=3Dc:\OpenSSL-Win32\bin ^ --signer-private-cert=3DNewCert.pem ^ --other-public-cert=3DNewSub.pub.pem ^ --trusted-public-cert=3DNewRoot.pub.pem ^ @@ -110,7 +109,6 @@ call Ge= nerateCapsule ^ --lsv %FMP_CAPSULE_LSV% ^ --capflag PersistAcrossReset ^ --capflag InitiateReset ^ - --signing-tool-path=3Dc:\OpenSSL-Win32\bin ^ --signer-private-cert=3D%WORKSPACE%\edk2\BaseTools\Source\Python\Pkcs7S= ign\TestCert.pem ^ --other-public-cert=3D%WORKSPACE%\edk2\BaseTools\Source\Python\Pkcs7Sig= n\TestSub.pub.pem ^ --trusted-public-cert=3D%WORKSPACE%\edk2\BaseTools\Source\Python\Pkcs7S= ign\TestRoot.pub.pem ^ -- 2.21.0.windows.1 --=20 Qian Yi