From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: None (no SPF record) identity=mailfrom; client-ip=203.199.198.232; helo=imsva.in.megatrends.com; envelope-from=karunakarp@amiindia.co.in; receiver=edk2-devel@lists.01.org Received: from IMSVA.IN.MEGATRENDS.COM (Webmail.amiindia.co.in [203.199.198.232]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B06252232BDE1 for ; Wed, 17 Jan 2018 01:08:17 -0800 (PST) Received: from IMSVA.IN.MEGATRENDS.COM (IMSVA.IN.MEGATRENDS.COM [127.0.0.1]) by IMSVA (Postfix) with ESMTP id F3C9682047; Wed, 17 Jan 2018 14:47:00 +0530 (IST) Received: from IMSVA.IN.MEGATRENDS.COM (IMSVA.IN.MEGATRENDS.COM [127.0.0.1]) by IMSVA (Postfix) with ESMTP id D317D82046; Wed, 17 Jan 2018 14:47:00 +0530 (IST) Received: from webmail.amiindia.co.in (venus1.in.megatrends.com [10.0.0.5]) by IMSVA.IN.MEGATRENDS.COM (Postfix) with ESMTPS; Wed, 17 Jan 2018 14:47:00 +0530 (IST) Received: from VENUS2.in.megatrends.com ([fe80::2002:4a07:4f17:c09b]) by VENUS1.in.megatrends.com ([fe80::951:7975:6ecf:eae5%14]) with mapi id 14.01.0438.000; Wed, 17 Jan 2018 14:43:33 +0530 From: Karunakar P To: "'Wu, Jiaxin'" , "Ye, Ting" , "Fu, Siyuan" , "'edk2-devel@lists.01.org'" Thread-Topic: AsciiPrint() in HttpBootDxe Corrupting the Setup screen Thread-Index: AdOJ2mcWk/hjX4urRy2rJe1VSk/7TQAm0IpAAT9QoLA= Date: Wed, 17 Jan 2018 09:13:32 +0000 Message-ID: References: <895558F6EA4E3B41AC93A00D163B72741635BF8D@SHSMSX103.ccr.corp.intel.com> In-Reply-To: <895558F6EA4E3B41AC93A00D163B72741635BF8D@SHSMSX103.ccr.corp.intel.com> Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.0.84.111] MIME-Version: 1.0 X-TM-AS-GCONF: 00 X-TM-AS-Product-Ver: IMSVA-9.1.0.1600-8.2.0.1013-23600.005 X-TM-AS-Result: No--22.452-5.0-31-10 X-imss-scan-details: No--22.452-5.0-31-10 X-TMASE-Version: IMSVA-9.1.0.1600-8.2.1013-23600.005 X-TMASE-Result: 10--22.452200-10.000000 X-TMASE-MatchedRID: 9vvqFUF7IWnoSitJVour/bxygpRxo469Ce1sPOFCidN2jD/JuqpOkizs QurLskPGCOvPZtMq+Po6QXObk0h1vvrqG4cFc/YA7TLIvnWov9ES12tj9Zvd87v408/GP5HqcZA 2mIwIeLPRH78Ygif3X+VZZWNPzK3YeAavp+4WHK34j93DsNIQEVAsG9fXVGlJr9sGCK8knu4CYy wzM82Z85QyG0vdVTG28/yp+WtonF4umkwlhTHaGcpQKjU7fBXV5Y0kb0hqatxaW2Ktn+I8/pgcm UeYCy4+YUIjtHlPEEjMxOfH6OC6cyHUxgcGANp8ma6DzXaohvPfVqwz+Cynace0H7LMCFcVwRq4 tsfhpBxXoWfCQzKBl2vuTEdabMloag/ZDTxTPRg2zdLf3NqhdjK1/qdbjc7QFLXUWU5hGiFdqWv miTG8mp/Xz1rC/1g0o7MuCMmELwiBkjWfpo1TNt/wYmMFcJSIl2F9+KxZd8cdI0m0WP5veieyhe /lYm1bfjI+5NpS2G8UGn2H7I5plAUYKFSjGhXD3y1ZMjVHx6khnAF+qfR1Zjg2jfgv3Zp9UdfEK c10rU54nNRC+UXW5z7V1OrezJhfWfg4pIIFh8dmNCKOCsW/OqcJxWZ5/lR8Z5yuplze9pupZz1g 43kqRyVzdnQceNR2FABeLgZr0ZEfE8yM4pjsD/7E6GNqs6ceAaUQk5EZOUn+efAnnZBiL6SszSE YZXnDKw4VvNndjNwG2ydY4ADMCLcAkCnslIyvbzQBvmcuugZ+3BndfXUhXQ== X-TMASE-SNAP-Result: 1.821001.0001-0-1-12:0,22:0,33:0,34:0,39:0-0 X-Content-Filtered-By: Mailman/MimeDel 2.1.23 Subject: Re: AsciiPrint() in HttpBootDxe Corrupting the Setup screen X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Jan 2018 09:08:18 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Jiaxin, We'll send the formal patch for review and also could you please let me kno= w if you want to fill a bug in Bugzilla if needed. Thank You, Karunakar From: Wu, Jiaxin [mailto:jiaxin.wu@intel.com] Sent: Thursday, January 11, 2018 6:21 AM To: Karunakar P; Ye, Ting; Fu, Siyuan Subject: RE: AsciiPrint() in HttpBootDxe Corrupting the Setup screen Hi Karunakar, I agree the fix, can you send out the formal patch for the review or need u= s to follow that? Thanks, Jiaxin From: Karunakar P [mailto:karunakarp@amiindia.co.in] Sent: Wednesday, January 10, 2018 4:48 PM To: Wu, Jiaxin >; Ye, Ting = >; Fu, Siyuan > Subject: AsciiPrint() in HttpBootDxe Corrupting the Setup screen Hello All, [Issue] 1. On giving Invalid URI in Boot URI field in "HTTP Boot Configuratio= n" Page, doing AsciiPrint() in TSE corrupting the Screen. AsciiPrint ("\n Error: Invalid URI address.\n"); 2. When HTTP connection are disabled using "PcdAllowHttpConnections" On giving http URI in Boot URI field in "HTTP Boot Configuration" Page, doi= ng AsciiPrint() in TSE corrupting the Screen. AsciiPrint ("\n Error: Access forbidden, only HTTPS connection is allowed.= \n"); [Fix] 1. I guess We've added this AsciiPrint() because HttpBootCheckUriSche= me() is common for both generic HTTP boot over IPv4/6 and "Http Boot Config= uration" page 2. In case of "Http Boot Configuration", AsciiPrint() may not be nee= ded in HttpBootCheckUriScheme because we're already using CreatePopUp() in = case of Error Status CreatePopUp ( EFI_LIGHTGRAY | EFI_BACKGROUND_BLUE, &Key, L"ERROR: Unsupported URI!", L"Only supports HTTP and HTTPS", NULL ); (Or) CreatePopUp ( EFI_LIGHTGRAY | EFI_BACKGROUND_BLUE, &Key, L"ERROR: Unsupported URI!", L"HTTP is disabled", NULL ); 3. When we do Http Boot over IPv4/6, from HttpBootCheckUriScheme() th= ere is chance to get return status as EFI_INVALID_PARAMETER or EFI_ACCESS_D= ENIED 4. In this case we can have AsciiPrint() based on return Status, inst= ead of doing in HttpBootCheckUriScheme() I've attached the suggested changes, could you please review and provide yo= ur comments/Suggestions. Thanks, Karunakar