From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: None (no SPF record) identity=mailfrom; client-ip=203.199.198.232; helo=imsva.in.megatrends.com; envelope-from=karunakarp@amiindia.co.in; receiver=edk2-devel@lists.01.org Received: from IMSVA.IN.MEGATRENDS.COM (Webmail.amiindia.co.in [203.199.198.232]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id A4FBA21F38820 for ; Fri, 13 Oct 2017 04:45:15 -0700 (PDT) Received: from IMSVA.IN.MEGATRENDS.COM (IMSVA.IN.MEGATRENDS.COM [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 0EE1D82047; Fri, 13 Oct 2017 17:21:36 +0530 (IST) Received: from IMSVA.IN.MEGATRENDS.COM (IMSVA.IN.MEGATRENDS.COM [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 0230782046; Fri, 13 Oct 2017 17:21:36 +0530 (IST) Received: from webmail.amiindia.co.in (venus2.in.megatrends.com [10.0.0.7]) by IMSVA.IN.MEGATRENDS.COM (Postfix) with ESMTPS; Fri, 13 Oct 2017 17:21:35 +0530 (IST) Received: from VENUS1.in.megatrends.com ([fe80::951:7975:6ecf:eae5]) by Venus2.in.megatrends.com ([fe80::2002:4a07:4f17:c09b%14]) with mapi id 14.03.0248.002; Fri, 13 Oct 2017 17:18:43 +0530 From: Karunakar P To: "'Fu, Siyuan'" , "Wu, Jiaxin" , "edk2-devel@lists.01.org" CC: "Ye, Ting" Thread-Topic: [Patch] NetworkPkg/IScsiDxe: Display InitiatorInfo in attempt page even DHCP enabled. Thread-Index: AQHTQ+ivI7V7QuFtIUatq482BVufGaLg876AgACybOA= Date: Fri, 13 Oct 2017 11:48:42 +0000 Message-ID: References: <1507874463-5684-1-git-send-email-jiaxin.wu@intel.com> In-Reply-To: Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.0.84.128] MIME-Version: 1.0 X-TM-AS-GCONF: 00 X-TM-AS-Product-Ver: IMSVA-9.1.0.1600-8.1.0.1062-23392.006 X-TM-AS-Result: No--11.063-5.0-31-10 X-imss-scan-details: No--11.063-5.0-31-10 X-TMASE-Version: IMSVA-9.1.0.1600-8.1.1062-23392.006 X-TMASE-Result: 10--11.062500-10.000000 X-TMASE-MatchedRID: L8tZF6zWW2pw08wUkhf6c9FzvmKugqoCKn5kDAS/iZJTYyyCA5vjwHSy wnHvmEg6DzV2gZa4PlNpZkze5rrHstBOYKsu3QKlgYt6Kq7XJMri639YwDKy06PzbSEkYj8Ef/b TCoZRptKtmpf2iRnuMP7DffVOwda7cF7yq9v3Tt0ea0JeKHt/0/sUgOYYN4ga31GU/N5W5BD5Db 21UXFs6DdxLXBaqjOZyWj4qexd4ONYjH6AJCrcxAwfhKwa9GwDIFb2VdwQdkABX1w330R6VqPFj JEFr+olhAvhah9RwybYDKq9BLK39zsAVzN+Ov/sVP+jc+rCGHgjZvhJBNVes2hw/ELDX8xB0GZU /TT5muMTY9knrVy5EA== X-TMASE-SNAP-Result: 1.821001.0001-0-1-12:0,22:0,33:0,34:0,39:0-0 Subject: Re: [Patch] NetworkPkg/IScsiDxe: Display InitiatorInfo in attempt page even DHCP enabled. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Oct 2017 11:45:16 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Jiaxin/Siyuan, I've verified Initiator details with this changes. I found an issue like Initiator Details are shown for Connection less NIC=20 Please find below details for more details [Issue details and steps to reproduce] 1. SUT have 2 LAN ports MAC XX:XX:XX:XX:XX:AA -> LAN Cable NOT connected to this port, i.= e. Link Status is Disconnected MAC XX:XX:XX:XX:XX:BB -> LAN Cable Connected to this port, i.e. = Link Status is Connected 2. I've added two attempts a. Attempt1 added to connection less NIC (MAC XX:XX:XX:XX:XX:AA ) b. Attempt2 added to connected NIC (MAC XX:XX:XX:XX:XX:BB ) [Observations] 1. Initiator IP Address and Subnet Mask displayed for both Attempt1 and Att= empt2 Could you please comment on this observation? Thanks, Karunakar -----Original Message----- From: Fu, Siyuan [mailto:siyuan.fu@intel.com]=20 Sent: Friday, October 13, 2017 11:54 AM To: Wu, Jiaxin; edk2-devel@lists.01.org Cc: Karunakar P; Ye, Ting Subject: RE: [Patch] NetworkPkg/IScsiDxe: Display InitiatorInfo in attempt = page even DHCP enabled. Reviewed-by: Fu Siyuan -----Original Message----- From: Wu, Jiaxin=20 Sent: Friday, October 13, 2017 2:01 PM To: edk2-devel@lists.01.org Cc: Karunakar P ; Ye, Ting ; = Fu, Siyuan ; Wu, Jiaxin Subject: [Patch] NetworkPkg/IScsiDxe: Display InitiatorInfo in attempt page= even DHCP enabled. Cc: Karunakar P Cc: Ye Ting Cc: Fu Siyuan Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Wu Jiaxin --- NetworkPkg/IScsiDxe/IScsiConfigVfr.vfr | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/NetworkPkg/IScsiDxe/IScsiConfigVfr.vfr b/NetworkPkg/IScsiDxe/I= ScsiConfigVfr.vfr index d401419..35e8f9a 100644 --- a/NetworkPkg/IScsiDxe/IScsiConfigVfr.vfr +++ b/NetworkPkg/IScsiDxe/IScsiConfigVfr.vfr @@ -189,13 +189,14 @@ formset flags =3D INTERACTIVE, key =3D KEY_DHCP_ENABLE, endcheckbox; endif; =20 - suppressif ideqval ISCSI_CONFIG_IFR_NVDATA.InitiatorInfoFromDhcp =3D= =3D 0x01 OR - ideqval ISCSI_CONFIG_IFR_NVDATA.IpMode =3D=3D IP_MODE_IP6 O= R=20 + suppressif ideqval ISCSI_CONFIG_IFR_NVDATA.IpMode =3D=3D IP_MODE_IP6 O= R=20 ideqval ISCSI_CONFIG_IFR_NVDATA.IpMode =3D=3D IP_MODE_AUTOC= ONFIG; + =20 + grayoutif ideqval ISCSI_CONFIG_IFR_NVDATA.InitiatorInfoFromDhcp =3D=3D= 0x01; string varid =3D ISCSI_CONFIG_IFR_NVDATA.LocalIp, prompt =3D STRING_TOKEN(STR_ISCSI_LOCAL_IP_ADDRESS), help =3D STRING_TOKEN(STR_ISCSI_IP_ADDRESS_HELP), flags =3D INTERACTIVE, key =3D KEY_LOCAL_IP, @@ -218,10 +219,11 @@ formset flags =3D INTERACTIVE, key =3D KEY_GATE_WAY, minsize =3D IP4_MIN_SIZE, maxsize =3D IP4_MAX_SIZE, endstring; + endif; =20 endif; =20 suppressif ideqval ISCSI_CONFIG_IFR_NVDATA.IpMode =3D=3D IP_MODE_AUTOC= ONFIG; subtitle text =3D STRING_TOKEN(STR_NULL); --=20 1.9.5.msysgit.1