From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: None (no SPF record) identity=mailfrom; client-ip=203.199.198.232; helo=imsva.in.megatrends.com; envelope-from=karunakarp@amiindia.co.in; receiver=edk2-devel@lists.01.org Received: from IMSVA.IN.MEGATRENDS.COM (Webmail.amiindia.co.in [203.199.198.232]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 9BCCD202E6113 for ; Tue, 17 Oct 2017 03:09:02 -0700 (PDT) Received: from IMSVA.IN.MEGATRENDS.COM (IMSVA.IN.MEGATRENDS.COM [127.0.0.1]) by IMSVA (Postfix) with ESMTP id A1D3182047; Tue, 17 Oct 2017 15:45:28 +0530 (IST) Received: from IMSVA.IN.MEGATRENDS.COM (IMSVA.IN.MEGATRENDS.COM [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 8B3A782046; Tue, 17 Oct 2017 15:45:28 +0530 (IST) Received: from webmail.amiindia.co.in (venus2.in.megatrends.com [10.0.0.7]) by IMSVA.IN.MEGATRENDS.COM (Postfix) with ESMTPS; Tue, 17 Oct 2017 15:45:28 +0530 (IST) Received: from VENUS1.in.megatrends.com ([fe80::951:7975:6ecf:eae5]) by Venus2.in.megatrends.com ([fe80::2002:4a07:4f17:c09b%14]) with mapi id 14.03.0248.002; Tue, 17 Oct 2017 15:42:34 +0530 From: Karunakar P To: "'Wu, Jiaxin'" , "edk2-devel@lists.01.org" CC: "Ye, Ting" , "Fu, Siyuan" Thread-Topic: [edk2] [Patch 0/2] Add IPv6 support condition check for HTTP/ISCSI. Thread-Index: AQHTRutzgYZnUvS1QUq9ZfByiwGsxKLm7cOAgADPqOA= Date: Tue, 17 Oct 2017 10:12:33 +0000 Message-ID: References: <1508205501-13832-1-git-send-email-jiaxin.wu@intel.com> <895558F6EA4E3B41AC93A00D163B72741633E5F1@SHSMSX103.ccr.corp.intel.com> In-Reply-To: <895558F6EA4E3B41AC93A00D163B72741633E5F1@SHSMSX103.ccr.corp.intel.com> Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.0.84.128] MIME-Version: 1.0 X-TM-AS-GCONF: 00 X-TM-AS-Product-Ver: IMSVA-9.1.0.1600-8.1.0.1062-23400.005 X-TM-AS-Result: No--25.379-5.0-31-10 X-imss-scan-details: No--25.379-5.0-31-10 X-TMASE-Version: IMSVA-9.1.0.1600-8.1.1062-23400.005 X-TMASE-Result: 10--25.379000-10.000000 X-TMASE-MatchedRID: EMyCvCfVN1HSw3nP8ewgPLxygpRxo469WDdWpJMntKjcgxUjNvm6Ix/X WBLkU7fumoWs5Zxz4062JFdhGpav6+ZcUcnEeIat6ivQ8oO6nUIwLjM7t3iRo7w2tvOM+/MnAHe dlY3p0SzHFMvks3o0Z0jBgsju+zn2XEfwOboaqxYAsHFAeQm1apxfK35V7okVHFSQk97VYGo4Cy 1TAHEtDYab/Qu2vnWOJRM9e2YjINZxIy4mIKeb4QPZZctd3P4BUXlp1FHYSPXKY//WmIj/oVdWJ fEqbx6Mj32FZ/iOs2u3jcHkn3paedqoygGFfC1GFYJUGv4DL3zvkROLxAaM3Fc/Cedjlcvk2ugQ ZCK503IRlDCAAgwkvCN4kclJ7wTRTtgN9Y+ILsbmAId+2bAQwsDyPNek9e/aLraGNlLRahhPdNC mICYiVfh+cww7NEtqoUNjrNnbqmhPNJFFp/jsVPHkpkyUphL9pxwSG8jIwhTIvQIyugvKdXmd+2 5VkQszINJHwopqLBkjOz6Zpw1fJH+OhC1J6Q0sngIgpj8eDcDInWAWA4yE6bazRqvlkBL0rzkaO Gjo+VYLbigRnpKlKT4yqD4LKu3A X-TMASE-SNAP-Result: 1.821001.0001-0-1-12:0,22:0,33:0,34:0,39:0-0 Subject: Re: [Patch 0/2] Add IPv6 support condition check for HTTP/ISCSI. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Oct 2017 10:09:03 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Jiaxin, I Reviewed the changes for 3 features/Bugs and verified the same, Please fi= nd my below comments and issues faced=20 A. Display InitiatorInfo in attempt page even DHCP enabled ---------------------------------------------------------------------------= --------------------------------------------------------------- 1. I applied IScsiConfigVfr.vfr changes and as well IScsiMisc.c changes 2. It displays initiator info properly when it's Enabled for DHCP 3. But, I found some different behavior in below case a. Add an Attempt (Attempt1 -> Initiator Info Enabled for DHCP) b. On reboot iSCSI attempt was success and Initiator Details shown pro= perly =3D=3D> This is as expected c. Edit the same Attempt1 details to IP6 and save changes and reset d. Now Iscsi connection with IP6 =3D=3D> This is as Expected e. Now if we again Change the Attempt1 to IP4, It is Displaying Subnet = Mask =3D=3D> I guess we are not clearing It =20 I guess we need to do ZeroMem for initiator details before. =20 B. [Patch 2/2] NetworkPkg/IScsiDxe: Add IPv6 support condition check. ---------------------------------------------------------------------------= -------------------------------------------------------------- -> This changes looks similar whatever I attached in Bugzilla, and verified= the same with off board card witch doesn't support IP6 -> It works fine, I didn't find any issues on it. C. [Patch 1/2] NetworkPkg/HttpBootDxe: Add IPv6 support condition check. ---------------------------------------------------------------------------= ---------------------------------------------------------------------------= ---------------- I found some issues in this changes, please find my below comments 1. HttpBootCheckIpv6Support() function definition and function call paramet= er differs , To correct this I've done 1 insertion(+), 1 deletion(-) like b= elow ... +HttpBootCheckIpv6Support ( + IN EFI_HANDLE ControllerHandle, + IN HTTP_BOOT_PRIVATE_DATA *Private, + OUT BOOLEAN *Ipv6Support + )=20 ... + // Set IPv6 available flag. + // + Status =3D HttpBootCheckIpv6Support (ControllerHandle,=20 -This->DriverBindingHandle, &Ipv6Available); +Private, &Ipv6Available); ... 2. With the above changes I've verified with Off board card which doesn't s= upport IP6, But I'm facing below ASSERT (324): CR has Bad Signature EFI_STATUS EFIAPI HttpBootIp4DxeDriverBindingStart ( IN EFI_DRIVER_BINDING_PROTOCOL *This, IN EFI_HANDLE ControllerHandle, IN EFI_DEVICE_PATH_PROTOCOL *RemainingDevicePath OPTIONAL ) { ... if (!EFI_ERROR (Status)) { Private =3D HTTP_BOOT_PRIVATE_DATA_FROM_ID(Id); // ASSERT= s here } else { ..... 3. I would like add some points and info about the this ASSERT, which I've = found The ASSERT is happening because of FreePool (Private), mentioned exact line= no below EFI_STATUS EFIAPI HttpBootIp6DxeDriverBindingStart ( IN EFI_DRIVER_BINDING_PROTOCOL *This, IN EFI_HANDLE ControllerHandle, IN EFI_DEVICE_PATH_PROTOCOL *RemainingDevicePath OPTIONAL ) { ... Status =3D gBS->InstallProtocolInterface ( &ControllerHandle, &gEfiCallerIdGuid, EFI_NATIVE_INTERFACE, &Private->Id ); if (EFI_ERROR (Status)) { goto ON_ERROR; } =20 } + + // + // Set IPv6 available flag. + // + Status =3D HttpBootCheckIpv6Support (ControllerHandle,=20 -This->DriverBindingHandle, &Ipv6Available); +Private, &Ipv6Available); + if (EFI_ERROR (Status)) { + // + // Fail to get the data whether UNDI supports IPv6.=20 + // Set default value to TRUE. + // + Ipv6Available =3D TRUE; + } + + if (!Ipv6Available) { + return EFI_UNSUPPORTED; + } =20 if (Private->Ip6Nic !=3D NULL) { // ... ON_ERROR: HttpBootDestroyIp6Children(This, Private); HttpBootConfigFormUnload (Private); FreePool (Private); = // If I comment this line ASSERT is not happening return Status; } 4. At your end could you please verify this IP6 Condition check for HTTP=20 Please correct if anything is wrong, Thanks for your support Thank You, Karunakar -----Original Message----- From: Wu, Jiaxin [mailto:jiaxin.wu@intel.com]=20 Sent: Tuesday, October 17, 2017 7:32 AM To: Wu, Jiaxin; edk2-devel@lists.01.org Cc: Karunakar P; Ye, Ting; Fu, Siyuan Subject: RE: [edk2] [Patch 0/2] Add IPv6 support condition check for HTTP/I= SCSI. Hello Karunakar, Base on your original changes attached in Bugzilla 701 (https://bugzilla.ti= anocore.org/show_bug.cgi?id=3D710), I created the formal series patches to = support the IPv6 condition check for HTTP/ISCSI.=20 Please help to review/verify it. BTW, To review the ISCSI part, please apply the "[Patch v2 0/2] NetworkPkg/= IScsiDxe: Display InitiatorInfo correctly" first to avoid any patch conflic= t. Thanks, Jiaxin > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of=20 > Jiaxin Wu > Sent: Tuesday, October 17, 2017 9:58 AM > To: edk2-devel@lists.01.org > Cc: Karunakar P ; Ye, Ting=20 > ; Fu, Siyuan ; Wu, Jiaxin=20 > > Subject: [edk2] [Patch 0/2] Add IPv6 support condition check for HTTP/ISC= SI. >=20 > Base on the request of=20 > https://bugzilla.tianocore.org/show_bug.cgi?id=3D710, > we provide this patch to IPv6 condition check by leveraging AIP Protocol. >=20 > Cc: Karunakar P > Cc: Ye Ting > Cc: Fu Siyuan > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Karunakar P > Signed-off-by: Wu Jiaxin >=20 > Jiaxin Wu (2): > NetworkPkg/HttpBootDxe: Add IPv6 support condition check. > NetworkPkg/IScsiDxe: Add IPv6 support condition check. >=20 > NetworkPkg/HttpBootDxe/HttpBootDxe.c | 115 > +++++++++++++++++++++++++++- > NetworkPkg/HttpBootDxe/HttpBootDxe.h | 2 + > NetworkPkg/HttpBootDxe/HttpBootDxe.inf | 4 +- > NetworkPkg/IScsiDxe/IScsiConfig.c | 18 +++++ > NetworkPkg/IScsiDxe/IScsiDriver.c | 2 +- > NetworkPkg/IScsiDxe/IScsiDriver.h | 1 + > NetworkPkg/IScsiDxe/IScsiDxe.inf | 2 + > NetworkPkg/IScsiDxe/IScsiImpl.h | 1 + > NetworkPkg/IScsiDxe/IScsiMisc.c | 135 > ++++++++++++++++++++++++++++++++- > NetworkPkg/IScsiDxe/IScsiMisc.h | 4 +- > 10 files changed, 278 insertions(+), 6 deletions(-) >=20 > -- > 1.9.5.msysgit.1 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel