From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: None (no SPF record) identity=mailfrom; client-ip=203.199.198.232; helo=imsva.in.megatrends.com; envelope-from=karunakarp@amiindia.co.in; receiver=edk2-devel@lists.01.org Received: from IMSVA.IN.MEGATRENDS.COM (Webmail.amiindia.co.in [203.199.198.232]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 2A623203525F6 for ; Thu, 26 Oct 2017 07:47:08 -0700 (PDT) Received: from IMSVA.IN.MEGATRENDS.COM (IMSVA.IN.MEGATRENDS.COM [127.0.0.1]) by IMSVA (Postfix) with ESMTP id DE9B482047; Thu, 26 Oct 2017 20:23:48 +0530 (IST) Received: from IMSVA.IN.MEGATRENDS.COM (IMSVA.IN.MEGATRENDS.COM [127.0.0.1]) by IMSVA (Postfix) with ESMTP id D19D682046; Thu, 26 Oct 2017 20:23:48 +0530 (IST) Received: from webmail.amiindia.co.in (venus2.in.megatrends.com [10.0.0.7]) by IMSVA.IN.MEGATRENDS.COM (Postfix) with ESMTPS; Thu, 26 Oct 2017 20:23:48 +0530 (IST) Received: from VENUS1.in.megatrends.com ([fe80::951:7975:6ecf:eae5]) by Venus2.in.megatrends.com ([fe80::2002:4a07:4f17:c09b%14]) with mapi id 14.03.0248.002; Thu, 26 Oct 2017 20:20:51 +0530 From: Karunakar P To: 'Jiaxin Wu' , "edk2-devel@lists.01.org" CC: Ye Ting , Fu Siyuan Thread-Topic: [Patch] NetworkPkg/IScsiDxe: Clear the old IFR TargetIp to avoid sharing it with other attempts. Thread-Index: AQHTTjVn3B2B9ewupUiXtqnw/w/6oqL2Nwrw Date: Thu, 26 Oct 2017 14:50:50 +0000 Message-ID: References: <1509006412-41404-1-git-send-email-jiaxin.wu@intel.com> In-Reply-To: <1509006412-41404-1-git-send-email-jiaxin.wu@intel.com> Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.0.84.111] MIME-Version: 1.0 X-TM-AS-GCONF: 00 X-TM-AS-Product-Ver: IMSVA-9.1.0.1600-8.1.0.1062-23418.006 X-TM-AS-Result: No--3.869-5.0-31-10 X-imss-scan-details: No--3.869-5.0-31-10 X-TMASE-Version: IMSVA-9.1.0.1600-8.1.1062-23418.006 X-TMASE-Result: 10--3.869400-10.000000 X-TMASE-MatchedRID: u1zqiMeMcrrybSXiGX6jIozb2GR6Ttd3nophrTcsI7YutoY2UtFqGE90 0KYgJiJVsOgv3K25H2nz/t9xm8yDBs6Qt1tBNVP9A9lly13c/gEP4vBWNr0zgZsoi2XrUn/JfY9 hsM0xN70qtq5d3cxkNW1cuav5GFaRo5Z2ZdyYDFfQSZ/itULmdbaQS17n0i7KMfiuMYKUXRIEkT ei07pbRByPMxl+5OKWG93/nS+TmLTC1LH1UwzBrIMjX6+sTNgks5WESolUFo4+jAdc+j1dGnQ34 PlJBtKejIzWhTtE7+RDDKa3G4nrLQ== X-TMASE-SNAP-Result: 1.821001.0001-0-1-12:0,22:0,33:0,34:0,39:0-0 Subject: Re: [Patch] NetworkPkg/IScsiDxe: Clear the old IFR TargetIp to avoid sharing it with other attempts. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Oct 2017 14:47:09 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Jiaxin, It can resolve the issue. Thanks, Karunakar -----Original Message----- From: Jiaxin Wu [mailto:jiaxin.wu@intel.com]=20 Sent: Thursday, October 26, 2017 1:57 PM To: edk2-devel@lists.01.org Cc: Karunakar P; Ye Ting; Fu Siyuan; Wu Jiaxin Subject: [Patch] NetworkPkg/IScsiDxe: Clear the old IFR TargetIp to avoid s= haring it with other attempts. Cc: Karunakar P Cc: Ye Ting Cc: Fu Siyuan Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Wu Jiaxin --- NetworkPkg/IScsiDxe/IScsiConfig.c | 1 + 1 file changed, 1 insertion(+) diff --git a/NetworkPkg/IScsiDxe/IScsiConfig.c b/NetworkPkg/IScsiDxe/IScsiC= onfig.c index 3ce37c5..3382982 100644 --- a/NetworkPkg/IScsiDxe/IScsiConfig.c +++ b/NetworkPkg/IScsiDxe/IScsiConfig.c @@ -539,10 +539,11 @@ IScsiConvertAttemptConfigDataToIfrNvData ( IScsiIpToStr (&Ip, FALSE, IfrNvData->LocalIp); CopyMem (&Ip.v4, &SessionConfigData->SubnetMask, sizeof (EFI_IPv4_ADDR= ESS)); IScsiIpToStr (&Ip, FALSE, IfrNvData->SubnetMask); CopyMem (&Ip.v4, &SessionConfigData->Gateway, sizeof (EFI_IPv4_ADDRESS= )); IScsiIpToStr (&Ip, FALSE, IfrNvData->Gateway); + ZeroMem (IfrNvData->TargetIp, sizeof (IfrNvData->TargetIp)); if (SessionConfigData->TargetIp.v4.Addr[0] !=3D '\0') { CopyMem (&Ip.v4, &SessionConfigData->TargetIp, sizeof (EFI_IPv4_ADDR= ESS)); IScsiIpToStr (&Ip, FALSE, IfrNvData->TargetIp); } =20 --=20 1.9.5.msysgit.1