public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* Syntax error in EFI iSCSI Initiator Name Protocol in UEFI2.7 Spec
@ 2017-12-19  8:28 Karunakar P
  2017-12-19  8:35 ` Ye, Ting
  0 siblings, 1 reply; 2+ messages in thread
From: Karunakar P @ 2017-12-19  8:28 UTC (permalink / raw)
  To: 'edk2-devel@lists.01.org'
  Cc: 'Fu, Siyuan', 'Ye, Ting', 'Wu, Jiaxin'

Hello All,

There is a typing mistake in EFI_ISCSI_INITIATOR_NAME_PROTOCOL Get() and Set() Prototypes

UEFI2.7 16.2 Page 921,922

EFI_ISCSI_INITIATOR_NAME_PROTOCOL. Get()

Summary

Retrieves the current set value of iSCSI Initiator Name.

Prototype

typedef EFI_STATUS

(EFIAPI *EFI_ISCSI_INITIATOR_NAME_GET) {

IN EFI_ISCSI_INITIATOR_NAME_PROTOCOL *This

IN OUT UINTN *BufferSize

OUT VOID *Buffer

}

EFI_ISCSI_INITIATOR_NAME_PROTOCOL.Set()

Summary

Sets the iSCSI Initiator Name.

Prototype

typedef EFI_STATUS

(EFIAPI *EFI_ISCSI_INITIATOR_NAME_SET) {

IN EFI_ISCSI_INITIATOR_NAME_PROTOCOL *This

IN OUT UINTN *BufferSize

IN VOID *Buffer

}



The Prototypes should be like below

typedef EFI_STATUS

(EFIAPI *EFI_ISCSI_INITIATOR_NAME_GET) (

IN EFI_ISCSI_INITIATOR_NAME_PROTOCOL *This

IN OUT UINTN *BufferSize

OUT VOID *Buffer

);


typedef EFI_STATUS

(EFIAPI *EFI_ISCSI_INITIATOR_NAME_SET) (

IN EFI_ISCSI_INITIATOR_NAME_PROTOCOL *This

IN OUT UINTN *BufferSize

IN VOID *Buffer

);


Thanks,
Karunakar


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: Syntax error in EFI iSCSI Initiator Name Protocol in UEFI2.7 Spec
  2017-12-19  8:28 Syntax error in EFI iSCSI Initiator Name Protocol in UEFI2.7 Spec Karunakar P
@ 2017-12-19  8:35 ` Ye, Ting
  0 siblings, 0 replies; 2+ messages in thread
From: Ye, Ting @ 2017-12-19  8:35 UTC (permalink / raw)
  To: Karunakar P, 'edk2-devel@lists.01.org'; +Cc: Fu, Siyuan, Wu, Jiaxin

Hi Karunakar,

Thanks for capturing the issue. We will raise it to spec group soon. Hopefully we can fix it in the next version of UEFI specification.

Best Regards,
Ting

From: Karunakar P [mailto:karunakarp@amiindia.co.in]
Sent: Tuesday, December 19, 2017 4:29 PM
To: 'edk2-devel@lists.01.org' <edk2-devel@lists.01.org>
Cc: Fu, Siyuan <siyuan.fu@intel.com>; Ye, Ting <ting.ye@intel.com>; Wu, Jiaxin <jiaxin.wu@intel.com>
Subject: Syntax error in EFI iSCSI Initiator Name Protocol in UEFI2.7 Spec

Hello All,

There is a typing mistake in EFI_ISCSI_INITIATOR_NAME_PROTOCOL Get() and Set() Prototypes

UEFI2.7 16.2 Page 921,922

EFI_ISCSI_INITIATOR_NAME_PROTOCOL. Get()

Summary

Retrieves the current set value of iSCSI Initiator Name.

Prototype

typedef EFI_STATUS

(EFIAPI *EFI_ISCSI_INITIATOR_NAME_GET) {

IN EFI_ISCSI_INITIATOR_NAME_PROTOCOL *This

IN OUT UINTN *BufferSize

OUT VOID *Buffer

}

EFI_ISCSI_INITIATOR_NAME_PROTOCOL.Set()

Summary

Sets the iSCSI Initiator Name.

Prototype

typedef EFI_STATUS

(EFIAPI *EFI_ISCSI_INITIATOR_NAME_SET) {

IN EFI_ISCSI_INITIATOR_NAME_PROTOCOL *This

IN OUT UINTN *BufferSize

IN VOID *Buffer

}



The Prototypes should be like below

typedef EFI_STATUS

(EFIAPI *EFI_ISCSI_INITIATOR_NAME_GET) (

IN EFI_ISCSI_INITIATOR_NAME_PROTOCOL *This

IN OUT UINTN *BufferSize

OUT VOID *Buffer

);


typedef EFI_STATUS

(EFIAPI *EFI_ISCSI_INITIATOR_NAME_SET) (

IN EFI_ISCSI_INITIATOR_NAME_PROTOCOL *This

IN OUT UINTN *BufferSize

IN VOID *Buffer

);


Thanks,
Karunakar


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-12-19  8:30 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-12-19  8:28 Syntax error in EFI iSCSI Initiator Name Protocol in UEFI2.7 Spec Karunakar P
2017-12-19  8:35 ` Ye, Ting

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox