public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Wang, Fan" <fan.wang@intel.com>
To: "Fu, Siyuan" <siyuan.fu@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Ye, Ting" <ting.ye@intel.com>, "Wu, Jiaxin" <jiaxin.wu@intel.com>
Subject: Re: [Patch] MdeModulePkg/DpcLib: return error if failed to locate DPC protocol.
Date: Fri, 22 Dec 2017 07:30:27 +0000	[thread overview]
Message-ID: <AB0DD9794D79E349BEB333942A69DBDA31ADE575@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <20171222061357.16916-1-siyuan.fu@intel.com>

Reviewed by Wang, Fan <fan.wang@intel.com>

-----Original Message-----
From: Fu, Siyuan 
Sent: Friday, December 22, 2017 2:14 PM
To: edk2-devel@lists.01.org
Cc: Ye, Ting <ting.ye@intel.com>; Wu, Jiaxin <jiaxin.wu@intel.com>; Wang, Fan <fan.wang@intel.com>
Subject: [Patch] MdeModulePkg/DpcLib: return error if failed to locate DPC protocol.

This patch updates the constructor of DpcLib to return error if failed to locate DPC protocol.

Cc: Ye Ting <ting.ye@intel.com>
Cc: Wu Jiaxin <jiaxin.wu@intel.com>
Cc: Wang Fan <fan.wang@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Fu Siyuan <siyuan.fu@intel.com>
---
 MdeModulePkg/Library/DxeDpcLib/DpcLib.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/MdeModulePkg/Library/DxeDpcLib/DpcLib.c b/MdeModulePkg/Library/DxeDpcLib/DpcLib.c
index 6eda8ca0fb..ddc3e0adda 100644
--- a/MdeModulePkg/Library/DxeDpcLib/DpcLib.c
+++ b/MdeModulePkg/Library/DxeDpcLib/DpcLib.c
@@ -45,7 +45,7 @@ DpcLibConstructor (
   Status = gBS->LocateProtocol (&gEfiDpcProtocolGuid, NULL, (VOID **)&mDpc);
   ASSERT_EFI_ERROR (Status);
 
-  return EFI_SUCCESS;
+  return Status;
 }
 
 /**
--
2.13.0.windows.1



      parent reply	other threads:[~2017-12-22  7:25 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-22  6:13 [Patch] MdeModulePkg/DpcLib: return error if failed to locate DPC protocol Fu Siyuan
2017-12-22  7:26 ` Wu, Jiaxin
2017-12-22  7:30 ` Wang, Fan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AB0DD9794D79E349BEB333942A69DBDA31ADE575@SHSMSX104.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox