From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.120; helo=mga04.intel.com; envelope-from=fan.wang@intel.com; receiver=edk2-devel@lists.01.org Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id E810521140F52 for ; Tue, 18 Sep 2018 18:52:26 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Sep 2018 18:52:26 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,392,1531810800"; d="scan'208";a="264738663" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga006.fm.intel.com with ESMTP; 18 Sep 2018 18:46:56 -0700 Received: from fmsmsx112.amr.corp.intel.com (10.18.116.6) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 18 Sep 2018 18:46:55 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by FMSMSX112.amr.corp.intel.com (10.18.116.6) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 18 Sep 2018 18:46:55 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.143]) by shsmsx102.ccr.corp.intel.com ([169.254.2.226]) with mapi id 14.03.0319.002; Wed, 19 Sep 2018 09:46:51 +0800 From: "Wang, Fan" To: "Wu, Jiaxin" , Laszlo Ersek , "Subramanian, Sriram" , "edk2-devel@lists.01.org" CC: "Ye, Ting" , "Fu, Siyuan" , "Subramanian@mx0b-002e3701.pphosted.com" Thread-Topic: [edk2] [Patch v2] NetworkPkg: UefiPxeBcDxe: Add EXCLUSIVE attribute when opening SNP protocol installed by PXE. Thread-Index: AQHUTAgOjfczhluTqU+UN3UJKbL52aT1U5KAgAD/QoCAAAODgIAAhmlQ Date: Wed, 19 Sep 2018 01:46:51 +0000 Message-ID: References: <20180914082415.800-1-fan.wang@intel.com> <895558F6EA4E3B41AC93A00D163B727416494038@SHSMSX103.ccr.corp.intel.com> <895558F6EA4E3B41AC93A00D163B727416494076@SHSMSX103.ccr.corp.intel.com> In-Reply-To: <895558F6EA4E3B41AC93A00D163B727416494076@SHSMSX103.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch v2] NetworkPkg: UefiPxeBcDxe: Add EXCLUSIVE attribute when opening SNP protocol installed by PXE. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Sep 2018 01:52:27 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Thanks, Laszlo and Jiaxin, I will have a check about the author name "edk2-= devel-bounces@lists.01.org". Best Regards Fan -----Original Message----- From: Wu, Jiaxin=20 Sent: Wednesday, September 19, 2018 9:44 AM To: Wu, Jiaxin ; Laszlo Ersek ; Sub= ramanian, Sriram ; Wang, Fan ; edk2-d= evel@lists.01.org Cc: Ye, Ting ; Fu, Siyuan ; Subrama= nian@mx0b-002e3701.pphosted.com Subject: RE: [edk2] [Patch v2] NetworkPkg: UefiPxeBcDxe: Add EXCLUSIVE attr= ibute when opening SNP protocol installed by PXE. Correct one of my comments. The new version patch should *NOT* include the reviewed-by tag from previou= s version. Thanks, Jiaxin > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of=20 > Wu, Jiaxin > Sent: Wednesday, September 19, 2018 9:32 AM > To: Laszlo Ersek ; Subramanian, Sriram s@hpe.com>; Wang, Fan ; edk2-devel@lists.01.org > Cc: Ye, Ting ; Fu, Siyuan ;=20 > Subramanian@mx0b-002e3701.pphosted.com > Subject: Re: [edk2] [Patch v2] NetworkPkg: UefiPxeBcDxe: Add EXCLUSIVE=20 > attribute when opening SNP protocol installed by PXE. >=20 > > > Subject: [Patch v2] NetworkPkg: UefiPxeBcDxe: Add EXCLUSIVE=20 > > > attribute > > when opening SNP protocol installed by PXE. > > > > > > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1152 > > > > > > v2: Sync the same logic to Ipv6 and update code comments. > > > > > > The PXE driver installs a SNP and open this SNP with attribute=20 > > > BY_DRIVER to avoid it being opened by MNP driver, this SNP is also=20 > > > expected not to be opened by other drivers with EXCLUSIVE=20 > > > attribute. In some cases, > other > > > drivers may happen to do this by error, and thus cause a system crash= . > > > This patch adds EXCLUSIVE attribute when opening SNP in PXE=20 > > > driver, and will reject all OpenProtocol requests by EXCLUSIVE. > > > > > > Cc: Subramanian, Sriram > > > Cc: Ye Ting > > > Cc: Fu Siyuan > > > Cc: Wu Jiaxin > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > > Signed-off-by: Wang Fan > > > --- > > > NetworkPkg/UefiPxeBcDxe/PxeBcDriver.c | 8 ++++---- > > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > Either my edk2-devel subscription is breaking down, or our=20 > > discipline regarding commit pushing is down the drain, recently. > > > > This patch has been pushed as commit cde5a72d365e. Problems with=20 > > that > > commit: > > > > (1) The git authorship is marked as "edk2-devel-bounces@lists.01.org". > > That's *wrong*. This patch was authored by Wang Fan=20 > > . > > >=20 > Sorry Laszlo, I didn't check the "Author" field before pushing the=20 > patch as I received the commit request form Fan. I don't know whether=20 > it's the patch reason or TortoiseGit failed to fetch the "Signed-off-by" = tag as "Author" field. > Anyway, I will double check that. >=20 > > (2) The commit lists Siyuan and Jiaxin as having given their=20 > > reviews. I don't see their *v2* reviews anywhere on the list. I see=20 > > their *v1* reviews, but the patch was changed in v2. Wang Fan was=20 > > correct not to carry forward the v1 reviews into the v2 posting. If=20 > > the v2 posting was fine, then Siyuan and Jiaxin should have=20 > > confirmed that (with R-b's) on the list, before pushing the commit. > > >=20 > Yes, you are right, Fan should include the v1 reviewer into the v2=20 > posting, and the reviewer should confirm the new version patch even=20 > he/she is the final version committer. >=20 The new version patch should *NOT* include the reviewed-by tag from previou= s version.=20 =20 > > Another process failure that I'm witnessing is that people forget to=20 > > close BZs once the corresponding fixes are upstream. Sorry but that=20 > > just makes a joke out of bug tracking. > > >=20 > Thanks the reminder, we will pay attention next time. >=20 > > Come on, guys. We can do better than this. Show some discipline and=20 > > dedication to the process, please. The process is not self-serving;=20 > > it's in place to promote mutual understanding. > > > > Laszlo > > _______________________________________________ > > edk2-devel mailing list > > edk2-devel@lists.01.org > > https://lists.01.org/mailman/listinfo/edk2-devel > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel