From: "Marvin Häuser" <mhaeuser@posteo.de>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: edk2-devel-groups-io <devel@edk2.groups.io>,
Leif Lindholm <quic_llindhol@quicinc.com>,
Ard Biesheuvel <ardb+tianocore@kernel.org>,
Sami Mujawar <sami.mujawar@arm.com>,
Vitaly Cheptsov <vit9696@protonmail.com>
Subject: Re: [edk2-devel] [PATCH 1/2] ArmPkg/AsmMacroIoLibV8: Introduce ASM_FUNC_ALIGN()
Date: Wed, 19 Apr 2023 21:42:24 +0000 [thread overview]
Message-ID: <ABF73F34-8C4F-4F83-B8C5-75D12A0A7454@posteo.de> (raw)
In-Reply-To: <D7BED99B-0867-469E-90B3-B0D15F79B72A@posteo.de>
> On 19. Apr 2023, at 22:10, Marvin Häuser <mhaeuser@posteo.de> wrote:
>
>
>> On 19. Apr 2023, at 21:48, Ard Biesheuvel <ardb@kernel.org> wrote:
>>
>> The issue is likely caused by
>>
>> -Wl,--defsym=PECOFF_HEADER_SIZE=0
>>
>> Why are you setting that? It breaks the ELF to PE conversion.
>
> Where?
AUDK doesn’t use that macro, so you must mean my edk2 branch. In that case - I don’t know, that’s upstream code that isn’t mine? :D
It’s only done for ASLDLINK, which should not interfere here. Still, ASLC does generate PE binaries, so I’m not sure what the deal is with setting it to 0.
Best regards,
Marvin
next prev parent reply other threads:[~2023-04-19 21:42 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-17 18:09 [PATCH 1/2] ArmPkg/AsmMacroIoLibV8: Introduce ASM_FUNC_ALIGN() Marvin Häuser
2023-04-17 18:09 ` [PATCH 2/2] ArmPkg/ArmMmuLib: Fix ArmReplaceLiveTranslationEntry() alignment Marvin Häuser
2023-04-17 19:53 ` Leif Lindholm
2023-04-17 19:52 ` [PATCH 1/2] ArmPkg/AsmMacroIoLibV8: Introduce ASM_FUNC_ALIGN() Leif Lindholm
2023-04-17 21:18 ` Ard Biesheuvel
2023-04-18 6:40 ` Marvin Häuser
2023-04-18 8:10 ` Ard Biesheuvel
2023-04-18 8:18 ` Marvin Häuser
2023-04-18 8:59 ` Ard Biesheuvel
2023-04-19 17:13 ` Marvin Häuser
2023-04-19 17:40 ` [edk2-devel] " Ard Biesheuvel
2023-04-19 17:45 ` Marvin Häuser
2023-04-19 18:03 ` Ard Biesheuvel
2023-04-19 18:25 ` Marvin Häuser
2023-04-19 18:26 ` Ard Biesheuvel
2023-04-19 18:31 ` Marvin Häuser
2023-04-19 19:48 ` Ard Biesheuvel
2023-04-19 20:10 ` Marvin Häuser
2023-04-19 21:42 ` Marvin Häuser [this message]
2023-04-19 21:55 ` Ard Biesheuvel
2023-04-19 22:15 ` Marvin Häuser
2023-04-19 22:27 ` Pedro Falcato
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ABF73F34-8C4F-4F83-B8C5-75D12A0A7454@posteo.de \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox