From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mout02.posteo.de (mout02.posteo.de [185.67.36.66])
 by mx.groups.io with SMTP id smtpd.web11.51432.1681940548613521059
 for <devel@edk2.groups.io>;
 Wed, 19 Apr 2023 14:42:28 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@posteo.de header.s=2017 header.b=q60qxUAi;
 spf=pass (domain: posteo.de, ip: 185.67.36.66, mailfrom: mhaeuser@posteo.de)
Received: from submission (posteo.de [185.67.36.169]) 
	by mout02.posteo.de (Postfix) with ESMTPS id D3131240302
	for <devel@edk2.groups.io>; Wed, 19 Apr 2023 23:42:25 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.de; s=2017;
	t=1681940545; bh=VRVYGrY51Z5zon1sB/lo4UezBDpInEP+SG5H6MdyxTM=;
	h=From:Subject:Date:Cc:To:From;
	b=q60qxUAixqsOYTzwzMtsdE4wH2n3A4VxKK5JM1JxPksECFWhL82yuKsT1q+zXgReO
	 k5vc5MAwmlg/SAWpFkg+XJAqgYaE77Jn+zcw5hm4lIcA7vaE/SvfVXUBDV/gnvcxDF
	 +RdNxNT6BGV88smVhRNbzB44zrFWVcWg4N2Rdzav+BNdenoFXfgNAMF6yhiLKBqhTR
	 sz+pc+M/L9kU4CGwCwEQGqP4q1x1iORzrOMgjsdbVJLrStd040R0aC77BmCqPTU0Tk
	 NuxGRZKTZAyeo1ROkbcjb4CybydwD3Mg7x7twOOm/6RVEuBO5QQu3BQHQqQrE9yXU9
	 m/rn61mR0za2g==
Received: from customer (localhost [127.0.0.1])
	by submission (posteo.de) with ESMTPSA id 4Q1vQS51tdz6tvr;
	Wed, 19 Apr 2023 23:42:24 +0200 (CEST)
From: =?UTF-8?B?TWFydmluIEjDpHVzZXI=?= <mhaeuser@posteo.de>
Mime-Version: 1.0 (1.0)
Subject: Re: [edk2-devel] [PATCH 1/2] ArmPkg/AsmMacroIoLibV8: Introduce ASM_FUNC_ALIGN()
Date: Wed, 19 Apr 2023 21:42:24 +0000
Message-Id: <ABF73F34-8C4F-4F83-B8C5-75D12A0A7454@posteo.de>
References: <D7BED99B-0867-469E-90B3-B0D15F79B72A@posteo.de>
Cc: edk2-devel-groups-io <devel@edk2.groups.io>,
 Leif Lindholm <quic_llindhol@quicinc.com>,
 Ard Biesheuvel <ardb+tianocore@kernel.org>,
 Sami Mujawar <sami.mujawar@arm.com>,
 Vitaly Cheptsov <vit9696@protonmail.com>
In-Reply-To: <D7BED99B-0867-469E-90B3-B0D15F79B72A@posteo.de>
To: Ard Biesheuvel <ardb@kernel.org>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


> On 19. Apr 2023, at 22:10, Marvin H=C3=A4user <mhaeuser@posteo.de> wrote:
>=20
> =EF=BB=BF
>> On 19. Apr 2023, at 21:48, Ard Biesheuvel <ardb@kernel.org> wrote:
>>=20
>> The issue is likely caused by
>>=20
>> -Wl,--defsym=3DPECOFF_HEADER_SIZE=3D0
>>=20
>> Why are you setting that? It breaks the ELF to PE conversion.
>=20
> Where?

AUDK doesn=E2=80=99t use that macro, so you must mean my edk2 branch. In tha=
t case - I don=E2=80=99t know, that=E2=80=99s upstream code that isn=E2=80=99=
t mine? :D

It=E2=80=99s only done for ASLDLINK, which should not interfere here. Still,=
 ASLC does generate PE binaries, so I=E2=80=99m not sure what the deal is wi=
th setting it to 0.

Best regards,
Marvin=