From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from nwk-aaemail-lapp01.apple.com (nwk-aaemail-lapp01.apple.com [17.151.62.66]) by mx.groups.io with SMTP id smtpd.web12.8648.1593731002190068608 for ; Thu, 02 Jul 2020 16:03:22 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@apple.com header.s=20180706 header.b=dChC4+dL; spf=pass (domain: apple.com, ip: 17.151.62.66, mailfrom: afish@apple.com) Received: from pps.filterd (nwk-aaemail-lapp01.apple.com [127.0.0.1]) by nwk-aaemail-lapp01.apple.com (8.16.0.42/8.16.0.42) with SMTP id 062Mv3Q3026636; Thu, 2 Jul 2020 16:03:19 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=apple.com; h=from : content-type : mime-version : subject : date : references : to : in-reply-to : message-id; s=20180706; bh=ysKnIcb+88pFWpaS4FFmOjR48TLFv6cOzEFKll0bpUY=; b=dChC4+dLKtgXHt/u7Rqa/ITRDGiaYq7HDXf7liB2FQDdGeBoe7HO/Ox+JjpXg8AEKV8z hS09H0Zwg0FO9eU2E3b8OOjs2rM+7j4VyA2BaRxbOwg0kDkL6Ii1t8v18MV6Uj6euSpA 2D3lfdYPqxqoPU9GwyNKySHXFnJCO9D71Bm1dSj4yfDd0C46FaAx5jN1B3RApLgn4Tun PRBap3qSAslfkttdh4AzxbghqD4j6SipUh46ptA3wtqAFNO4yasmj4OEf8nxuqG95Ec5 qNxte7WaFdSpc/h8Lgus9FNUU8T49+6SGOR8MR0ligzGcAP+jc7WXfi0m2Mts+J3Cbw+ Lw== Received: from rn-mailsvcp-mta-lapp04.rno.apple.com (rn-mailsvcp-mta-lapp04.rno.apple.com [10.225.203.152]) by nwk-aaemail-lapp01.apple.com with ESMTP id 31x52742av-6 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO); Thu, 02 Jul 2020 16:03:19 -0700 Received: from rn-mailsvcp-mmp-lapp01.rno.apple.com (rn-mailsvcp-mmp-lapp01.rno.apple.com [17.179.253.14]) by rn-mailsvcp-mta-lapp04.rno.apple.com (Oracle Communications Messaging Server 8.1.0.5.20200312 64bit (built Mar 12 2020)) with ESMTPS id <0QCV00W096PJ9WC0@rn-mailsvcp-mta-lapp04.rno.apple.com>; Thu, 02 Jul 2020 16:03:19 -0700 (PDT) Received: from process_milters-daemon.rn-mailsvcp-mmp-lapp01.rno.apple.com by rn-mailsvcp-mmp-lapp01.rno.apple.com (Oracle Communications Messaging Server 8.1.0.5.20200312 64bit (built Mar 12 2020)) id <0QCV00E005NXJB00@rn-mailsvcp-mmp-lapp01.rno.apple.com>; Thu, 02 Jul 2020 16:03:19 -0700 (PDT) X-Va-A: X-Va-T-CD: 678bf7de5df0d9ff994f556fd1b44182 X-Va-E-CD: 0c20cc27f9a9e809919f6d78cad20069 X-Va-R-CD: 607ff9cbcc47efcff04288274998a897 X-Va-CD: 0 X-Va-ID: 00fccb6b-f8a9-4ea4-945a-62d7f45121c1 X-V-A: X-V-T-CD: 678bf7de5df0d9ff994f556fd1b44182 X-V-E-CD: 0c20cc27f9a9e809919f6d78cad20069 X-V-R-CD: 607ff9cbcc47efcff04288274998a897 X-V-CD: 0 X-V-ID: 00091d49-a0b3-41dd-aecb-2448a8a6e72d X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.235,18.0.687 definitions=2020-07-02_09:2020-07-02,2020-07-02 signatures=0 Received: from [17.235.30.145] (unknown [17.235.30.145]) by rn-mailsvcp-mmp-lapp01.rno.apple.com (Oracle Communications Messaging Server 8.1.0.5.20200312 64bit (built Mar 12 2020)) with ESMTPSA id <0QCV00LF26PHK300@rn-mailsvcp-mmp-lapp01.rno.apple.com>; Thu, 02 Jul 2020 16:03:19 -0700 (PDT) From: "Andrew Fish" MIME-version: 1.0 (Mac OS X Mail 13.4 \(3608.80.23.2.2\)) Subject: Re: [edk2-devel] UefiPayloadPkg: assert error in PciHostBridgeDxe Date: Thu, 02 Jul 2020 16:03:17 -0700 References: To: devel@edk2.groups.io, kingsumos@gmail.com In-reply-to: Message-id: X-Mailer: Apple Mail (2.3608.80.23.2.2) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.235,18.0.687 definitions=2020-07-02_09:2020-07-02,2020-07-02 signatures=0 Content-type: multipart/alternative; boundary="Apple-Mail=_452059CE-841A-4765-925F-ABC1F7E454B0" --Apple-Mail=_452059CE-841A-4765-925F-ABC1F7E454B0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On Jul 2, 2020, at 3:54 PM, King Sumo wrote: >=20 > Hi, >=20 > When booting UefiPayloadPkg in my system (x86 Denverton SoC, coreboot) a= n assert error is generated in the PciHostBridgeDxe driver. > In the InitializePciHostBridge() function if all ASSERT's are ignored (b= y commenting out the code) the boot can move further on until it reaches th= e UEFI Shell. > Any clues? >=20 > Loading driver at 0x0007EE61000 EntryPoint=3D0x0007EE6CF52 PciHostBridge= Dxe.efi > InstallProtocolInterface: BC62157E-3E33-4FEC-9920-2D3B36D750DF 7EF1F698 > ProtectUefiImageCommon - 0x7EF1F140 > - 0x000000007EE61000 - 0x0000000000013000 > SetUefiImageMemoryAttributes - 0x000000007EE61000 - 0x0000000000001000 (= 0x0000000000004008) > SetUefiImageMemoryAttributes - 0x000000007EE62000 - 0x0000000000010000 (= 0x0000000000020008) > SetUefiImageMemoryAttributes - 0x000000007EE72000 - 0x0000000000002000 (= 0x0000000000004008) > PROGRESS CODE: V03040002 I0 > InitRootBridge: populated root bus 0, with room for 7 subordinate bus(es= ) > RootBridge: PciRoot(0x0) > Support/Attr: 10003 / 10003 > DmaAbove4G: No > NoExtConfSpace: No > AllocAttr: 0 () > Bus: 0 - 7 Translation=3D0 > Io: 0 - 4FFF Translation=3D0 > Mem: D4000000 - FE0FFFFF Translation=3D0 > MemAbove4G: FFFFFFFFFFFFFFFF - 0 Translation=3D0 > PMem: FFFFFFFFFFFFFFFF - 0 Translation=3D0 > PMemAbove4G: FFFFFFFFFFFFFFFF - 0 Translation=3D0 > PciHostBridgeDxe: IntersectMemoryDescriptor: desc [E0000000, F0000000) t= ype 1 cap 870000000002600F conflicts with aperture [D4000000, FE100000) cap= 1 > It looks like the above request for "D4000000 - FE0FFFFF=E2=80=9D overlaps= with an existing mapping (E0000000, F0000000). The edk2 has something call= ed GCD (Global Coherency Domain) that is kind of like malloc for MMIO space= , and what part of the CPU address has DRAM. So it looks like 2 device thin= k they own (E0000000, F0000000), and there can be only one. You may be gett= ing lucky that your hardware works, but something seems miss configured.=20 Thanks, Andrew Fish > ASSERT_EFI_ERROR (Status =3D Invalid Parameter) > ASSERT [PciHostBridgeDxe] /home/lxuser/occ/edk2/MdeModulePkg/Bus/Pci/Pci= HostBridgeDxe/PciHostBridge.c(488): !EFI_ERROR (Status) >=20 > Thanks, > Sumo >=20 >=20 --Apple-Mail=_452059CE-841A-4765-925F-ABC1F7E454B0 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8

On Jul 2, 20= 20, at 3:54 PM, King Sumo <kingsumos@gmail.com> wrote:

Hi,

When booting&n= bsp;UefiPayloadPkg in my system (x86 Denverton SoC, coreboot) an assert err= or is generated in the PciHostBridgeDxe driver.
In the I= nitializePciHostBridge() function if all ASSERT's are ignored (by commentin= g out the code) the boot can move further on until it reaches the UEFI Shel= l.
Any clues?

Loading driver at 0x0007EE61000 EntryPoint=3D0x0007EE6CF52= PciHostBridgeDxe.efi
InstallProtocolInterface: BC62157E-3E33-4FEC-9920-2D3B36D7= 50DF 7EF1F698
ProtectUefiImageCommon - 0x7EF1F140
  - 0x000000007EE61000 - 0x0000000000013000
SetUefiImageMemoryAttributes - 0x000000007EE61000 - 0x0000= 000000001000 (0x0000000000004008)
SetUefiImageMemoryAttributes - 0x000000007EE62000 - 0x0000= 000000010000 (0x0000000000020008)
SetUefiImageMemoryAttributes - 0x000000007EE72000 - 0x0000= 000000002000 (0x0000000000004008)
PROGRESS CODE: V03040002 I0
InitRootBridge: populated root bus 0, with room for 7 subo= rdinate bus(es)
RootBridge: PciRoot(0x0)
  Support/Attr: 10003 / 10003
    DmaAbove4G: No
NoExtConfSpace: No
     AllocAttr: 0 ()
           Bus: 0 - 7 Transl= ation=3D0
            Io: 0 - 4FFF Tra= nslation=3D0
           Mem: D4000000 - F= E0FFFFF Translation=3D0
    MemAbove4G: FFFFFFFFFFFFFFFF - 0 Translation= = =3D0
          PMem: FFFFFFFFFFFFFFFF = - 0 Translation=3D0
   PMemAbove4G: FFFFFFFFFFFFFFFF - 0 Translation= = =3D0
PciHostBridgeDxe: IntersectMemoryDescriptor: desc [E000000= 0, F0000000) type 1 cap 870000000002600F conflicts with aperture [D4000000,= FE100000) cap 1
 

<= div>It looks like the above request for "D4000000 - FE0FFFFF=E2=80=9D overl= aps with an existing mapping (E0000000, F0000000). The edk2 has something c= alled GCD (Global Coherency Domain) that is kind of like malloc for MMIO sp= ace, and what part of the CPU address has DRAM. So it looks like 2 device t= hink they own (E0000000, F0000000), and there can be only one. You may be g= etting lucky that your hardware works, but something seems miss configured.=  

Thanks,

Andrew Fish

ASSERT_EFI_ERROR (Status =3D Invalid Parameter)
ASSERT [PciHostBridgeDxe] /home/lxuser/occ/edk2/MdeModuleP= kg/Bus/Pci/PciHostBridgeDxe/PciHostBridge.c(488): !EFI_ERROR (Status)

Thanks,
Sumo


--Apple-Mail=_452059CE-841A-4765-925F-ABC1F7E454B0--