public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Sami Mujawar" <sami.mujawar@arm.com>
To: Jeshua Smith <jeshuas@nvidia.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Subject: Re: [edk2-devel] [PATCH v1 05/11] DynamicTablesPkg: Update MADT generator for ACPI 6.5
Date: Mon, 11 Sep 2023 17:59:31 +0000	[thread overview]
Message-ID: <ADD36946-0900-4639-97BF-96E59132129D@arm.com> (raw)
In-Reply-To: <DM6PR12MB3371399AC10672D257AD7D01DBF2A@DM6PR12MB3371.namprd12.prod.outlook.com>

[-- Attachment #1: Type: text/plain, Size: 1878 bytes --]

Hi Jeshua,

Apologies, I was busy with some other tasks. I will pick this up in this week.

Regards,

Sami Mujawar

From: Jeshua Smith <jeshuas@nvidia.com>
Date: Monday, 11 September 2023 at 17:58
To: Sami Mujawar <Sami.Mujawar@arm.com>, "devel@edk2.groups.io" <devel@edk2.groups.io>
Subject: RE: [edk2-devel] [PATCH v1 05/11] DynamicTablesPkg: Update MADT generator for ACPI 6.5

Hi Sami,

What is the status of getting this series updated, reviewed, and merged?

From: Sami Mujawar <sami.mujawar@arm.com>
Sent: Thursday, August 3, 2023 1:08 AM
To: Jeshua Smith <jeshuas@nvidia.com>; devel@edk2.groups.io
Subject: Re: [edk2-devel] [PATCH v1 05/11] DynamicTablesPkg: Update MADT generator for ACPI 6.5

External email: Use caution opening links or attachments

Hi Jeshua,

Thank you for the feedback.

On Tue, Aug 1, 2023 at 08:44 AM, Jeshua Smith wrote:
It looks like you are setting the wrong field here (should be TrbeInterrupt, not SpeOverflowInterrupt):
+ // Setting TrbeInterrupt to 0 ensures backward compatibility with
+ // ACPI 6.4
+ Gicc->SpeOverflowInterrupt = 0;
Indeed this is a bug. I will address this in the v2 series.

Regards,

Sami Mujawar
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108496): https://edk2.groups.io/g/devel/message/108496
Mute This Topic: https://groups.io/mt/100347387/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



[-- Attachment #2: Type: text/html, Size: 6227 bytes --]

  reply	other threads:[~2023-09-11 17:59 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-25 10:27 [edk2-devel] [PATCH v1 00/11] Update MADT for ACPI 6.5, and add TRBE & ETE support Sami Mujawar
2023-07-25 10:27 ` [edk2-devel] [PATCH v1 01/11] MdePkg: MADT: Add Online capable flag in GICC Sami Mujawar
2023-07-25 10:27 ` [edk2-devel] [PATCH v1 02/11] MdePkg: MADT: Add TRBE interrupt to GICC Sami Mujawar
2023-07-25 10:27 ` [edk2-devel] [PATCH v1 03/11] DynamicTablesPkg: Add TRBE interrupt to GICC object Sami Mujawar
2023-07-25 10:27 ` [edk2-devel] [PATCH v1 04/11] DynamicTablesPkg: Add TRBE interrupt to GICC object parser Sami Mujawar
2023-07-25 10:27 ` [edk2-devel] [PATCH v1 05/11] DynamicTablesPkg: Update MADT generator for ACPI 6.5 Sami Mujawar
2023-08-01 15:44   ` Jeshua Smith via groups.io
2023-08-03  7:07     ` Sami Mujawar
2023-09-11 16:58       ` Jeshua Smith via groups.io
2023-09-11 17:59         ` Sami Mujawar [this message]
2023-07-25 10:27 ` [edk2-devel] [PATCH v1 06/11] DynamicTablesPkg: Update FADT generator to " Sami Mujawar
2023-07-25 10:27 ` [edk2-devel] [PATCH v1 07/11] ShellPkg: Acpiview: Update MADT parser for TRBE interrupt Sami Mujawar
2023-07-25 10:27 ` [edk2-devel] [PATCH v1 08/11] DynamicTablesPkg: Add an ET info object to Arm namespace Sami Mujawar
2023-07-25 10:27 ` [edk2-devel] [PATCH v1 09/11] DynamicTablesPkg: Add an ET info object parser Sami Mujawar
2023-07-25 10:27 ` [edk2-devel] [PATCH v1 10/11] DynamicTablesPkg: Add ETE device to CPU node in AML Sami Mujawar
2023-07-25 10:27 ` [edk2-devel] [PATCH v1 11/11] DynamicTablesPkg: Fix referencing of CPC token Sami Mujawar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ADD36946-0900-4639-97BF-96E59132129D@arm.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox