public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Nate DeSimone" <nathaniel.l.desimone@intel.com>
To: "Desimone, Ashley E" <ashley.e.desimone@intel.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Pandya, Puja" <puja.pandya@intel.com>,
	"Bjorge, Erik C" <erik.c.bjorge@intel.com>,
	Bret Barkelew <Bret.Barkelew@microsoft.com>,
	"Agyeman, Prince" <prince.agyeman@intel.com>
Subject: Re: [edk2-staging/EdkRepo] [PATCH] EdkRepo: Add missing import definition
Date: Fri, 27 Mar 2020 20:33:01 +0000	[thread overview]
Message-ID: <ADFA01FE-6023-4B12-9169-C42C9A469C1D@intel.com> (raw)
In-Reply-To: <20200326212548.19968-1-ashley.e.desimone@intel.com>

Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com>

On 3/26/20, 2:26 PM, "Desimone, Ashley E" <ashley.e.desimone@intel.com> wrote:

    Add the definition of PIN_FILE_HELP to
    checkout_pin_args.py to fix import error.
    
    Signed-off-by: Ashley E Desimone <ashley.e.desimone@intel.com>
    Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
    Cc: Puja Pandya <puja.pandya@intel.com>
    Cc: Erik Bjorge <erik.c.bjorge@intel.com>
    Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
    Cc: Prince Agyeman <prince.agyeman@intel.com>
    ---
     edkrepo/commands/arguments/checkout_pin_args.py | 1 +
     1 file changed, 1 insertion(+)
    
    diff --git a/edkrepo/commands/arguments/checkout_pin_args.py b/edkrepo/commands/arguments/checkout_pin_args.py
    index abd01b3..6020145 100644
    --- a/edkrepo/commands/arguments/checkout_pin_args.py
    +++ b/edkrepo/commands/arguments/checkout_pin_args.py
    @@ -9,3 +9,4 @@
     
     COMMAND_DESCRIPTION = ('Checks out the revisions described in a PIN file in '
                            'an existing workpace of the same project')
    +PIN_FILE_HELP = ('The name of the pin file to checkout.')
    -- 
    2.16.2.windows.1
    
    


      parent reply	other threads:[~2020-03-27 20:33 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-26 21:25 [edk2-staging/EdkRepo] [PATCH] EdkRepo: Add missing import definition Desimone, Ashley E
2020-03-26 21:32 ` Bjorge, Erik C
2020-03-26 21:55 ` Agyeman, Prince
2020-03-27 20:33 ` Nate DeSimone [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ADFA01FE-6023-4B12-9169-C42C9A469C1D@intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox