From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-in6.apple.com (mail-out6.apple.com [17.151.62.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 224B221A16EFB for ; Wed, 17 May 2017 23:16:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; d=apple.com; s=mailout2048s; c=relaxed/simple; q=dns/txt; i=@apple.com; t=1495088179; h=From:Sender:Reply-To:Subject:Date:Message-id:To:Cc:MIME-version:Content-type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-reply-to:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=oV76r9/mLUodQ+LFRkimD1EQheHKOvPWFWAbAUNls90=; b=fKvCw9OCYpjl37GQxQiiv3VOHVfafsw18OzUE4WJAzzi1/Wuje7xel9Xtl+KNB2a tPCuBZZmSCybwB16/OMRdv7a1VK1rnsEbJMg1y47lqxIx3iP419T2zDzmV6tSvbQ +gm9fqUxzw1aeAcUqsnDAShFyCAOfpTUuTiSOrSCabrjdG82SseiciNHkrMEIyOj 3x5FgrildoKRdtg0zeU7hvfvSIvuHquYpeWFAwhDHwR1nSpm6hl8w52VAV4LpFGW B/4bDEY95zg22FSnFaRB0oSqEPt5UbsE2Kg5aLzosgBm8+XN0FZBvVPZYe9nUFz8 jtmpqXNaUJbrGxv2S4JUFQ==; Received: from relay2.apple.com (relay2.apple.com [17.128.113.67]) (using TLS with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mail-in6.apple.com (Apple Secure Mail Relay) with SMTP id F2.CE.26227.23C3D195; Wed, 17 May 2017 23:16:19 -0700 (PDT) X-AuditID: 11973e15-0b9fb70000006673-37-591d3c321436 Received: from nwk-mmpp-sz10.apple.com (nwk-mmpp-sz10.apple.com [17.128.115.122]) by relay2.apple.com (Apple SCV relay) with SMTP id 04.D6.07829.13C3D195; Wed, 17 May 2017 23:16:18 -0700 (PDT) MIME-version: 1.0 Received: from [17.153.32.91] by nwk-mmpp-sz10.apple.com (Oracle Communications Messaging Server 8.0.1.2.20170210 64bit (built Feb 10 2017)) with ESMTPSA id <0OQ400HMYXF4R830@nwk-mmpp-sz10.apple.com>; Wed, 17 May 2017 23:16:17 -0700 (PDT) Sender: afish@apple.com From: Andrew Fish Message-id: Date: Wed, 17 May 2017 23:16:16 -0700 In-reply-to: <37A305D9-9DD3-4D55-9E72-33219ABD8046@apple.com> Cc: Mike Kinney , edk2-devel-01 , "Dong, Eric" , "Zeng, Star" To: Michael Zimmermann References: <98D24FD3-B4DD-4132-BFA3-7D3887CA250D@apple.com> <37A305D9-9DD3-4D55-9E72-33219ABD8046@apple.com> X-Mailer: Apple Mail (2.3273) X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrGLMWRmVeSWpSXmKPExsUi2FDorGtsIxtpcPOgvMWeQ0eZLTa/CLbo 6PjHZDF36lNWi3291g6sHjtn3WX3WLznJZNH9+x/LAHMUVw2Kak5mWWpRfp2CVwZs3fdZCmY NZel4sGuw8wNjAtvM3cxcnJICJhI/J2xnA3EFhJYzSRxbpkWTHzPxQVQ8UOMEmd+i4HYvAKC Ej8m32MBsZkFwiQmnvrH3sXIBVTzhVFidccxsAZhAXGJd2c2gS1gE1CWWDH/AztEs43E6zV7 WSFqdCSmLjwHFmcRUJXY+XIr2FBOAVuJaa/7geIcQAsWMkrcigMJiwgYSjxtfswEseskk8T1 f9+hHpCVuDX7EjNIQkLgPpvEj7mdbBMYhWYhOXYWkmMhbC2J749ageIgO+QlDp6XhQhrSjy7 9wmqRFviybsLrAsY2VYxCuUmZuboZuaZ6SUWFOSk6iXn525iBEXMdDvRHYxnVlkdYhTgYFTi 4d0QJBMpxJpYVlyZe4hRmoNFSZw3dDNQSCA9sSQ1OzW1ILUovqg0J7X4ECMTB6dUA+OuU/cn VEl6H27cafbY4GP2oWV5Irrn0r99ZXevq35c55N16Wr6wxfyv/m0Q3o+9exNPnxBR6ryzlv9 2co+B5dGaPFs1q5K5Lv8yefmEWbFOX5rC17mSnoe9vp6Z02573x3WR3Tg8YiVm4101o/9TmF eQjFFmT5RiwwMFzz2UV8fsV2g/jDoUosxRmJhlrMRcWJAB21mmp5AgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrIIsWRmVeSWpSXmKPExsUi2FBcpWtkIxtpcOOEoMWeQ0eZLTa/CLbo 6PjHZDF36lNWi3291g6sHjtn3WX3WLznJZNH9+x/LAHMUVw2Kak5mWWpRfp2CVwZs3fdZCmY NZel4sGuw8wNjAtvM3cxcnJICJhI7Lm4gA3EFhI4xChx5rcYiM0rICjxY/I9FhCbWSBMYuKp f+xdjFxANV8YJVZ3HANrEBYQl3h3ZhPYIDYBZYkV8z+wQzTbSLxes5cVokZHYurCc2BxFgFV iZ0vt4IN5RSwlZj2uh8ozgG0YCGjxK04kLCIgKHE0+bHTBC7TjJJXP/3HepQWYlbsy8xT2Dk n4XkvllI7oOwtSS+P2oFioOMlZc4eF4WIqwp8ezeJ6gSbYkn7y6wLmBkW8UoUJSak1hppJdY UJCTqpecn7uJERzihc47GI8tszrEKMDBqMTDuyFIJlKINbGsuDIXGEYczEoivNMtZCOFeFMS K6tSi/Lji0pzUosPMU5kBHpyIrOUaHI+MALzSuINTUwMTIyNzYyNzU3MaSmsJM77WBzoIoH0 xJLU7NTUgtQimKOYODilGhj5DToj9txzPmptqBNy7YJbx+xajvrEgqnyHDoaq7YUCKlZzH17 6t3rpW69xm31zfFnrs7qW9EsVSJf96ufZZH5zS2aLYenzvpVHeqtn2Q2cTazaop02PbzV0K/ P7N9bXvBOpevXbIwXlbabdbmnKsflG5I5h38mpcRv4fnn9zLV0c4Jn5aYK7EUpyRaKjFXFSc CACXWqpy5AIAAA== X-Content-Filtered-By: Mailman/MimeDel 2.1.22 Subject: Re: UEFI_DRIVER dependencies X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 May 2017 06:16:20 -0000 Content-Type: text/plain; CHARSET=US-ASCII Content-Transfer-Encoding: 7BIT Michael, I forgot to mention If the DXE phase does not produce all the protocols required to dispatch UEFI_DRIVERs you get a lot of DEBUG prints and an ASSERTs out of the DXE Core. https://github.com/tianocore/edk2/blob/master/MdeModulePkg/Core/Dxe/DxeMain/DxeMain.c#L480 // // Display Architectural protocols that were not loaded if this is DEBUG build // DEBUG_CODE_BEGIN (); CoreDisplayMissingArchProtocols (); DEBUG_CODE_END (); // // Display any drivers that were not dispatched because dependency expression // evaluated to false if this is a debug build // DEBUG_CODE_BEGIN (); CoreDisplayDiscoveredNotDispatched (); DEBUG_CODE_END (); // // Assert if the Architectural Protocols are not present. // Status = CoreAllEfiServicesAvailable (); if (EFI_ERROR(Status)) { // // Report Status code that some Architectural Protocols are not present. // REPORT_STATUS_CODE ( EFI_ERROR_CODE | EFI_ERROR_MAJOR, (EFI_SOFTWARE_DXE_CORE | EFI_SW_DXE_CORE_EC_NO_ARCH) ); } ASSERT_EFI_ERROR (Status); > On May 17, 2017, at 11:09 PM, Andrew Fish wrote: > >> >> On May 17, 2017, at 10:42 PM, Michael Zimmermann > wrote: >> >> Michael, that's a good point but it only works for drivers which bind >> to a device. If you're just installing a protocol e.g. for virtual >> devices or special services which you don't want to turn into >> libraries then this doesn't work. >> >> Haojian, that's what I was thinking, I just wasn't sure if the order >> is reliable. >> > > Micheal, > > From a PI/UEFI architectural perspective the contract is the depex are honored. If multiple drivers are TRUE at the same time the order they execute is not defined. Basically it is implementation choice and you should not write code that depends on this. This is why the A priori file exists, it is the only architectural way to force order of dispatch. Well DXE has BEFORE and AFTER. > > When I wrote the original dispatcher I ended up adding new drivers to the tail of the list vs. the head. Both would have been legal from a spec point of view. So by observing the current behavior you are conflating my implementation choice with the contract provided by specification. > > >> Andrew, your description sounds like its about DXE_DRIVERs and their >> Depex sections, does this apply to UEFI_DRIVERs too when they're >> auto-loaded from the fdf(since they don't support the Depex section)? >> > > No Depex section for UEFI_DRIVERS implies this Depex: > > [Depex] > gEfiSecurityArchProtocolGuid AND > gEfiCpuArchProtocolGuid AND > gEfiMetronomeArchProtocolGuid AND > gEfiTimerArchProtocolGuid AND > gEfiBdsArchProtocolGuid AND > gEfiWatchdogTimerArchProtocolGuid AND > gEfiRuntimeArchProtocolGuid AND > gEfiVariableArchProtocolGuid AND > gEfiVariableWriteArchProtocolGuid AND > gEfiCapsuleArchProtocolGuid AND > gEfiMonotonicCounterArchProtocolGuid AND > gEfiResetArchProtocolGuid AND > gEfiRealTimeClockArchProtocolGuid > > This is how we glued PI (DXE_DRIVERS) and UEFI (UEFI_DRIVER) together. EFI predates the concept of DXE in PI. > > The primary job of DXE_DRIVERS is to configure all the hardware required to provide all the EFI Boot and Runtime Services. The above protocols are what the DXE Core requires to produce all the EFI Boot and Runtime services. > > Thanks, > > Andrew Fish > >> Thanks for all your answers, >> Michael >> >> On Thu, May 18, 2017 at 7:21 AM, Andrew Fish wrote: >>> >>>> On May 17, 2017, at 10:00 PM, Kinney, Michael D wrote: >>>> >>>> Michael, >>>> >>>> The UEFI Driver Model and the Driver Binding Protocol >>>> provide support for this case. The idea is that a driver >>>> is loaded and started, but when a UEFI Driver is started, >>>> it only registers a Driver Binding Protocol. Then in the >>>> BDS phase, the devices required to boot are started using >>>> the UEFI Boot Service ConnectController() and >>>> ConnectController() calls the Driver Binding Protocol(s). >>>> >>>> The dependencies between UEFI Drivers are in their Driver >>>> Binding Protocols which are not used until after all of >>>> the UEFI Drivers are loaded and started. >>>> >>> >>> Micheal, >>> >>> 1st off no dependency is really a dependency on all the architecture protocols, which is a fancy way of saying all the EFI Boot and Runtime Services are available. >>> >>> Lets say you have a driver that depends on DiskIo. The DiskIo driver depends on BlockIo. Now what happens when a disk driver is connected and produces a BlockIO is the DiskIo driver can know get connected. The DXE Core knows a protocol was added to the handle so it will keep trying to connect drivers to that handle as long as new protocols get added. So this is how the DriverBinding Support() is used to resolve the sequence issues. >>> >>> Thanks, >>> >>> Andrew Fish >>> >>>> Mike >>>> >>>>> -----Original Message----- >>>>> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Michael >>>>> Zimmermann >>>>> Sent: Wednesday, May 17, 2017 9:43 PM >>>>> To: edk2-devel-01 ; Zeng, Star ; Dong, >>>>> Eric >>>>> Subject: [edk2] UEFI_DRIVER dependencies >>>>> >>>>> I know that UEFI_DRIVERs don't need or support Depex sections, but >>>>> what if an UEFI_DRIVER depends on a protocol provided by another >>>>> UEFI_DRIVER? >>>>> Since they get loaded automatically because I put them in my >>>>> platform's fdf, it raises the question of the loading order. >>>>> >>>>> Will they get loaded in the order they're defined? How often will the >>>>> core retry if one of the drivers returns EFI_NOT_READY? >>>>> >>>>> Thanks, >>>>> Michael >>>>> _______________________________________________ >>>>> edk2-devel mailing list >>>>> edk2-devel@lists.01.org >>>>> https://lists.01.org/mailman/listinfo/edk2-devel >>>> _______________________________________________ >>>> edk2-devel mailing list >>>> edk2-devel@lists.01.org >>>> https://lists.01.org/mailman/listinfo/edk2-devel >>> >> _______________________________________________ >> edk2-devel mailing list >> edk2-devel@lists.01.org >> https://lists.01.org/mailman/listinfo/edk2-devel > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel