Re: [PATCH] CloudHv: can't find gUefiOvmfPkgTokenSpaceGuid

["Sami Mujawar" <sami.mujawar@arm.com>]

Hi Jianyong,

Please find my response inline marked [SAMI].

Regards,

Sami Mujawar

On 28/03/2023, 09:17, "Jianyong Wu" <Jianyong.Wu@arm.com <mailto:Jianyong.Wu@arm.com>> wrote:


Hi Sami,


I have never added CI for CloudHv. So, should I add it?
[SAMI] I think you can prepare the patch that adds the CI support and push your changes to your private github branch. You should then be able to generate a draft pull request to test that the CI patch works.

Also, I will update this patch based on your comment and send the second version.
[SAMI] Please also update the commit message with the r-b received so far.


Thanks,
Jianyong


> -----Original Message-----
> From: Sami Mujawar <Sami.Mujawar@arm.com <mailto:Sami.Mujawar@arm.com>>
> Sent: 2023年3月28日 15:52
> To: Sunil V L <sunilvl@ventanamicro.com <mailto:sunilvl@ventanamicro.com>>; Jianyong Wu
> <Jianyong.Wu@arm.com <mailto:Jianyong.Wu@arm.com>>
> Cc: devel@edk2.groups.io <mailto:devel@edk2.groups.io>; Ard Biesheuvel <ardb@kernel.org <mailto:ardb@kernel.org>>
> Subject: Re: [PATCH] CloudHv: can't find gUefiOvmfPkgTokenSpaceGuid
>
> Hi Jianyong,
>
> Please find my response inline marked [SAMI].
>
> Regards,
>
> Sami Mujawar
>
> On 28/03/2023, 08:45, "Sunil V L" <sunilvl@ventanamicro.com <mailto:sunilvl@ventanamicro.com>
> <mailto:sunilvl@ventanamicro.com <mailto:sunilvl@ventanamicro.com>>> wrote:
>
>
> On Tue, Mar 28, 2023 at 03:28:25AM +0000, Jianyong Wu wrote:
> > Add Ard Biesheuvel <ardb@kernel.org <mailto:ardb@kernel.org> <mailto:ardb@kernel.org <mailto:ardb@kernel.org>>> and Sunil
> V L <sunilvl@ventanamicro.com <mailto:sunilvl@ventanamicro.com> <mailto:sunilvl@ventanamicro.com <mailto:sunilvl@ventanamicro.com>>> to cc
> list.
> >
> > > -----Original Message-----
> > > From: Jianyong Wu <jianyong.wu@arm.com <mailto:jianyong.wu@arm.com>
> <mailto:jianyong.wu@arm.com <mailto:jianyong.wu@arm.com>>>
> > > Sent: 2023年2月17日 14:48
> > > To: devel@edk2.groups.io <mailto:devel@edk2.groups.io> <mailto:devel@edk2.groups.io <mailto:devel@edk2.groups.io>>; Sami Mujawar
> > > <Sami.Mujawar@arm.com <mailto:Sami.Mujawar@arm.com> <mailto:Sami.Mujawar@arm.com <mailto:Sami.Mujawar@arm.com>>>
> > > Cc: Jianyong Wu <Jianyong.Wu@arm.com <mailto:Jianyong.Wu@arm.com>
> <mailto:Jianyong.Wu@arm.com <mailto:Jianyong.Wu@arm.com>>>
> > > Subject: [PATCH] CloudHv: can't find gUefiOvmfPkgTokenSpaceGuid
> > >
> > > commit f13264b34 introduces a bug for CloudHv as OvmfPkg/OvmfPkg.dec
> > > is missing in CloudHvHasAcpiDtDxe.inf which leads to
> > > gUefiOvmfPkgTokenSpaceGuid found nowhere.
> > >
> > > Signed-off-by: Jianyong Wu <jianyong.wu@arm.com <mailto:jianyong.wu@arm.com>
> > > <mailto:jianyong.wu@arm.com <mailto:jianyong.wu@arm.com>>>
> > > ---
> Hi Jianyong,
>
>
> Any reason why this platform is not built as part of CI? I think it will be good to
> add so that we don't break by some changes like this.
> [SAMI] Ard has recently added CI support for Kvmtool guest firmware. Please
> see the change at
> https://github.com/tianocore/edk2/commit/ca573b86157e7fcd34cd44e79ebd <https://github.com/tianocore/edk2/commit/ca573b86157e7fcd34cd44e79ebd>
> 10e89d8b8cc4.
>
> Thanks,
> Sunil
>
>
>





IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.