From: "Andrew Fish" <afish@apple.com>
To: Leif Lindholm <leif@nuviainc.com>
Cc: edk2-devel-groups-io <devel@edk2.groups.io>,
Mike Kinney <michael.d.kinney@intel.com>,
Laszlo Ersek <lersek@redhat.com>,
Pankaj Bansal <pankaj.bansal@oss.nxp.com>
Subject: Re: [PATCH edk2-InfSpecification] Drop statement on package ordering
Date: Tue, 02 Jun 2020 20:33:40 -0700 [thread overview]
Message-ID: <AF520596-0DA8-4865-9C02-1BBE400C535A@apple.com> (raw)
In-Reply-To: <20200529140251.23933-1-leif@nuviainc.com>
> On May 29, 2020, at 7:02 AM, Leif Lindholm <leif@nuviainc.com> wrote:
>
> The description of [Packages] sections stated that
> "Packages must be listed in the order that may be required for specifying
> include path statements for a compiler. For example, the
> MdePkg/MdePkg.dec file must be listed before the
> MdeModulePkg/MdeModulePkg.dec file."
>
> Drop it.
>
> Signed-off-by: Leif Lindholm <leif@nuviainc.com>
> ---
>
> Surely this isn't something we take seriously?
> If there is a measurable performance impact to the order of -I option
> on the compiler command line, we should approach this programmatically.
>
I think the intent of this was to deal with duplicates include file names, and it was not really about build performance.
Thanks,
Andrew Fish
> 3_edk_ii_inf_file_format/37_[packages]_sections.md | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/3_edk_ii_inf_file_format/37_[packages]_sections.md b/3_edk_ii_inf_file_format/37_[packages]_sections.md
> index 17a8d91..c09112b 100644
> --- a/3_edk_ii_inf_file_format/37_[packages]_sections.md
> +++ b/3_edk_ii_inf_file_format/37_[packages]_sections.md
> @@ -42,11 +42,8 @@ Defines the `[Packages]` section tag that is used in EDK II module INF files.
> Each entry in this section contains a directory name, forward slash character
> and the name of the DEC file contained in the directory name.
>
> -Packages must be listed in the order that may be required for specifying
> -include path statements for a compiler. For example, the _MdePkg/MdePkg.dec_
> -file must be listed before the `MdeModulePkg/MdeModulePkg.dec` file. If there
> -are PCDs listed in the generated "As Built" INF, the packages that declare any
> -PCDs must be listed in this section.
> +If there are PCDs listed in the generated "As Built" INF, the packages that
> +declare any PCDs must be listed in this section.
>
> Each package filename must be listed only once per section. Package filenames
> listed in architectural sections are not permitted to be listed in the common
> --
> 2.20.1
>
next prev parent reply other threads:[~2020-06-03 3:33 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-29 14:02 [PATCH edk2-InfSpecification] Drop statement on package ordering Leif Lindholm
2020-05-31 22:19 ` Michael D Kinney
2020-05-31 22:43 ` [edk2-devel] " Leif Lindholm
2020-06-01 3:39 ` Pankaj Bansal
2020-06-01 5:15 ` Michael D Kinney
2020-06-01 7:01 ` Pankaj Bansal
2020-06-01 15:31 ` Michael D Kinney
2020-06-02 13:29 ` Laszlo Ersek
2020-06-02 13:37 ` Pankaj Bansal
2020-06-02 14:22 ` Leif Lindholm
2020-06-02 16:11 ` Laszlo Ersek
2020-06-03 3:12 ` Pankaj Bansal
2020-06-02 14:20 ` Leif Lindholm
2020-06-02 16:20 ` Laszlo Ersek
2020-06-03 11:44 ` Leif Lindholm
2020-06-03 13:43 ` Laszlo Ersek
2020-06-03 3:33 ` Andrew Fish [this message]
[not found] ` <1614EB3F428C08F5.21938@groups.io>
2020-06-03 3:41 ` Andrew Fish
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AF520596-0DA8-4865-9C02-1BBE400C535A@apple.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox