From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from ma1-aaemail-dr-lapp03.apple.com (ma1-aaemail-dr-lapp03.apple.com [17.171.2.72]) by mx.groups.io with SMTP id smtpd.web11.6346.1591155224641602669 for ; Tue, 02 Jun 2020 20:33:45 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@apple.com header.s=20180706 header.b=QL9iAw7l; spf=pass (domain: apple.com, ip: 17.171.2.72, mailfrom: afish@apple.com) Received: from pps.filterd (ma1-aaemail-dr-lapp03.apple.com [127.0.0.1]) by ma1-aaemail-dr-lapp03.apple.com (8.16.0.42/8.16.0.42) with SMTP id 0533FmsG021663; Tue, 2 Jun 2020 20:33:43 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=apple.com; h=content-type : mime-version : subject : from : in-reply-to : date : cc : content-transfer-encoding : message-id : references : to; s=20180706; bh=La9i4CMMRaVAvPg7NREGF9rhnT/Y/Vt8HdjQfrokdHE=; b=QL9iAw7lSUbE4ZvoWcombL7vtxcroT1ke1sNt8huvgRRelWdwiPNFxcOu4NxbTRu14ox 2FgW+UUI5A6tlbjn6myyLl6+K0cvc3BiyRv17hB/CYnJZoJK9F64J650vJx1ViBcVdtw 5SZJqsR66vvC+A2RirBQ/LSV2r0uDeGf0ay9FoqvWmKXMWREo5mm/rOm/cMq8TwhgFDB Xa6icicJcZdKEdra3wVdA021SvYxdnY12y4ZC9rw26TLMFPb2XDeYQBhVxyEqNleWy49 ST7xGHgTN2LAdNPDtHYgFqiZt4SfR1FEoPQ3uRgeOmMCHUm/L6TIlXHFUG8Ai7QS727M 4A== Received: from rn-mailsvcp-mta-lapp03.rno.apple.com (rn-mailsvcp-mta-lapp03.rno.apple.com [10.225.203.151]) by ma1-aaemail-dr-lapp03.apple.com with ESMTP id 31bpfuam48-2 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO); Tue, 02 Jun 2020 20:33:43 -0700 Received: from rn-mailsvcp-mmp-lapp01.rno.apple.com (rn-mailsvcp-mmp-lapp01.rno.apple.com [17.179.253.14]) by rn-mailsvcp-mta-lapp03.rno.apple.com (Oracle Communications Messaging Server 8.1.0.5.20200312 64bit (built Mar 12 2020)) with ESMTPS id <0QBB00MRRZ86ZZ40@rn-mailsvcp-mta-lapp03.rno.apple.com>; Tue, 02 Jun 2020 20:33:42 -0700 (PDT) Received: from process_milters-daemon.rn-mailsvcp-mmp-lapp01.rno.apple.com by rn-mailsvcp-mmp-lapp01.rno.apple.com (Oracle Communications Messaging Server 8.1.0.5.20200312 64bit (built Mar 12 2020)) id <0QBB00C00YNTGJ00@rn-mailsvcp-mmp-lapp01.rno.apple.com>; Tue, 02 Jun 2020 20:33:42 -0700 (PDT) X-Va-A: X-Va-T-CD: 609d8f453071288a9328a06bc9547b4d X-Va-E-CD: e73f1569e314c8db389979aa355e171e X-Va-R-CD: 2f99bb2c10602c1604f177003befaba6 X-Va-CD: 0 X-Va-ID: 060049a7-e3db-45d1-8266-80be564d31bb X-V-A: X-V-T-CD: 609d8f453071288a9328a06bc9547b4d X-V-E-CD: e73f1569e314c8db389979aa355e171e X-V-R-CD: 2f99bb2c10602c1604f177003befaba6 X-V-CD: 0 X-V-ID: 4cd589c0-8cdf-4313-9f6b-d801ccb7c07a X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.216,18.0.687 definitions=2020-06-02_15:2020-06-02,2020-06-02 signatures=0 Received: from [17.235.27.245] (unknown [17.235.27.245]) by rn-mailsvcp-mmp-lapp01.rno.apple.com (Oracle Communications Messaging Server 8.1.0.5.20200312 64bit (built Mar 12 2020)) with ESMTPSA id <0QBB009HRZ84W400@rn-mailsvcp-mmp-lapp01.rno.apple.com>; Tue, 02 Jun 2020 20:33:42 -0700 (PDT) MIME-version: 1.0 (Mac OS X Mail 13.4 \(3608.80.23.2.2\)) Subject: Re: [PATCH edk2-InfSpecification] Drop statement on package ordering From: "Andrew Fish" In-reply-to: <20200529140251.23933-1-leif@nuviainc.com> Date: Tue, 02 Jun 2020 20:33:40 -0700 Cc: edk2-devel-groups-io , Mike Kinney , Laszlo Ersek , Pankaj Bansal Message-id: References: <20200529140251.23933-1-leif@nuviainc.com> To: Leif Lindholm X-Mailer: Apple Mail (2.3608.80.23.2.2) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.216,18.0.687 definitions=2020-06-02_15:2020-06-02,2020-06-02 signatures=0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: quoted-printable > On May 29, 2020, at 7:02 AM, Leif Lindholm wrote: >=20 > The description of [Packages] sections stated that > "Packages must be listed in the order that may be required for = specifying > include path statements for a compiler. For example, the > MdePkg/MdePkg.dec file must be listed before the > MdeModulePkg/MdeModulePkg.dec file." >=20 > Drop it. >=20 > Signed-off-by: Leif Lindholm > --- >=20 > Surely this isn't something we take seriously? > If there is a measurable performance impact to the order of -I option > on the compiler command line, we should approach this = programmatically. >=20 I think the intent of this was to deal with duplicates include file = names, and it was not really about build performance.=20 Thanks, Andrew Fish > 3_edk_ii_inf_file_format/37_[packages]_sections.md | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) >=20 > diff --git a/3_edk_ii_inf_file_format/37_[packages]_sections.md = b/3_edk_ii_inf_file_format/37_[packages]_sections.md > index 17a8d91..c09112b 100644 > --- a/3_edk_ii_inf_file_format/37_[packages]_sections.md > +++ b/3_edk_ii_inf_file_format/37_[packages]_sections.md > @@ -42,11 +42,8 @@ Defines the `[Packages]` section tag that is used = in EDK II module INF files. > Each entry in this section contains a directory name, forward slash = character > and the name of the DEC file contained in the directory name. >=20 > -Packages must be listed in the order that may be required for = specifying > -include path statements for a compiler. For example, the = _MdePkg/MdePkg.dec_ > -file must be listed before the `MdeModulePkg/MdeModulePkg.dec` file. = If there > -are PCDs listed in the generated "As Built" INF, the packages that = declare any > -PCDs must be listed in this section. > +If there are PCDs listed in the generated "As Built" INF, the = packages that > +declare any PCDs must be listed in this section. >=20 > Each package filename must be listed only once per section. Package = filenames > listed in architectural sections are not permitted to be listed in the = common > --=20 > 2.20.1 >=20