* [PATCH] MdePkg: Add PI 1.5 SmramMemoryReserve HOB file
@ 2019-07-26 10:12 Marc W Chen
2019-07-29 7:49 ` Liming Gao
0 siblings, 1 reply; 3+ messages in thread
From: Marc W Chen @ 2019-07-26 10:12 UTC (permalink / raw)
To: devel; +Cc: Michael D Kinney, Liming Gao, Ray Ni
This is a special GUID extension Hob to describe SMRAM memory regions
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2020
Signed-off-by: Marc W Chen <marc.w.chen@intel.com>
---
MdePkg/Include/Guid/SmramMemoryReserve.h | 45 ++++++++++++++++++++++++++++++++
MdePkg/MdePkg.dec | 3 +++
2 files changed, 48 insertions(+)
create mode 100644 MdePkg/Include/Guid/SmramMemoryReserve.h
diff --git a/MdePkg/Include/Guid/SmramMemoryReserve.h b/MdePkg/Include/Guid/SmramMemoryReserve.h
new file mode 100644
index 0000000000..9bb4925711
--- /dev/null
+++ b/MdePkg/Include/Guid/SmramMemoryReserve.h
@@ -0,0 +1,45 @@
+/** @file
+ This is a special GUID extension Hob to describe SMRAM memory regions.
+
+ This file defines:
+ * the GUID used to identify the GUID HOB for reserving SMRAM regions.
+ * the data structure of SMRAM descriptor to describe SMRAM candidate regions
+ * values of state of SMRAM candidate regions
+ * the GUID specific data structure of HOB for reserving SMRAM regions.
+
+ Copyright (c) 2019, Intel Corporation. All rights reserved.<BR>
+ SPDX-License-Identifier: BSD-2-Clause-Patent
+
+ @par Revision Reference:
+ GUIDs defined in PI SPEC version 1.5.
+
+**/
+
+#ifndef _EFI_SMRAM_MEMORY_RESERVE_H_
+#define _EFI_SMRAM_MEMORY_RESERVE_H_
+
+#define EFI_SMRAM_MEMORY_RESERVE_GUID \
+ { \
+ 0x6dadf1d1, 0xd4cc, 0x4910, {0xbb, 0x6e, 0x82, 0xb1, 0xfd, 0x80, 0xff, 0x3d } \
+ }
+
+/**
+* The GUID extension hob is to describe SMRAM memory regions supported by the platform.
+**/
+typedef struct {
+ ///
+ /// Designates the number of possible regions in the system
+ /// that can be usable for SMRAM.
+ ///
+ UINT32 NumberOfSmmReservedRegions;
+ ///
+ /// Used throughout this protocol to describe the candidate
+ /// regions for SMRAM that are supported by this platform.
+ ///
+ EFI_SMRAM_DESCRIPTOR Descriptor[1];
+} EFI_SMRAM_HOB_DESCRIPTOR_BLOCK;
+
+extern EFI_GUID gEfiSmramMemoryReserveGuid;
+
+#endif
+
diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec
index b382efd578..5cc12886fa 100644
--- a/MdePkg/MdePkg.dec
+++ b/MdePkg/MdePkg.dec
@@ -749,6 +749,9 @@
## Include/Guid/GraphicsInfoHob.h
gEfiGraphicsDeviceInfoHobGuid = { 0xe5cb2ac9, 0xd35d, 0x4430, { 0x93, 0x6e, 0x1d, 0xe3, 0x32, 0x47, 0x8d, 0xe7 }}
+ ## Include/Guid/SmramMemoryReserve.h
+ gEfiSmramMemoryReserveGuid = { 0x6dadf1d1, 0xd4cc, 0x4910, { 0xbb, 0x6e, 0x82, 0xb1, 0xfd, 0x80, 0xff, 0x3d }}
+
#
# GUID defined in PI1.6
#
--
2.16.2.windows.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] MdePkg: Add PI 1.5 SmramMemoryReserve HOB file
2019-07-26 10:12 [PATCH] MdePkg: Add PI 1.5 SmramMemoryReserve HOB file Marc W Chen
@ 2019-07-29 7:49 ` Liming Gao
2019-07-29 7:56 ` Marc W Chen
0 siblings, 1 reply; 3+ messages in thread
From: Liming Gao @ 2019-07-29 7:49 UTC (permalink / raw)
To: Chen, Marc W, devel@edk2.groups.io; +Cc: Kinney, Michael D, Ni, Ray
Marc:
In PI spec 1.6, I see the guid macro is defined as EFI_SMM_SMRAM_MEMORY_GUID.
Why you define it as EFI_SMRAM_MEMORY_RESERVE_GUID?
Thanks
Liming
>-----Original Message-----
>From: Chen, Marc W
>Sent: Friday, July 26, 2019 6:13 PM
>To: devel@edk2.groups.io
>Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming
><liming.gao@intel.com>; Ni, Ray <ray.ni@intel.com>
>Subject: [PATCH] MdePkg: Add PI 1.5 SmramMemoryReserve HOB file
>
>This is a special GUID extension Hob to describe SMRAM memory regions
>
>Cc: Michael D Kinney <michael.d.kinney@intel.com>
>Cc: Liming Gao <liming.gao@intel.com>
>Cc: Ray Ni <ray.ni@intel.com>
>Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2020
>Signed-off-by: Marc W Chen <marc.w.chen@intel.com>
>---
> MdePkg/Include/Guid/SmramMemoryReserve.h | 45
>++++++++++++++++++++++++++++++++
> MdePkg/MdePkg.dec | 3 +++
> 2 files changed, 48 insertions(+)
> create mode 100644 MdePkg/Include/Guid/SmramMemoryReserve.h
>
>diff --git a/MdePkg/Include/Guid/SmramMemoryReserve.h
>b/MdePkg/Include/Guid/SmramMemoryReserve.h
>new file mode 100644
>index 0000000000..9bb4925711
>--- /dev/null
>+++ b/MdePkg/Include/Guid/SmramMemoryReserve.h
>@@ -0,0 +1,45 @@
>+/** @file
>+ This is a special GUID extension Hob to describe SMRAM memory regions.
>+
>+ This file defines:
>+ * the GUID used to identify the GUID HOB for reserving SMRAM regions.
>+ * the data structure of SMRAM descriptor to describe SMRAM candidate
>regions
>+ * values of state of SMRAM candidate regions
>+ * the GUID specific data structure of HOB for reserving SMRAM regions.
>+
>+ Copyright (c) 2019, Intel Corporation. All rights reserved.<BR>
>+ SPDX-License-Identifier: BSD-2-Clause-Patent
>+
>+ @par Revision Reference:
>+ GUIDs defined in PI SPEC version 1.5.
>+
>+**/
>+
>+#ifndef _EFI_SMRAM_MEMORY_RESERVE_H_
>+#define _EFI_SMRAM_MEMORY_RESERVE_H_
>+
>+#define EFI_SMRAM_MEMORY_RESERVE_GUID \
>+ { \
>+ 0x6dadf1d1, 0xd4cc, 0x4910, {0xbb, 0x6e, 0x82, 0xb1, 0xfd, 0x80, 0xff, 0x3d }
>\
>+ }
>+
>+/**
>+* The GUID extension hob is to describe SMRAM memory regions supported
>by the platform.
>+**/
>+typedef struct {
>+ ///
>+ /// Designates the number of possible regions in the system
>+ /// that can be usable for SMRAM.
>+ ///
>+ UINT32 NumberOfSmmReservedRegions;
>+ ///
>+ /// Used throughout this protocol to describe the candidate
>+ /// regions for SMRAM that are supported by this platform.
>+ ///
>+ EFI_SMRAM_DESCRIPTOR Descriptor[1];
>+} EFI_SMRAM_HOB_DESCRIPTOR_BLOCK;
>+
>+extern EFI_GUID gEfiSmramMemoryReserveGuid;
>+
>+#endif
>+
>diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec
>index b382efd578..5cc12886fa 100644
>--- a/MdePkg/MdePkg.dec
>+++ b/MdePkg/MdePkg.dec
>@@ -749,6 +749,9 @@
> ## Include/Guid/GraphicsInfoHob.h
> gEfiGraphicsDeviceInfoHobGuid = { 0xe5cb2ac9, 0xd35d, 0x4430, { 0x93,
>0x6e, 0x1d, 0xe3, 0x32, 0x47, 0x8d, 0xe7 }}
>
>+ ## Include/Guid/SmramMemoryReserve.h
>+ gEfiSmramMemoryReserveGuid = { 0x6dadf1d1, 0xd4cc, 0x4910, { 0xbb,
>0x6e, 0x82, 0xb1, 0xfd, 0x80, 0xff, 0x3d }}
>+
> #
> # GUID defined in PI1.6
> #
>--
>2.16.2.windows.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] MdePkg: Add PI 1.5 SmramMemoryReserve HOB file
2019-07-29 7:49 ` Liming Gao
@ 2019-07-29 7:56 ` Marc W Chen
0 siblings, 0 replies; 3+ messages in thread
From: Marc W Chen @ 2019-07-29 7:56 UTC (permalink / raw)
To: Gao, Liming, devel@edk2.groups.io; +Cc: Kinney, Michael D, Ni, Ray
It's my mistake, let me correct it in next patch.
Thanks,
Marc
> -----Original Message-----
> From: Gao, Liming
> Sent: Monday, July 29, 2019 3:50 PM
> To: Chen, Marc W <marc.w.chen@intel.com>; devel@edk2.groups.io
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Ni, Ray
> <ray.ni@intel.com>
> Subject: RE: [PATCH] MdePkg: Add PI 1.5 SmramMemoryReserve HOB file
>
> Marc:
> In PI spec 1.6, I see the guid macro is defined as
> EFI_SMM_SMRAM_MEMORY_GUID.
> Why you define it as EFI_SMRAM_MEMORY_RESERVE_GUID?
>
> Thanks
> Liming
> >-----Original Message-----
> >From: Chen, Marc W
> >Sent: Friday, July 26, 2019 6:13 PM
> >To: devel@edk2.groups.io
> >Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming
> ><liming.gao@intel.com>; Ni, Ray <ray.ni@intel.com>
> >Subject: [PATCH] MdePkg: Add PI 1.5 SmramMemoryReserve HOB file
> >
> >This is a special GUID extension Hob to describe SMRAM memory regions
> >
> >Cc: Michael D Kinney <michael.d.kinney@intel.com>
> >Cc: Liming Gao <liming.gao@intel.com>
> >Cc: Ray Ni <ray.ni@intel.com>
> >Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2020
> >Signed-off-by: Marc W Chen <marc.w.chen@intel.com>
> >---
> > MdePkg/Include/Guid/SmramMemoryReserve.h | 45
> >++++++++++++++++++++++++++++++++
> > MdePkg/MdePkg.dec | 3 +++
> > 2 files changed, 48 insertions(+)
> > create mode 100644 MdePkg/Include/Guid/SmramMemoryReserve.h
> >
> >diff --git a/MdePkg/Include/Guid/SmramMemoryReserve.h
> >b/MdePkg/Include/Guid/SmramMemoryReserve.h
> >new file mode 100644
> >index 0000000000..9bb4925711
> >--- /dev/null
> >+++ b/MdePkg/Include/Guid/SmramMemoryReserve.h
> >@@ -0,0 +1,45 @@
> >+/** @file
> >+ This is a special GUID extension Hob to describe SMRAM memory regions.
> >+
> >+ This file defines:
> >+ * the GUID used to identify the GUID HOB for reserving SMRAM regions.
> >+ * the data structure of SMRAM descriptor to describe SMRAM candidate
> >regions
> >+ * values of state of SMRAM candidate regions
> >+ * the GUID specific data structure of HOB for reserving SMRAM regions.
> >+
> >+ Copyright (c) 2019, Intel Corporation. All rights reserved.<BR>
> >+ SPDX-License-Identifier: BSD-2-Clause-Patent
> >+
> >+ @par Revision Reference:
> >+ GUIDs defined in PI SPEC version 1.5.
> >+
> >+**/
> >+
> >+#ifndef _EFI_SMRAM_MEMORY_RESERVE_H_
> >+#define _EFI_SMRAM_MEMORY_RESERVE_H_
> >+
> >+#define EFI_SMRAM_MEMORY_RESERVE_GUID \
> >+ { \
> >+ 0x6dadf1d1, 0xd4cc, 0x4910, {0xbb, 0x6e, 0x82, 0xb1, 0xfd, 0x80, 0xff,
> 0x3d }
> >\
> >+ }
> >+
> >+/**
> >+* The GUID extension hob is to describe SMRAM memory regions
> supported
> >by the platform.
> >+**/
> >+typedef struct {
> >+ ///
> >+ /// Designates the number of possible regions in the system
> >+ /// that can be usable for SMRAM.
> >+ ///
> >+ UINT32 NumberOfSmmReservedRegions;
> >+ ///
> >+ /// Used throughout this protocol to describe the candidate
> >+ /// regions for SMRAM that are supported by this platform.
> >+ ///
> >+ EFI_SMRAM_DESCRIPTOR Descriptor[1];
> >+} EFI_SMRAM_HOB_DESCRIPTOR_BLOCK;
> >+
> >+extern EFI_GUID gEfiSmramMemoryReserveGuid;
> >+
> >+#endif
> >+
> >diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec
> >index b382efd578..5cc12886fa 100644
> >--- a/MdePkg/MdePkg.dec
> >+++ b/MdePkg/MdePkg.dec
> >@@ -749,6 +749,9 @@
> > ## Include/Guid/GraphicsInfoHob.h
> > gEfiGraphicsDeviceInfoHobGuid = { 0xe5cb2ac9, 0xd35d, 0x4430, { 0x93,
> >0x6e, 0x1d, 0xe3, 0x32, 0x47, 0x8d, 0xe7 }}
> >
> >+ ## Include/Guid/SmramMemoryReserve.h
> >+ gEfiSmramMemoryReserveGuid = { 0x6dadf1d1, 0xd4cc, 0x4910, { 0xbb,
> >0x6e, 0x82, 0xb1, 0xfd, 0x80, 0xff, 0x3d }}
> >+
> > #
> > # GUID defined in PI1.6
> > #
> >--
> >2.16.2.windows.1
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-07-29 7:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-07-26 10:12 [PATCH] MdePkg: Add PI 1.5 SmramMemoryReserve HOB file Marc W Chen
2019-07-29 7:49 ` Liming Gao
2019-07-29 7:56 ` Marc W Chen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox