From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.126, mailfrom: marc.w.chen@intel.com) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by groups.io with SMTP; Mon, 29 Jul 2019 00:57:32 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Jul 2019 00:56:13 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,321,1559545200"; d="scan'208";a="322776071" Received: from pgsmsx103.gar.corp.intel.com ([10.221.44.82]) by orsmga004.jf.intel.com with ESMTP; 29 Jul 2019 00:56:12 -0700 Received: from pgsmsx108.gar.corp.intel.com ([169.254.8.190]) by PGSMSX103.gar.corp.intel.com ([169.254.2.247]) with mapi id 14.03.0439.000; Mon, 29 Jul 2019 15:56:05 +0800 From: "Marc W Chen" To: "Gao, Liming" , "devel@edk2.groups.io" CC: "Kinney, Michael D" , "Ni, Ray" Subject: Re: [PATCH] MdePkg: Add PI 1.5 SmramMemoryReserve HOB file Thread-Topic: [PATCH] MdePkg: Add PI 1.5 SmramMemoryReserve HOB file Thread-Index: AQHVQ5q/GL7KY5kyBUa6rCuJj9sJ1KbhPOkAgAAB5uA= Date: Mon, 29 Jul 2019 07:56:05 +0000 Message-ID: References: <20190726101246.20468-1-marc.w.chen@intel.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E4C44B8@SHSMSX104.ccr.corp.intel.com> In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E4C44B8@SHSMSX104.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOWE4MTE1ZTktZmFiZS00NDQ4LWI5YjUtZTMxMmZhODNjMzY3IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiSjVSbXpZV0Q4bFprMXRVZ1JxXC9SYmRTSndqMHpRNE5ldXE3eFA3YnNoN29IelpzWkNvZ2V6dnNMY2NBWTQwRkYifQ== x-originating-ip: [172.30.20.206] MIME-Version: 1.0 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable It's my mistake, let me correct it in next patch. Thanks, Marc > -----Original Message----- > From: Gao, Liming > Sent: Monday, July 29, 2019 3:50 PM > To: Chen, Marc W ; devel@edk2.groups.io > Cc: Kinney, Michael D ; Ni, Ray > > Subject: RE: [PATCH] MdePkg: Add PI 1.5 SmramMemoryReserve HOB file >=20 > Marc: > In PI spec 1.6, I see the guid macro is defined as > EFI_SMM_SMRAM_MEMORY_GUID. > Why you define it as EFI_SMRAM_MEMORY_RESERVE_GUID? >=20 > Thanks > Liming > >-----Original Message----- > >From: Chen, Marc W > >Sent: Friday, July 26, 2019 6:13 PM > >To: devel@edk2.groups.io > >Cc: Kinney, Michael D ; Gao, Liming > >; Ni, Ray > >Subject: [PATCH] MdePkg: Add PI 1.5 SmramMemoryReserve HOB file > > > >This is a special GUID extension Hob to describe SMRAM memory regions > > > >Cc: Michael D Kinney > >Cc: Liming Gao > >Cc: Ray Ni > >Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2020 > >Signed-off-by: Marc W Chen > >--- > > MdePkg/Include/Guid/SmramMemoryReserve.h | 45 > >++++++++++++++++++++++++++++++++ > > MdePkg/MdePkg.dec | 3 +++ > > 2 files changed, 48 insertions(+) > > create mode 100644 MdePkg/Include/Guid/SmramMemoryReserve.h > > > >diff --git a/MdePkg/Include/Guid/SmramMemoryReserve.h > >b/MdePkg/Include/Guid/SmramMemoryReserve.h > >new file mode 100644 > >index 0000000000..9bb4925711 > >--- /dev/null > >+++ b/MdePkg/Include/Guid/SmramMemoryReserve.h > >@@ -0,0 +1,45 @@ > >+/** @file > >+ This is a special GUID extension Hob to describe SMRAM memory regions= . > >+ > >+ This file defines: > >+ * the GUID used to identify the GUID HOB for reserving SMRAM regions. > >+ * the data structure of SMRAM descriptor to describe SMRAM candidate > >regions > >+ * values of state of SMRAM candidate regions > >+ * the GUID specific data structure of HOB for reserving SMRAM regions= . > >+ > >+ Copyright (c) 2019, Intel Corporation. All rights reserved.
> >+ SPDX-License-Identifier: BSD-2-Clause-Patent > >+ > >+ @par Revision Reference: > >+ GUIDs defined in PI SPEC version 1.5. > >+ > >+**/ > >+ > >+#ifndef _EFI_SMRAM_MEMORY_RESERVE_H_ > >+#define _EFI_SMRAM_MEMORY_RESERVE_H_ > >+ > >+#define EFI_SMRAM_MEMORY_RESERVE_GUID \ > >+ { \ > >+ 0x6dadf1d1, 0xd4cc, 0x4910, {0xbb, 0x6e, 0x82, 0xb1, 0xfd, 0x80, 0x= ff, > 0x3d } > >\ > >+ } > >+ > >+/** > >+* The GUID extension hob is to describe SMRAM memory regions > supported > >by the platform. > >+**/ > >+typedef struct { > >+ /// > >+ /// Designates the number of possible regions in the system > >+ /// that can be usable for SMRAM. > >+ /// > >+ UINT32 NumberOfSmmReservedRegions; > >+ /// > >+ /// Used throughout this protocol to describe the candidate > >+ /// regions for SMRAM that are supported by this platform. > >+ /// > >+ EFI_SMRAM_DESCRIPTOR Descriptor[1]; > >+} EFI_SMRAM_HOB_DESCRIPTOR_BLOCK; > >+ > >+extern EFI_GUID gEfiSmramMemoryReserveGuid; > >+ > >+#endif > >+ > >diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec > >index b382efd578..5cc12886fa 100644 > >--- a/MdePkg/MdePkg.dec > >+++ b/MdePkg/MdePkg.dec > >@@ -749,6 +749,9 @@ > > ## Include/Guid/GraphicsInfoHob.h > > gEfiGraphicsDeviceInfoHobGuid =3D { 0xe5cb2ac9, 0xd35d, 0x4430, {= 0x93, > >0x6e, 0x1d, 0xe3, 0x32, 0x47, 0x8d, 0xe7 }} > > > >+ ## Include/Guid/SmramMemoryReserve.h > >+ gEfiSmramMemoryReserveGuid =3D { 0x6dadf1d1, 0xd4cc, 0x4910, { 0x= bb, > >0x6e, 0x82, 0xb1, 0xfd, 0x80, 0xff, 0x3d }} > >+ > > # > > # GUID defined in PI1.6 > > # > >-- > >2.16.2.windows.1