From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=40.107.2.84; helo=eur02-ve1-obe.outbound.protection.outlook.com; envelope-from=pankaj.bansal@nxp.com; receiver=edk2-devel@lists.01.org Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20084.outbound.protection.outlook.com [40.107.2.84]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 829D02034AB3F for ; Tue, 31 Oct 2017 22:53:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=Ghs1nEeNc9jUz5s2vzRgOJErtqiSLaQwJ9HDYM0741A=; b=yFswIDEO6O6NpNfBmIpm5fjO6OfH+FFzeaCo/vojOCYzTiy3D5A2Q2FTC158rBgR8kP08G+wvRg8f7PPE/cRlczckX8iHCX/26MjJGJh3BpLUqLypQ0ELXhc3pS5IyevWVfrcrOqh8HnFP1qvBz5fwXAGa/2uJKiSmem6uzOaZc= Received: from AM0PR0402MB3940.eurprd04.prod.outlook.com (52.133.40.140) by AM0PR0402MB3937.eurprd04.prod.outlook.com (52.133.39.161) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.178.6; Wed, 1 Nov 2017 05:57:06 +0000 Received: from AM0PR0402MB3940.eurprd04.prod.outlook.com ([fe80::3dca:b485:74ca:f5c8]) by AM0PR0402MB3940.eurprd04.prod.outlook.com ([fe80::3dca:b485:74ca:f5c8%13]) with mapi id 15.20.0178.014; Wed, 1 Nov 2017 05:57:06 +0000 From: Pankaj Bansal To: Marcin Wojtas , Leif Lindholm CC: "Tian, Feng" , Hua Jing , "Ard Biesheuvel" , edk2-devel-01 , "Gao, Liming" , "nadavh@marvell.com" , Kostya Porotchkin , Neta Zur Hershkovits , "Kinney, Michael D" Thread-Topic: [edk2] [PATCH 1/1] EmbeddedPkg: Implement NorFlashLib Thread-Index: AQHTUb37Iu3g5ei70k+sTnMpusA04qL9mIoAgAAFBoCAAWlLkA== Date: Wed, 1 Nov 2017 05:57:05 +0000 Message-ID: References: <1509395425-15145-1-git-send-email-mw@semihalf.com> <20171031075818.l7rdpy6d6nue7l4r@bivouac.eciton.net> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=pankaj.bansal@nxp.com; x-originating-ip: [192.88.169.1] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; AM0PR0402MB3937; 6:lujbbHpois2Dq1bNPDBYgS1buqJNinBl7CCfS2KlgngsqLN9UwO1A4OQVDryXkXKYmnt0gEED/xKxu+xpm9jnEbS3rEH0YYq3gwf/vnV9dI++b5dssZoUM3FBZGg5q3QOfHHY42yG48HFmNVKTgvUrWUQrBYLy+lnpysy7x3Vopz1E2eqVf401WZxyJ6eXbKW02bXVj2QUAYxfUQEkNlb+aqxdu9BOLDVTqe9InswnCENQonP3Crx+OZJYtZQbzgNtWnpdYz3CsrBcAZpCmW3ClhEvqj4G6MgqJsXTZKBtb7iH4uD5DcqEzuFOz3CXAVSzq2kd5BL54AOm5zVcGY0KvBYb0J7sDRiuFm/QI++p8=; 5:b23WwCUOv6n4BNX+/2+FChuZzWumU8anykqCeH8ohNc6ge2Hj4ngYAu6mnwkOThBiv5rZBe/nXXkWdE0WnrOA/2pOxls+07LYOuTnTjPfN2kGNKx2ZNYQ6bA1LVEVgh5ypLzA3Kn9v/RX870RMT4LuiG6KZDTSIuR8QBMpgi0Fc=; 24:Xp0SPnAC9qsvHH1y6SRgSaJVDUuaGChJ2Fh145bQJMTB2zPvI8+XULbY/972SysoQuxJFfA7AKSIXnHTXFl6LrBSYhcIq1k8S7XsWH1je3A=; 7:jwT/lkYpLYfj5gMq7ZBKP+rEtV6juSBJ6ifyURIEkqyxV/tnsj9Yzh/0+8KQEjfcOKSzHdaMdMQ9NeBkNmNm6WYOinpU2huc8SgLFnNzeU+ein5ZKPAyOlMxRWox7H+/Eofwe0+drQ0TQxSS3Th09k9Svp/vHJorjdlYQ5QA/5j0aRUtoFxxre/jBDMdQjR5dCf6LhNLwDS1BpLFZbXBv72g3SOvCWjbGsVu4rSMES1KhAbap/9f0AucWcqJNKXM x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-correlation-id: d1b05c38-1e22-4880-5421-08d520ed61a1 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(4534020)(4602075)(48565401081)(2017052603199); SRVR:AM0PR0402MB3937; x-ms-traffictypediagnostic: AM0PR0402MB3937: x-exchange-antispam-report-test: UriScan:(189930954265078)(162533806227266)(45079756050767)(228905959029699); x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(100000703101)(100105400095)(3002001)(3231020)(93006095)(93001095)(10201501046)(6055026)(6041248)(20161123555025)(20161123562025)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123560025)(20161123564025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:AM0PR0402MB3937; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:AM0PR0402MB3937; x-forefront-prvs: 0478C23FE0 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6009001)(376002)(346002)(39860400002)(377424004)(199003)(51914003)(24454002)(13464003)(189002)(6116002)(5660300001)(102836003)(3846002)(7416002)(7696004)(3280700002)(3660700001)(16799955002)(97736004)(66066001)(2906002)(74316002)(229853002)(305945005)(2900100001)(7736002)(6436002)(68736007)(2950100002)(6506006)(53546010)(4326008)(53936002)(76176999)(50986999)(99286003)(53946003)(6306002)(189998001)(6246003)(55016002)(966005)(14454004)(86362001)(575784001)(478600001)(81166006)(33656002)(9686003)(8936002)(54356999)(101416001)(25786009)(5250100002)(106356001)(4001150100001)(105586002)(81156014)(45080400002)(54906003)(316002)(110136005)(8676002); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR0402MB3937; H:AM0PR0402MB3940.eurprd04.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: d1b05c38-1e22-4880-5421-08d520ed61a1 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Nov 2017 05:57:05.9000 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0402MB3937 Subject: Re: [PATCH 1/1] EmbeddedPkg: Implement NorFlashLib X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Nov 2017 05:53:18 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Marcin, The SPI flash Jedec id is not standardized across flashes. The JEDEDC group only assigns first byte (Manufacturer ID) to different ven= dors. Rest of the bytes are up to the Manufacturer to decide. Therefore this info should be left to the SPI flash driver to parse. It should not be stored in tabular form rather calculated based on JEDEDC d= ata read. Thanks & Regards, Pankaj Bansal -----Original Message----- From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Marc= in Wojtas Sent: Tuesday, October 31, 2017 1:46 PM To: Leif Lindholm Cc: Tian, Feng ; Hua Jing ; Ard B= iesheuvel ; edk2-devel-01 ; Gao, Liming ; nadavh@marvell.com; Kostya Porotch= kin ; Neta Zur Hershkovits ; Kinney, = Michael D Subject: Re: [edk2] [PATCH 1/1] EmbeddedPkg: Implement NorFlashLib Hi Leif, 2017-10-31 8:58 GMT+01:00 Leif Lindholm : > On Mon, Oct 30, 2017 at 09:30:25PM +0100, Marcin Wojtas wrote: >> The SPI NOR flash drivers which base on ArmPlatformPkg's NorFlashDxe=20 >> usually make use of static declarations of the flash instances with=20 >> their type and parameters. As a result it implies hardcoding the=20 >> exact way flash handling, not to mention the code does not look very=20 >> nice. Much better solution would be obtaining the flash ID and hence=20 >> its description in runtime. >> >> Because JEDEC compliant SPI NOR devices allow to obtain their ID with=20 >> READ_ID command (0x9f), implement a NorFlashLib that gives access to=20 >> the NOR flash data, such as name, page size, sector >> (block) size and others, of more than 50 different models. >> The new library user should pass an output array issuing READ_ID=20 >> command to the GetNorFlashInfo () routine - if the match is found, an=20 >> allocated (optionally for RT) pool with the flash description will be=20 >> returned. >> >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Marcin Wojtas >> --- >> EmbeddedPkg/EmbeddedPkg.dec | 1 + >> EmbeddedPkg/Include/Library/NorFlashInfoLib.h | 84 ++++++++ >> EmbeddedPkg/Library/NorFlashInfoLib/NorFlashInfoLib.c | 225 +++++++++= +++++++++++ >> EmbeddedPkg/Library/NorFlashInfoLib/NorFlashInfoLib.inf | 34 +++ >> 4 files changed, 344 insertions(+) >> >> diff --git a/EmbeddedPkg/EmbeddedPkg.dec=20 >> b/EmbeddedPkg/EmbeddedPkg.dec index 52482af..aa551ab 100644 >> --- a/EmbeddedPkg/EmbeddedPkg.dec >> +++ b/EmbeddedPkg/EmbeddedPkg.dec >> @@ -45,6 +45,7 @@ >> EblNetworkLib|Include/Library/EblNetworkLib.h >> GdbSerialLib|Include/Library/GdbSerialLib.h >> DebugAgentTimerLib|Include/Library/DebugAgentTimerLib.h >> + NorFlashInfoLib|Include/Library/NorFlashInfoLib.h >> >> DtPlatformDtbLoaderLib|Include/Library/DtPlatformDtbLoaderLib.h >> >> diff --git a/EmbeddedPkg/Include/Library/NorFlashInfoLib.h=20 >> b/EmbeddedPkg/Include/Library/NorFlashInfoLib.h >> new file mode 100644 >> index 0000000..ae0e45f >> --- /dev/null >> +++ b/EmbeddedPkg/Include/Library/NorFlashInfoLib.h >> @@ -0,0 +1,84 @@ >> +/** @file >> +* >> +* Copyright (c) 2017 Marvell International Ltd. >> +* >> +* This program and the accompanying materials >> +* are licensed and made available under the terms and conditions of=20 >> +the BSD License >> +* which accompanies this distribution. The full text of the=20 >> +license may be found at >> +* =20 >> +https://emea01.safelinks.protection.outlook.com/?url=3Dhttp%3A%2F%2Fop >> +ensource.org%2Flicenses%2Fbsd-license.php&data=3D02%7C01%7Cpankaj.bans >> +al%40nxp.com%7C753424b872b346c9c76f08d52037acfc%7C686ea1d3bc2b4c6fa9 >> +2cd99c5c301635%7C0%7C0%7C636450345874702676&sdata=3DcxqjBkGwxPBYUu%2Fh >> +Rwn8xdMheRjl%2BXBokEA74oIyaTw%3D&reserved=3D0 >> +* >> +* THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS"=20 >> +BASIS, >> +* WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR= IMPLIED. >> +* >> +**/ >> + >> +#ifndef __NOR_FLASH_ID_LIB_H__ >> +#define __NOR_FLASH_ID_LIB_H__ >> + >> +#include >> + >> +#define NOR_FLASH_MAX_ID_LEN 6 >> + >> +typedef struct { >> + /* Device name */ >> + UINT16 *Name; >> + >> + /* >> + * JEDEC ID >> + */ >> + UINT8 Id[NOR_FLASH_MAX_ID_LEN]; >> + UINT8 IdLen; >> + >> + UINT16 PageSize; >> + >> + /* >> + * Below parameters can be referred as BlockSize >> + * and BlockCount, when treating the NorFlash as >> + * block device. >> + */ >> + UINT32 SectorSize; >> + UINT32 SectorCount; >> + >> + UINT16 Flags; >> +#define NF_ERASE_4K 1 << 0 /* Use 4096B erase blocks and CMD_ERAS= E_4K */ >> +#define NF_WRITE_FSR 1 << 1 /* Use flag status register for write = */ >> +#define NF_4B_ADDR 1 << 2 /* Use 4B addressing */ > > I think these should keep a NOR_FLASH_ prefix, like the rest of the file. > >> +} NOR_FLASH_INFO; >> + >> +/** >> + Return a pool allocated copy of the NOR flash . >> + >> + @param[in] Id Pointer to an array with JEDEC ID= obtained >> + from the NOR flash with READ_ID c= ommand >> + (0x9f) >> + @param[in out] FlashInfo Pointer to NOR flash information = structure >> + @param[in] AllocateForRuntime A flag specifying a type of a cop= y pool >> + allocation (TRUE for runtime, FAL= SE for >> + normal) >> + >> + @retval EFI_SUCCESS Operation completed successfully >> + @retval EFI_NOT_FOUND No matching entry in NOR ID table= found >> + @retval EFI_OUT_OF_RESOURCES No pool memory available >> + >> +**/ >> +EFI_STATUS >> +EFIAPI >> +GetNorFlashInfo ( > > NorFlashGetInfo? > >> + IN UINT8 *Id, >> + IN OUT NOR_FLASH_INFO **FlashInfo, >> + IN BOOLEAN AllocateForRuntime >> + ); >> + >> +/** >> + Print NOR flash information basing on data stored in >> + the NOR_FLASH_INFO structure. >> + >> + @param[in] FlashInfo Pointer to NOR flash information = structure >> + >> +**/ >> +VOID >> +EFIAPI >> +PrintNorFlashInfo ( > > NorFlashPrintInfo? > >> + IN NOR_FLASH_INFO *Info >> + ); >> +#endif >> diff --git a/EmbeddedPkg/Library/NorFlashInfoLib/NorFlashInfoLib.c=20 >> b/EmbeddedPkg/Library/NorFlashInfoLib/NorFlashInfoLib.c >> new file mode 100644 >> index 0000000..2185163 >> --- /dev/null >> +++ b/EmbeddedPkg/Library/NorFlashInfoLib/NorFlashInfoLib.c >> @@ -0,0 +1,225 @@ >> +/** @file >> +* >> +* Copyright (c) 2017 Marvell International Ltd. >> +* >> +* This program and the accompanying materials >> +* are licensed and made available under the terms and conditions of=20 >> +the BSD License >> +* which accompanies this distribution. The full text of the=20 >> +license may be found at >> +* =20 >> +https://emea01.safelinks.protection.outlook.com/?url=3Dhttp%3A%2F%2Fop >> +ensource.org%2Flicenses%2Fbsd-license.php&data=3D02%7C01%7Cpankaj.bans >> +al%40nxp.com%7C753424b872b346c9c76f08d52037acfc%7C686ea1d3bc2b4c6fa9 >> +2cd99c5c301635%7C0%7C0%7C636450345874702676&sdata=3DcxqjBkGwxPBYUu%2Fh >> +Rwn8xdMheRjl%2BXBokEA74oIyaTw%3D&reserved=3D0 >> +* >> +* THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS"=20 >> +BASIS, >> +* WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR= IMPLIED. >> +* >> +**/ >> + >> +#include >> + >> +#include >> +#include >> +#include >> +#include >> +#include #include=20 >> + >> + >> +static CONST NOR_FLASH_INFO NorFlashIds[] =3D { >> + /* ATMEL */ >> + {L"at45db011d", {0x1f, 0x22, 0x00}, 3, 256, 64 * 1024, 4, NF_= ERASE_4K}, >> + {L"at45db021d", {0x1f, 0x23, 0x00}, 3, 256, 64 * 1024, 8, NF_= ERASE_4K}, >> + {L"at45db041d", {0x1f, 0x24, 0x00}, 3, 256, 64 * 1024, 8, NF_= ERASE_4K}, >> + {L"at45db081d", {0x1f, 0x25, 0x00}, 3, 256, 64 * 1024, 16, NF_= ERASE_4K}, >> + {L"at45db161d", {0x1f, 0x26, 0x00}, 3, 256, 64 * 1024, 32, NF_= ERASE_4K}, >> + {L"at45db321d", {0x1f, 0x27, 0x00}, 3, 256, 64 * 1024, 64, NF_= ERASE_4K}, >> + {L"at45db641d", {0x1f, 0x28, 0x00}, 3, 256, 64 * 1024, 128, NF_= ERASE_4K}, >> + {L"at25df321a", {0x1f, 0x47, 0x01}, 3, 256, 64 * 1024, 64, NF_= ERASE_4K}, >> + {L"at25df321", {0x1f, 0x47, 0x00}, 3, 256, 64 * 1024, 64, NF_= ERASE_4K}, >> + {L"at26df081a", {0x1f, 0x45, 0x01}, 3, 256, 64 * 1024, 16, NF_= ERASE_4K}, >> + /* EON */ >> + {L"en25q32b", {0x1c, 0x30, 0x16}, 3, 256, 64 * 1024, 64, 0}, >> + {L"en25q64", {0x1c, 0x30, 0x17}, 3, 256, 64 * 1024, 128, NF_= ERASE_4K}, >> + {L"en25q128b", {0x1c, 0x30, 0x18}, 3, 256, 64 * 1024, 256, 0}, >> + {L"en25s64", {0x1c, 0x38, 0x17}, 3, 256, 64 * 1024, 128, 0}, >> + /* GIGADEVICE */ >> + {L"gd25q64b", {0xc8, 0x40, 0x17}, 3, 256, 64 * 1024, 128, NF_= ERASE_4K}, >> + {L"gd25lq32", {0xc8, 0x60, 0x16}, 3, 256, 64 * 1024, 64, NF_= ERASE_4K}, >> + /* ISSI */ >> + {L"is25lp032", {0x9d, 0x60, 0x16}, 3, 256, 64 * 1024, 64, 0}, >> + {L"is25lp064", {0x9d, 0x60, 0x17}, 3, 256, 64 * 1024, 128, 0}, >> + {L"is25lp128", {0x9d, 0x60, 0x18}, 3, 256, 64 * 1024, 256, 0}, >> + /* MACRONIX */ >> + {L"mx25l2006e", {0xc2, 0x20, 0x12}, 3, 256, 64 * 1024, 4, 0}, >> + {L"mx25l4005", {0xc2, 0x20, 0x13}, 3, 256, 64 * 1024, 8, 0}, >> + {L"mx25l8005", {0xc2, 0x20, 0x14}, 3, 256, 64 * 1024, 16, 0}, >> + {L"mx25l1605d", {0xc2, 0x20, 0x15}, 3, 256, 64 * 1024, 32, 0}, >> + {L"mx25l3205d", {0xc2, 0x20, 0x16}, 3, 256, 64 * 1024, 64, 0}, >> + {L"mx25l6405d", {0xc2, 0x20, 0x17}, 3, 256, 64 * 1024, 128, 0}, >> + {L"mx25l12805", {0xc2, 0x20, 0x18}, 3, 256, 64 * 1024, 256, 0}, >> + {L"mx25l25635f", {0xc2, 0x20, 0x19}, 3, 256, 64 * 1024, 512, 0}, >> + {L"mx25l51235f", {0xc2, 0x20, 0x1a}, 3, 256, 64 * 1024, 1024, 0}, >> + {L"mx25l12855e", {0xc2, 0x26, 0x18}, 3, 256, 64 * 1024, 256, 0}, >> + {L"mx66u51235f", {0xc2, 0x25, 0x3a}, 3, 256, 64 * 1024, 1024, 0}, >> + {L"mx66l1g45g", {0xc2, 0x20, 0x1b}, 3, 256, 64 * 1024, 2048, 0}, >> + /* SPANSION */ >> + {L"s25fl008a", {0x01, 0x02, 0x13}, 3, 256, 64 * 1024, 16, 0}, >> + {L"s25fl016a", {0x01, 0x02, 0x14}, 3, 256, 64 * 1024, 32, 0}, >> + {L"s25fl032a", {0x01, 0x02, 0x15}, 3, 256, 64 * 1024, 64, 0}, >> + {L"s25fl064a", {0x01, 0x02, 0x16}, 3, 256, 64 * 1024, 128, 0}, >> + {L"s25fl116k", {0x01, 0x40, 0x15}, 3, 256, 64 * 1024, 128, 0}, >> + {L"s25fl164k", {0x01, 0x40, 0x17, 0x01, 0x40}, 5, 256, 64 * 102= 4, 128, 0}, >> + {L"s25fl128p_256k", {0x01, 0x20, 0x18, 0x03, 0x00}, 5, 256, 256 * 102= 4, 64, 0}, >> + {L"s25fl128p_64k", {0x01, 0x20, 0x18, 0x03, 0x01}, 5, 256, 64 * 102= 4, 256, 0}, >> + {L"s25fl032p", {0x01, 0x02, 0x15, 0x4d, 0x00}, 5, 256, 64 * 102= 4, 64, 0}, >> + {L"s25fl064p", {0x01, 0x02, 0x16, 0x4d, 0x00}, 5, 256, 64 * 102= 4, 128, 0}, >> + {L"s25fl128s_256k", {0x01, 0x20, 0x18, 0x4d, 0x00}, 5, 256, 256 * 102= 4, 64, 0}, >> + {L"s25fl128s_64k", {0x01, 0x20, 0x18, 0x4d, 0x01}, 5, 256, 64 * 102= 4, 256, 0}, >> + {L"s25fl256s_256k", {0x01, 0x02, 0x19, 0x4d, 0x00}, 5, 256, 256 * 102= 4, 128, 0}, >> + {L"s25fl256s_64k", {0x01, 0x02, 0x19, 0x4d, 0x01}, 5, 256, 64 * 102= 4, 512, 0}, >> + {L"s25fl512s_256k", {0x01, 0x02, 0x20, 0x4d, 0x00}, 5, 256, 256 * 102= 4, 256, 0}, >> + {L"s25fl512s_64k", {0x01, 0x02, 0x20, 0x4d, 0x01}, 5, 256, 64 * 102= 4, 1024, 0}, >> + {L"s25fl512s_512k", {0x01, 0x02, 0x20, 0x4f, 0x00}, 5, 256, 256 * 102= 4, 256, 0}, >> + /* STMICRO */ >> + {L"m25p10", {0x20, 0x20, 0x11}, 3, 256, 32 * 1024, 4, 0}, >> + {L"m25p20", {0x20, 0x20, 0x12}, 3, 256, 64 * 1024, 4, 0}, >> + {L"m25p40", {0x20, 0x20, 0x13}, 3, 256, 64 * 1024, 8, 0}, >> + {L"m25p80", {0x20, 0x20, 0x14}, 3, 256, 64 * 1024, 16, 0}, >> + {L"m25p16", {0x20, 0x20, 0x15}, 3, 256, 64 * 1024, 32, 0}, >> + {L"m25pE16", {0x20, 0x80, 0x15, 0x10, 0x00}, 5, 256, 64 * 1024= , 32, 0}, >> + {L"m25pX16", {0x20, 0x71, 0x15, 0x10, 0x00}, 5, 256, 64 * 1024= , 32, 0}, >> + {L"m25p32", {0x20, 0x20, 0x16}, 3, 256, 64 * 1024, 64, 0}= , >> + {L"m25p64", {0x20, 0x20, 0x17}, 3, 256, 64 * 1024, 128, 0}= , >> + {L"m25p128", {0x20, 0x20, 0x18}, 3, 256, 256 * 1024, 64, 0}= , >> + {L"m25pX64", {0x20, 0x71, 0x17}, 3, 256, 64 * 1024, 128, NF= _ERASE_4K}, >> + {L"n25q016a", {0x20, 0xbb, 0x15}, 3, 256, 64 * 1024, 32, NF= _ERASE_4K}, >> + {L"n25q32", {0x20, 0xba, 0x16}, 3, 256, 64 * 1024, 64, NF= _ERASE_4K}, >> + {L"n25q32a", {0x20, 0xbb, 0x16}, 3, 256, 64 * 1024, 64, NF= _ERASE_4K}, >> + {L"n25q64", {0x20, 0xba, 0x17}, 3, 256, 64 * 1024, 128, NF= _ERASE_4K}, >> + {L"n25q64a", {0x20, 0xbb, 0x17}, 3, 256, 64 * 1024, 128, NF= _ERASE_4K}, >> + {L"n25q128", {0x20, 0xba, 0x18}, 3, 256, 64 * 1024, 256, 0}= , >> + {L"n25q128a", {0x20, 0xbb, 0x18}, 3, 256, 64 * 1024, 256, 0}= , >> + {L"n25q256", {0x20, 0xba, 0x19}, 3, 256, 64 * 1024, 512, NF= _ERASE_4K}, >> + {L"n25q256a", {0x20, 0xbb, 0x19}, 3, 256, 64 * 1024, 512, NF= _ERASE_4K}, >> + {L"n25q512", {0x20, 0xba, 0x20}, 3, 256, 64 * 1024, 1024, NF= _WRITE_FSR | NF_ERASE_4K}, >> + {L"n25q512a", {0x20, 0xbb, 0x20}, 3, 256, 64 * 1024, 1024, NF= _WRITE_FSR | NF_ERASE_4K}, >> + {L"n25q1024", {0x20, 0xba, 0x21}, 3, 256, 64 * 1024, 2048, NF= _WRITE_FSR | NF_ERASE_4K}, >> + {L"n25q1024a", {0x20, 0xbb, 0x21}, 3, 256, 64 * 1024, 2048, NF= _WRITE_FSR | NF_ERASE_4K}, >> + {L"mt25qu02g", {0x20, 0xbb, 0x22}, 3, 256, 64 * 1024, 4096, NF= _WRITE_FSR | NF_ERASE_4K}, >> + {L"mt25ql02g", {0x20, 0xba, 0x22}, 3, 256, 64 * 1024, 4096, NF= _WRITE_FSR | NF_ERASE_4K}, >> + /* SST */ >> + {L"sst25vf040b", {0xbf, 0x25, 0x8d}, 3, 256, 64 * 1024, 8, NF= _ERASE_4K}, >> + {L"sst25vf080b", {0xbf, 0x25, 0x8e}, 3, 256, 64 * 1024, 16, NF= _ERASE_4K}, >> + {L"sst25vf016b", {0xbf, 0x25, 0x41}, 3, 256, 64 * 1024, 32, NF= _ERASE_4K}, >> + {L"sst25vf032b", {0xbf, 0x25, 0x4a}, 3, 256, 64 * 1024, 64, NF= _ERASE_4K}, >> + {L"sst25vf064c", {0xbf, 0x25, 0x4b}, 3, 256, 64 * 1024, 128, NF= _ERASE_4K}, >> + {L"sst25wf512", {0xbf, 0x25, 0x01}, 3, 256, 64 * 1024, 1, NF= _ERASE_4K}, >> + {L"sst25wf010", {0xbf, 0x25, 0x02}, 3, 256, 64 * 1024, 2, NF= _ERASE_4K}, >> + {L"sst25wf020", {0xbf, 0x25, 0x03}, 3, 256, 64 * 1024, 4, NF= _ERASE_4K}, >> + {L"sst25wf040", {0xbf, 0x25, 0x04}, 3, 256, 64 * 1024, 8, NF= _ERASE_4K}, >> + {L"sst25wf040b", {0x62, 0x16, 0x13}, 3, 256, 64 * 1024, 8, NF= _ERASE_4K}, >> + {L"sst25wf080", {0xbf, 0x25, 0x05}, 3, 256, 64 * 1024, 16, NF= _ERASE_4K}, >> + /* WINBOND */ >> + {L"w25p80", {0xef, 0x20, 0x14}, 3, 256, 64 * 1024, 16, 0}= , >> + {L"w25p16", {0xef, 0x20, 0x15}, 3, 256, 64 * 1024, 32, 0}= , >> + {L"w25p32", {0xef, 0x20, 0x16}, 3, 256, 64 * 1024, 64, 0}= , >> + {L"w25x40", {0xef, 0x30, 0x13}, 3, 256, 64 * 1024, 8, NF= _ERASE_4K}, >> + {L"w25x16", {0xef, 0x30, 0x15}, 3, 256, 64 * 1024, 32, NF= _ERASE_4K}, >> + {L"w25x32", {0xef, 0x30, 0x16}, 3, 256, 64 * 1024, 64, NF= _ERASE_4K}, >> + {L"w25x64", {0xef, 0x30, 0x17}, 3, 256, 64 * 1024, 128, NF= _ERASE_4K}, >> + {L"w25q80bl", {0xef, 0x40, 0x14}, 3, 256, 64 * 1024, 16, NF= _ERASE_4K}, >> + {L"w25q16cl", {0xef, 0x40, 0x15}, 3, 256, 64 * 1024, 32, NF= _ERASE_4K}, >> + {L"w25q32bv", {0xef, 0x40, 0x16}, 3, 256, 64 * 1024, 64, NF= _ERASE_4K}, >> + {L"w25q64cv", {0xef, 0x40, 0x17}, 3, 256, 64 * 1024, 128, NF= _ERASE_4K}, >> + {L"w25q128bv", {0xef, 0x40, 0x18}, 3, 256, 64 * 1024, 256, NF= _ERASE_4K}, >> + {L"w25q256", {0xef, 0x40, 0x19}, 3, 256, 64 * 1024, 512, NF= _ERASE_4K}, >> + {L"w25q80bw", {0xef, 0x50, 0x14}, 3, 256, 64 * 1024, 16, NF= _ERASE_4K}, >> + {L"w25q16dw", {0xef, 0x60, 0x15}, 3, 256, 64 * 1024, 32, NF= _ERASE_4K}, >> + {L"w25q32dw", {0xef, 0x60, 0x16}, 3, 256, 64 * 1024, 64, NF= _ERASE_4K}, >> + {L"w25q64dw", {0xef, 0x60, 0x17}, 3, 256, 64 * 1024, 128, NF= _ERASE_4K}, >> + {L"w25q128fw", {0xef, 0x60, 0x18}, 3, 256, 64 * 1024, 256, NF= _ERASE_4K}, >> + {}, /* Empty entry to terminate the list */ }; >> + >> +/** >> + Return a pool allocated copy of the NOR flash . > > Well, a copy of the NOR flash information structure, not the flash conten= ts. > Extra space before period. > > / Thanks for the review. Will submit v2 with all corrections (also with typo = fix in the commit log). Best regards, Marcin _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://emea01.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Flists.= 01.org%2Fmailman%2Flistinfo%2Fedk2-devel&data=3D02%7C01%7Cpankaj.bansal%40n= xp.com%7C753424b872b346c9c76f08d52037acfc%7C686ea1d3bc2b4c6fa92cd99c5c30163= 5%7C0%7C0%7C636450345874702676&sdata=3DXrtsj3B7deTGx45bVNfBi%2FjUoQOMQIfb65= d0510U02c%3D&reserved=3D0