From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (EUR04-DB3-obe.outbound.protection.outlook.com [40.107.6.69]) by mx.groups.io with SMTP id smtpd.web09.828.1608316302285200315 for ; Fri, 18 Dec 2020 10:31:43 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=F85yBf2t; spf=pass (domain: arm.com, ip: 40.107.6.69, mailfrom: sami.mujawar@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/U8pgfoYl35QoD7+eMAnDEzEqg+QekjzLoFsyM0yYTo=; b=F85yBf2tFMZIOp4z8CnPYmQ850g5XHsSsvLOabyZAtc97a/Zj+cmdE9n47mbftkN4VkuJe5piSab9IhvR7WwVDYGKy/qSejK+j+FT0Nymkfiz3pVyPVFjbxDrUEEw8d2pX0GgnOSb2mjRuQ3kzbaoMILeB5MJ8YVezi8/jIda/c= Received: from AS8PR04CA0114.eurprd04.prod.outlook.com (2603:10a6:20b:31e::29) by HE1PR0801MB2043.eurprd08.prod.outlook.com (2603:10a6:3:4d::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3654.20; Fri, 18 Dec 2020 18:31:40 +0000 Received: from VE1EUR03FT020.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:31e:cafe::76) by AS8PR04CA0114.outlook.office365.com (2603:10a6:20b:31e::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3676.28 via Frontend Transport; Fri, 18 Dec 2020 18:31:39 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT020.mail.protection.outlook.com (10.152.18.242) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3676.22 via Frontend Transport; Fri, 18 Dec 2020 18:31:39 +0000 Received: ("Tessian outbound 76bd5a04122f:v71"); Fri, 18 Dec 2020 18:31:38 +0000 X-CR-MTA-TID: 64aa7808 Received: from 700722053327.3 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 7E04269F-C5C1-438E-A887-CA03CB122E80.1; Fri, 18 Dec 2020 18:31:33 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 700722053327.3 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 18 Dec 2020 18:31:33 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dRGw7by5wrMss+VH+QkgtcCnFMzTrzP0ETRiV56SFb4royU3nHQz6DsBcdAWWrNoWN/Ru8MOLwiTHcXP7fPrnrlm+F0l/Ff/Z1DBWG8YZFd4kybSqMJRBguTlKrxJpcv4LZJbPmwPKwWcCXddXw+MWN36tC+MOdgzwuKAR0LaTDHqakGC/mEZ788LM021v0MmbO0EiK2rqtPqFRBnHt0UCLQMlYfsN4YGYjMjg9FvouDFtIEVJKFn+/0v1sRLh5z0r9sN7TFTHMs5TUl54uXPsYycReRZUzFrurkmV6SPvM++AMIZwWm5IQOiejBTQ825R7UV7yU6PP2cv0sBTVAug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/U8pgfoYl35QoD7+eMAnDEzEqg+QekjzLoFsyM0yYTo=; b=c2hyviEWQ3WQmgWv9qORZeEA7BgvJJ4olEGTZNQXlI6dDZ4Qya1b6JOpWDd0YwYo5AYR8tsC9416N1qnOHE+cotlj0DDFRHBwR8Vz0NEG30YDYStQnElUpJckRnz/obDKIPvl+1OkMtB4D/OEtJc8rIuIx9qQnzV/Xtx6SI0QDT1WZkXMS50thr0b6g+FcjJm+qvClaViYCjwT7vHjwYuHWvX86Qg6dyC/6dbu+3plyVboJ5vsk54jELVgG9qPqX+cEcn1sBGeGOaR9zTh/amGW12a4kLuwvaQ/B07rv4UWPZ/pQR9rFVe3Kod0rRhvW54AxVkYiprNjS2dhU5EVvw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/U8pgfoYl35QoD7+eMAnDEzEqg+QekjzLoFsyM0yYTo=; b=F85yBf2tFMZIOp4z8CnPYmQ850g5XHsSsvLOabyZAtc97a/Zj+cmdE9n47mbftkN4VkuJe5piSab9IhvR7WwVDYGKy/qSejK+j+FT0Nymkfiz3pVyPVFjbxDrUEEw8d2pX0GgnOSb2mjRuQ3kzbaoMILeB5MJ8YVezi8/jIda/c= Received: from AM0PR08MB3091.eurprd08.prod.outlook.com (2603:10a6:208:60::10) by AM9PR08MB5986.eurprd08.prod.outlook.com (2603:10a6:20b:281::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3654.25; Fri, 18 Dec 2020 18:31:32 +0000 Received: from AM0PR08MB3091.eurprd08.prod.outlook.com ([fe80::2c1c:6f6a:bd35:cd65]) by AM0PR08MB3091.eurprd08.prod.outlook.com ([fe80::2c1c:6f6a:bd35:cd65%3]) with mapi id 15.20.3654.024; Fri, 18 Dec 2020 18:31:32 +0000 From: "Sami Mujawar" To: "devel@edk2.groups.io" , Pierre Gondois , Ard Biesheuvel , "leif@nuviainc.com" , nd Subject: Re: [edk2-devel] [PATCH v1 00/25] Fix Ecc reported errors in ArmPkg Thread-Topic: [edk2-devel] [PATCH v1 00/25] Fix Ecc reported errors in ArmPkg Thread-Index: AQHW09AldO1IjRUE7E6CxiArBw8o36n9L+Bg Date: Fri, 18 Dec 2020 18:31:32 +0000 Message-ID: References: <20201216172200.25846-1-Pierre.Gondois@arm.com> In-Reply-To: <20201216172200.25846-1-Pierre.Gondois@arm.com> Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 8D5EF3CBC31C3C47BE0DCB933EE080D7.0 x-checkrecipientchecked: true Authentication-Results-Original: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=arm.com; x-originating-ip: [217.140.99.251] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 703dc0ca-b2d0-4756-4f7c-08d8a38328dd x-ms-traffictypediagnostic: AM9PR08MB5986:|HE1PR0801MB2043: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:8882;OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: c9DRS55/53p87iR1Wnj2Rgyz+7eq+7s+84U3+F6oZiXO86y3uSe3Lxn9d1qJ5g2v16P/2GIPmQk/SRoG8fTpw62TlKIcXYq6WDvhUNWnb1vcLv5qyJtaTnyNMon0GJQwWwHdQLV9lnm58IECrAOCHPSvx2zx1224M31UGQot897rJbP+bsVg3iDo7stfGdg4PfLeRkTXnSTV4Dt1lbabAFCE52yojiYx5cLzpWxT6HSii+ct+msgxJP2M+DRtLOZbkHRq9/2R4CfzNkjZ4Om29OQqHsU/AF2KhSRylEPBpMQ+SWOVRaTR2Lb2MGY+8XYBpVc76tPo6xCT+cFa04gY7cFLYNJ98LymXlTWfGS4bcwNiRvYB7Je6rRmuhtgVa8xns3BE9lO0SJBzkWnaO9Cg== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB3091.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(376002)(346002)(39860400002)(366004)(136003)(396003)(52536014)(6506007)(316002)(9686003)(8676002)(7696005)(110136005)(33656002)(55016002)(2906002)(8936002)(86362001)(66446008)(71200400001)(66556008)(83380400001)(64756008)(478600001)(53546011)(26005)(66476007)(76116006)(186003)(66946007)(19627235002)(5660300002)(6636002)(966005);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?vvSAjXnm1cLXgxT5LwsBPcZwkFPwz2Y6dad97IDbmqBlpyX1gLfqGbDg9923?= =?us-ascii?Q?khrX5zgm69sSm2+gImVPQouPdRSDq0JwRy8pwn7aDxxs2cksXaJ5VhNecUOj?= =?us-ascii?Q?jdCcEWyamk3D+vogeSHtv7htuZ6N59QkTPUyjfM2iUB7jqWByuCKzq9v7IJ2?= =?us-ascii?Q?viXnD2IIpiaYVW0P9OGqzbIWhWstmjb54dy4eTis0j44A4pPcyF79/DKGEU8?= =?us-ascii?Q?NW1gNK6eTez2ZdKeLJplkJhGcZpMkYqs+dE8bgZBA7Y7rkH11aaLZ74wTymI?= =?us-ascii?Q?7Qq9wKeeCy8OKJwCWq007NU9oegOBRvaF2aRK3deexlF9/kcqnJgQaWvwKPs?= =?us-ascii?Q?u3VMpSiagepINJwkqbAMMH3YBk2VW5osfn1ldR1PWcjsEfjdUFQSBEkk46D5?= =?us-ascii?Q?8yVZDE2EIVuMYVaXLrFUhYq5mb3GNRukQv8OYjZGO8Ice17hLciF6E5l/wGR?= =?us-ascii?Q?0MdGVtmNjvTh4xQOvQXccy1oZoIp+EeX8Xn8QPBBqXVZQpKwi5ofFBDu9W8m?= =?us-ascii?Q?tds5RTjgXmzwtZ51DNx44tDJgqkqdBOBVrDXx4NWItplGszhiaxY51soRtQE?= =?us-ascii?Q?kNGG134r4KA/wsAEQ0c6Hw3uSe/SemIt3pwRh45Q1k+6N4UxbHucMz1YoKby?= =?us-ascii?Q?FCQTBux8y/ef1yBrMeJQS9WtMpozbgE7OurlvfDXgup6bkMFQTBuxs990WB0?= =?us-ascii?Q?tqdqbjWabkzQgpOjl+zDBa3NnTuRCMrUgU9SXGvHIuKhA2ytfOjSxV6TFxHx?= =?us-ascii?Q?VkXhwos9oH/uQVZT2JIjZhGf6eIcjwfq7FikUCa+6umdD3dZaEpMPe9wXQ/6?= =?us-ascii?Q?WA1KrbTZPEM9yMXNmGs2NCFSmLgXhGx5aGY/QPBYF/GCZ1D1VCgxOZMBr9uZ?= =?us-ascii?Q?Z4cCD2EuzscXjDB2XQ4RB9QP78arrj08zl78LkLjbZBjzcM5eMKUY2nUIz/a?= =?us-ascii?Q?c0LHHREh8kjlpoDrkI9slzzjoqKxnHq2zCEge6GZ3UI=3D?= MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB5986 Original-Authentication-Results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT020.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: e31d1105-d275-47af-2ec2-08d8a38324cc X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Sk6vp+FbUqwVv/wWMRGiiB39kIY2fBubSB5RO9CnMbZq6ZPqCSZeC3l63MFggKt9qviEvun9nAvwtcW9xKgq0C2IV+oS3CytizG1zlNPIgwc1CZESByZGIcxTTQIv7CPpvd+gpbEhBSkrzMePCGn+DDMV21rGM0l9MVdtQ5vTb+FluWH21+aKSUgmXay2UsXBQVY61lMtU6Xf7qToaCWKPjzON2rQ6eGPkcjBQnzOqKoojdHtZ42tAWxUKauX0txYAmqA3sBjKn43GDyZNsDYNw+qW9i+lsxsAeYW6sduk0yunIm+oGCNSrI92pjAK4M5ykn2/t4dgVmtv+Y7Mr33LWpNhlfFZysLXKPZONIjJcEA3+fM8VNmnRuaAu5OvV8OwWW8KVmJ/LGWgL1MX3aO1usUKcdiT5sMnZAlInJqNqQJ0GyVHf+SCRWmnOZi81pPltyG2wO1CEtx17TkR7j8MGqfOLLOc80TCUgWNBm2jo= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(136003)(376002)(346002)(39860400002)(396003)(46966005)(19627235002)(26005)(53546011)(6636002)(33656002)(82740400003)(55016002)(356005)(478600001)(110136005)(52536014)(47076004)(316002)(70206006)(966005)(5660300002)(81166007)(186003)(83380400001)(6506007)(8676002)(70586007)(336012)(86362001)(9686003)(2906002)(7696005)(82310400003)(8936002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Dec 2020 18:31:39.3271 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 703dc0ca-b2d0-4756-4f7c-08d8a38328dd X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT020.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0801MB2043 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable For this patch series: Reviewed-by: Sami Mujawar Regards, Sami Mujawar -----Original Message----- From: devel@edk2.groups.io On Behalf Of PierreGondo= is via groups.io Sent: 16 December 2020 05:22 PM To: devel@edk2.groups.io; Ard Biesheuvel ; leif@nu= viainc.com Cc: Sami Mujawar Subject: [edk2-devel] [PATCH v1 00/25] Fix Ecc reported errors in ArmPkg From: Pierre Gondois The Ecc tools available in the BaseTools package checks for good practice coding standards. Some errors reported while running Ecc on the ArmPkg require modifications. The changes can be seen at: https://github.com/PierreARM/edk2/commits/1552= _Ecc_ArmPkg_v1 Pierre Gondois (25): ArmPkg: Format header to fix Ecc crash in ArmMmuLib ArmPkg: Fix Ecc error 3002 in CompilerIntrinsicsLib ArmPkg: Fix Ecc error 3002 in OpteeLib ArmPkg: Fix Ecc error 3002 in ArmMmuLib ArmPkg: Fix Ecc error 3002 in TimerDxe ArmPkg: Fix Ecc error 3002 in MmCommunicationDxe ArmPkg: Fix Ecc error 3002 in CpuDxe ArmPkg: Fix Ecc error 3002 in SemihostFs ArmPkg: Fix Ecc error 3002 in ArmDisassemblerLib ArmPkg: Fix Ecc error 3001 in SemihostFs ArmPkg: Fix Ecc error 5005 in CpuDxe ArmPkg: Fix Ecc error 5005 in ArmExceptionLib ArmPkg: Fix Ecc error 5007 in CompilerIntrinsicsLib ArmPkg: Fix Ecc error 5007 in ArmScmiDxe ArmPkg: Fix Ecc error 5007 in CpuDxe ArmPkg: Fix Ecc error 5007 in TimerDxe ArmPkg: Fix Ecc error 5007 in SemihostFs ArmPkg: Fix Ecc error 5007 in ArmCacheMaintenanceLib ArmPkg: Fix Ecc error 5007 in ArmDisassemblerLib ArmPkg: Fix Ecc error 5007 in ArmLib ArmPkg: Fix Ecc error 5007 in ArmMmuLib ArmPkg: Fix Ecc error 5007 in SemiHostingSerialPortLib ArmPkg: Fix Ecc error 5007 in SemihostLib ArmPkg: Fix Ecc error 5007 in StandaloneMmMmuLib ArmPkg: Fix Ecc error 5007 in DefaultExceptionHandlerLib ArmPkg/Drivers/ArmScmiDxe/Scmi.c | 5 ++- ArmPkg/Drivers/ArmScmiDxe/ScmiClockProtocol.c | 8 ++-- ArmPkg/Drivers/CpuDxe/AArch64/Mmu.c | 8 ++-- ArmPkg/Drivers/CpuDxe/Arm/Mmu.c | 14 +++---- ArmPkg/Drivers/CpuDxe/Exception.c | 8 ++-- .../MmCommunicationDxe/MmCommunication.c | 4 +- ArmPkg/Drivers/TimerDxe/TimerDxe.c | 7 ++-- ArmPkg/Filesystem/SemihostFs/Arm/SemihostFs.c | 25 ++++++----- .../ArmCacheMaintenanceLib.c | 13 +++--- .../ArmDisassemblerLib/ArmDisassembler.c | 11 ++++- .../Library/ArmExceptionLib/ArmExceptionLib.c | 5 ++- ArmPkg/Library/ArmLib/ArmLib.c | 20 +++------ .../Library/ArmMmuLib/AArch64/ArmMmuLibCore.c | 2 +- .../AArch64/ArmMmuPeiLibConstructor.c | 14 +++---- .../Library/ArmMmuLib/Arm/ArmMmuLibUpdate.c | 34 +++++++-------- .../Library/CompilerIntrinsicsLib/memcmp_ms.c | 10 +++-- ArmPkg/Library/CompilerIntrinsicsLib/memcpy.c | 11 +++-- .../Library/CompilerIntrinsicsLib/memcpy_ms.c | 11 +++-- .../CompilerIntrinsicsLib/memmove_ms.c | 14 +++++-- ArmPkg/Library/CompilerIntrinsicsLib/memset.c | 8 +++- .../Library/CompilerIntrinsicsLib/memset_ms.c | 8 +++- .../Arm/DefaultExceptionHandler.c | 41 ++++++++++--------- ArmPkg/Library/OpteeLib/Optee.c | 7 ++-- .../SemiHostingSerialPortLib/SerialPortLib.c | 8 +++- ArmPkg/Library/SemihostLib/SemihostLib.c | 6 +-- .../AArch64/ArmMmuStandaloneMmLib.c | 13 +++--- 26 files changed, 182 insertions(+), 133 deletions(-) -- 2.17.1 IMPORTANT NOTICE: The contents of this email and any attachments are confi= dential and may also be privileged. If you are not the intended recipient, = please notify the sender immediately and do not disclose the contents to an= y other person, use it for any purpose, or store or copy the information in= any medium. Thank you.