From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (EUR05-VI1-obe.outbound.protection.outlook.com [40.107.21.42]) by mx.groups.io with SMTP id smtpd.web10.242.1612908489077165549 for ; Tue, 09 Feb 2021 14:08:10 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=798xVLWb; spf=pass (domain: arm.com, ip: 40.107.21.42, mailfrom: sami.mujawar@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ncCtIbC7T1d0IiDYRUOPzJ7BhHOtGXJTLejKI5VgzKs=; b=798xVLWb+hdY/tmhwcIRnqWpR3XLdaXnM5D8Mcnm29MMWMmxVwVLlwcITKjd0Qxz68l2XgFd80ueTQ20Lq6aFgOOG6fyHVnln4KRVeyizBEgziaJFkwROsOLzf0K/6NBpk7PiK/Vw49mlyEvMR9yxlQrx3rE6sA/BWy7lnxQ6Es= Received: from AM6P193CA0106.EURP193.PROD.OUTLOOK.COM (2603:10a6:209:88::47) by AM7PR08MB5429.eurprd08.prod.outlook.com (2603:10a6:20b:107::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3825.23; Tue, 9 Feb 2021 22:08:06 +0000 Received: from VE1EUR03FT026.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:88:cafe::93) by AM6P193CA0106.outlook.office365.com (2603:10a6:209:88::47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3825.20 via Frontend Transport; Tue, 9 Feb 2021 22:08:06 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT026.mail.protection.outlook.com (10.152.18.148) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3784.11 via Frontend Transport; Tue, 9 Feb 2021 22:08:06 +0000 Received: ("Tessian outbound 2b57fdd78668:v71"); Tue, 09 Feb 2021 22:08:05 +0000 X-CR-MTA-TID: 64aa7808 Received: from 313e7da56ca4.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id A27676BC-1814-4910-9F6F-098681944511.1; Tue, 09 Feb 2021 22:08:00 +0000 Received: from EUR02-AM5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 313e7da56ca4.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 09 Feb 2021 22:08:00 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=E0paroDg+5TXhHhG395HkFTHyRLMBuRjs81nVxfs/5PpX+m7IppP1bHhLvHAaT84tmIXatoHxfCb1FfP5GCdtKt7NEZUOL1U13s2FhUolsoxY8Hls0YAibNa3/D3oHhuqa1t/h6PgbLMXLEhyGQgLqNVidxe3vX1Lz08kdRsLIctesoBoMr9eML9QVITOSK25n3hAYk1ldmBe2FAmXk/D9DHpqZzAs+7lIzof2klerwQUN91FAzqQKfajx0LtfM2CwZGArfPt4SaKZsPKRcGjG/2r2etvt1ZpMKwomtvJ5QUosjuV4QHYRTKV1rnZF4QyBZECry0ym2bAHwvnf9m8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ncCtIbC7T1d0IiDYRUOPzJ7BhHOtGXJTLejKI5VgzKs=; b=GhyybXC8YKlW6Cw7EnKItbjcWktRPyIh6pObAiabpSoJ/9wW6bvIqmqXBT8MeGXTfB5KkuIHlQexWYBPs6fxPioo5B08r/KoFPzljPcNv6pnNVDZFZLQiFJ7jr/dtS5mwFuxikyM178GPUUxUVZiEuLm8i8qIgVdrjz6Qu5BrZz5F21/RAma1tZWsN8ZBlnkGw2wjJmlCyeRLsTU28Hc3MhjI4HAmEFnWHBQFOmPzrivnd7AV3sZxHPfsUR+Oc3KD9yQPqpXou0jBzVZl2XUO+5fEkMBtDkSmdJ/SP1fTIp0AmC3QWj4lAXIueDrLmWz8nk6tEdrZzoCtcQIP1gwTA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ncCtIbC7T1d0IiDYRUOPzJ7BhHOtGXJTLejKI5VgzKs=; b=798xVLWb+hdY/tmhwcIRnqWpR3XLdaXnM5D8Mcnm29MMWMmxVwVLlwcITKjd0Qxz68l2XgFd80ueTQ20Lq6aFgOOG6fyHVnln4KRVeyizBEgziaJFkwROsOLzf0K/6NBpk7PiK/Vw49mlyEvMR9yxlQrx3rE6sA/BWy7lnxQ6Es= Received: from AM0PR08MB3091.eurprd08.prod.outlook.com (2603:10a6:208:60::10) by AM8PR08MB6564.eurprd08.prod.outlook.com (2603:10a6:20b:314::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3805.27; Tue, 9 Feb 2021 22:07:58 +0000 Received: from AM0PR08MB3091.eurprd08.prod.outlook.com ([fe80::15bb:2d5c:ddab:ca8c]) by AM0PR08MB3091.eurprd08.prod.outlook.com ([fe80::15bb:2d5c:ddab:ca8c%2]) with mapi id 15.20.3825.030; Tue, 9 Feb 2021 22:07:58 +0000 From: "Sami Mujawar" To: "mikuback@linux.microsoft.com" , "devel@edk2.groups.io" CC: Ard Biesheuvel , Jiewen Yao , Supreeth Venkatesh , nd Subject: Re: [PATCH v1 1/1] StandaloneMmPkg/StandaloneMmCore: Fix compiler warning Thread-Topic: [PATCH v1 1/1] StandaloneMmPkg/StandaloneMmCore: Fix compiler warning Thread-Index: AQHW+eAIOfp9fWqDfkGgaRrhofEbUapQatbw Date: Tue, 9 Feb 2021 22:07:58 +0000 Message-ID: References: <20210203035052.402-1-mikuback@linux.microsoft.com> In-Reply-To: <20210203035052.402-1-mikuback@linux.microsoft.com> Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 58482416430B7142A9D2D90DFD3A7AF2.0 x-checkrecipientchecked: true Authentication-Results-Original: linux.microsoft.com; dkim=none (message not signed) header.d=none;linux.microsoft.com; dmarc=none action=none header.from=arm.com; x-originating-ip: [109.145.9.160] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 4a7560ce-b486-41d9-261d-08d8cd472d74 x-ms-traffictypediagnostic: AM8PR08MB6564:|AM7PR08MB5429: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:136;OLM:136; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: opEndpAdMCOq/3RZSUM6rn4ZHWIFMUW+MCQLugOpWZa0/H7NklZNsQmedSbNMyQZGp2Nqrd5+OupyiLLVtp0EAQ22+nvlg2Ayb+APirGdNmZFoshf6kpDfsX1XXPuxQ7VmuNXzEG7DCGiV/45jdqF3Fydsx3deuy1c8B1baTwZpE29t0w5GWH53lqmZzupj0DA3eGOEqqm2U6EdLVEyeQ5K+CZoSx7yJAVKwjUHP6/KnxOQgP47x8BNbr9Ucruh0ud2h3g+TggMQmL3VbQ+rf46XWGehXgyMwEQHEqcdtp589yUxREuV+XXRsmjqC1a+VZypwQ1d3Qp6L919Q6UULrDb5tHngCk5OZGdtaGfXL1UgyiQ8SaPj8KGNd1ngxnmOAtTQNbIESjpfaU41qIlv9yj3CwDWKY9kg3+4AXRj+5wBxb7D1+GXzUTliBkLp/UgK69tba+Z7Gg1bxiYLr4xHvgoD0UiJsSBE9zGduCnlSbzo6S1bXBv26N+58ia4UuV1kGlfP1i/PNuAatEsiITzfO2IuaF+UlI650LjnS4lymADh43LstpN12ScE5vYx0OFjBroMA29V29q3r1tG/astoyJEu0MJCdiP+gPhV8vk= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB3091.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(6029001)(4636009)(396003)(136003)(366004)(346002)(376002)(39850400004)(66476007)(66446008)(110136005)(9686003)(83380400001)(66946007)(66556008)(26005)(55016002)(71200400001)(54906003)(6506007)(76116006)(5660300002)(33656002)(8936002)(64756008)(186003)(8676002)(53546011)(86362001)(7696005)(4326008)(52536014)(478600001)(316002)(2906002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?LjR+5glJe6FJuc37U26sDJ7VWpih+C4vCtaboGfpBkRVa1meRhFwSFG5DKyj?= =?us-ascii?Q?VVyzdoGntwFvv+CObVFVRsqKFv+RsnU7f9dOjsrwNS+GjKrbiFbc4J9s3qy9?= =?us-ascii?Q?FVLX/c/WXNhIa1g7gCAzK1Yhp0syyTN6KNnD0lgzQMS6xh6Sx9BsuZ21mcWl?= =?us-ascii?Q?UJdAQaJEzkabX99s3b9vGmv4t2tDuBkAXYeMlZQLk2obZQVslaJ/AQM013xV?= =?us-ascii?Q?b0y/0LrrtXZ0GjPqbDIDcx16Ye/b4vDR3PY9jAGje4Zr844dH3vzGqJa5ruL?= =?us-ascii?Q?OCMMj28zhkrWXeZsk65ErWtjOqyGByK72/koIKHby2JA/zoaHFw9CM3yiV9F?= =?us-ascii?Q?rAElMRL/HNFV1Kfsim45BuyEwpeWbwz33E8CJbWzNX+qfc5wKjap5PDu8Dpy?= =?us-ascii?Q?h4VuKmSlg4LhEHzhedEfeHZaOYBLx2UTzVXeuAFusI+51jskqBOpmRXKKuNu?= =?us-ascii?Q?O/oN53P9LpTEXYP6/Wd3B8RkbyGr9Tn9YqJAU1/HwGU8D+ZskAcQWjLLknWF?= =?us-ascii?Q?AWOara2gjzRm9mX77vLB2jyVf81ies9SlBpiXpax0R34AvKzsIZjiXhZO7dC?= =?us-ascii?Q?vMFBwDOpgy99ry5zyGn5Iq17t2nv389cp+Cbye5jNYSqSi9NFOPErtexWZ5G?= =?us-ascii?Q?GUlhh1cvDD7qOQiaSa/9OxYasPPRP3G9KtHbubNXY56R5EEk6zaGEJIOHJUp?= =?us-ascii?Q?n4AxARa1O8iTEfW/vyCb3Tl9ihzKNQvWV+VOOfYbyMM8A7Hsg+5wZwfWoQSn?= =?us-ascii?Q?CA2cjw5wgD79cLPpyZOXdn3+Pa0K7QKlwAzTs5kwd6TpTXc/VzuLH+b8czQI?= =?us-ascii?Q?7Ir7aEegkAZbTjBmphyrruzNceR1WuJbW6vc5tOvjHYHuGZUhjXDggJ1HVB3?= =?us-ascii?Q?KATraFTfvGqsfnjvN1zQusdV8mF0nCwE/LGM57E/Pz6x8ZRPrjbyUF3dwy9U?= =?us-ascii?Q?wkXGwewvpWHotVC01TeyEhoLsctBVK4ygM5cfT4LGPitne7VCURLG85VyEWJ?= =?us-ascii?Q?yq8k8p8Zsb49H88m/lZjmXtTMUulioIv9qeg0ImVOL1jNrmV3A8owKpOXGIK?= =?us-ascii?Q?O3NWqj/7wJ/J6uIWI5ZGSrBiLCvzRs1lajV3EHvUKnRbxmJqL99iMTTw9v2P?= =?us-ascii?Q?NCYXABMrgjAh6FPx1a7vMACvaK11j6aIIIUSa69etY0mv2upQZF9ea1xonO2?= =?us-ascii?Q?6vftEzRLEKunSf0ivQgDe0Vwt32csnnz2WzLSxQ2fK+uK0jU/OetM8B3h9aP?= =?us-ascii?Q?W1J9MTF86DGYVyp3NSs+qbjKTxg0nJ0QxWbG3GurKoZMjMPJoHdVjV646j8g?= =?us-ascii?Q?jg2EzORo74WjaxfOzgXKCqYT?= MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB6564 Original-Authentication-Results: linux.microsoft.com; dkim=none (message not signed) header.d=none;linux.microsoft.com; dmarc=none action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT026.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 57cd78c2-f436-4363-822f-08d8cd4728fb X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: w1LjLJs4Dqx+u4yQtWWS1VHomZDCsv479KCdlWUVQlcY7yLk7nKufBjwXQrbuxWxqycOB2YuYq/kfuhxgpZxpu0cy9nsUca+LWJq7BzuIv+lESesn/Xc6zGrf3dNMS5g6kuzCpCK6U3DfCWiHMzon2O0Gmb36zwAEISc/Y7sidAnybrFKGTLjMXBL5ZEJ+AY+2BK3fdyGkYz1M+ARHQ9aqtnwmULwHrb05U8wXM8/JwV/OUd1Z7EOnp1IIUMhxa0vaThmfyISuHwEZZ5p/bdb0jgiWhcyUy+7P67J8k33Ups0c0CoNFXgx455JyM91bYjOUAVz2Xym72+OMZ4q+MvAvCKwnSwdQbCwBr9llqoH73X3I7ThkucuIs2IBPljqZWw+nTZyVgd1iP5/T3h3ihaDWo5aILUVkDql2yX6B3QYX2b+N2S6OFpQBFyjlte0BmKwlsrDXOccMzaqgNBFMUHcf6Sd/vOJPDQpi3tSdllIkRCZPO7FFRmfZ+iR0Uvyze7zWc2Wo13EV1tmgyNws1U3vbKs2zpPNgpor76F0f7oWrEaRdVSEdHbWq1xtKSX4gUTzEX8fKi8WbX1f3t0S6/fFyXCWfsOpns3sk5LtfXrGgwbAr6gaH3XGYJzkcjkyxQkV8pdOxKoXBz2is52GZg/NwLp8X/beTIuX/PgS4sUzuSTf9SVnx9Gux1l5bstfeHRMQInK76lOmmRcp8tauazShFsZpku2oqNiaNenWN8= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(6029001)(4636009)(136003)(376002)(39850400004)(346002)(396003)(46966006)(36840700001)(45080400002)(6506007)(26005)(7696005)(70586007)(82310400003)(9686003)(2906002)(53546011)(8676002)(356005)(86362001)(54906003)(36860700001)(52536014)(5660300002)(4326008)(110136005)(316002)(33656002)(82740400003)(81166007)(47076005)(336012)(8936002)(55016002)(83380400001)(70206006)(478600001)(186003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Feb 2021 22:08:06.0534 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4a7560ce-b486-41d9-261d-08d8cd472d74 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT026.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR08MB5429 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Michael, Please see my response inline marked [SAMI]. Other than the minor space change needed to match the coding style, this pa= tch looks good to me. With that changed: Reviewed-by: Sami Mujawar Regards, Sami Mujawar -----Original Message----- From: mikuback@linux.microsoft.com =20 Sent: 03 February 2021 03:51 AM To: devel@edk2.groups.io Cc: Ard Biesheuvel ; Sami Mujawar ; Jiewen Yao ; Supreeth Venkatesh Subject: [PATCH v1 1/1] StandaloneMmPkg/StandaloneMmCore: Fix compiler warn= ing From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D3204 Fixes the following compiler warning in VS2019 by changing defining the MmramRangeCount variable to be UINTN and type casting prior to value assignment. \edk2\StandaloneMmPkg\Core\StandaloneMmCore.c(570): error C2220: the following warning is treated as an error \edk2\StandaloneMmPkg\Core\StandaloneMmCore.c(570): warning C4244: '=3D': conversion from 'UINT64' to 'UINT32', possible loss of data Cc: Ard Biesheuvel Cc: Sami Mujawar Cc: Jiewen Yao Cc: Supreeth Venkatesh Signed-off-by: Michael Kubacki --- StandaloneMmPkg/Core/StandaloneMmCore.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/StandaloneMmPkg/Core/StandaloneMmCore.c b/StandaloneMmPkg/Core= /StandaloneMmCore.c index 8388ec289ca8..d254a68f2fb8 100644 --- a/StandaloneMmPkg/Core/StandaloneMmCore.c +++ b/StandaloneMmPkg/Core/StandaloneMmCore.c @@ -511,7 +511,7 @@ StandaloneMmMain ( EFI_HOB_GUID_TYPE *MmramRangesHob; EFI_MMRAM_HOB_DESCRIPTOR_BLOCK *MmramRangesHobData; EFI_MMRAM_DESCRIPTOR *MmramRanges; - UINT32 MmramRangeCount; + UINTN MmramRangeCount; EFI_HOB_FIRMWARE_VOLUME *BfvHob; =20 ProcessLibraryConstructorList (HobStart, &gMmCoreMmst); @@ -546,7 +546,7 @@ StandaloneMmMain ( MmramRangesHobData =3D GET_GUID_HOB_DATA (MmramRangesHob); ASSERT (MmramRangesHobData !=3D NULL); MmramRanges =3D MmramRangesHobData->Descriptor; - MmramRangeCount =3D MmramRangesHobData->NumberOfMmReservedRegions; + MmramRangeCount =3D (UINTN) MmramRangesHobData->NumberOfMmReservedRegi= ons; [SAMI] There should be no space between the typecast and the variable, i.e.= space after typecast (UINTN) and MmramRangesHobData. Same at other places in this file. [/SAMI] ASSERT (MmramRanges); ASSERT (MmramRangeCount); =20 @@ -554,7 +554,7 @@ StandaloneMmMain ( // Copy the MMRAM ranges into MM_CORE_PRIVATE_DATA table just in case = any // code relies on them being present there // - gMmCorePrivate->MmramRangeCount =3D MmramRangeCount; + gMmCorePrivate->MmramRangeCount =3D (UINT64) MmramRangeCount; gMmCorePrivate->MmramRanges =3D (EFI_PHYSICAL_ADDRESS)(UINTN)AllocatePool (MmramRangeCount * sizeof = (EFI_MMRAM_DESCRIPTOR)); ASSERT (gMmCorePrivate->MmramRanges !=3D 0); @@ -567,7 +567,7 @@ StandaloneMmMain ( DataInHob =3D GET_GUID_HOB_DATA (GuidHob); gMmCorePrivate =3D (MM_CORE_PRIVATE_DATA *)(UINTN)DataInHob->Address; MmramRanges =3D (EFI_MMRAM_DESCRIPTOR *)(UINTN)gMmCorePrivate->Mmr= amRanges; - MmramRangeCount =3D gMmCorePrivate->MmramRangeCount; + MmramRangeCount =3D (UINTN) gMmCorePrivate->MmramRangeCount; } =20 // --=20 2.28.0.windows.1