From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR03-VE1-obe.outbound.protection.outlook.com (EUR03-VE1-obe.outbound.protection.outlook.com [40.107.5.72]) by mx.groups.io with SMTP id smtpd.web09.11807.1605217792436312589 for ; Thu, 12 Nov 2020 13:49:53 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=WjCZrmdq; spf=pass (domain: arm.com, ip: 40.107.5.72, mailfrom: sami.mujawar@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=REedcQogueHLxYsKVG+xutAkNbJEFIaLaQRvYrG97do=; b=WjCZrmdqD3WCr8PP8xBh+mdRy5j7V7I8/OHSs10c0LnIQFWHVk5r/xHJU6/q0rSpb1V51gJajwr6e2/kgfX4arzPq5Y07oa2r/W8GWZ8kPKiSrM5bwG3TAosN9Zc+KUczsydzSHLtMLz6/U5rJz9APWg9IZadWUG8LkMTNjAEeQ= Received: from AM6PR08CA0025.eurprd08.prod.outlook.com (2603:10a6:20b:c0::13) by VI1PR0801MB1712.eurprd08.prod.outlook.com (2603:10a6:800:5a::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3541.25; Thu, 12 Nov 2020 21:49:48 +0000 Received: from AM5EUR03FT050.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:c0:cafe::4a) by AM6PR08CA0025.outlook.office365.com (2603:10a6:20b:c0::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3564.25 via Frontend Transport; Thu, 12 Nov 2020 21:49:48 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT050.mail.protection.outlook.com (10.152.17.47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3564.22 via Frontend Transport; Thu, 12 Nov 2020 21:49:48 +0000 Received: ("Tessian outbound d6c201accd3c:v71"); Thu, 12 Nov 2020 21:49:48 +0000 X-CR-MTA-TID: 64aa7808 Received: from 6fa31b4ad6dc.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 986EF8E4-FA64-47DD-8D6E-B97D25A8794C.1; Thu, 12 Nov 2020 21:49:43 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 6fa31b4ad6dc.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 12 Nov 2020 21:49:43 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nKgUskpC5fv44Wh3rd5lC5CwwKm0i8Fw+IxqqBk4RQ0MnEOZ2wYSVH3HSYh6V5UjV61GSkDxI4OTC2maLYfMqT6n8OA7JDxcgQMpdXoUDhRIsOgcRluBVyP4Sv2KdjWDomCMzaC158xenCWOorjbDR1FpNIGCQAiqi34fsFtCSFFJ1OmiUoddtKgDsCw4Uq7znMpRF+MQCRmZhGoNHEco98w6FffZ1S0pFFVejp/5TXfLQlcLIx621ZtgdqPQjqU640ATUMCBCjJdPOv4flq3ugQIQ8QfiYc1whlBHhQNw2vEvyK2bicDG7MSObvuAY4+HgAfEI4nyzAzlD15vBfPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=REedcQogueHLxYsKVG+xutAkNbJEFIaLaQRvYrG97do=; b=NkSQRIGEwUfan/bhYK3oWbOzF3eNs6qjuYTWeRB62AcgEKv26X1e8SnDWOjLi6bxVJjyGNYKLb40+az4tgCefsRkR5QFGCnjRfwSProYQ7yLmGbWEYfwO7RWyyrCGgsbPNCygH/z2G1zP447PzCroFiNMrb8esqxUblppjMKgEbCXSzLbyVFx6HNzV0lq+Y9e0So0VruVlbl1e07zR/T7pNpFxqwDqcWVbjt7bNFQfSe8Z2cCjBYqO/LZW+NubUjjomRR/Z0ae0ja4DjPmmqB2vpvmWS5ynhj+rHFh/T9vLF4NkbV5fIt+w4b/8gyDF3TlnT+UBCZa/8XpDghxkghg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=REedcQogueHLxYsKVG+xutAkNbJEFIaLaQRvYrG97do=; b=WjCZrmdqD3WCr8PP8xBh+mdRy5j7V7I8/OHSs10c0LnIQFWHVk5r/xHJU6/q0rSpb1V51gJajwr6e2/kgfX4arzPq5Y07oa2r/W8GWZ8kPKiSrM5bwG3TAosN9Zc+KUczsydzSHLtMLz6/U5rJz9APWg9IZadWUG8LkMTNjAEeQ= Received: from AM0PR08MB3091.eurprd08.prod.outlook.com (2603:10a6:208:60::10) by AM8PR08MB5844.eurprd08.prod.outlook.com (2603:10a6:20b:1d1::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3541.21; Thu, 12 Nov 2020 21:49:40 +0000 Received: from AM0PR08MB3091.eurprd08.prod.outlook.com ([fe80::4484:77e2:2b0f:1d1]) by AM0PR08MB3091.eurprd08.prod.outlook.com ([fe80::4484:77e2:2b0f:1d1%7]) with mapi id 15.20.3541.025; Thu, 12 Nov 2020 21:49:40 +0000 From: "Sami Mujawar" To: "devel@edk2.groups.io" , "rebecca@nuviainc.com" CC: Leif Lindholm , Ard Biesheuvel , Michael D Kinney , Liming Gao , Zhiguang Liu Subject: Re: [edk2-devel] [PATCH v3 1/3] ArmPkg: Add ARM SMC Architecture functions to ArmStdSmc.h Thread-Topic: [edk2-devel] [PATCH v3 1/3] ArmPkg: Add ARM SMC Architecture functions to ArmStdSmc.h Thread-Index: AQHWt8BcxSlvwr5+JUC9uQEGg+ZZm6nE/6Ug Date: Thu, 12 Nov 2020 21:49:40 +0000 Message-ID: References: <20201111001748.20217-1-rebecca@nuviainc.com> <20201111001748.20217-2-rebecca@nuviainc.com> In-Reply-To: <20201111001748.20217-2-rebecca@nuviainc.com> Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 29B6E2E6E40D3247BD867010BB6F1FF7.0 x-checkrecipientchecked: true Authentication-Results-Original: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=arm.com; x-originating-ip: [217.140.99.251] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 3837df0b-fafa-4b2e-168b-08d88754e050 x-ms-traffictypediagnostic: AM8PR08MB5844:|VI1PR0801MB1712: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:5797;OLM:7691; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: Pd4Pxw29StBkbKWwwLsYR+ee89rdayTrm1ZPq/5KI+pufuKxljs6XAuVQmw43bwUlblXEvYb6cphMsOcx0dpk820r3NDOarTVKQzDxr0Z176OSsBhIqkV7pDLdPRJXTRgSsXnR7tmCGD7WgbwNeLQ3viC1liKPSN90a18boMbOlzm9hXBkytBeFldEPZeN6ZjDINsCj6E05kiECevEQEigbDNEvFBt6Qdzq0Ac7cEtQEqmWZUjELpOORO8Uj4TxLHVPcgjeFDNvOCuafueswWTiRCExDfocSulU5wLhOglRzUa5Gi9gmWG3e74eJENmIxzUVmstrL53xTtU+blJqfa133Ec/6zsdsSY0ASCxHetklxWG6rigJDOW5bNsmJnAFx6boCEAPz+Qhw3T4J2f8A== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB3091.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(346002)(366004)(396003)(39860400002)(376002)(136003)(76116006)(54906003)(966005)(86362001)(66556008)(55016002)(7696005)(4326008)(186003)(110136005)(66476007)(33656002)(26005)(64756008)(83380400001)(66446008)(66946007)(2906002)(478600001)(316002)(52536014)(8936002)(9686003)(8676002)(71200400001)(5660300002)(53546011)(6506007);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: HftpCRsBRsOa7lERfEjQk/G5N+1PU7A4gNI7iGqDhtPdW8EZm4LeaFEv60LPMxaDsJVNt8tKNQqgO0VmETvZnHUewwQ2/a8jpG7s1CpA78ITN4FM7PAezZhsh2GC1hWPnGc2Nh9WQ3QYj9dUsPzcFJ4XDHjIbJFQn3MBLD1y9NztMF32M8SMDKheHCIJK0KcO+xjjvQzi7gzDGnDvSPyg0M/rAGNiMhwDdNsxoAO1eVqVdCRr0ftJIbnZwKFojycAOPyhUwn+81A3kAh1imxMsGHN9IRVg8AI6grfxhpxyw6PLvEzzIKwmb/A/6masoQpHu0ceC8hQA7xadoaF4zUwfSXnGFswc9ZccLEdRtaqpastfXGzTGYFsVJAS4v1480VYIb6MfWTrOXxLz4kP+rQiE9tYZ52/NIDwOmyGXHiQdoEw//Tx42s64zgpoh6x6pJzs3OtWLBb+8HULKXkZYRk8Ep5jpSYpu/w9rGJ9MFbNg/mUaHTl9UGIm2GW6uLfcF9HQFFiOpvUQq0YlXkQ3JuqajIxdFHjT9y4r6HZcbh0Ipz2zIN1CrdmX0T4PGqIoAyMJOxZUuFoKo6C0Vw1YN3lDsHt/Jl9zvNyqAZ63nLEjBYLpCGNZjNzmr1+gW9LTo1mCt8sATdoY6B2C9vO+GO7VKp8K3D+fkYHSpSSUpvf8Mlg24Hr4rGUw4Cv8E+6jE2k8T5Aot5+S4FBNCFofnSGYoKEBBcYXFblhZnLYLSOt+kTMTrVuOz9ghQWnxxcT4i2rW4rzxnhps8DeJsaElNYd+vZDSJ68zDsulhzJ5bCPQYKJlIIEdeBmMH+1licrXN9HsJPsY2+j24NLv2xsnqIHJ6hPPvwMfCRcavVR2dYKR5IDpbusRjxvVR1vzq0L6TcO+pOnZNCciLDRyDlsg== MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB5844 Original-Authentication-Results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT050.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 74623f28-ce40-45e4-d5cb-08d88754db97 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ITP/SnxpQO9xiCIEZY0rRbZBFoASEbRb7INFgOcdpu2Kpemy9YHkmqoI2daA7oeV+orBxJ5B3H0LdDGilMw7gn3IJGIIwGT9bpzBB6dBvbZz/irLKWdX4Buua2f7ezRzcQ4kEMWdXnvMId5CQcn8UrVNKUhK6JLX0Sf/SxNhhdUj5E9u8E5cMn6EdCXI20rODjEI5IXogd5x05yFweVud0XScU7+6y/lIVR4S30a2It+pMZY6Z58pRLejJFs+TiaXUDdLLgJ300ZPPPa4xofHgXjrB4fghn3SJSr24I+zOau3MwHmz6k9kEl29SYp5GOAEzLDFzslvPJNOuuGQLFrE0iuuRZb5kg4ZBkGxMCtE1iDzWxK7csIUTmO0b1ZyfdDFh+Z0YRMQebI1j8sE6gb6Q37sRjvgmZZG5zKhxGUEz2whr89VJ/6pWUUuktsDgtqvEWQGFtzA/HrnYIW6hLKV8kPOIqbxGJEQdgW1H75h0= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(136003)(39860400002)(346002)(396003)(376002)(46966005)(966005)(86362001)(54906003)(8936002)(47076004)(82310400003)(81166007)(478600001)(110136005)(9686003)(5660300002)(52536014)(6506007)(53546011)(55016002)(356005)(7696005)(82740400003)(4326008)(70586007)(186003)(33656002)(316002)(26005)(36906005)(8676002)(107886003)(336012)(83380400001)(2906002)(70206006);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Nov 2020 21:49:48.2533 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3837df0b-fafa-4b2e-168b-08d88754e050 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT050.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0801MB1712 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Rebecca, Thank you for this patch. Please find my response inline marked [SAMI]. Otherwise this patch looks good to me. Regards, Sami Mujawar -----Original Message----- From: devel@edk2.groups.io On Behalf Of Rebecca Cra= n via groups.io Sent: 11 November 2020 12:18 AM To: devel@edk2.groups.io Cc: Rebecca Cran ; Leif Lindholm = ; Ard Biesheuvel ; Michael D Kinney ; Liming Gao ; Zhiguang Liu Subject: [edk2-devel] [PATCH v3 1/3] ArmPkg: Add ARM SMC Architecture func= tions to ArmStdSmc.h The ARM SMC Architecture functions were missing from ArmStdSmc.h. Add them, based on the SMC Calling Convention version 1.2 specification. Signed-off-by: Rebecca Cran --- ArmPkg/Include/IndustryStandard/ArmStdSmc.h | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/ArmPkg/Include/IndustryStandard/ArmStdSmc.h b/ArmPkg/Include/= IndustryStandard/ArmStdSmc.h index 3509eb680f18..90f32c2249cd 100644 --- a/ArmPkg/Include/IndustryStandard/ArmStdSmc.h +++ b/ArmPkg/Include/IndustryStandard/ArmStdSmc.h @@ -1,5 +1,6 @@ /** @file * +* Copyright (c) 2020, NUVIA Inc. All rights reserved. * Copyright (c) 2012-2017, ARM Limited. All rights reserved. * * SPDX-License-Identifier: BSD-2-Clause-Patent [SAMI] Can you add a reference to the SMCCC 1.2 spec in the file header, p= lease? Something like: @par Revision Reference: - SMC Calling Convention version 1.2 (https://developer.arm.com/documentation/den0028/latest) [/SAMI] @@ -52,6 +53,18 @@ #define ARM_SMC_MM_RET_DENIED -3 #define ARM_SMC_MM_RET_NO_MEMORY -4 +// ARM Architecture Calls +#define ARM_SMC_ID_ARCH_VERSION 0x80000000 +#define ARM_SMC_ID_ARCH_FEATURES 0x80000001 +#define ARM_SMC_ID_ARCH_SOC_ID 0x80000002 +#define ARM_SMC_ID_ARCH_WORKAROUND_1 0x80008000 +#define ARM_SMC_ID_ARCH_WORKAROUND_2 0x80007FFF + +#define ARM_SMC_ARCH_RET_SUCCESS 0 +#define ARM_SMC_ARCH_RET_NOT_SUPPORTED -1 +#define ARM_SMC_ARCH_RET_NOT_REQUIRED -2 +#define ARM_SMC_ARCH_RET_INVALID_PARAMETER -3 + /* * Power State Coordination Interface (PSCI) calls cover a subset of the * Standard Service Call range. -- 2.26.2 IMPORTANT NOTICE: The contents of this email and any attachments are confi= dential and may also be privileged. If you are not the intended recipient, = please notify the sender immediately and do not disclose the contents to an= y other person, use it for any purpose, or store or copy the information in= any medium. Thank you.