From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR03-DB5-obe.outbound.protection.outlook.com (EUR03-DB5-obe.outbound.protection.outlook.com [40.107.4.83]) by mx.groups.io with SMTP id smtpd.web08.2948.1605266725747649490 for ; Fri, 13 Nov 2020 03:25:26 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=yaNz42at; spf=pass (domain: arm.com, ip: 40.107.4.83, mailfrom: sami.mujawar@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RiFUOVvI85yAnwVCUpG8a8yYaXtB/qHDE93XwRctm7U=; b=yaNz42at5KfDLnTjgSHUrpPHH+WI4xZSUnIJDOvuDTBTfSR8BBbgwJOxc+viFC1YTX4cFArShpd9Tk5EeXx2tJ21PumvCznfTwg9o3bL4P3NcdJcOLAJ90wsDk/E/+Rm3Hm201pSsCtq5edo5vrgCJ+9xAZwCkuKkcW3hmzuqEs= Received: from AM6PR01CA0071.eurprd01.prod.exchangelabs.com (2603:10a6:20b:e0::48) by AM9PR08MB6241.eurprd08.prod.outlook.com (2603:10a6:20b:281::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3541.22; Fri, 13 Nov 2020 11:25:23 +0000 Received: from AM5EUR03FT055.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:e0:cafe::26) by AM6PR01CA0071.outlook.office365.com (2603:10a6:20b:e0::48) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3541.21 via Frontend Transport; Fri, 13 Nov 2020 11:25:23 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT055.mail.protection.outlook.com (10.152.17.214) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3564.22 via Frontend Transport; Fri, 13 Nov 2020 11:25:23 +0000 Received: ("Tessian outbound 13ed5f5344c0:v71"); Fri, 13 Nov 2020 11:25:23 +0000 X-CR-MTA-TID: 64aa7808 Received: from 96965829e730.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 57965E2B-FD57-4650-8EC8-2A29DA2812EA.1; Fri, 13 Nov 2020 11:25:18 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 96965829e730.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 13 Nov 2020 11:25:18 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=X8oDWf9O3HK6JBa88Gm3ENXJboziGXm9G5j1hI4+swD2BCnJJzyYGebcfQZ7L0KQNOtGLLpTVhEk7ARYjv/sJEpxGKuFivO6cdqmWIAzlpaYofA8bWFeIeLhIfLwI6DNBkNLdUUFaAVIdkDSUsmOwlv1e+FEEkAk3S7fyDiKKiYby2dY0kxFPQRbQ7MoTpGeYbMku3mtbBS0LFEMHgJpJZIs3B4UdY1tQO41SaVHhuy60JO/f7sVLQlSEzJ62Dtd6PMBR0ozfEib4BtPP7Fmn02pWh5ROA/k+q/pFo4It8zoWq6sJtL1ySMB69dw0aK6qvBLM0vLYCN7woa7j0puZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RiFUOVvI85yAnwVCUpG8a8yYaXtB/qHDE93XwRctm7U=; b=SUjuioG7cJYqQmDVVtEKwxWtuQs4lr2kLL8emVL7bqEpui3DGf4MgzPKTc+QIgQP33PSwVMYg1fTySuGESuICqZDshmBxfGkqOGuWOCHmuy3GxxoaIVete/c9sdA6ZPEtqAoPuQYa5/+Df+j2g/oNAeAgf4N1Be2G85ok0aQAL15N2t4mgrvVdMIobH643sOzTSh6h9Ai40qZS6cZbOfp93Ed254XRL2yg08Cxm3RI9miO6abijC/EmICtyiUlS2DHoCNGPiVWsUfxTDGqXbtKTfvNgIsSE0Fpm5gLeVH6uaYu4VsYcmBYprZbOuD03rYLrHVaaLWSXMsyvzUz9C+g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RiFUOVvI85yAnwVCUpG8a8yYaXtB/qHDE93XwRctm7U=; b=yaNz42at5KfDLnTjgSHUrpPHH+WI4xZSUnIJDOvuDTBTfSR8BBbgwJOxc+viFC1YTX4cFArShpd9Tk5EeXx2tJ21PumvCznfTwg9o3bL4P3NcdJcOLAJ90wsDk/E/+Rm3Hm201pSsCtq5edo5vrgCJ+9xAZwCkuKkcW3hmzuqEs= Received: from AM0PR08MB3091.eurprd08.prod.outlook.com (2603:10a6:208:60::10) by AM0PR08MB3187.eurprd08.prod.outlook.com (2603:10a6:208:5b::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3541.21; Fri, 13 Nov 2020 11:25:17 +0000 Received: from AM0PR08MB3091.eurprd08.prod.outlook.com ([fe80::4484:77e2:2b0f:1d1]) by AM0PR08MB3091.eurprd08.prod.outlook.com ([fe80::4484:77e2:2b0f:1d1%7]) with mapi id 15.20.3541.025; Fri, 13 Nov 2020 11:25:17 +0000 From: "Sami Mujawar" To: "devel@edk2.groups.io" , "rebecca@nuviainc.com" CC: Leif Lindholm , Ard Biesheuvel , Michael D Kinney , Liming Gao , Zhiguang Liu Subject: Re: [edk2-devel] [PATCH v3 2/3] MdePkg: Update IndustryStandard/SmBios.h with processor status data Thread-Topic: [edk2-devel] [PATCH v3 2/3] MdePkg: Update IndustryStandard/SmBios.h with processor status data Thread-Index: AQHWt8BzWdbcV5x4AU+paVfzvRLR8anFBdaQ Date: Fri, 13 Nov 2020 11:25:16 +0000 Message-ID: References: <20201111001748.20217-1-rebecca@nuviainc.com> <20201111001748.20217-3-rebecca@nuviainc.com> In-Reply-To: <20201111001748.20217-3-rebecca@nuviainc.com> Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 32870532598E2448944A6A026DFF46E9.0 x-checkrecipientchecked: true Authentication-Results-Original: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=arm.com; x-originating-ip: [2a00:23c6:548a:4800:c1ea:451:8c76:ba5f] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 01868901-7cc1-4417-5a98-08d887c6cffa x-ms-traffictypediagnostic: AM0PR08MB3187:|AM9PR08MB6241: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:4125;OLM:7219; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: FFEdUvJU+jSIwDwqDJOFMwnnsVhlR1laKNFZ68S4+zo3TlQZ5yx9sjtENRSaQrnextC0n25RaUjS5FdvZSx7ZmHwthLgxfNSuV1s0xQ94PTV9Y7g3Rj1KXt4/SCWsY2NPdYk3At/Qui0OvbYlvL0cfZh6bFgnCyKQGSp1vm26GM6NbVAIRXGt5zce9UZvizCKjT66PUZIKjmJiZRJXMhyh4NpD0jR7AZu1g3nYaD+RUhHUIyYAZzI5d9FjlP54tdL/r4y6E2M1JYG0dmueCKAovk3BDCn/1NpP+AQMo+nkWb5nArFKMSVgqha0imaK0WZcFdZLgRHmj3SFAMv5xbDvoVpfKypNDGnsOr9/LeUsCxzrqP1tQY3PKs0r0vHjdTVs+XOHqx8b2WSBWRCfJMAw== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB3091.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(6029001)(4636009)(366004)(376002)(39860400002)(136003)(396003)(346002)(52536014)(7696005)(8936002)(478600001)(966005)(2906002)(33656002)(76116006)(71200400001)(186003)(8676002)(6506007)(83380400001)(110136005)(55016002)(66446008)(66476007)(5660300002)(4326008)(9686003)(66946007)(15650500001)(316002)(86362001)(66556008)(54906003)(64756008)(53546011);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?w33rGz4C2/H8v4E74VQLhzIcy+VJoi6r0pi8RgAx7PBTRSzJliIC8bar7s1v?= =?us-ascii?Q?SqMQQCSMTpvMHUro7M0hylcNCW+CXl9iQ/5v3z/G18rmCyng0A+9eYVPpz9D?= =?us-ascii?Q?UARav4W2SS6C5IqhbCeX16xeY7zAIuHO7fiKQGdjE5f0BsK0/iN+Yct8S7fB?= =?us-ascii?Q?VBl/vJPH/k+uCQF33oiwGlC98XjWzbznGtApjDnIBaNt56Im5etSKO34Z6m7?= =?us-ascii?Q?rchk/uXwaSaudS4D0/0s6mCHdVgYAuxE/eWoZq78tOHRw8zGtAttTB4dVimr?= =?us-ascii?Q?+jOHL1yPmbDHMGDrcmx/tZ7lrDsGDH5OjY5JvZEJ8Ezx+QCkRVK79qdi/TL0?= =?us-ascii?Q?p327LeLdH5LoA5wyWWeLSO8I1ss6FCrxwZHZ0uez+X9OlKnXAwhxyL0mWYql?= =?us-ascii?Q?4adjrfpg1Ii9KKcfxhgacLyiUu2cjxnxcd8qf30d+pQ4I3G+xsKJ6Z+FvRHQ?= =?us-ascii?Q?wfd8+y5PiULNU25Nh7YfrZUofN1g4yVevSq/FRLteUAnipzO2p6c7E0kAxf3?= =?us-ascii?Q?Q+xVhRdc/8RB9wSyTewaVXtHHAYEIQlKBg9MbXZ59V3RGWeThnjquNwiQbY8?= =?us-ascii?Q?dW82Hk8YMKVyy4pPCmkEBnYslr1+NC1n+5w1IyJv4IbONAL4K+FXTtEU/AZk?= =?us-ascii?Q?EdknHy0DK3l/nRFfuJvK7AIGPnJ39vblRRCV/zXsyN07NczKaMqOJZujh49D?= =?us-ascii?Q?cuWLD6KKMOB4bVDgPXp800qhFPMLxzCmdbpDfwFv9VO3makPecj2feMuQQAV?= =?us-ascii?Q?SGuOkpcsN1oqgz48VQDB6nSq+7ZGNSZ+I+D+vsCLUsowF4qWPd9gJiSo3WMb?= =?us-ascii?Q?trm3XKQdXkyS+2OUVhv+aFiUlwlQ0vyM0VETK1WhGT1RW70pJnELK0Dgwn/i?= =?us-ascii?Q?YI51W94arwtCDn/7IJPXPCto/oDmTX+J6B22hValcfucyfOzp1NUfpYDrOn7?= =?us-ascii?Q?Bp39KeXtXnlvAhfcxnXVpg=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB3187 Original-Authentication-Results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT055.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 3f663bc6-0b6c-4124-4d74-08d887c6cc1f X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: vGB6i+HCQFiEuTCRbyCu1Wbp/B7VlZMwp8tm36WLweWWQOYfJeSKpAR+vblRFeV4SzpcMD9Vy3idWC3XrXSQ37dShU02HAHQDh6a8fk28gTBlZGARh2C6+Ini1fb8slbiNbXoXhrwI1xskEziKRUQeDRTEKakpV1ZgGtExNLz0vogG2O6hhJ4WCeGpcuxAcIPrGm2jvii005Ykx+5tLZkuR2/TDOfHjmBEwxxSMxDiDYZKIpA0pjd9uNl3bd2HmTcwQRsZob6GI/ogFWkYFKPR2PPMZUDFY2JZawtoBmwXO4rioH21KLr6fYPbkJxRsApmQPPsRlZRWLg1X3ukruPri+rY6HTkScUXeCP2pV/GTPwTbKuCR/y4OSHiJQTAQHiK/KiYNHnXh3JFkgxQBstV3fGEHUsMnWwKHuT8kfiDScY57B6WRdYAjTWPi35+TyQ74s9Csgil0ygjjYDdHzlmH1kV922iRDDo+u1e7L7EA= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(6029001)(4636009)(346002)(376002)(136003)(39860400002)(396003)(46966005)(316002)(47076004)(15650500001)(81166007)(26005)(55016002)(9686003)(83380400001)(70206006)(5660300002)(70586007)(52536014)(2906002)(8676002)(356005)(86362001)(8936002)(110136005)(36906005)(186003)(4326008)(336012)(54906003)(82310400003)(966005)(82740400003)(107886003)(6506007)(478600001)(33656002)(53546011)(7696005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Nov 2020 11:25:23.4850 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 01868901-7cc1-4417-5a98-08d887c6cffa X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT055.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB6241 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Rebecca, Please find my response inline marked [SAMI]. With that changed: Acked-by: Sami Mujawar Regards, Sami Mujawar -----Original Message----- From: devel@edk2.groups.io On Behalf Of Rebecca Cra= n via groups.io Sent: 11 November 2020 12:18 AM To: devel@edk2.groups.io Cc: Rebecca Cran ; Leif Lindholm = ; Ard Biesheuvel ; Michael D Kinney ; Liming Gao ; Zhiguang Liu Subject: [edk2-devel] [PATCH v3 2/3] MdePkg: Update IndustryStandard/SmBio= s.h with processor status data Add a bitfield that describes the structure of the byte in the Status field of the SMBIOS Type 4 Processor Information table. Signed-off-by: Rebecca Cran --- MdePkg/Include/IndustryStandard/SmBios.h | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/MdePkg/Include/IndustryStandard/SmBios.h b/MdePkg/Include/Ind= ustryStandard/SmBios.h index 1ee01645679a..bb4a3a8dc0d3 100644 --- a/MdePkg/Include/IndustryStandard/SmBios.h +++ b/MdePkg/Include/IndustryStandard/SmBios.h @@ -875,6 +875,19 @@ typedef struct { UINT16 ProcessorReserved2 :6; } PROCESSOR_CHARACTERISTIC_FLAGS; +/// +/// Processor Information - Status +/// +typedef union { + struct { + UINT8 CpuStatus :3; // Indicates the status of the processor. [SAMI] Please use ///< doxygen comment style. [/SAMI] + UINT8 Reserved1 :3; // Reserved for future use. Should be set t= o zero. [SAMI] IMO, 'Must be set to zero' would be better. [/SAMI] + UINT8 SocketPopulated :1; // Indicates if the processor socket is pop= ulated or not. + UINT8 Reserved2 :1; // Reserved for future use. Should be set t= o zero. + } Bits; + UINT8 Data; +} PROCESSOR_STATUS_DATA; + typedef struct { PROCESSOR_SIGNATURE Signature; PROCESSOR_FEATURE_FLAGS FeatureFlags; -- 2.26.2 IMPORTANT NOTICE: The contents of this email and any attachments are confi= dential and may also be privileged. If you are not the intended recipient, = please notify the sender immediately and do not disclose the contents to an= y other person, use it for any purpose, or store or copy the information in= any medium. Thank you.