From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (EUR05-VI1-obe.outbound.protection.outlook.com [40.107.21.45]) by mx.groups.io with SMTP id smtpd.web11.202.1612909502383469738 for ; Tue, 09 Feb 2021 14:25:03 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=Na0Z2go3; spf=pass (domain: arm.com, ip: 40.107.21.45, mailfrom: sami.mujawar@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5QMW7HYpBMLNAnevKeqDr2kM+UeHN6+GIdYCuLrx1kA=; b=Na0Z2go3K8veXFJAZ1AkexM2bpTEjVSELKBHPL1uSdpOJpgGkCtc8MWyGMHvAj1YS/8Xhf3uIk5vjLN0OoHYRqqS2nTOVMoLq8aE469e7HiKJ9NDfQbiLnt0652Vg1rJ/YNr1nC8YMIECkl0uyzuxg3+Pmc56WH+qSp/rnuTC7I= Received: from AM5PR0402CA0015.eurprd04.prod.outlook.com (2603:10a6:203:90::25) by DB8PR08MB4122.eurprd08.prod.outlook.com (2603:10a6:10:ac::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3825.30; Tue, 9 Feb 2021 22:24:59 +0000 Received: from AM5EUR03FT040.eop-EUR03.prod.protection.outlook.com (2603:10a6:203:90:cafe::62) by AM5PR0402CA0015.outlook.office365.com (2603:10a6:203:90::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3846.25 via Frontend Transport; Tue, 9 Feb 2021 22:24:59 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT040.mail.protection.outlook.com (10.152.17.148) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3784.11 via Frontend Transport; Tue, 9 Feb 2021 22:24:59 +0000 Received: ("Tessian outbound 587c3d093005:v71"); Tue, 09 Feb 2021 22:24:58 +0000 X-CR-MTA-TID: 64aa7808 Received: from cc7447f78e2b.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 747FEB2A-0944-4EE7-810B-7E66B756001F.1; Tue, 09 Feb 2021 22:24:53 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id cc7447f78e2b.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 09 Feb 2021 22:24:53 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cNbAFzTq2v2tp4KcqBQlMimWPKdwrEye0JQWpLFjJcqJMsJCIlSeM5ypEgGXmmN42YaJbKfenQVUPaHMszt1E5xbQ0Onz5jzXwM72Q4L96SGNiAetfrqfXUkpwQ6n/iSRNqhWoTIeEdFoezAsClkNF4O8nP3mcZw4m31Wo1RAPcAICqABQemd+ylPQyRF6ZB5Rp2OLLSmJGK2nM6L+e97IGdWaDXwQjHd8OHpbDaLkwlqewokjvDFZsV0IpLo36Iiy+zxz3CzrTOiRDUutjZQ7EKbCMwFhEjX32lTqgjFOvHn8DZsyw4FVqdCdMUulTimXSNhw0Q1HdOw6Tx/rCfwg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5QMW7HYpBMLNAnevKeqDr2kM+UeHN6+GIdYCuLrx1kA=; b=X2YtEBnKFOXPMQ48u3vyJ98W9xCpjsr85tEeJ9tg9/QKwHqHdcXB/t4y4OGJZTaQZTxqJZzA6JHt8Uacil3En/ee3loyqpwXIw7nHZKlXNCYUYljrrTx1KIMp5fTVilkhQzvK8ibO2r3Yoh0ompDt7wpsyEu73UEIeKHeHmkWLAgd8sO7duoWWhxbLuxv3UTr9OSijoyEjm+exaMttWmBsAzxkeeuVBfeJDPvckaviUuxr9F+TjAvizi2KXrKxVwAYawaB/lEWRINcSjGs/NxfOw3QVp11JqMVLxZ7u24eeEvKAq6YLI8AM6syJOiq13Sy9VZgnLN5y/kXvWGdH+hg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5QMW7HYpBMLNAnevKeqDr2kM+UeHN6+GIdYCuLrx1kA=; b=Na0Z2go3K8veXFJAZ1AkexM2bpTEjVSELKBHPL1uSdpOJpgGkCtc8MWyGMHvAj1YS/8Xhf3uIk5vjLN0OoHYRqqS2nTOVMoLq8aE469e7HiKJ9NDfQbiLnt0652Vg1rJ/YNr1nC8YMIECkl0uyzuxg3+Pmc56WH+qSp/rnuTC7I= Received: from AM0PR08MB3091.eurprd08.prod.outlook.com (2603:10a6:208:60::10) by AM4PR0802MB2371.eurprd08.prod.outlook.com (2603:10a6:200:5d::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3825.23; Tue, 9 Feb 2021 22:24:45 +0000 Received: from AM0PR08MB3091.eurprd08.prod.outlook.com ([fe80::15bb:2d5c:ddab:ca8c]) by AM0PR08MB3091.eurprd08.prod.outlook.com ([fe80::15bb:2d5c:ddab:ca8c%2]) with mapi id 15.20.3825.030; Tue, 9 Feb 2021 22:24:44 +0000 From: "Sami Mujawar" To: "devel@edk2.groups.io" , "mikuback@linux.microsoft.com" CC: Ard Biesheuvel , Jiewen Yao , Supreeth Venkatesh , nd Subject: Re: [edk2-devel] [PATCH v1 1/1] StandaloneMmPkg/FvLib.h: Add EFIAPI to FfsFindSection() Thread-Topic: [edk2-devel] [PATCH v1 1/1] StandaloneMmPkg/FvLib.h: Add EFIAPI to FfsFindSection() Thread-Index: AQHW+eAnQmFkGGHGcEiq5Lu2OdBw+KpQbN4g Date: Tue, 9 Feb 2021 22:24:44 +0000 Message-ID: References: <20210203035215.458-1-mikuback@linux.microsoft.com> In-Reply-To: <20210203035215.458-1-mikuback@linux.microsoft.com> Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 40AF64235734AA45AB517427D7441986.1 x-checkrecipientchecked: true Authentication-Results-Original: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=arm.com; x-originating-ip: [109.145.9.160] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 312e6224-2756-4906-d176-08d8cd49893e x-ms-traffictypediagnostic: AM4PR0802MB2371:|DB8PR08MB4122: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:7691;OLM:7691; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: vsYHlN0NZlL9vWawlHdhYzxopiE25V20DTpKHQaCw7WIzkMRmeTOCCqbwA1LlGVXXxgMtghhhIm3yoTznIdrYeMcghcvlPsqvAETpbDXZUMwoqFzyto+jHodaJ6urSFNkiZxGdAX3co1oTnVFa1gUG21WQsghijsLEO3FMuHcWZyLJuUItogA3TD+S8lfFmyG+g9oewQ+7YqqR4e4C5p6Cbkl+StIphY8YrIbbpPgO6TkQQB61nQ3oB81oIpvNujXl05EvwzmHT58oIyzIQ0raolxh8F7OQFonD0YUC7cbotz9q6Ycj9VjdeUY+nvu2UCSrDJBUuD/3H+iBPcpxvN8Mj4SGvLTYNt36cdPIEplfIchYp9wbdb6HZsUL4PidBQXDD5Z5gysrGtUzxsSxmJcnCHlb0Tc3rL+SpZmnyOP87Va3y0nQpocVOVCQUdw9AY05KTyHeJjxnHdgunJ0kv1OXTOBnlatoANUkH8ZQ8cJ9PeyWfKEkQlAUON7ptd7ANMszM0s/pYMoqi4ybHIKW00OpckQSB3sIA+NeqekC5yLd4SCIKDm/dGcQIOGNjKbSvgzcz1tzvA7G+Gie1fKYqVHtlasBWZ0h8kklEOaegQ= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB3091.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(6029001)(4636009)(136003)(346002)(39860400002)(366004)(396003)(376002)(76116006)(2906002)(186003)(33656002)(83380400001)(66946007)(55016002)(4326008)(9686003)(54906003)(53546011)(71200400001)(5660300002)(86362001)(6506007)(316002)(66556008)(110136005)(66476007)(8936002)(8676002)(26005)(7696005)(52536014)(966005)(66446008)(478600001)(64756008);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?yknplluJsu2GsQFZBB+Eb2pcsLefvzL+FiH4O0BBm9rdLD+uqUKabF7a/uT4?= =?us-ascii?Q?jFVC9H+LokmBa9pRVpMjZRyxS0F8GBWBvLzAhG0aIHkZPkomF4EZOdnIagkj?= =?us-ascii?Q?k1Z1ZWfKQJn1K3CRBG9zyYI8bSnqzGbdDfXkJyRE3nTAtg1uQ0y2EyT+jYSn?= =?us-ascii?Q?HZml5A1cmJSCeEk0IuW+JgAkmsQpUhH4RlcJ7A6Mi79B+0C9wpxOPVgJwePP?= =?us-ascii?Q?kERGg9YU8b/mc5XaCap/0/qRofZJsj7nRHeQPDAiEqpT3UOXXJA2lkDaFuyY?= =?us-ascii?Q?bzLx1GGHgZT0cZJuFm6EVFh3xWwvgh4rEPIiKe4kcG6Uo6kE7B8m3skSUeQ+?= =?us-ascii?Q?Br/aoS+L498/38rWjrr2W/9UWcgjoH4aMgNIBJ0uAX415sjPW1XceFpWkeEm?= =?us-ascii?Q?PD8R/+ZUuOBGdVyggzILbwhwLSHZhX9QZK9HnOBOS77EekR3Y0PhcV83Cndq?= =?us-ascii?Q?yGMjf6i9XZu6oTxk0yuflef91R3a7i+/2O+eJuwP2Okt58nbykwpzojZvEvS?= =?us-ascii?Q?3MYK/VZdvH18BSqy3eBRVoXVeO4JbU2ixcLXg+T1+5jDDsuH/B1JdmMfCIik?= =?us-ascii?Q?vH9Cr1wJesXROmtJpQpUvF+/fuqHFIEyDYBhhTkudALLE/2YfhQZiiRNyQKF?= =?us-ascii?Q?KIzo9trscMMnHVPmR3+DUsyH4vQ8XUGMSfvIfq3lpuquT1LvaGvpIVv/CEtd?= =?us-ascii?Q?GoWC9XJU2RP1qs6hMP+mLIPD3HQ8xFaBxkAzYVe7oZcxdyzXMvTC3dEbUk/8?= =?us-ascii?Q?PBDL+IOYNQ+GeklhfLdPdbTttfhhOOmhXtraIQ4deKtLUb282VYt/hTAtPYP?= =?us-ascii?Q?2lCamE6JlVNFkoEdzCfqVJB5CqO6ePDbqxgm2CUYF2E4bU1R2nc8oMJxyWv8?= =?us-ascii?Q?r9c/2cC8Vy7dSwghPgjoYeXRLCKrQ1XIgb2iibScafBC7xB7CIM4eB3HPCaz?= =?us-ascii?Q?9p7BL6srbAfFMaeyfkEQs+3kD4oWlGy3Iw5V7nJRm0WSHFxHZHdibftx1Sqb?= =?us-ascii?Q?VsZFftheuDs5ln0kMOMQoM4ytN2E2MAR6oW5Psfi3E9ceO25sYrRAoG2NkwQ?= =?us-ascii?Q?gEQqyCW7ONHmDwrnizbEwRTbi8L6gDgyr8aGf2Qh09kFsOiCdcP1u3Dc5/c+?= =?us-ascii?Q?a/GXzPkaSewsu2Qs+fjLnLN6EtSPRZw6bEU9LqpKkE8I+L6HudxZNuap0KsR?= =?us-ascii?Q?XqMHImNY30eyRpPpDIySWmMySAh7s59fx8L8aYx3iWZloFH7gMP5IGo6UvLi?= =?us-ascii?Q?Qgk/7N9NrOfUjooHj1qsbOq6t8zidH5MFd/ne3MF5PzrABupV0Kpc6QgBawM?= =?us-ascii?Q?Cwbal5648d+5XRLc4SRcZAvS?= MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR0802MB2371 Original-Authentication-Results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT040.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 18807203-d341-49f1-b1b9-08d8cd4980c6 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: brRQDbZcXlxFDR7byK+QI66BMdP55pLGq0fs+WwVh+kKSSaAsOQXhpI4NE3Ea5QsJkWYrzEbKQ3ViLM0026VAoDPMrrlZ7gYyH7zaRAsHjsuWyOOFE+6n6JdXDvw85Tx3ORvlB3PGnziNiB8aA5HzYvgXMpnmw/qy58f7bXfp1xksYFvZRL3JmAGvUW2NnWdHlkgCVCe2io8FOB3shc0FgGdQiiuzWxQKwgiVE9H7bv+FrgWeScwdBOeSH8yXe8DoY9kKG70T4dTcZLDCe5hhMCbsUlNcFwfrKvnt36RsztbOSHur2RqrW3sOKJAKg3R4e7rj7Us6Y96Yrm/RhXncwubJ7vrucT5rIi7lKc0D2R71vDAc4RxXSwHVhIpUESd88nIdI3ZXnnlobP8ygMERhlc2gZSZu/MXPwzRWHZ43G+RvoyHrorbdIlNTFFTu0emA0Jz4OLzVHQx0r3wUBoY2S2382xtX9kTgAwgtLoD4Qcs5xH4nFps5Dg7XHhsK++CrxrXANGaRTjgNt/NNbgozOSTJrMPxLHLIA4o+XAJFXFIW2MhpLfHZ2es9uQsr+hYxgld3XuJm9fp5IuuxKgfvV6E2QyzbEWKsXiIPFe21Zb8hVIfwo6DmukSc0s+xE77KuP9H/iUZnBd1pRfWqxXioQr+/6A33gFqxeTylVqXXQ0XdqKJPGRC2H6wSknoisst0VaHQgbTGgeiH7L94o8DL3DidTpDvY5k8cKMKMUBI= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(6029001)(4636009)(346002)(39860400002)(376002)(396003)(136003)(46966006)(36840700001)(8936002)(53546011)(33656002)(81166007)(6506007)(2906002)(9686003)(110136005)(55016002)(36860700001)(4326008)(478600001)(186003)(86362001)(54906003)(316002)(70206006)(5660300002)(8676002)(47076005)(336012)(966005)(45080400002)(356005)(52536014)(83380400001)(70586007)(82310400003)(82740400003)(7696005)(26005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Feb 2021 22:24:59.1237 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 312e6224-2756-4906-d176-08d8cd49893e X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT040.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB4122 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Michael, Thank you for this patch. There must be something missing with the GCC5 settings for AARCH64 as this = problem does not get flagged.=20 However, this change looks good to me.=20 Reviewed-by: Sami Mujawar Regards, Sami Mujawar -----Original Message----- From: devel@edk2.groups.io On Behalf Of mikuback via= groups.io Sent: 03 February 2021 03:52 AM To: devel@edk2.groups.io Cc: Ard Biesheuvel ; Sami Mujawar ; Jiewen Yao ; Supreeth Venkatesh Subject: [edk2-devel] [PATCH v1 1/1] StandaloneMmPkg/FvLib.h: Add EFIAPI to= FfsFindSection() From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D3203 The EFIAPI modifier is present in the function definition in FvLib.c but missing in FvLib.h. Causes a GCC build error. Cc: Ard Biesheuvel Cc: Sami Mujawar Cc: Jiewen Yao Cc: Supreeth Venkatesh Signed-off-by: Michael Kubacki --- StandaloneMmPkg/Include/Library/FvLib.h | 1 + 1 file changed, 1 insertion(+) diff --git a/StandaloneMmPkg/Include/Library/FvLib.h b/StandaloneMmPkg/Incl= ude/Library/FvLib.h index c08e043cf65f..4ef2c8540a1f 100644 --- a/StandaloneMmPkg/Include/Library/FvLib.h +++ b/StandaloneMmPkg/Include/Library/FvLib.h @@ -50,6 +50,7 @@ FfsFindNextFile ( @retval EFI_SUCCESS **/ EFI_STATUS +EFIAPI FfsFindSection ( IN EFI_SECTION_TYPE SectionType, IN EFI_FFS_FILE_HEADER *FfsFileHeader, --=20 2.28.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D Groups.io Links: You receive all messages sent to this group. View/Reply Online (#71088): https://edk2.groups.io/g/devel/message/71088 Mute This Topic: https://groups.io/mt/80346397/1779659 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [sami.mujawar@arm.com] -=3D-=3D-=3D-=3D-=3D-=3D