From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=40.92.67.63; helo=eur02-am5-obe.outbound.protection.outlook.com; envelope-from=marvin.haeuser@outlook.com; receiver=edk2-devel@lists.01.org Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-oln040092067063.outbound.protection.outlook.com [40.92.67.63]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id CEA64211ADA2D for ; Thu, 3 Jan 2019 05:25:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=D9CMGCP0t8Yv4FmirawAjrqXTk5QuvMP3bEUHmEgVyc=; b=SBjze6XbdD9ztgKeLRyCiSdm9LgxWD0HHE2YZATYcCQlXksOGfOtoySDxjOPcFWMKMKU26adG3ouHFi81mHyEtY0Me6i0GK0NKYhfq9AEIqHnH5ZR3WcI1OHduUjXpSXWWnrZb+w3OXnmFHZ1jok+ZZ3KhdM0OwVs51jacswDAWVopzXF+Uf5+X+wf2cXwd6XYNtFPx8CDcUs0pF7V0rbg+WZvmsNDjRLeVz9t29MnECo9icoj7DrKMBhXth0Mw0yz9X5fkCfAIuWck/aioNGNanVGZFlXR+CYd056xO3KQOGcVsXFUKyaAT3fjuBEyLe8FynuANnIk9xS6vnZ/GSQ== Received: from VE1EUR02FT033.eop-EUR02.prod.protection.outlook.com (10.152.12.60) by VE1EUR02HT027.eop-EUR02.prod.protection.outlook.com (10.152.13.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.1471.13; Thu, 3 Jan 2019 13:25:07 +0000 Received: from AM0PR08MB3924.eurprd08.prod.outlook.com (10.152.12.52) by VE1EUR02FT033.mail.protection.outlook.com (10.152.12.99) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.1471.13 via Frontend Transport; Thu, 3 Jan 2019 13:25:07 +0000 Received: from AM0PR08MB3924.eurprd08.prod.outlook.com ([fe80::ac44:9373:b9e5:83ad]) by AM0PR08MB3924.eurprd08.prod.outlook.com ([fe80::ac44:9373:b9e5:83ad%3]) with mapi id 15.20.1471.019; Thu, 3 Jan 2019 13:25:07 +0000 From: =?iso-8859-1?Q?Marvin_H=E4user?= To: Laszlo Ersek , edk2-devel-01 CC: Ard Biesheuvel , Liming Gao , Michael D Kinney Thread-Topic: [PATCH 26/26] Revert "MdePkg: avoid __builtin_unreachable() on GCC v4.4" Thread-Index: AQHUow7qinOIwPIx5kiDuXXs+hws26WdiJWQ Date: Thu, 3 Jan 2019 13:25:06 +0000 Message-ID: References: <20190103024816.9236-1-lersek@redhat.com> <20190103024816.9236-27-lersek@redhat.com> In-Reply-To: <20190103024816.9236-27-lersek@redhat.com> Accept-Language: de-DE, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-incomingtopheadermarker: OriginalChecksum:42899F1C96DF1E4E5815905ADE972A0A14028359DF6A02140F119079FB39134C; UpperCasedChecksum:224820DAFB96B14C5A6EDF9CAC3031E2AC7F98F37CC67EC487A204664EF564A6; SizeAsReceived:7302; Count:47 x-ms-exchange-messagesentrepresentingtype: 1 x-tmn: [Mq3FfGvRAsQBhU+4ZLASTZAjhvp5yvLa] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; VE1EUR02HT027; 6:TDmAIyZdgk2S68b+BfQJdL7FIkCMlK6EhOAZBWPFvQPEm7vgvCQGlJypEKwoHOFCk1hd8OsJ+Pe5JUhTbCmZvjju6Tgd1qiZ9Toz/EsixvxzlXFNYXnHRvZPfH5gP43HSmwEvXJIyJGMB3JYNgew6B4D1GMDlsDHprvyRYmBWR+LgD0VY6N8SbJmONU7s3F4GhWCYkO2d16+eJMm4whjs3Cwl5C9m/GjklpsUgFs1ZGSLInfPf2m3VlUh/bw/THISL+YWX2DLNaH/lixqGVyfoKgH/UcWwFzjT4XFo2ApmymELdQ8L/qbNvknV1OjZcpke+0VjXD0ZjiN1+qmLE7/ITOmy7UTgQXKXBL6Rr/kU2ln49voMhWcYUo6bVWVLzagf770OnRZ3hVeud4IS6DimpX/tdj5vwu2G02WkAxSxlqoh0wFPMI7Fo9BGRqQGTocjKrubYLfqbOlZHrNwwT6g==; 5:6V5qKEfgXlIzXx/PLVDqOm/r6p2GtMu4LtxKj1FVZUmZC9RTDwR86U7xdJHFWJUSUAhkKz5oXfE5fI17nQ1dLjIxYVe4GuCpekXHKV8cCd907/96afG2hxulu+y1yseB9YyKzLP6obqaKWzQMNJLJr+9cIGGoQTuCkrOjM52Tjg=; 7:BnTWcxwfcRKj296SsZ6zlnpTKiOG4b/3eDXyCgpVNk68M0KE+WiJjwLt6hmFcUAiiAb/mItHBgHAMl+x/p33CaATHTcbV1xx9mWb1jahZiSt8BKYvLgkSf12h5bqjeHaZoJAldZBbrjXHDcRQ02/QA== x-incomingheadercount: 47 x-eopattributedmessage: 0 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(201702061078)(5061506573)(5061507331)(1603103135)(2017031320274)(2017031323274)(2017031324274)(2017031322404)(1601125500)(1603101475)(1701031045); SRVR:VE1EUR02HT027; x-ms-traffictypediagnostic: VE1EUR02HT027: x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(4566010)(82015058); SRVR:VE1EUR02HT027; BCL:0; PCL:0; RULEID:; SRVR:VE1EUR02HT027; x-microsoft-antispam-message-info: bdRoqUc7pisLaityPFA0awytiiFAmxsPfytuxIYnQxRXyTEBEOuNId/cOueHqOGU MIME-Version: 1.0 X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 7181d4b0-87d6-4f4e-ba33-0d3746212cec X-MS-Exchange-CrossTenant-Network-Message-Id: 019140c5-9338-49fe-1146-08d6717ee0c2 X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 7181d4b0-87d6-4f4e-ba33-0d3746212cec X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Jan 2019 13:25:06.9326 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Internet X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1EUR02HT027 Subject: Re: [PATCH 26/26] Revert "MdePkg: avoid __builtin_unreachable() on GCC v4.4" X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Jan 2019 13:25:13 -0000 Content-Language: de-DE Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: Laszlo Ersek > Sent: Thursday, January 3, 2019 3:48 AM > To: edk2-devel-01 > Cc: Ard Biesheuvel ; Liming Gao > ; Marvin Haeuser ; > Michael D Kinney > Subject: [PATCH 26/26] Revert "MdePkg: avoid __builtin_unreachable() on > GCC v4.4" >=20 > This reverts commit 357cec385d4f ("MdePkg: avoid __builtin_unreachable() > on GCC v4.4", 2016-07-21). >=20 > We've removed BaseTools support for GCC44..GCC47, therefore we need > not catch the GCC44 corner case for __builtin_unreachable(). >=20 > No GCC44..GCC47 references remain under MdePkg after this patch. >=20 > Cc: Ard Biesheuvel > Cc: Liming Gao > Cc: Marvin Haeuser Reviewed-by: Marvin Haeuser > Cc: Michael D Kinney > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1377 > Signed-off-by: Laszlo Ersek > --- >=20 > Notes: > I build-tested this change by building ArmVirtQemu with the GCC5 > toolchain (gcc-6.1.1), and OVMF with the GCC48 toolchain (gcc-4.8.5). >=20 > Namely, the PeiCore() function > [MdeModulePkg/Core/Pei/PeiMain/PeiMain.c] > and the DxeMain() function > [MdeModulePkg/Core/Dxe/DxeMain/DxeMain.c] > use UNREACHABLE(). >=20 > MdePkg/Include/Base.h | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) >=20 > diff --git a/MdePkg/Include/Base.h b/MdePkg/Include/Base.h index > bc877d8125a5..d6b04baeaf8b 100644 > --- a/MdePkg/Include/Base.h > +++ b/MdePkg/Include/Base.h > @@ -112,11 +112,10 @@ VERIFY_SIZE_OF (__VERIFY_UINT32_ENUM_SIZE, > 4); // warnings. > // > #ifndef UNREACHABLE > - #if __GNUC__ > 4 || (__GNUC__ =3D=3D 4 && __GNUC_MINOR__ > 4) > + #ifdef __GNUC__ > /// > /// Signal compilers and analyzers that this call is not reachable. = It is > /// up to the compiler to remove any code past that point. > - /// Not implemented by GCC 4.4 or earlier. > /// > #define UNREACHABLE() __builtin_unreachable () > #elif defined (__has_feature) > -- > 2.19.1.3.g30247aa5d201