From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 2F090AC10FF for ; Fri, 5 Jan 2024 11:52:49 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=xIsM3I+P2tb3gwwP7SVWuPx+JXuLOWi/O5v+4fsM2RA=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:Received-SPF:ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:Authentication-Results-Original:nodisclaimer:MIME-Version:Original-Authentication-Results:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1704455568; v=1; b=XmoIhh3A7w/8r4AABFXeUkk3Ucq5Ozog1Wc+SQqAKq9i+WT3YpjgsJFpIi8h8wbli+Z7gr5M I28lCb1PStBIYGMp5yxJ0YFROTkvLLNx8pnDylu/JoRu6w0ObYZF8n25TTj+fDCARZ2vf/j0sjQ UT2et2HeaukR6SL045tqGTog= X-Received: by 127.0.0.2 with SMTP id uXvpYY7687511xSugl8uufED; Fri, 05 Jan 2024 03:52:48 -0800 X-Received: from EUR04-HE1-obe.outbound.protection.outlook.com (EUR04-HE1-obe.outbound.protection.outlook.com [40.107.7.41]) by mx.groups.io with SMTP id smtpd.web11.21819.1704455567733301994 for ; Fri, 05 Jan 2024 03:52:48 -0800 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=GKJeOtaoY46n01ZljBOxlUxUeUF/uQfdP/J1FizkSxlOUMv875l38QMIglJfBjbMkOUKinn7WGIegT5O1BeZ+gQnOiwBGUNjj8+vBNuENNCe0NWA7wF26ehaH2+ReR9Me9jvAXhnqhPWviPqvnXVyjffRCNGHsL0xA+3MjWy2O7RpisIC7bxnU6e8wOsHpogVPKgGPQjU7EJqlz5OABknamaB46eUdAIx9kGNJ4Sgi+UGlVE4qoi1U4FFroiLyT0ZrivwsRwKE8XnC9kpjg8aGHsVOaAC91XwOsF3fRe7em8envZ5fr7kRhmvCNq7UprEruMhDlj2t446SQ5vM+bKg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Tldxbp4NLf4vXHiWdiRNDf7SFWJrcecWAlU4AyjtQmI=; b=DnmtXsu8R3H+k1EepCLI+FmDc83UGYoBL6QXlchFZHoXKOkGgcUKtr5NnglVNSUhWI1xltHMi9J40RjOmZyh9WCipxC9VCaefwpRcSgcHk3SIL9xXjn2o7asFwjeg1971lIh2aiLrgTbE1Wf3vNvS0W1pR2Osj0YccsmXsMFHJR1i/1/eg1Bgnye4P6ExpLKaCHXaoi9Wuog04NKIMUYbdUs15bv84rC41ltzeD9nafcfmA7bK/9XKJNtwP2+LBfeHujIreeraHwy7BEzazPP7i1Fuedz+IOrimxXOYp/+C2O7s+vu9xf1nTxgR2+algQc9+hy4AZ5GCP7foIFTU6g== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) X-Received: from DUZPR01CA0181.eurprd01.prod.exchangelabs.com (2603:10a6:10:4b3::22) by DB4PR08MB9333.eurprd08.prod.outlook.com (2603:10a6:10:3f6::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7159.16; Fri, 5 Jan 2024 11:52:43 +0000 X-Received: from DB5PEPF00014B8A.eurprd02.prod.outlook.com (2603:10a6:10:4b3:cafe::f6) by DUZPR01CA0181.outlook.office365.com (2603:10a6:10:4b3::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7159.17 via Frontend Transport; Fri, 5 Jan 2024 11:52:43 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5PEPF00014B8A.mail.protection.outlook.com (10.167.8.198) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7159.9 via Frontend Transport; Fri, 5 Jan 2024 11:52:42 +0000 X-Received: ("Tessian outbound 3dfbe14a1a3c:v239"); Fri, 05 Jan 2024 11:52:42 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: abdb5ef708663ac8 X-CR-MTA-TID: 64aa7808 X-Received: from 92ccb6c66bf6.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 1D5B0B4C-A990-40CF-8FDE-0CF6BDF99EE7.1; Fri, 05 Jan 2024 11:52:36 +0000 X-Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 92ccb6c66bf6.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 05 Jan 2024 11:52:36 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XNrjrc2/qBtRdM5FvTBl14p1d+fOnEO6Gi76ndkL+aFQTpsO4wFcSFFetoBpZZV/TXcxBEKcQ7LM0LjTjDwP6nEt9LuYGAvwhUQfuLqTrwLt1g8BoFmAiBEHLjfJwh30een2cAtwU6SEazOBSdlpPQY8M1SIVG7XX0YXbpvKrlXSrqagLIXctd6zu+Ti24hlT02aUdB67eNkDWf9QF48/13uzUeg9zgjJfGSJm/OmJ46+QlGoIJat062dvlc9k3jgPAuMJ7IPfHHa5SyvFnOcbPPmJ2aY/2g3sI7cVpXcmWz9R37GGgW3X42SkWqtAPZ1rbRrB0a40rIuQ3L3D8SNQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Tldxbp4NLf4vXHiWdiRNDf7SFWJrcecWAlU4AyjtQmI=; b=YjdbRUELMQHHPkZHvQWZdHIH4MRxApTyGnnwLHDdUNfdDp1VCG7JFMU5wBPCXHvE80dW4GhI2ijieqiyNIAiQ9KIICxsp5rMEnvQjtMhkVmJV6M1ldHXuE17qzsueznV8KVwSLhXVNnGRe1eGT/BZi18IphDwaKl18hsm2r282F9hg2jvH4DqqSH20ONWXZz611EKo2PWRGC7iGEvPyt/F5athgGB4m4MtAzjj2Tt38WIX14+8DNi2kuvnNGzvp6mmw2545rGV/iCein1Gkvl2VUNcgn1rLjsK06S25OcblqR0tTSDi2ja4Mw0J2mEdzhvY37WS2hMMQ3Q6i0mbU3g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none X-Received: from AM0PR08MB4289.eurprd08.prod.outlook.com (2603:10a6:208:148::12) by PA4PR08MB6016.eurprd08.prod.outlook.com (2603:10a6:102:e3::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7159.16; Fri, 5 Jan 2024 11:52:33 +0000 X-Received: from AM0PR08MB4289.eurprd08.prod.outlook.com ([fe80::50d8:8f44:8189:811f]) by AM0PR08MB4289.eurprd08.prod.outlook.com ([fe80::50d8:8f44:8189:811f%7]) with mapi id 15.20.7159.015; Fri, 5 Jan 2024 11:52:33 +0000 From: "levi.yun" To: "devel@edk2.groups.io" , Ard Biesheuvel CC: Sami Mujawar , Pierre Gondois , nd Subject: Re: [edk2-devel] [PATCH v1 1/1] StandaloneMmPkg: Initialise serial port early in StandaloneMmEntryPoint Thread-Topic: [PATCH v1 1/1] StandaloneMmPkg: Initialise serial port early in StandaloneMmEntryPoint Thread-Index: AQHaP81Hf1Dbor0epEaChKgCUYhJTrDLG3Ll Date: Fri, 5 Jan 2024 11:52:33 +0000 Message-ID: References: <20240105114931.844886-1-yeoreum.yun@arm.com> In-Reply-To: <20240105114931.844886-1-yeoreum.yun@arm.com> Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM0PR08MB4289:EE_|PA4PR08MB6016:EE_|DB5PEPF00014B8A:EE_|DB4PR08MB9333:EE_ X-MS-Office365-Filtering-Correlation-Id: ce993c2f-97c5-477c-8b1c-08dc0de4d343 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: KjsssTbc2XcirYEo7HoBR1fJolTOl6ijsUN4vuMFZB6r/T0HJQIavvjWlLX7SngaHfj6ykCCOSCrUgoXpkuo+oYMY+oYxr1C+nlCOqujwu8FhagtwY5zdloMOHVdZqbVzb1iBX2y4Xr8PYg0b0FhMmOH80PYYXftAwdt97mJAStaoXNREpvh5+00mUXsew9vgb0XXELTlC2Y3BdkPk7cMeWb4h7AEW84WYpizSgDaKCu0MKTz0VDpntN0ypXZ2srT1RAS0BpT6A7UawdlrqosBIxy5beFIhf01wRu6YoyouAa20vCS79H92H2B5RcpYhsUcJHAf923pZ4NOyTYkXy3zO8ogIeD+g+mwTj2Aqk+JIv6juP8dr9Gl0XQORVnf+a6olYFXrFA9xDPjTsxn/2tFM6ryYrU3b0ubkAc91xRCTNUxLzV3vIa4mxXjurwsQqdhXvowwcb3/AAyxbh94do6vlYlQ/pxGbbl21vqjMIKapXrfpCGt7NEXpZ0dRP7OzylpWByE1ooklZZ5yhONYWky4smwN2/Ydxx876FhReq3kMKrlBSRIymgHFeGpjai6Q+ifD3OVoQ7KsdAkM9GUFryKGFs8P2RATMyUkXZPSU= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB4289.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(6029001)(346002)(39860400002)(376002)(366004)(396003)(136003)(230922051799003)(64100799003)(451199024)(1800799012)(186009)(76116006)(66556008)(66476007)(66446008)(64756008)(66946007)(38100700002)(122000001)(8676002)(9686003)(55016003)(6506007)(71200400001)(7696005)(86362001)(53546011)(26005)(5660300002)(2906002)(91956017)(966005)(478600001)(33656002)(83380400001)(110136005)(54906003)(316002)(8936002)(52536014)(4326008)(38070700009)(41300700001);DIR:OUT;SFP:1101; MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB6016 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5PEPF00014B8A.eurprd02.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 73db3d43-d2ea-4c23-2bd2-08dc0de4cd94 X-Microsoft-Antispam-Message-Info: OfcVYXvA/EZL5zhiv8bebdJBFsXv8hdK4BF956PyMAWtO2uRiSeai1wR5n4MLCN1yWXORcqNo27bYdnk/pC+Xvs88g/q2plaCwy/FKpQu+9dvtNZeiS4469teG631elaxHcxDfpKKZphX5fI+//5u6W25lt90Vw7HxVVJ4O9PX3YS/E7o1OKOQS1Nc1cN6PP5e1d7bzt1OxZtwk6Pd63scnWYP+bgDwyRCpuecPBcLYZtz0s7FMbYHiNhJdTuSinQKWywhaozSsOmAzjfl5QTMDyDY0nTlycAIkEqvzdF0edSUxkA0emUScefKuzSLDJmj8Vr3vaSaxvPXkf5bf044iYyVmJLMe407dUIpf05WOQ5w9Tj05/CEMrKqgQU9S5T8I3j3eDRXE4tP6l5J98PQR9RV/hsFB+hekC/z0a6yQHoVpAenr+uIf1e4i29wK+RDjd2diy2sdf1jTIMfUZg5nshwz8PWP51xojhOidonphprD0E2UFa3wW/ZFZmqIICDa2WmS/dKYHRIhtB62nkc7ibak9Wd+8a+DlSFANQkznLmisBXmqqNJyXIo8jSI90nkiC3ukQtZ1Z+egCgY/2Um8sdYVSw9B18l80wvEQipn+vV+PnDTm5E2YXAoZH4Spgb8Wx/Tm8HHpfMEF09GFVyf7XMlN95AlLXHXMixCrapUXUiMp7LDoG0TZgpRzvE X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jan 2024 11:52:42.7891 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ce993c2f-97c5-477c-8b1c-08dc0de4d343 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5PEPF00014B8A.eurprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB4PR08MB9333 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,yeoreum.yun@arm.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 9YfaEgBtl4Y3G4AaGBFVbO0Tx7686176AA= Content-Language: en-GB Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=XmoIhh3A; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=arm.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io + ardb+tianocore@kernel.org ________________________________________ From: levi.yun Sent: 05 January 2024 11:49 To: devel@edk2.groups.io Cc: Yeo Reum Yun; ard.biesheuvel@linaro.org; Sami Mujawar; ray.ni@intel.com= ; Pierre Gondois; nd Subject: [PATCH v1 1/1] StandaloneMmPkg: Initialise serial port early in St= andaloneMmEntryPoint Serial port used by the DEBUG macro is initialised in StandaloneMmMain by the DebugLib constructor. When we use a serial port initialised by TF-A it is not a problem. However, if we use a serial port that is not initialised by TF-A, the debug log prints hangs. Therefore, initialise the serial port early on in the entry point. Signed-off-by: levi.yun --- These changes can be seen at https://github.com/LeviYeoReum/edk2/tree/levi/2956_init_serial too. StandaloneMmPkg/StandaloneMmPkg.dsc = | 1 + StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/StandaloneMmCoreEntryPo= int.inf | 1 + StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/Arm/StandaloneMmCoreEnt= ryPoint.c | 3 +++ 3 files changed, 5 insertions(+) diff --git a/StandaloneMmPkg/StandaloneMmPkg.dsc b/StandaloneMmPkg/Standalo= neMmPkg.dsc index 8012f93b7dcc38ea8fdd2de98912bbc09157ec53..040a4aa5b3d268fdfaaec9a975c= fc6ff31aa37b4 100644 --- a/StandaloneMmPkg/StandaloneMmPkg.dsc +++ b/StandaloneMmPkg/StandaloneMmPkg.dsc @@ -66,6 +66,7 @@ [LibraryClasses.AARCH64, LibraryClasses.ARM] ArmSvcLib|ArmPkg/Library/ArmSvcLib/ArmSvcLib.inf CacheMaintenanceLib|ArmPkg/Library/ArmCacheMaintenanceLib/ArmCacheMainte= nanceLib.inf PeCoffExtraActionLib|StandaloneMmPkg/Library/StandaloneMmPeCoffExtraActi= onLib/StandaloneMmPeCoffExtraActionLib.inf + SerialPortLib|MdePkg/Library/BaseSerialPortLibNull/BaseSerialPortLibNull= .inf NULL|ArmPkg/Library/CompilerIntrinsicsLib/CompilerIntrinsicsLib.inf NULL|MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib.inf diff --git a/StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/StandaloneM= mCoreEntryPoint.inf b/StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/St= andaloneMmCoreEntryPoint.inf index 75cfb98c0e75cd7cee2a59723035679612da4528..086639ecfbc983627aed7381781= 5e2485104375e 100644 --- a/StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/StandaloneMmCoreEn= tryPoint.inf +++ b/StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/StandaloneMmCoreEn= tryPoint.inf @@ -42,6 +42,7 @@ [LibraryClasses] DebugLib [LibraryClasses.ARM, LibraryClasses.AARCH64] + SerialPortLib StandaloneMmMmuLib ArmSvcLib diff --git a/StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/Arm/Standal= oneMmCoreEntryPoint.c b/StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/= Arm/StandaloneMmCoreEntryPoint.c index 96de10405af829c66e3f43ed4692f785d8df113e..66b56bdfe4959d5ab6152ff024c= aa6e900e7a948 100644 --- a/StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/Arm/StandaloneMmCo= reEntryPoint.c +++ b/StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/Arm/StandaloneMmCo= reEntryPoint.c @@ -335,6 +335,9 @@ _ModuleEntryPoint ( UINTN TeDataSize; EFI_PHYSICAL_ADDRESS ImageBase; + // Initialize the Serial Port early to print debug log before Standalone= MmMain. + SerialPortInitialize (); + // Get Secure Partition Manager Version Information Status =3D GetSpmVersion (); if (EFI_ERROR (Status)) { -- Guid("CE165669-3EF3-493F-B85D-6190EE5B9759") IMPORTANT NOTICE: The contents of this email and any attachments are confid= ential and may also be privileged. If you are not the intended recipient, p= lease notify the sender immediately and do not disclose the contents to any= other person, use it for any purpose, or store or copy the information in = any medium. Thank you. -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113277): https://edk2.groups.io/g/devel/message/113277 Mute This Topic: https://groups.io/mt/103540969/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-