From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id AC9079417C4 for ; Mon, 11 Mar 2024 14:29:20 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=Qehrpxo7/qGOAVbQYRe+kXQ4iieW56ZR0J3l0cEFSdA=; c=relaxed/simple; d=groups.io; h=Received-SPF:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:Authentication-Results-Original:nodisclaimer:MIME-Version:Original-Authentication-Results:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1710167359; v=1; b=ZYR2uD5BaoleeLgo3ygAiqKGW7GmDSZBQrtnhn+mcNjx+3vCDRc9j/dV4YxOr1qTXeZHJ3fh OiZuZ8ZKGQk4a7pMIzXKwEa+Nlk9KkBhNYadU24CX4gtADaVSm2AMf5WjEpi2JT7QakOW3ypSFQ h25DT5O7pS2NWoQkfbn3d7xzuD4UVRGN7i7PeK11A10T7G34TiF9U+AavVDVx11q83P1Q6/LTLU 9xPXqHBGV6RHlsOIKFiH4OV76bk+uQp0lz3kNk1az5B8XiEqCg4WIMwzkzrwK1uh6MEYszZDRkk i7yJZZe4tz6UhkoQSnLVMgruRVK/uala+qLVpsMEQWfow== X-Received: by 127.0.0.2 with SMTP id 6K7XYY7687511x73zwpezStm; Mon, 11 Mar 2024 07:29:19 -0700 X-Received: from EUR01-HE1-obe.outbound.protection.outlook.com (EUR01-HE1-obe.outbound.protection.outlook.com [40.107.13.85]) by mx.groups.io with SMTP id smtpd.web11.64344.1710167358440501516 for ; Mon, 11 Mar 2024 07:29:18 -0700 X-Received: from DU2P251CA0019.EURP251.PROD.OUTLOOK.COM (2603:10a6:10:230::26) by AS8PR08MB6167.eurprd08.prod.outlook.com (2603:10a6:20b:298::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7362.35; Mon, 11 Mar 2024 14:29:15 +0000 X-Received: from DB1PEPF000509E8.eurprd03.prod.outlook.com (2603:10a6:10:230:cafe::af) by DU2P251CA0019.outlook.office365.com (2603:10a6:10:230::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7362.35 via Frontend Transport; Mon, 11 Mar 2024 14:29:15 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB1PEPF000509E8.mail.protection.outlook.com (10.167.242.58) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.12 via Frontend Transport; Mon, 11 Mar 2024 14:29:14 +0000 X-Received: ("Tessian outbound 5fdc1e2b2c35:v276"); Mon, 11 Mar 2024 14:29:14 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: e1884d30e90005ec X-CR-MTA-TID: 64aa7808 X-Received: from d3f7abc2d4b7.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id D9B30E8B-1C95-4D4C-AC70-A05D6DF0F78B.1; Mon, 11 Mar 2024 14:29:08 +0000 X-Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id d3f7abc2d4b7.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 11 Mar 2024 14:29:08 +0000 X-Received: from AM0PR08MB4289.eurprd08.prod.outlook.com (2603:10a6:208:148::12) by GV1PR08MB8107.eurprd08.prod.outlook.com (2603:10a6:150:94::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7362.35; Mon, 11 Mar 2024 14:29:05 +0000 X-Received: from AM0PR08MB4289.eurprd08.prod.outlook.com ([fe80::4a5d:48:bf49:a524]) by AM0PR08MB4289.eurprd08.prod.outlook.com ([fe80::4a5d:48:bf49:a524%7]) with mapi id 15.20.7362.035; Mon, 11 Mar 2024 14:29:05 +0000 From: "levi.yun" To: "devel@edk2.groups.io" , Prabin CA CC: Ard Biesheuvel , Leif Lindholm , Sami Mujawar , Thomas Abraham Subject: Re: [edk2-devel] [edk2-platforms][PATCH v5 2/9] Platform/Sgi: Update the datatype of PcdSmmuBase from u32 to u64 Thread-Topic: [edk2-devel] [edk2-platforms][PATCH v5 2/9] Platform/Sgi: Update the datatype of PcdSmmuBase from u32 to u64 Thread-Index: AQHac7ZhO+Epd/M7TUGFyETyMFy1ALEymYNr Date: Mon, 11 Mar 2024 07:29:18 -0700 Message-ID: References: <20240311131416.823580-1-prabin.ca@arm.com> <20240311131416.823580-3-prabin.ca@arm.com> In-Reply-To: <20240311131416.823580-3-prabin.ca@arm.com> Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM0PR08MB4289:EE_|GV1PR08MB8107:EE_|DB1PEPF000509E8:EE_|AS8PR08MB6167:EE_ X-MS-Office365-Filtering-Correlation-Id: df99c264-3647-42ff-80a4-08dc41d7a0a4 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: GbgokTHkZFPQd2cHkYGHZ31YfqR1Rs1TV+UJQCBxSd7rM2bPe8nHqfet5c8+iSk1xefq08kAjvwlq+R8luEfwTA7MrriR8PzammNdxss8o3jHNHlCLmtg1L4LIESi/UimfgOODMNLGb8G7N9RDkgpwS8tYfyJvSjOVps5PkmkeeM4OYqUlfoGJrQjyWDS5DcS458nmS2CI8zT7ME3tMRRb4gWSrX90jwudn+wOQ4cTxFAbEji1qIyB1Uui/YLB2p1jTgbort+1KhQYI/XefVeUAiROOCKvQemReAnrpcs4IJOktG3qyg9j0vqsQB2z9jPTIyTTc9RI5ZO/Aetniz9YyCKBrSO3NsDwgNckedMB54tAcYSuKxqf8bqncJLUcJ3IqKLpHGS9bftRTXV4PLZM7Bfde55NCYvjU5levMeX7oCH7oMZ2ezzlrL23SHHYmo3jmKvoB17gGD+i0t4UKEt4LbF1APD6e4XEhMCQp6DnLHvu7LcnDjY5KFAIu5FbDxiIkjjgcp0jZKFH4wbJwCg1yg0zyVhvWAEi/b3gpT4u0Vm6VHn1wKQe5qf1RwzHyj9Yd3pTiyMh8fiWJqgrZAS1DXMb8UIwSXD9pSsfar1GSenpUYG4Cod/uT2WcPmzFEH2QHlmnI/mDJzSVlHdaZNRn2weXC2F0reiBhcNBNe/DpAONWRYwMTuRhxVHUN2w X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB4289.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(1800799015)(376005)(38070700009);DIR:OUT;SFP:1101; MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB8107 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB1PEPF000509E8.eurprd03.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: bbd4b70d-7d64-44e3-de39-08dc41d79b2d X-Microsoft-Antispam-Message-Info: 0hXoFDbnmhvmfufsbdCynmQIhM6Ydfc6EwyP8Fw6SGpXfYAQ8cIcKC6FYE7FY+B47QtWkDuQAGrBBLJ+DIVCJ1yM6hiTLMxI31X5K/W54tMIZQSc9dWPBNTF8IUH0S/q5Cd/pamCQTkvlFTYFiZrIbSD/bWbCa56Z1vHzBYNqHMmnmOwYCHlhqzImNbIQT5ZDNzQkupCPbfAeRr6KwEAaKUAPkdJddq54xjTbimU4D2Zp8BcEhMJ6qq/5hikA8OVENdQB8R2uxpLOGppXTiymzYF5YMnEaQCfTHv9tPMbj236Jd1hE6uRwOhvTnFti1+86RJrjVKLB/ZcolKZNIDZ0f3Ps3r2+CrO1aqcubAVKqaXkb4qnQO3SzL4rzfxpC/BbWY7Nyz2aNHhjQ59b9PZRwoaE236Iygi2zJBcypMEi5QQssTLGEhqOZMegzRXpSUpYrnKgVgLu4ROWIoylOqgzOx9biMziR1ui5qpL6Z4mMTVtgxFJT5LNVlimequjudsnadEQPcb/vxvJQ8FrmWKt4rB7ItPmrsELFC/IHGDWUJF3oYyzNtp902v/8UgwoCCOGqvF8Ns7+PFbpZwd8+dcXHhB4gVzk1RjFFDaO8tqWkbnevsIl8ed1f5mtb/tgB/0JJZAcOFW0L+DQaGiWxGw+h020jsGWFTCE6ZkrHzN7W56xQNh9zDe0Gve9e6NC6mAd5sh+TN1CESPHL6ttlA== X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Mar 2024 14:29:14.8521 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: df99c264-3647-42ff-80a4-08dc41d7a0a4 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB1PEPF000509E8.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6167 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,yeoreum.yun@arm.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: IfvI1ZBPMcpdMdRSKxk6bmZ4x7686176AA= Content-Language: en-GB Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=ZYR2uD5B; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=arm.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Reviewed-by: levi.yun ________________________________________ From: devel@edk2.groups.io on behalf of Prabin CA vi= a groups.io Sent: 11 March 2024 13:14 To: devel@edk2.groups.io Cc: Ard Biesheuvel; Leif Lindholm; Sami Mujawar; Thomas Abraham Subject: [edk2-devel] [edk2-platforms][PATCH v5 2/9] Platform/Sgi: Update t= he datatype of PcdSmmuBase from u32 to u64 From: Vivek Gautam On RD-N2 and previous generation platforms, the base address was within 32-bit region. However, on upcoming platforms, the SMMUv3 base address is beyond 32-bit address region. So, update the datatype of SMMUv3 base PCD. Signed-off-by: Prabin CA --- Platform/ARM/SgiPkg/SgiPlatform.dec | 2 +- Platform/ARM/SgiPkg/Library/PlatformLib/PlatformLibMem.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/Platform/ARM/SgiPkg/SgiPlatform.dec b/Platform/ARM/SgiPkg/SgiP= latform.dec index 103dff8471a7..4087ff6cad2e 100644 --- a/Platform/ARM/SgiPkg/SgiPlatform.dec +++ b/Platform/ARM/SgiPkg/SgiPlatform.dec @@ -79,7 +79,7 @@ [PcdsFixedAtBuild] gArmSgiTokenSpaceGuid.PcdWdogWS1Gsiv|0|UINT32|0x00000014 # SMMU - gArmSgiTokenSpaceGuid.PcdSmmuBase|0|UINT32|0x0000001D + gArmSgiTokenSpaceGuid.PcdSmmuBase|0|UINT64|0x0000001D gArmSgiTokenSpaceGuid.PcdSmmuSize|0|UINT32|0x0000001E # GPIO Controller diff --git a/Platform/ARM/SgiPkg/Library/PlatformLib/PlatformLibMem.c b/Pla= tform/ARM/SgiPkg/Library/PlatformLib/PlatformLibMem.c index fa3cfbc730f6..62c212f3c5b0 100644 --- a/Platform/ARM/SgiPkg/Library/PlatformLib/PlatformLibMem.c +++ b/Platform/ARM/SgiPkg/Library/PlatformLib/PlatformLibMem.c @@ -1,6 +1,6 @@ /** @file * -* Copyright (c) 2018-2023, ARM Limited. All rights reserved. +* Copyright (c) 2018-2024, Arm Limited. All rights reserved. * * SPDX-License-Identifier: BSD-2-Clause-Patent * @@ -167,8 +167,8 @@ ArmPlatformGetVirtualMemoryMap ( VirtualMemoryTable[Index].Attributes =3D ARM_MEMORY_REGION_ATTRIBUT= E_DEVICE; // Sub System Peripherals - SMMU - VirtualMemoryTable[++Index].PhysicalBase =3D FixedPcdGet32 (PcdSmmuBase= ); - VirtualMemoryTable[Index].VirtualBase =3D FixedPcdGet32 (PcdSmmuBase= ); + VirtualMemoryTable[++Index].PhysicalBase =3D FixedPcdGet64 (PcdSmmuBase= ); + VirtualMemoryTable[Index].VirtualBase =3D FixedPcdGet64 (PcdSmmuBase= ); VirtualMemoryTable[Index].Length =3D FixedPcdGet32 (PcdSmmuSize= ); VirtualMemoryTable[Index].Attributes =3D ARM_MEMORY_REGION_ATTRIBUT= E_DEVICE; -- 2.34.1 -=3D-=3D-=3D-=3D-=3D-=3D Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116614): https://edk2.groups.io/g/devel/message/116614 Mute This Topic: https://groups.io/mt/104862627/7717249 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [yeoreum.yun@arm.com] -=3D-=3D-=3D-=3D-=3D-=3D IMPORTANT NOTICE: The contents of this email and any attachments are confid= ential and may also be privileged. If you are not the intended recipient, p= lease notify the sender immediately and do not disclose the contents to any= other person, use it for any purpose, or store or copy the information in = any medium. Thank you. -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116638): https://edk2.groups.io/g/devel/message/116638 Mute This Topic: https://groups.io/mt/104862627/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-