From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id D5833D8042B for ; Wed, 1 Nov 2023 11:44:22 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=NJfwI0UP73eLd5czSRv6w+I/ghMRQ1wAbT5lhksyiqI=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:Received-SPF:ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:Authentication-Results-Original:nodisclaimer:MIME-Version:Original-Authentication-Results:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1698839061; v=1; b=d4JrNySklfwjTIqkoAJVqcJU9t5+XsWsceK3KnGyQuoF42eCGnhkLUP7qkF/GVwssxhFszAY vxWMPyjb8x/FsPMOoHx6gSnGaqjN4aJLdaNSSlIUvjSXGMaXOftCDfhfey9g/QgmAlNflEJQt/t JJh2Te6No71+dl+FbZJOOICw= X-Received: by 127.0.0.2 with SMTP id D1XvYY7687511xQvDmabLza8; Wed, 01 Nov 2023 04:44:21 -0700 X-Received: from EUR04-VI1-obe.outbound.protection.outlook.com (EUR04-VI1-obe.outbound.protection.outlook.com [40.107.8.77]) by mx.groups.io with SMTP id smtpd.web10.4938.1698839060162249154 for ; Wed, 01 Nov 2023 04:44:20 -0700 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=Iigqwx1sBMhI6zR1Pix8mM3zLtg5uZoZ2HZt9auqszy7Yl4o1touxyhLHVpCoznrn/ARghWRdA1l0FI/5cpLateIeN0Uu/oKzcUuMjQmPdKCEypz6qJhfagMKGJTSuOiqqCoi1t/SZpXjnX9aavvKryaMloeVAOgwTpERj6o3XlriJXoVdReBTUPCUPcJQzJg05lJjXqqBuiynsUw+DwtlV3wK/Ed3QxtsX5kTwu4yhctkofwgopLOzQ8yahRdoRMyTPm1S14l76GFNjbUIoR8eGJLIJoaSvlXusVqRXLmNHFTviHfJ8aFOWtsLfN10qCwBkEb/ZWEC0/+2hT6T+Bw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=J57q4HdY/fTFtd4ntwXVpHdZNTYS5QsRMfRr5eI3//g=; b=T+HyxTe2LCYdNGHrjKirpi3ZjQpsEzb8PEdx7TsgydcydmNedRKtla1ZsQz6gHkCdNp4Ok7lPVtbyQiXowbb8AuimmI8dbapMVDVjuCEePPdiPfVfaxST8hUSgqWqXPITjDdxcsCHSIBUXLLbB5/mKlbXVTw34wUvI6d4gQazZH6W1n+nB6Lvw7rVerbohwnVywYXlSe/0kOJjPjMWkio5d3Pvl51A0mXm/gMBTlqcaay5UCwe8E6oGaILSmo8c1lbXv9WXwvt8UqJf1gjH2eWT5gbLukfQaJnXl64ITYZx6T0gnXbpTbR9ZjDOR0PBQ+dIehRmeY0G6CgOARteOjw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) X-Received: from AM0PR08CA0027.eurprd08.prod.outlook.com (2603:10a6:208:d2::40) by AM9PR08MB6050.eurprd08.prod.outlook.com (2603:10a6:20b:285::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6933.19; Wed, 1 Nov 2023 11:44:14 +0000 X-Received: from AM4PEPF00027A65.eurprd04.prod.outlook.com (2603:10a6:208:d2:cafe::aa) by AM0PR08CA0027.outlook.office365.com (2603:10a6:208:d2::40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6954.19 via Frontend Transport; Wed, 1 Nov 2023 11:44:14 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM4PEPF00027A65.mail.protection.outlook.com (10.167.16.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6954.19 via Frontend Transport; Wed, 1 Nov 2023 11:44:13 +0000 X-Received: ("Tessian outbound 26ee1d40577c:v228"); Wed, 01 Nov 2023 11:44:13 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 4a43a22db913ba00 X-CR-MTA-TID: 64aa7808 X-Received: from d69d1eab6510.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 70652089-EF96-42F5-9C17-AA8C82F487BB.1; Wed, 01 Nov 2023 11:44:06 +0000 X-Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id d69d1eab6510.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 01 Nov 2023 11:44:06 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=W/BImnsldDgFAc35hqaPQOEtaJ3/m/cn/xBPrXxibM84k/Or057j6cLNMkjmfDLD9DJSgjPSpOtAm/iQmoqzwqq07Bx17GP9JIqKl3DjShPhfqPdi8k4Jki+npsWFFxGYttHB9q75RPyyawjr8hjxJIdnQCFCOs6le9kM6pbOKqS+rbT5WH3VCgqB5j+4TOknCJW9QNSxdDpDesicznJI8D0mtcRU6b9M8juTlOFX5CiLpOHDsIit99emOLxUtd6NCTITA9j7Cq55Tsz7LjCtTsxg3Le8h/zhqzh8TQ0EmeiX+oBrFR41da5UCdExj2lAz1KTNO2pQdb0rchipDg/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=J57q4HdY/fTFtd4ntwXVpHdZNTYS5QsRMfRr5eI3//g=; b=OZA1F7FNnZ2P4KE4uD/ENKrP4R5PLQevWnsfriZKwDUS7TypplKDeiSiNKlXkwqcNxyKsDcfspHFYOdxYTzW653gjnshGwgk3f+3P5uFKT1LIyXvzhORuU9eIDu2WQoa/CMtepNLYeJ1htK6X9iOHgHRXx7hF7YHYCjwMKW/Y2kIboCkz1zeHRyT/bUVHOFZN/OwIzwOvPlNUXodtUx37vPLTfmsMWYL6CgCb3Y+ioc3+DzK3O19BpbDZ17YNzauh6LLoy012o0Eh4d+gyY+QNxcNSIXmtReHAFtig6jda1dEJ62bNofI0hdqhCnjevCd2HGJf+QvLxKsplH5kVBJA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none X-Received: from AM0PR08MB4289.eurprd08.prod.outlook.com (2603:10a6:208:148::12) by AS1PR08MB7401.eurprd08.prod.outlook.com (2603:10a6:20b:4c7::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6933.28; Wed, 1 Nov 2023 11:44:03 +0000 X-Received: from AM0PR08MB4289.eurprd08.prod.outlook.com ([fe80::3ea:4bdb:1711:3567]) by AM0PR08MB4289.eurprd08.prod.outlook.com ([fe80::3ea:4bdb:1711:3567%6]) with mapi id 15.20.6933.029; Wed, 1 Nov 2023 11:44:03 +0000 From: "levi.yun" To: Sami Mujawar , "devel@edk2.groups.io" CC: Pierre Gondois , "quic_llindhol@quicinc.com" , Akanksha Jain , Sibel Allinson , nd Subject: Re: [edk2-devel] [PATCH v1 1/1] DynamicTablesPkg: Fix assert in CmObject parser Thread-Topic: [PATCH v1 1/1] DynamicTablesPkg: Fix assert in CmObject parser Thread-Index: AQHaDK4hLHtt6IAkJEq0yWmZA9+bobBlV/RD Date: Wed, 1 Nov 2023 11:44:03 +0000 Message-ID: References: <20231101102803.26716-1-sami.mujawar@arm.com> In-Reply-To: <20231101102803.26716-1-sami.mujawar@arm.com> Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM0PR08MB4289:EE_|AS1PR08MB7401:EE_|AM4PEPF00027A65:EE_|AM9PR08MB6050:EE_ X-MS-Office365-Filtering-Correlation-Id: aab3b4c8-aacf-402a-37db-08dbdacfdebc x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: Q+lebCXs5OKpZpUaUQ4V8aBLBjw4eMKmbieU1lWOco6x2DJ76BiwPGZ6QPIQvdJBtPTOZWOXF6FO5Hk2AFo4CEFnmSKv0XbXdLgAHWWObjmtVMTAFk8D6RJiCV/Nar9FSQ7UxIkpDGMG+i+snnHzQdrJgyj2yY5T9mfZRA7iKl+ciGV5ooR5KnSqlIFxlWkxaTb/TIyHQIV+94piDO9WJw4kNz8dJjW1MLWoMa11K1wnw7vE6kxy0esvossmLmiYvYrKYAmlLq4LhKCzZjNcETsugivLNliVwLbKqtuMYWJXBpdb6TD+cvKl6Py0HD/GCilUqi3PlMUHGjHP5/17HLT/ft6u9fuhg4zobq76YXv2IDIDftw2SZtHVOiVFCDWrxhG2lomIPGlg35m7aXY4gz+FzqmS+XH33127ymkKdAMganIkQKLtS7sWrRH+cHPdGUZsEADx6WIT4s5horqU7k2ldg22JNyLL3Bjs90ie3SBsrUH5HNv6Nk6dseBM1HO7r0Qatv4rtYptI6XvmHYLqER8pKIshxZqf5721fZMXlcWS60z+oIDVk0uRQG6Ig0DrgPmoGQYl3F+0X7z3Y6rI5MWp/JjPz1F0QIAXb4W+e5/ATuQMrdi46CqNs2j0L X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB4289.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(6029001)(39860400002)(346002)(396003)(376002)(366004)(136003)(230922051799003)(451199024)(64100799003)(186009)(1800799009)(55016003)(83380400001)(478600001)(64756008)(66946007)(26005)(91956017)(66556008)(2906002)(8676002)(4326008)(54906003)(316002)(41300700001)(66476007)(9686003)(71200400001)(66446008)(52536014)(6506007)(53546011)(76116006)(8936002)(5660300002)(110136005)(7696005)(38100700002)(122000001)(86362001)(33656002)(38070700009);DIR:OUT;SFP:1101; MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1PR08MB7401 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM4PEPF00027A65.eurprd04.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 39254241-145b-4617-a437-08dbdacfd8e9 X-Microsoft-Antispam-Message-Info: 4a7C4GL7pFrcmDCb3ASQwSsxyPOGV9213eGNJSFzwWEvN6kJuGfkAfY7PTDlUE09JosfgSNE9jE0Mk6az36TAXZehGwYmi5J3soF8X3PeuX9XzT7FbcLEqYwPAtYb/h4r+BEmBAU/ZfLb7Is2jltmKGQ/rxtELpohrxm28iC48mMsBRf7zNhtFV0vDS1WUQ5ECNNurJxS6D2Ba4wU/A5IpSzili44BjIfj0n8m3rEkZ/Cphr+EUnv7KQI2HY39JD8/WJYhIoY/6/VqNcflVwwcr9LWaFTy2KF+ELG51I9U+nA2yyI3u98def8no+hvsJ3WkF4Ox/cqXAcNoOSiAMUUops/Is7AJh8OuEVOe6DCEB1lZO6WxaDKCgTVgrvy9kwClJeSshv/QRvzUbtZI4GlwUUneg57fPXIkyHb3/Cw2wx5K8hKNshJQyBYZkyNS1I8cAWhN0mS3Ghn7JkbNvYljGtq63oKfjSDTLZcobgb2Sh2WPveqKi3n9p2z9U4nv4l9zxS3nb/nFdmQlGBXH9Qb8WnMS3kS9OGtoKeToEcfRHRgeSwz4ua8QJj1xwz+W+ZgLBtazITwiijNXHLMo+O7iFHBxynFVCpERYVu2q7YGWVIenvjtnqWxBsGJJDuW0yLjnmFfYxw26zW3gvMqRhfnVnHt18DH2Wib4X2P8Hha+BYgdKtWFzqthNuIn8i/KOxfLmIj+uHgjbVNmt9w8k6QKY14PBQXbJuCcfTON6NmEowK5FZ9aX3fJ8bWI/Jr X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Nov 2023 11:44:13.2550 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: aab3b4c8-aacf-402a-37db-08dbdacfdebc X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM4PEPF00027A65.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB6050 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,yeoreum.yun@arm.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 5zIAZtkZ0vcCHEyxsZIetbjQx7686176AA= Content-Language: en-GB Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=d4JrNySk; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=arm.com (policy=none); arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") Reviewed-by: levi.yun (yeoreum.yun@arm.com) ________________________________________ From: Sami Mujawar Sent: 01 November 2023 10:28 To: devel@edk2.groups.io Cc: Sami Mujawar; Pierre Gondois; Yeo Reum Yun; quic_llindhol@quicinc.com; = Akanksha Jain; Sibel Allinson; nd Subject: [PATCH v1 1/1] DynamicTablesPkg: Fix assert in CmObject parser The patch "f81ee47513e5 DynamicTablesPkg: Add an ET info object parser" updates the Configuration Manager object parser to add support for parsing CM_ARM_ET_INFO object. However, the GicC info structure also has an ET Reference token that points to the CM_ARM_ET_INFO object. Therefore, update the GICC info object parser to add an entry to parse the ET reference token. Without this change an assert stating that the RemainingSize !=3D 0 will be triggered. Signed-off-by: Sami Mujawar --- DynamicTablesPkg/Library/Common/TableHelperLib/ConfigurationManagerObjectP= arser.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/DynamicTablesPkg/Library/Common/TableHelperLib/ConfigurationMa= nagerObjectParser.c b/DynamicTablesPkg/Library/Common/TableHelperLib/Config= urationManagerObjectParser.c index 127675d4cec435e6a076c4466b86a31160bf9de1..ce494816ed884f14af56fb32e7b= f6bbba8595521 100644 --- a/DynamicTablesPkg/Library/Common/TableHelperLib/ConfigurationManagerOb= jectParser.c +++ b/DynamicTablesPkg/Library/Common/TableHelperLib/ConfigurationManagerOb= jectParser.c @@ -84,7 +84,8 @@ STATIC CONST CM_OBJ_PARSER CmArmGicCInfoParser[] =3D { { "ClockDomain", 4, "0x%x", N= ULL }, { "AffinityFlags", 4, "0x%x", N= ULL }, { "CpcToken", sizeof (CM_OBJECT_TOKEN), "0x%p", N= ULL }, - { "TRBEInterrupt", 2, "0x%x", N= ULL } + { "TRBEInterrupt", 2, "0x%x", N= ULL }, + { "EtToken", sizeof (CM_OBJECT_TOKEN), "0x%p", N= ULL } }; /** A parser for EArmObjGicDInfo. -- 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' IMPORTANT NOTICE: The contents of this email and any attachments are confid= ential and may also be privileged. If you are not the intended recipient, p= lease notify the sender immediately and do not disclose the contents to any= other person, use it for any purpose, or store or copy the information in = any medium. Thank you. -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110476): https://edk2.groups.io/g/devel/message/110476 Mute This Topic: https://groups.io/mt/102315705/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-