public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "levi.yun" <yeoreum.yun@arm.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	"tphan@ventanamicro.com" <tphan@ventanamicro.com>,
	Sami Mujawar <Sami.Mujawar@arm.com>
Cc: "ardb+tianocore@kernel.org" <ardb+tianocore@kernel.org>,
	Sami Mujawar <Sami.Mujawar@arm.com>,
	"ray.ni@intel.com" <ray.ni@intel.com>,
	"huangming@linux.alibaba.com" <huangming@linux.alibaba.com>,
	"sunilvl@ventanamicro.com" <sunilvl@ventanamicro.com>,
	"yong.li@intel.com" <yong.li@intel.com>, nd <nd@arm.com>
Subject: Re: [edk2-devel] [PATCH] StandaloneMmPkg: Make StandaloneMmCpu driver platform independent
Date: Fri, 8 Sep 2023 07:12:00 +0000	[thread overview]
Message-ID: <AM0PR08MB4289A31FDA37A55F113B375DFBEDA@AM0PR08MB4289.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <20230907045914.29608-1-tphan@ventanamicro.com>

> Signed-off-by: Tuan Phan <tphan@ventanamicro.com>
> ---
>  .../Drivers/StandaloneMmCpu/EventHandle.c     | 25 +++--------
> .../Drivers/StandaloneMmCpu/StandaloneMmCpu.c | 42 +++++++++---------
> .../StandaloneMmCpu/StandaloneMmCpu.inf       |  9 ++--
> .../Library/Arm/StandaloneMmCoreEntryPoint.h  | 17 ++------
> .../StandaloneMmCpu.h                         | 22 +++++++---
> .../Arm/CreateHobList.c                       | 43 ++++++++++---------
> .../Arm/StandaloneMmCoreEntryPoint.c          | 15 ++++++-
> .../StandaloneMmCoreEntryPoint.inf            |  2 +-
> StandaloneMmPkg/StandaloneMmPkg.dec           |  2 +-
> 9 files changed, 86 insertions(+), 91 deletions(-)
> rename StandaloneMmPkg/{Drivers/StandaloneMmCpu => Include}/StandaloneMmCpu.h (82%)


@Sami,  This patch looks good to me :)

BTW, I think it's much better to split this patch to platform independent part and ARM specific part.
Many thanks.
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108440): https://edk2.groups.io/g/devel/message/108440
Mute This Topic: https://groups.io/mt/101209230/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



  reply	other threads:[~2023-09-08  7:12 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-07  4:59 [edk2-devel] [PATCH] StandaloneMmPkg: Make StandaloneMmCpu driver platform independent Tuan Phan
2023-09-08  7:12 ` levi.yun [this message]
2023-09-08 16:00   ` Tuan Phan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AM0PR08MB4289A31FDA37A55F113B375DFBEDA@AM0PR08MB4289.eurprd08.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox