From: "Prachotan Bathi" <prachotan.bathi@arm.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
Prachotan Bathi <Prachotan.Bathi@arm.com>
Cc: G Edhaya Chandran <Edhaya.Chandran@arm.com>,
Barton Gao <gaojie@byosoft.com.cn>,
Carolyn Gjertsen <Carolyn.Gjertsen@amd.com>,
Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>,
Eric Jin <eric.jin@intel.com>, Arvin Chen <arvinx.chen@intel.com>,
Supreeth Venkatesh <Supreeth.Venkatesh@amd.com>
Subject: Re: [edk2-devel] [PATCH v1 0/1] EDK2-Test: Bug 4244 - SCT improvement - Print out the PCIe device path
Date: Wed, 5 Jun 2024 14:47:03 +0000 [thread overview]
Message-ID: <AM0PR08MB44839052FFD9E5A58BC4938EEFF92@AM0PR08MB4483.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <17D5E71624FFAB6A.27337@groups.io>
[-- Attachment #1: Type: text/plain, Size: 7703 bytes --]
Here's a sample output reflecting the changes:
https://github.com/tianocore/edk2-test/pull/96#issuecomment-2150234924
[https://opengraph.githubassets.com/693d739ae94bb87787ee0ac25f41c83df2babd68a6b23b54cb21b9a5e52fb6bc/tianocore/edk2-test/pull/96]<https://github.com/tianocore/edk2-test/pull/96#issuecomment-2150234924>
EDK2-Test: Bug 4244 - SCT improvement - Print out the PCIe device pat… by PrachotanReddy · Pull Request #96 · tianocore/edk2-test<https://github.com/tianocore/edk2-test/pull/96#issuecomment-2150234924>
https://bugzilla.tianocore.org/show_bug.cgi?id=4244 Tests Modified: AdapterInfoBBTestConformance HIIConfigAccessBBTestConformance PxeBaseCodeBBTestConformance SimpleNetworkBBTestConformance UEFI-SC...
github.com
________________________________
From: devel@edk2.groups.io <devel@edk2.groups.io> on behalf of Prachotan Bathi via groups.io <prachotan.bathi=arm.com@groups.io>
Sent: Tuesday, June 4, 2024 3:28 PM
To: devel@edk2.groups.io <devel@edk2.groups.io>; Prachotan Bathi <Prachotan.Bathi@arm.com>
Cc: G Edhaya Chandran <Edhaya.Chandran@arm.com>; Barton Gao <gaojie@byosoft.com.cn>; Carolyn Gjertsen <Carolyn.Gjertsen@amd.com>; Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>; Eric Jin <eric.jin@intel.com>; Arvin Chen <arvinx.chen@intel.com>; Supreeth Venkatesh <Supreeth.Venkatesh@amd.com>
Subject: Re: [edk2-devel] [PATCH v1 0/1] EDK2-Test: Bug 4244 - SCT improvement - Print out the PCIe device path
Here's the PR for your convenience: https://github.com/tianocore/edk2-test/pull/96
________________________________
From: devel@edk2.groups.io <devel@edk2.groups.io> on behalf of Prachotan Bathi via groups.io <prachotan.bathi=arm.com@groups.io>
Sent: Monday, June 3, 2024 1:27 PM
To: devel@edk2.groups.io <devel@edk2.groups.io>
Cc: G Edhaya Chandran <Edhaya.Chandran@arm.com>; Barton Gao <gaojie@byosoft.com.cn>; Carolyn Gjertsen <Carolyn.Gjertsen@amd.com>; Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>; Eric Jin <eric.jin@intel.com>; Arvin Chen <arvinx.chen@intel.com>; Supreeth Venkatesh <Supreeth.Venkatesh@amd.com>
Subject: [edk2-devel] [PATCH v1 0/1] EDK2-Test: Bug 4244 - SCT improvement - Print out the PCIe device path
Worked on the following protocols’ test cases as we have seen PCIe card UEFI driver related failures with these test cases:
EFI_HII_CONFIG_ACCESS_PROTOCOL
EFI_ADAPTER_INFORMATION_PROTOCOL
EFI_SIMPLE_NETWORK_PROTOCOL
EFI_PXE_BASE_CODE_PROTOCOL
Output of a failed PCIe test
Auto Conformance Test for Arp
------------------------------------------------------------
Logfile: "\EFI\BOOT\bbr\SCT\Overall\Summary.log"
Test Started: 02/16/23 05:04p
------------------------------------------------------------
EFI_PXE_BASE_CODE_PROTOCOL.Start - Check Return Code -- FAILURE
6A8CAA83-B9DA-46C7-98F6-D4969DABDAA0
/home/cherat01/ATEG/SystemReady/SystemReady/arm-systemready/SR/scripts/edk2-test/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/PxeBaseCode/BlackBoxTest/PxeBaseCodeBBTestConformance.c:2140:Status - Unsupported
Returned Status Code: Unsupported
Arp_Conf: [FAILED]
Passes........... 0
Warnings......... 0
Errors........... 1
We want to see message like COMPONENT_NAME2_PROTOCOL test case having the message in red to show what device/driver was tested.
------------------------------------------------------------
Conformance Test for GetControllerName
------------------------------------------------------------
Logfile: "\EFI\BOOT\bbr\SCT\Overall\Summary.log"
Test Started: 02/16/23 05:14p
------------------------------------------------------------
Device Path: Fv(5C60F367-A505-419A-859E-2A4FF6CA6FE5)/FvFile(F2AD0AD0-D4B6-11E3-9C1A-0800200C9A66)
COMPONENT_NAME2_PROTOCOL.GetControllerName - GetControllerName() returns EFI_INVALID_PARAMETER with a NULL ControllerHandle -- FAILURE
C38A85AF-2D0A-4BFA-8F44-A247F1FD7B94
/home/cherat01/ATEG/SystemReady/SystemReady/arm-systemready/SR/scripts/edk2-test/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/ComponentName2/BlackBoxTest/ComponentName2BBTestConformance.c:551: Language - en, Status - Success, NULL
Found the device path from the protocol handle. Used SctDevicePathToStr(DevicePath) to print as str.
Tested on rpi and AADP systems.
https://github.com/PrachotanReddy/edk2-test
Cc: G Edhaya Chandran <Edhaya.Chandran@arm.com>
Cc: Barton Gao <gaojie@byosoft.com.cn>
Cc: Carolyn Gjertsen <Carolyn.Gjertsen@amd.com>
Cc: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>
Cc: Eric Jin <eric.jin@intel.com>
Cc: Arvin Chen <arvinx.chen@intel.com>
Cc: Supreeth Venkatesh <Supreeth.Venkatesh@amd.com>
Prachotan Bathi (1):
EDK2-Test: Bug 4244 - SCT improvement - Print out the PCIe device path for PCIe card/device related SCT failures.
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/AdapterInfo/BlackBoxTest/AdapterInfoProtocolBBTest.inf | 2 +
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/PxeBaseCode/BlackBoxTest/PxeBBTest.inf | 3 +-
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/SimpleNetwork/BlackBoxTest/SimpleNetworkBBTest.inf | 4 +-
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/AdapterInfo/BlackBoxTest/AdapterInfoBBTestMain.h | 17 +-
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/HIIConfigAccess/BlackBoxTest/HIIConfigAccessBBTestMain.h | 6 +
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/PxeBaseCode/BlackBoxTest/PxeBaseCodeBBTestMain.h | 6 +
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/SimpleNetwork/BlackBoxTest/SimpleNetworkBBTestMain.h | 6 +
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/AdapterInfo/BlackBoxTest/AdapterInfoBBTestConformance.c | 63 +-
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/AdapterInfo/BlackBoxTest/AdapterInfoBBTestMain.c | 96 ++
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/HIIConfigAccess/BlackBoxTest/HIIConfigAccessBBTestConformance.c | 48 +-
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/HIIConfigAccess/BlackBoxTest/HIIConfigAccessBBTestMain.c | 67 +-
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/PxeBaseCode/BlackBoxTest/PxeBaseCodeBBTestConformance.c | 305 +++++-
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/PxeBaseCode/BlackBoxTest/PxeBaseCodeBBTestMain.c | 1158 +++++++++-----------
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/SimpleNetwork/BlackBoxTest/SimpleNetworkBBTestConformance.c | 258 ++++-
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/SimpleNetwork/BlackBoxTest/SimpleNetworkBBTestMain.c | 96 ++
15 files changed, 1451 insertions(+), 684 deletions(-)
--
2.34.1
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119474): https://edk2.groups.io/g/devel/message/119474
Mute This Topic: https://groups.io/mt/106471265/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
[-- Attachment #2: Type: text/html, Size: 13584 bytes --]
next prev parent reply other threads:[~2024-06-05 14:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <17D59B57F459D1B4.11931@groups.io>
2024-06-04 20:28 ` [edk2-devel] [PATCH v1 0/1] EDK2-Test: Bug 4244 - SCT improvement - Print out the PCIe device path Prachotan Bathi
[not found] ` <17D5E71624FFAB6A.27337@groups.io>
2024-06-05 14:47 ` Prachotan Bathi [this message]
2024-06-03 18:27 Prachotan Bathi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM0PR08MB44839052FFD9E5A58BC4938EEFF92@AM0PR08MB4483.eurprd08.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox