Re: [edk2-devel] [edk2-platforms][PATCH v4 1/9] Platform/ARM/Sgi: Create individual Platform Description File

["Aditya Angadi" <aditya.angadi@arm.com>]

Hi Ard,

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Ard
> Biesheuvel via groups.io
> Sent: 27 April 2020 20:26
> To: Aditya Angadi <Aditya.Angadi@arm.com>; devel@edk2.groups.io
> Cc: Thomas Abraham <thomas.abraham@arm.com>; leif@nuviainc.com;
> Vijayenthiran Subramaniam <Vijayenthiran.Subramaniam@arm.com>
> Subject: Re: [edk2-devel] [edk2-platforms][PATCH v4 1/9] Platform/ARM/Sgi:
> Create individual Platform Description File
>
> On 4/27/20 4:54 PM, Aditya Angadi wrote:
> > Hi Ard,
> >
> >> -----Original Message-----
> >> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Ard
> >> Biesheuvel via groups.io
> >> Sent: 27 April 2020 16:32
> >> To: devel@edk2.groups.io; Aditya Angadi <Aditya.Angadi@arm.com>
> >> Cc: Thomas Abraham <thomas.abraham@arm.com>; leif@nuviainc.com;
> >> Vijayenthiran Subramaniam <Vijayenthiran.Subramaniam@arm.com>
> >> Subject: Re: [edk2-devel] [edk2-platforms][PATCH v4 1/9]
> Platform/ARM/Sgi:
> >> Create individual Platform Description File
> >>
> >> On 4/14/20 2:52 PM, Aditya Angadi via groups.io wrote:
> >>> From: Vijayenthiran Subramaniam
> <vijayenthiran.subramaniam@arm.com>
> >>>
> >>> In preparation for adding support for Reference Design (RD)
> >>> platforms that have different base addresses for GIC distributor or
> >>> redistributor, create individual platform description files for all
> >>> SGI/RD platforms and move GIC related base addresses from the
> common
> >>> SGI/RD platform description file to individual platform description
> >>> files.The existing platform description is then included by
> >>> individual platform description files. With this change, the builds
> >>> for each supported platform is separate.
> >>>
> >>> Signed-off-by: Aditya Angadi <aditya.angadi@arm.com>
> >>
> >> Can you split this up please? There are a lot of different things
> >> going on at the same time AFAICT.
> >>
> >
> > Thanks for your review. I will send the updated patchset tomorrow. I am
> assuming that so far the comments are for first three patches only. So I will
> address the comments accordingly and update the patchset.
> >
>
> Please wait until I finish the review of this series.
>

Appreciate your time to review the v4 of this series. The next set of patches have addressed all your comments so far and is ready to be posted for review. I have not seen any comments on the last three patches on the v4 series and so I wasn’t sure if you have completed your review of v4 patches. In any case, v5 is ready to be posted, so please let me know if it is okay to post v5 for review.

Thanks,
Aditya.

>
> 

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.