From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0614.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe1f::614]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id AD4111A1DF5 for ; Fri, 5 Aug 2016 12:34:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=MCrovou+dpe0SyMe+bHKMWvKF8NLs48RC/kkqP9nZv4=; b=YZqe8uTAcDeeIJTzThcr4xP3F5Qpx+8HhAA8FGlm/FjQfmvYTSuIoq6dgRcRVuAR7lfTsfJUsT0o+X4p7dFWGQd7pbwl1HSLd/aKC9BVp53m4DxImfr4MLVJiy1GKG1VyXi8nXS8wK1t/fLR6QA4uY130Q/C+xWfoqi91ek2J+s= Received: from AM4PR0401MB2289.eurprd04.prod.outlook.com (10.165.45.12) by AM4PR0401MB2291.eurprd04.prod.outlook.com (10.165.45.14) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id 15.1.557.8; Fri, 5 Aug 2016 19:34:37 +0000 Received: from AM4PR0401MB2289.eurprd04.prod.outlook.com ([10.165.45.12]) by AM4PR0401MB2289.eurprd04.prod.outlook.com ([10.165.45.12]) with mapi id 15.01.0557.009; Fri, 5 Aug 2016 19:34:37 +0000 From: Bhupesh Sharma To: Tim Lewis , "Carsey, Jaben" , Meenakshi Aggarwal , "edk2-devel@lists.01.org" Thread-Topic: Shell version 2.2 Thread-Index: AdHu+W3lndTU8FzJTNWqMdU/Mik5KQARG1wwAAJ26aAAAUJQAAAAG/SwAAC/YJA= Date: Fri, 5 Aug 2016 19:34:36 +0000 Message-ID: References: <7236196A5DF6C040855A6D96F556A53F3DA5B3@msmail.insydesw.com.tw> <7236196A5DF6C040855A6D96F556A53F3DA697@msmail.insydesw.com.tw> In-Reply-To: <7236196A5DF6C040855A6D96F556A53F3DA697@msmail.insydesw.com.tw> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=bhupesh.sharma@nxp.com; x-originating-ip: [182.69.195.176] x-ms-office365-filtering-correlation-id: 330e0135-8c9d-4319-f835-08d3bd67893a x-microsoft-exchange-diagnostics: 1; AM4PR0401MB2291; 6:GtoV+fcZuzWlesuuyGttbgFdpqE81dCdJ6IiiAdk1RhjvE9M0klg8FSVOuoPD1kw371DmYP0gB72LsFA3uI0O3/WBrNwfMrzl6zqKH1OQeZBkcc6K+P4JsTQKd3BWoCmYqEHlCu8dIxzjSqtltUU5YRUtxJnMng92rjA2j7Mje992yhRVA7Ny8aCv3V0f66zWKfRPRro8yWXuXjTG/LCvZllBpXEKylbrmsC5jiaPznGHOGFGg93HZV8Sv839atu3DzNSmH6zv9n42n5dJre+LrmK4Ku1Wr852/qGlzvOfLlAJpaC97epnQ7ovcgZlgoQ4fYViBCjAMXJCwfBxEfYA==; 5:XAshDdVVlFgTGfoqa3NkjxAdipAtEnTrXZnEtXnNYg++EN7m8/7RGp8fjmYWmn1p2QP/BPYWCWQsFDHsH/YTUFV5ONWJJSc3ZEC+ei7pLMO6bEeD9MqMiHA4UlxmT29WN2KDlBQv8F1VTXV+oFg1Yg==; 24:jZ1D6JbXbKl6Cv3qC/D/ojSw8nou84HxBanIQyJfHoKYWV0qwjSWx17LKDlLuEZ6qHRKNlvl4ufEofrAQRaTt4viuuNBLcQUU4kSITTIkSY=; 7:eWlc5V0AqQmaNXsEdz2BiAxj7Hkb1w5bpXwHCvzs5iobE2jExQkzKTQ3QPlip5ANChec3rLcRzsaMuriQeD1HDUbIPJmVH+zOnMR45gqsMgZlExOcHAp3Wlqnyn+KlDna+zPouCqDvdSEKcMyHAtSny1Kpk6cBp1j4yyO0UXsxA9qfnQ01zPU3D0HWYEwQF+CBjGmHs5MjVL7QxJaY62mQwNVOq8b6aVGCvQBqfpwdr7+xim4ylM7tQYPRZtbMOX x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:AM4PR0401MB2291; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(185117386973197)(162533806227266)(228905959029699); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6055026); SRVR:AM4PR0401MB2291; BCL:0; PCL:0; RULEID:; SRVR:AM4PR0401MB2291; x-forefront-prvs: 0025434D2D x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6009001)(7916002)(13464003)(24433001)(199003)(51444003)(377454003)(189002)(50986999)(33656002)(19580405001)(106356001)(11100500001)(122556002)(3846002)(97736004)(9686002)(105586002)(68736007)(81166006)(8676002)(8936002)(19580395003)(586003)(66066001)(86362001)(74316002)(3660700001)(81156014)(87936001)(2950100001)(305945005)(76176999)(77096005)(10400500002)(7846002)(93886004)(5001770100001)(15975445007)(7736002)(107886002)(6116002)(189998001)(101416001)(54356999)(102836003)(76576001)(2900100001)(92566002)(2906002)(3280700002)(5002640100001)(7696003)(491001); DIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR0401MB2291; H:AM4PR0401MB2289.eurprd04.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Aug 2016 19:34:36.9254 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR0401MB2291 Subject: Re: Shell version 2.2 X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Aug 2016 19:34:42 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Unfortunately the 'ver' command on the shell also shows up a 2.1 shell vers= ion with the latest edk2/master. So, we think it is rather a bug. Regards, Bhupesh > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > Tim Lewis > Sent: Saturday, August 06, 2016 12:47 AM > To: Carsey, Jaben ; Meenakshi Aggarwal > ; edk2-devel@lists.01.org devel@ml01.01.org> > Subject: Re: [edk2] Shell version 2.2 >=20 > Yes, but they are the same numbers. So I think this is probably a >=20 > The specification says (in the Shell protocol section's Related > Defintiions): >=20 > #define EFI_SHELL_MAJOR_VERSION 2 > #define EFI_SHELL_MINOR_VERSION 2 >=20 > And, from ver.c: >=20 > ShellPrintHiiEx ( > 0, > gST->ConOut->Mode->CursorRow, > NULL, > STRING_TOKEN (STR_VER_OUTPUT_SIMPLE), > gShellLevel3HiiHandle, > gEfiShellProtocol->MajorVersion, > gEfiShellProtocol->MinorVersion > ); >=20 > And the shell protocol instance comes from ShellProtocol.c (see below): >=20 > EFI_SHELL_PROTOCOL mShellProtocol =3D { > EfiShellExecute, > EfiShellGetEnv, > EfiShellSetEnv, > EfiShellGetAlias, > EfiShellSetAlias, > EfiShellGetHelpText, > EfiShellGetDevicePathFromMap, > EfiShellGetMapFromDevicePath, > EfiShellGetDevicePathFromFilePath, > EfiShellGetFilePathFromDevicePath, > EfiShellSetMap, > EfiShellGetCurDir, > EfiShellSetCurDir, > EfiShellOpenFileList, > EfiShellFreeFileList, > EfiShellRemoveDupInFileList, > EfiShellBatchIsActive, > EfiShellIsRootShell, > EfiShellEnablePageBreak, > EfiShellDisablePageBreak, > EfiShellGetPageBreak, > EfiShellGetDeviceName, > (EFI_SHELL_GET_FILE_INFO)FileHandleGetInfo, //* > (EFI_SHELL_SET_FILE_INFO)FileHandleSetInfo, //* > EfiShellOpenFileByName, > EfiShellClose, > EfiShellCreateFile, > (EFI_SHELL_READ_FILE)FileHandleRead, //* > (EFI_SHELL_WRITE_FILE)FileHandleWrite, //* > (EFI_SHELL_DELETE_FILE)FileHandleDelete, //* > EfiShellDeleteFileByName, > (EFI_SHELL_GET_FILE_POSITION)FileHandleGetPosition, //* > (EFI_SHELL_SET_FILE_POSITION)FileHandleSetPosition, //* > (EFI_SHELL_FLUSH_FILE)FileHandleFlush, //* > EfiShellFindFiles, > EfiShellFindFilesInDir, > (EFI_SHELL_GET_FILE_SIZE)FileHandleGetSize, //* > EfiShellOpenRoot, > EfiShellOpenRootByHandle, > NULL, > SHELL_MAJOR_VERSION, > SHELL_MINOR_VERSION, >=20 > // New for UEFI Shell 2.1 > EfiShellRegisterGuidName, > EfiShellGetGuidName, > EfiShellGetGuidFromName, > EfiShellGetEnvEx > }; >=20 > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > Carsey, Jaben > Sent: Friday, August 05, 2016 12:10 PM > To: Tim Lewis ; Meenakshi Aggarwal > ; edk2-devel@lists.01.org devel@ml01.01.org> > Cc: Carsey, Jaben > Subject: Re: [edk2] Shell version 2.2 >=20 > Tim, >=20 > Yes, ver command would output that the version of the shell is > different. >=20 > The #define below is specifically the version of the Protocol, not the > version of the spec. >=20 > It could have been a miss on the part of the committee, but that was > hoe I interpreted the non-change to the protocol version. >=20 > -Jaben >=20 > > -----Original Message----- > > From: Tim Lewis [mailto:tim.lewis@insyde.com] > > Sent: Friday, August 5, 2016 11:36 AM > > To: Carsey, Jaben ; Meenakshi Aggarwal > > ; edk2-devel@lists.01.org > devel@ml01.01.org> > > Subject: RE: Shell version 2.2 > > Importance: High > > > > Jaben -- > > > > Are there no shell commands where the standard command-line > parameters > > have changed? > > > > Tim > > > > -----Original Message----- > > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf > Of > > Carsey, Jaben > > Sent: Friday, August 05, 2016 10:26 AM > > To: Meenakshi Aggarwal ; edk2- > > devel@lists.01.org > > Cc: Carsey, Jaben > > Subject: Re: [edk2] Shell version 2.2 > > > > I think that that version (2.1) is correct for the version of the > > protocol. The protocol API was not changed for the UEFI Shell 2.2. > > > > That is the current version and should support the 2.2 spec. > > > > -Jaben > > > > > -----Original Message----- > > > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf > > > Of Meenakshi Aggarwal > > > Sent: Friday, August 5, 2016 2:20 AM > > > To: edk2-devel@lists.01.org > > > Subject: [edk2] Shell version 2.2 > > > Importance: High > > > > > > Hi, > > > > > > > > > I can see UEFI shell specification 2.2 > > > > (http://www.uefi.org/sites/default/files/resources/UEFI_Shell_2_2.pd > > > f) is available, But on edk2 master branch current version of Shell > > > is still showing > > 2.1. > > > > > > File:ShellPkg/Include/Protocol/EfiShell.h > > > > > > enum ShellVersion { > > > SHELL_MAJOR_VERSION =3D 2, > > > SHELL_MINOR_VERSION =3D 1 > > > }; > > > > > > > > > > > > Please tell if I am looking at correct file, actually I want to > > > update my shell to 2.2, but it looks like edk2 master branch > doesn't > > > support shell > > specification 2.2. > > > > > > Is my understanding correct? > > > > > > > > > > > > Thanks & Regards, > > > Meenakshi > > > _______________________________________________ > > > edk2-devel mailing list > > > edk2-devel@lists.01.org > > > https://lists.01.org/mailman/listinfo/edk2-devel > > _______________________________________________ > > edk2-devel mailing list > > edk2-devel@lists.01.org > > https://lists.01.org/mailman/listinfo/edk2-devel > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel