From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-oln040092072047.outbound.protection.outlook.com [40.92.72.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id D2E3721E43B63 for ; Fri, 22 Sep 2017 08:50:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=o064NmrL5hTMQvLjNoXD8KzTA6eaaHMoC9dxWsy3eT8=; b=lrC0ML6O2nbYripe13Da4TdcN8+u6dKwgEImLMlV3RjyAegd19/5MyIVcd6ZmlRofrkK9R636CJalDozbT7S4X749f+b0str1JSq+Ut5i08wFT2GmWyiCeuAV+7YaLDT2c1jowGDpUZHym2+1ddaAl6pRiCtlIA2BhCT/jkSGaHv79ZT80BlEfI4fXIaZtvsDWNdnzNgKcpuedrLdA0ZF7gaxCjHnSD1qDYAh6fk9NP4kdWXc4vhYhzBigYNsTOMSfLqrZ7K9evGxaUMo9G/egYUmlQVf5ZSRnXIk8hE6Ihs29eIBL+vEsKhTiGN/5pDIdHImwB68BV2kZe09+k7DA== Received: from AM5EUR03FT011.eop-EUR03.prod.protection.outlook.com (10.152.16.56) by AM5EUR03HT219.eop-EUR03.prod.protection.outlook.com (10.152.17.195) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.20.35.14; Fri, 22 Sep 2017 15:53:13 +0000 Received: from AM4PR06MB1491.eurprd06.prod.outlook.com (10.152.16.58) by AM5EUR03FT011.mail.protection.outlook.com (10.152.16.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.20.56.11 via Frontend Transport; Fri, 22 Sep 2017 15:53:13 +0000 Received: from AM4PR06MB1491.eurprd06.prod.outlook.com ([fe80::d9cb:81d:c687:534f]) by AM4PR06MB1491.eurprd06.prod.outlook.com ([fe80::d9cb:81d:c687:534f%13]) with mapi id 15.20.0077.011; Fri, 22 Sep 2017 15:53:13 +0000 From: Marvin H?user To: "edk2-devel@lists.01.org" CC: "Gao, Liming" , "steven.shi@intel.com" , "yonghong.zhu@intel.com" Thread-Topic: [PATCH] BaseTools/Conf: Support LLVM39 and LLVM40 in CLANG38 toolchain Thread-Index: AQHTG92/8mh+ojyM9EiDFgxR8WypwaKZZCjggCfYXyA= Date: Fri, 22 Sep 2017 15:53:12 +0000 Message-ID: References: <20170823070107.38848-1-steven.shi@intel.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14D7815F7@shsmsx102.ccr.corp.intel.com> In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14D7815F7@shsmsx102.ccr.corp.intel.com> Accept-Language: de-DE, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: lists.01.org; dkim=none (message not signed) header.d=none;lists.01.org; dmarc=none action=none header.from=outlook.com; x-incomingtopheadermarker: OriginalChecksum:73449364F366591EB583AF56ACD57B2D5975EE3CCF95874E44D9D9817F452436; UpperCasedChecksum:281FF497AF5D8E865FAB0096E76A898515B8DA8963BC10AB4A720397D8316E05; SizeAsReceived:7438; Count:46 x-tmn: [2LqgeKALIKncrvlr0RFvZ1jrMxUt8FC2DGhPB6+oCJMwPuAumubyOLUL8qxJ1mBZ] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; AM5EUR03HT219; 6:9CaV41XVLX5iYCX8ISzZGHS0CpwGV9qWSWh+g/U7dPeYtPeZkCtTGKvKGtyfM/YdEFmqhVhKMtil4HlyHaoAi1A2d1NM3GvPlDp+yebTWzNEgGgc4sf18TWV9bUBRum9xq/6vy/Pq1W7rzDqQZAYWURzKwxyYR1mOpkBrR2IdoRViMtOhc+vDlXUTdn7FWT0415LyyzzpjqNbgmnuSC3W5tT5EfH4JiSS8MOvgJZFa6pbvLHeh+vn+wR4j7X4MlJAswFQJPjmv3oCvFV7OprtesynDRaZwsKYtoE9J2zFzPi6eravXXf0V8V4Xfycg+zyT6iZ99+O6OLefnYQM6+dQ==; 5:cBZhaenwD0ie4OkT/qMgFEggO7UQqImtKOyYhdOqB7A8yJt71W3Fkatju7QSlwKi5onF0+rSH7sY3RV4UahfE9iJEkqBmi9PZXzLl/vhFdkiMzQSkJmB8GO+5VUcFjWkQP+Rd6FeYqkf5wHwMUOb7w==; 24:XSJ5scXQuX159Wut2U81JvkafM7eJWSNvsJFLBKrmUd/gn//RF2Ft6gz/QV+1lySX+NaHDi0teHHMwTqP9LoALo9ucN32WTgPzS+TX4s4+I=; 7:rm9TBlbwFYUr1f1f61MEM0kba2wdFUAbYMnQHjN1JxelJwfzdyXRhcPwA6ip0ip8PI1JuUx4jPiJeSc0vl+BWlmDwGU53qus6/WV+rXxvB0kmhaie9le1E3hRU6Lu+qU9NDrTS6aEeVW1Mlekyi3uexKBI5W3VxlLDSKHfNIgmivUYeeXWdfQgVA9qyyl6+E7cGxo2gwBkboR27n/XBb6VGXYnFeqFRFq4wkutsrAcU= x-incomingheadercount: 46 x-eopattributedmessage: 0 x-ms-office365-filtering-correlation-id: e82b73c2-ee45-463c-2a57-08d501d207ee x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(300000503095)(300135400095)(201702061074)(5061506573)(5061507331)(1603103135)(2017031320274)(2017031324274)(2017031323274)(2017031322404)(1601125374)(1603101448)(1701031045)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:AM5EUR03HT219; x-ms-traffictypediagnostic: AM5EUR03HT219: x-exchange-antispam-report-test: UriScan:(162533806227266)(228905959029699); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(444000031); SRVR:AM5EUR03HT219; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:AM5EUR03HT219; x-forefront-prvs: 0438F90F17 x-forefront-antispam-report: SFV:NSPM; SFS:(7070007)(98901004); DIR:OUT; SFP:1901; SCL:1; SRVR:AM5EUR03HT219; H:AM4PR06MB1491.eurprd06.prod.outlook.com; FPR:; SPF:None; LANG:; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Sep 2017 15:53:12.9977 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Internet X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5EUR03HT219 Subject: Re: [PATCH] BaseTools/Conf: Support LLVM39 and LLVM40 in CLANG38 toolchain X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Sep 2017 15:50:08 -0000 Content-Language: de-DE Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hey, I just noticed this patch as it recently has been pushed. I found this has = been a reaction to https://bugzilla.tianocore.org/show_bug.cgi?id=3D410 Though as Clang correctly detected, this is Undefined Behavior per the C sp= ecification, so why was the warning hidden? In context of the issue in UefiLib, providing the first element of the VA l= ist as a prototyped argument, would have solved the issue without UB. Do you wish such a patch? Thanks, Marvin. > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > Gao, Liming > Sent: Monday, August 28, 2017 9:19 AM > To: Shi, Steven ; edk2-devel@lists.01.org > Subject: Re: [edk2] [PATCH] BaseTools/Conf: Support LLVM39 and LLVM40 in > CLANG38 toolchain >=20 > Reviewed-by: Liming Gao >=20 > >-----Original Message----- > >From: Shi, Steven > >Sent: Wednesday, August 23, 2017 3:01 PM > >To: edk2-devel@lists.01.org; Gao, Liming > >Cc: Zhu, Yonghong ; Shi, Steven > > > >Subject: [PATCH] BaseTools/Conf: Support LLVM39 and LLVM40 in CLANG38 > >toolchain > > > >From: "Shi, Steven" > > > >Add LLVM39 and LLVM40 support in CLANG38 toolchain > > > >Contributed-under: TianoCore Contribution Agreement 1.0 > >Signed-off-by: Steven Shi > >--- > > BaseTools/Conf/tools_def.template | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > >diff --git a/BaseTools/Conf/tools_def.template > >b/BaseTools/Conf/tools_def.template > >index 1fa3ca3..2f83341 100755 > >--- a/BaseTools/Conf/tools_def.template > >+++ b/BaseTools/Conf/tools_def.template > >@@ -380,7 +380,8 @@ DEFINE SOURCERY_CYGWIN_TOOLS =3D > /cygdrive/c/Program > >Files/CodeSourcery/Sourcery G > > # Intel(r) ACPI Compiler from > > # https://acpica.org/downloads > > # CLANG38 -Linux- Requires: > >-# Clang v3.8 or later, LLVMgold plugin and = GNU binutils 2.26 > >targeting x86_64-linux-gnu > >+# Clang v3.8, LLVMgold plugin and GNU binut= ils 2.26 > targeting > >x86_64-linux-gnu > >+# Clang v3.9 or later, LLVMgold plugin and = GNU binutils 2.28 > >targeting x86_64-linux-gnu > > # Optional: > > # Required to build platforms or ACPI table= s: > > # Intel(r) ACPI Compiler from > >@@ -5512,7 +5513,7 @@ DEFINE CLANG38_X64_PREFIX =3D > >ENV(CLANG38_BIN) > > DEFINE CLANG38_IA32_TARGET =3D -target i686-pc-linux-gnu > > DEFINE CLANG38_X64_TARGET =3D -target x86_64-pc-linux-gnu > > > >-DEFINE CLANG38_ALL_CC_FLAGS =3D DEF(GCC44_ALL_CC_FLAGS) -Wno- > >empty-body -fno-stack-protector -mms-bitfields -Wno-address -Wno-shift- > >negative-value -Wno-parentheses-equality -Wno-unknown-pragmas - > Wno- > >tautological-constant-out-of-range-compare -Wno-incompatible-library- > >redeclaration -fno-asynchronous-unwind-tables -mno-sse -mno-mmx - > msoft- > >float -mno-implicit-float -ftrap- > >function=3Dundefined_behavior_has_been_optimized_away_by_clang - > >funsigned-char -fno-ms-extensions -Wno-null-dereference -Wno- > >tautological-compare -Wno-unknown-warning-option > >+DEFINE CLANG38_ALL_CC_FLAGS =3D DEF(GCC44_ALL_CC_FLAGS) - > Wno- > >empty-body -fno-stack-protector -mms-bitfields -Wno-address -Wno-shift- > >negative-value -Wno-parentheses-equality -Wno-unknown-pragmas - > Wno- > >tautological-constant-out-of-range-compare -Wno-incompatible-library- > >redeclaration -fno-asynchronous-unwind-tables -mno-sse -mno-mmx - > msoft- > >float -mno-implicit-float -ftrap- > >function=3Dundefined_behavior_has_been_optimized_away_by_clang - > >funsigned-char -fno-ms-extensions -Wno-null-dereference -Wno- > >tautological-compare -Wno-unknown-warning-option -Wno-varargs > > > > ########################### > > # CLANG38 IA32 definitions > >-- > >2.7.4 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel