From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-oln040092065093.outbound.protection.outlook.com [40.92.65.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id CE56C21D0DE5F for ; Tue, 25 Jul 2017 01:56:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=Y2mXzz78JHgaWgp/aqs4E2J2+95I5khGARD8T22qlPg=; b=l3fqUnm6sQbw7KuxKbWATKjX6zxHuXGEkr9UgaM1WL3+B5/Vin7XB+/U/qM8daVnZET5vcZN/KOrsIJ5hTulaiKv+PggRQlGKjC/PhHhO+3Z1NLw1Etpky9zIq0Hcs7bOC7ZD5PLKfCkBLbYqaKBHiaxxkL8vkxShQkxeUiuJvY1xWc7G9UqsfoJReDD36WAslkieJ1gUO+4DuHaxlBn9qg5W4RHA3u5bAcqUiJTo2gfo5keheJZoscF1KTHIrHC78E8Mdgd1pCSK7bFohXA8vjn8BKmiyU6HKv+dfe2Iujd3AsEPYWAxxhw1I6A/cvRZqgpPBgEXUCDP1bgOaTbCA== Received: from VE1EUR01FT025.eop-EUR01.prod.protection.outlook.com (10.152.2.57) by VE1EUR01HT058.eop-EUR01.prod.protection.outlook.com (10.152.3.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.1240.9; Tue, 25 Jul 2017 08:57:59 +0000 Received: from AM4PR06MB1491.eurprd06.prod.outlook.com (10.152.2.53) by VE1EUR01FT025.mail.protection.outlook.com (10.152.2.232) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1240.9 via Frontend Transport; Tue, 25 Jul 2017 08:57:59 +0000 Received: from AM4PR06MB1491.eurprd06.prod.outlook.com ([fe80::dcd0:60e6:90e0:871b]) by AM4PR06MB1491.eurprd06.prod.outlook.com ([fe80::dcd0:60e6:90e0:871b%13]) with mapi id 15.01.1282.020; Tue, 25 Jul 2017 08:57:59 +0000 From: Marvin H?user To: "edk2-devel@lists.01.org" CC: "Zeng, Star" Thread-Topic: [UEFI PI 1.6/EDK2] Missing decorators for EFI_PEI_GET_VARIABLE2. Thread-Index: AdMEm0stAu8v+ZaLQCePXmnkVRlHwgAg1CNQAAEYgJA= Date: Tue, 25 Jul 2017 08:57:59 +0000 Message-ID: References: <0C09AFA07DD0434D9E2A0C6AEB0483103B8F5988@shsmsx102.ccr.corp.intel.com> In-Reply-To: <0C09AFA07DD0434D9E2A0C6AEB0483103B8F5988@shsmsx102.ccr.corp.intel.com> Accept-Language: de-DE, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: lists.01.org; dkim=none (message not signed) header.d=none;lists.01.org; dmarc=none action=none header.from=outlook.com; x-incomingtopheadermarker: OriginalChecksum:B0583FD4CA7CA0DBF78870C17707C77298513468458D8E2403A10503AADAFE87; UpperCasedChecksum:70A275B3C03B102DA116F9239DB3B4982DFD8843EF65AE05DAF3BF99F0AB56E4; SizeAsReceived:7454; Count:45 x-tmn: [EqKXC/tGmKhVnBvuIJzSdIhe+J2ZT1FvmXs5/alxrSoP/gKeStfH6DDPJKphbx2F] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; VE1EUR01HT058; 7:cti6chq2TDRgEAjUTb+vsOlLWoK41hfndnAQ/imdqMQwY5BhuPzXk3etK2qB+hT9f4FNCdO4pDnjohMF9y04YHGQs/HPMwTtGb4CvreT1rDolVv/GMPBs7/Z2ybwOiB6gMspTaO7mmS/+rDllppkzp2CbQJsZ2hO0DuwIG5JZks1I3ROpbfOpF+QRDzpqZSWu8GD7zAoD8w8KE/yzgP0Nk4d2yRcJqCXQUUxAROJQTSqbUzmp//f9ABtlW1TIz1gi/mrlDL51xO4plmAdognVhmnYfcXxbZn/ksZkLuy1UkvI2WKEzWXQkFPFmyip6hbvk/h5gE/8+9CpA7r5l4prwI7b51Nr2i4EtJAABwBwu3OVSg4KDrp8LULX7EN6Gpxhra4guA1wc7g5m14sKHHakNtJlKH4/bYwJBjH3edaKLrdFnqJhc7FXdtMNHe7NRz0lbY2m2QrpivQE5E+kDxjcIXKjHG7TWUT9hJiVvnL1Gj8NnJ8LLbQgUp1Ra6y2FEfuYBNrE+lB0tyVi7A4i3Hf1stZH47YAvv2FFtduxKV3AaVJROgCJTBdpTxU51XWfGybltOAortY/V7pUGHXWybMm8LVzyjmD09Rs78FrCOVh9DrVVwmYI1ft2DZ42RIw3AGedb0tsKG3Lmr1qwbbPEuPGEV21e5Xob4D6K41FQlFNAcjhMZggJCo6mp0cSBInxhVzCV0lAqi3mRVKWnSwKahXeS9cppwQgIPraM2ZIeRXSfT4xpqMq5z6lyC7g7TNHr1Pi3USqvjzgSXtVjPsw== x-incomingheadercount: 45 x-eopattributedmessage: 0 x-forefront-antispam-report: EFV:NLI; SFV:NSPM; SFS:(7070007)(98901004); DIR:OUT; SFP:1901; SCL:1; SRVR:VE1EUR01HT058; H:AM4PR06MB1491.eurprd06.prod.outlook.com; FPR:; SPF:None; LANG:en; x-ms-office365-filtering-correlation-id: af243660-941e-4982-8ce5-08d4d33b3fd6 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(300000503095)(300135400095)(201702061074)(5061506573)(5061507331)(1603103135)(2017031320274)(2017031324274)(2017031323274)(2017031322350)(1601125374)(1603101448)(1701031045)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:VE1EUR01HT058; x-ms-traffictypediagnostic: VE1EUR01HT058: x-exchange-antispam-report-test: UriScan:(189930954265078)(162533806227266)(228905959029699); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(444000031); SRVR:VE1EUR01HT058; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:VE1EUR01HT058; x-forefront-prvs: 03793408BA spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Jul 2017 08:57:59.2857 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Internet X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1EUR01HT058 Subject: Re: [UEFI PI 1.6/EDK2] Missing decorators for EFI_PEI_GET_VARIABLE2. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Jul 2017 08:56:02 -0000 Content-Language: de-DE Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hey Star, Thanks for your comment! Sorry, I never submited such a report, could you p= lease point me in the right direction? The only way of contact I found on the sit= e of the UEFI Forum were Administration and Press, both don't sound like the right p= lace to post to. Or Is 'Administration' specification administration rather than fo= rum administration? Regarding 'IN': Correct me if I'm wrong, but in contrast to just 'OUT' para= meters, which are 'blindly' written to, 'Attributes' must be checked against NULL first b= efore attempting a dereference. Is this not the correct usage of IN? Is IN only used, when t= he pointer's destination is read? Thanks again! Regards, Marvin. > -----Original Message----- > From: Zeng, Star [mailto:star.zeng@intel.com] > Sent: Tuesday, July 25, 2017 10:25 AM > To: Marvin H?user ; edk2- > devel@lists.01.org > Cc: Zeng, Star > Subject: RE: [UEFI PI 1.6/EDK2] Missing decorators for > EFI_PEI_GET_VARIABLE2. >=20 > Marvin, >=20 > I think you are right about the statement of decorator 'OPTIONAL', you ca= n > submit PI ECR, then it can be aligned with UEFI EFI_GET_VARIABLE. > typedef > EFI_STATUS > (EFIAPI *EFI_GET_VARIABLE)( > IN CHAR16 *VariableName, > IN EFI_GUID *VendorGuid, > OUT UINT32 *Attributes, OPTIONAL > IN OUT UINTN *DataSize, > OUT VOID *Data OPTIONAL > ); >=20 > And since the passed-in state of the referenced data is not used by the > routine, I don't think decorator 'IN' should be added. >=20 >=20 >=20 > Thanks, > Star > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > Marvin H?user > Sent: Tuesday, July 25, 2017 12:42 AM > To: edk2-devel@lists.01.org > Subject: [edk2] [UEFI PI 1.6/EDK2] Missing decorators for > EFI_PEI_GET_VARIABLE2. >=20 > Dear developers, >=20 > I noticed that EFI_PEI_GET_VARIABLE2 is lacking decorators in both the UE= FI > PI 1.6 specification and the EDK2 codebase. The parameter description for > 'Attributes' starts with 'If non-NULL', hence it may be NULL, which is no= t > reflected in the function prototype with the decorator 'OPTIONAL'. > Furthermore, as the possibility of it being NULL is not coupled to the va= lues > of the other parameters, 'IN' should be added as well. >=20 > Can someone please forward this to the right working group? >=20 > Thanks and best regards, > Marvin. > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel